186896 2018-06-21 14:24:08 -0700 Do some CoW cleanup 2018-06-26 10:30:03 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 187051 1 saam saam benjamin bugs-noreply calvaris clopez commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1435252 0 saam 2018-06-21 14:24:08 -0700 ... 1435266 1 343278 saam 2018-06-21 14:53:06 -0700 Created attachment 343278 patch 1435272 2 343278 mark.lam 2018-06-21 14:57:22 -0700 Comment on attachment 343278 patch r=me 1435273 3 343278 keith_miller 2018-06-21 14:57:53 -0700 Comment on attachment 343278 patch View in context: https://bugs.webkit.org/attachment.cgi?id=343278&action=review > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:-4598 > - // TODO: Do I need this? Whoops, that's definitely my bad! lol 1435288 4 343278 commit-queue 2018-06-21 15:57:16 -0700 Comment on attachment 343278 patch Clearing flags on attachment: 343278 Committed r233065: <https://trac.webkit.org/changeset/233065> 1435289 5 commit-queue 2018-06-21 15:57:17 -0700 All reviewed patches have been landed. Closing bug. 1435290 6 webkit-bug-importer 2018-06-21 15:58:19 -0700 <rdar://problem/41347603> 1435398 7 clopez 2018-06-22 04:59:43 -0700 (In reply to WebKit Commit Bot from comment #4) > Comment on attachment 343278 [details] > patch > > Clearing flags on attachment: 343278 > > Committed r233065: <https://trac.webkit.org/changeset/233065> This broke our Ubuntu bot (clang-3.8 with libstcd++-5.4) ./../Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h:312:16: error: chosen constructor is explicit in copy-initialization return { profile, recommendedIndexingType }; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/tuple:612:19: note: constructor declared here constexpr tuple(_U1&& __a1, _U2&& __a2) ^ 1 error generated. Log: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20Ubuntu%20LTS%20%28Build%29/builds/13359/steps/compile-webkit/logs/stdio 1435444 8 keith_miller 2018-06-22 08:45:22 -0700 (In reply to Carlos Alberto Lopez Perez from comment #7) > (In reply to WebKit Commit Bot from comment #4) > > Comment on attachment 343278 [details] > > patch > > > > Clearing flags on attachment: 343278 > > > > Committed r233065: <https://trac.webkit.org/changeset/233065> > > This broke our Ubuntu bot (clang-3.8 with libstcd++-5.4) > > > ./../Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h:312:16: error: > chosen constructor is explicit in copy-initialization > return { profile, recommendedIndexingType }; > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/ > tuple:612:19: note: constructor declared here > constexpr tuple(_U1&& __a1, _U2&& __a2) > ^ > 1 error generated. > > > Log: > https://build.webkit.org/builders/GTK%20Linux%2064- > bit%20Release%20Ubuntu%20LTS%20%28Build%29/builds/13359/steps/compile-webkit/ > logs/stdio There probably just needs to be a WTFMove around profile and recommendedIndexingType. 1436564 9 clopez 2018-06-26 10:30:03 -0700 (In reply to Keith Miller from comment #8) > (In reply to Carlos Alberto Lopez Perez from comment #7) > > (In reply to WebKit Commit Bot from comment #4) > > > Comment on attachment 343278 [details] > > > patch > > > > > > Clearing flags on attachment: 343278 > > > > > > Committed r233065: <https://trac.webkit.org/changeset/233065> > > > > This broke our Ubuntu bot (clang-3.8 with libstcd++-5.4) > > > > > > ./../Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h:312:16: error: > > chosen constructor is explicit in copy-initialization > > return { profile, recommendedIndexingType }; > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/ > > tuple:612:19: note: constructor declared here > > constexpr tuple(_U1&& __a1, _U2&& __a2) > > ^ > > 1 error generated. > > > > > > Log: > > https://build.webkit.org/builders/GTK%20Linux%2064- > > bit%20Release%20Ubuntu%20LTS%20%28Build%29/builds/13359/steps/compile-webkit/ > > logs/stdio > > There probably just needs to be a WTFMove around profile and > recommendedIndexingType. That didn't worked.. I was only able to fix the build error by reverting changes of r233065 over UnlinkedCodeBlock.h I have submitted a patch for fixing this at bug 187051 .. if you can review it that will be great. 343278 2018-06-21 14:53:06 -0700 2018-06-21 15:57:16 -0700 patch c-backup.diff text/plain 3643 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjMzMDYwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDE4LTA2LTIxICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IERvIHNvbWUgQ29XIGNsZWFudXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4Njg5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogYnl0ZWNvZGUvVW5saW5rZWRDb2RlQmxvY2suaDoKKyAgICAgICAgKEpT Qzo6VW5saW5rZWRDb2RlQmxvY2s6OmRlY29tcHJlc3NBcnJheUFsbG9jYXRpb25Qcm9maWxlKToK KyAgICAgICAgV2UgZG9uJ3QgbmVlZCB0byBXVEZNb3ZlKCkgaW50cworCisgICAgICAgICogZGZn L0RGR0J5dGVDb2RlUGFyc2VyLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpCeXRlQ29kZVBhcnNl cjo6cGFyc2VCbG9jayk6CisgICAgICAgIHJlbW92ZSBhIFRPRE8uCisKKyAgICAgICAgKiBydW50 aW1lL0pTT2JqZWN0LmNwcDoKKyAgICAgICAgKEpTQzo6SlNPYmplY3Q6OnB1dEJ5SW5kZXgpOgor ICAgICAgICBXZSB3ZXJlIGNoZWNraW5nIGZvciBpc0NvcHlPbldyaXRlIGV2ZW4gYWZ0ZXIgd2Ug Y29udmVydGVkIGF3YXkKKyAgICAgICAgZnJvbSBDb1cgaW4gYWJvdmUgY29kZS4KKyAgICAgICAg KEpTQzo6SlNPYmplY3Q6OmVuc3VyZVdyaXRhYmxlSW50MzJTbG93KToKKyAgICAgICAgTW9kZWwg dGhpcyBpbiB0aGUgc2FtZSB3YXkgdGhlIG90aGVyIGVuc3VyZVdyaXRhYmxlWFNsb3cgYXJlIG1v ZGVsZWQuCisKIDIwMTgtMDYtMjAgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5j b20+CiAKICAgICAgICAgZmxhdHRlbkRpY3Rpb25hcnlTdHJ1dHVyZSBuZWVkcyB0byB6ZXJvIGlu bGluZSBzdG9yYWdlLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1VubGlu a2VkQ29kZUJsb2NrLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVj b2RlL1VubGlua2VkQ29kZUJsb2NrLmgJKHJldmlzaW9uIDIzMzA1OSkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ieXRlY29kZS9VbmxpbmtlZENvZGVCbG9jay5oCSh3b3JraW5nIGNvcHkpCkBA IC0zMDksNyArMzA5LDcgQEAgcHVibGljOgogICAgIHsKICAgICAgICAgdW5zaWduZWQgcHJvZmls ZSA9IChjb21wcmVzc2VkUHJvZmlsZSA8PCA4KSA+PiA4OwogICAgICAgICBJbmRleGluZ1R5cGUg cmVjb21tZW5kZWRJbmRleGluZ1R5cGUgPSBjb21wcmVzc2VkUHJvZmlsZSA+PiAyNDsKLSAgICAg ICAgcmV0dXJuIHN0ZDo6bWFrZV90dXBsZTx1bnNpZ25lZCwgSW5kZXhpbmdUeXBlPihXVEZNb3Zl KHByb2ZpbGUpLCBXVEZNb3ZlKHJlY29tbWVuZGVkSW5kZXhpbmdUeXBlKSk7CisgICAgICAgIHJl dHVybiB7IHByb2ZpbGUsIHJlY29tbWVuZGVkSW5kZXhpbmdUeXBlIH07CiAKICAgICB9CiAgICAg dW5zaWduZWQgbnVtYmVyT2ZPYmplY3RBbGxvY2F0aW9uUHJvZmlsZXMoKSB7IHJldHVybiBtX29i amVjdEFsbG9jYXRpb25Qcm9maWxlQ291bnQ7IH0KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCShyZXZpc2lvbiAyMzMwNTkpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNDU5NSw3ICs0NTk1LDYgQEAgdm9pZCBCeXRlQ29kZVBhcnNlcjo6cGFyc2VCbG9j ayh1bnNpZ25lZAogICAgICAgICAgICAgSlNJbW11dGFibGVCdXR0ZXJmbHkqIGltbXV0YWJsZUJ1 dHRlcmZseSA9IGZyb3plbi0+Y2FzdDxKU0ltbXV0YWJsZUJ1dHRlcmZseSo+KCk7CiAgICAgICAg ICAgICBOZXdBcnJheUJ1ZmZlckRhdGEgZGF0YSB7IH07CiAgICAgICAgICAgICBkYXRhLmluZGV4 aW5nTW9kZSA9IGltbXV0YWJsZUJ1dHRlcmZseS0+aW5kZXhpbmdNb2RlKCk7Ci0gICAgICAgICAg ICAvLyBUT0RPOiBEbyBJIG5lZWQgdGhpcz8KICAgICAgICAgICAgIGRhdGEudmVjdG9yTGVuZ3Ro SGludCA9IGltbXV0YWJsZUJ1dHRlcmZseS0+dG9CdXR0ZXJmbHkoKS0+dmVjdG9yTGVuZ3RoKCk7 CiAKICAgICAgICAgICAgIHNldChWaXJ0dWFsUmVnaXN0ZXIoYnl0ZWNvZGUuZHN0KCkpLCBhZGRU b0dyYXBoKE5ld0FycmF5QnVmZmVyLCBPcEluZm8oZnJvemVuKSwgT3BJbmZvKGRhdGEuYXNRdWFk V29yZCkpKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5j cHAJKHJldmlzaW9uIDIzMzA1OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT T2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODUxLDcgKzg1MSw3IEBAIGJvb2wgSlNPYmpl Y3Q6OnB1dEJ5SW5kZXgoSlNDZWxsKiBjZWxsLCAKICAgICB9CiAgICAgICAgIAogICAgIGNhc2Ug QUxMX0lOVDMyX0lOREVYSU5HX1RZUEVTOiB7Ci0gICAgICAgIGlmICghdmFsdWUuaXNJbnQzMigp IHx8IGlzQ29weU9uV3JpdGUodGhpc09iamVjdC0+aW5kZXhpbmdNb2RlKCkpKSB7CisgICAgICAg IGlmICghdmFsdWUuaXNJbnQzMigpKSB7CiAgICAgICAgICAgICB0aGlzT2JqZWN0LT5jb252ZXJ0 SW50MzJGb3JWYWx1ZSh2bSwgdmFsdWUpOwogICAgICAgICAgICAgcmV0dXJuIHB1dEJ5SW5kZXgo Y2VsbCwgZXhlYywgcHJvcGVydHlOYW1lLCB2YWx1ZSwgc2hvdWxkVGhyb3cpOwogICAgICAgICB9 CkBAIC0xNDc4LDkgKzE0NzgsMTAgQEAgQ29udGlndW91c0pTVmFsdWVzIEpTT2JqZWN0OjplbnN1 cmVXcml0YQogewogICAgIEFTU0VSVChpbmhlcml0cyh2bSwgaW5mbygpKSk7CiAKLSAgICBpZiAo aXNDb3B5T25Xcml0ZShpbmRleGluZ01vZGUoKSkgJiYgaGFzSW50MzIoaW5kZXhpbmdNb2RlKCkp KSB7CisgICAgaWYgKGlzQ29weU9uV3JpdGUoaW5kZXhpbmdNb2RlKCkpKSB7CiAgICAgICAgIGNv bnZlcnRGcm9tQ29weU9uV3JpdGUodm0pOwotICAgICAgICByZXR1cm4gYnV0dGVyZmx5KCktPmNv bnRpZ3VvdXNJbnQzMigpOworICAgICAgICBpZiAoaGFzSW50MzIoaW5kZXhpbmdNb2RlKCkpKQor ICAgICAgICAgICAgcmV0dXJuIGJ1dHRlcmZseSgpLT5jb250aWd1b3VzSW50MzIoKTsKICAgICB9 CiAKICAgICBpZiAoc3RydWN0dXJlKHZtKS0+aGlqYWNrc0luZGV4aW5nSGVhZGVyKCkpCg==