186836 2018-06-20 00:56:48 -0700 [GTK][WPE][Nicosia] Add name for Nicosia Painting Threads 2018-06-20 02:01:25 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki cgarcia clopez mcatanzaro webkit-bug-importer oldest_to_newest 1434713 0 ysuzuki 2018-06-20 00:56:48 -0700 [GTK][WPE][Nicosia] Add name for Nicosia Painting Threads 1434714 1 343138 ysuzuki 2018-06-20 00:57:50 -0700 Created attachment 343138 Patch 1434715 2 343139 ysuzuki 2018-06-20 00:59:51 -0700 Created attachment 343139 Patch 1434717 3 343139 cgarcia 2018-06-20 01:22:31 -0700 Comment on attachment 343139 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343139&action=review > Source/WTF/wtf/WorkerPool.h:66 > + const char* m_name; This is a problem if the passed name is not a static string. I think it would be safer to use a CString even if we have to duplicate it, no? 1434722 4 343139 ysuzuki 2018-06-20 01:27:20 -0700 Comment on attachment 343139 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343139&action=review >> Source/WTF/wtf/WorkerPool.h:66 >> + const char* m_name; > > This is a problem if the passed name is not a static string. I think it would be safer to use a CString even if we have to duplicate it, no? Is there the use case of the non-static string for WorkerPool name? I think ASCIILiteral would be nice, but I'm not sure CString is necessary. 1434724 5 cgarcia 2018-06-20 01:31:05 -0700 (In reply to Yusuke Suzuki from comment #4) > Comment on attachment 343139 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=343139&action=review > > >> Source/WTF/wtf/WorkerPool.h:66 > >> + const char* m_name; > > > > This is a problem if the passed name is not a static string. I think it would be safer to use a CString even if we have to duplicate it, no? > > Is there the use case of the non-static string for WorkerPool name? I think > ASCIILiteral would be nice, but I'm not sure CString is necessary. I don't know, if you are sure a static string is always going to be used, I'm fine. 1434725 6 343139 ysuzuki 2018-06-20 01:36:08 -0700 Comment on attachment 343139 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343139&action=review >>>> Source/WTF/wtf/WorkerPool.h:66 >>>> + const char* m_name; >>> >>> This is a problem if the passed name is not a static string. I think it would be safer to use a CString even if we have to duplicate it, no? >> >> Is there the use case of the non-static string for WorkerPool name? I think ASCIILiteral would be nice, but I'm not sure CString is necessary. > > I don't know, if you are sure a static string is always going to be used, I'm fine. I would like to keep thread names as static if we do not have strong use cases, because static thread names are easy to grep, and the code shows clear intention (this thread is for "XXX") :) 1434729 7 cgarcia 2018-06-20 01:48:43 -0700 (In reply to Yusuke Suzuki from comment #6) > Comment on attachment 343139 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=343139&action=review > > >>>> Source/WTF/wtf/WorkerPool.h:66 > >>>> + const char* m_name; > >>> > >>> This is a problem if the passed name is not a static string. I think it would be safer to use a CString even if we have to duplicate it, no? > >> > >> Is there the use case of the non-static string for WorkerPool name? I think ASCIILiteral would be nice, but I'm not sure CString is necessary. > > > > I don't know, if you are sure a static string is always going to be used, I'm fine. > > I would like to keep thread names as static if we do not have strong use > cases, because static thread names are easy to grep, and the code shows > clear intention (this thread is for "XXX") :) Ok, is there a way to enforce it? 1434730 8 343139 cgarcia 2018-06-20 01:48:51 -0700 Comment on attachment 343139 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343139&action=review >>>>>> Source/WTF/wtf/WorkerPool.h:66 >>>>>> + const char* m_name; >>>>> >>>>> This is a problem if the passed name is not a static string. I think it would be safer to use a CString even if we have to duplicate it, no? >>>> >>>> Is there the use case of the non-static string for WorkerPool name? I think ASCIILiteral would be nice, but I'm not sure CString is necessary. >>> >>> I don't know, if you are sure a static string is always going to be used, I'm fine. >> >> I would like to keep thread names as static if we do not have strong use cases, because static thread names are easy to grep, and the code shows clear intention (this thread is for "XXX") :) > > Ok, is there a way to enforce it? This is a problem if the passed name is not a static string. I think it would be safer to use a CString even if we have to duplicate it, no? 1434731 9 343139 ysuzuki 2018-06-20 01:53:24 -0700 Comment on attachment 343139 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343139&action=review >>>>>>> Source/WTF/wtf/WorkerPool.h:66 >>>>>>> + const char* m_name; >>>>>> >>>>>> This is a problem if the passed name is not a static string. I think it would be safer to use a CString even if we have to duplicate it, no? >>>>> >>>>> Is there the use case of the non-static string for WorkerPool name? I think ASCIILiteral would be nice, but I'm not sure CString is necessary. >>>> >>>> I don't know, if you are sure a static string is always going to be used, I'm fine. >>> >>> I would like to keep thread names as static if we do not have strong use cases, because static thread names are easy to grep, and the code shows clear intention (this thread is for "XXX") :) >> >> Ok, is there a way to enforce it? > > This is a problem if the passed name is not a static string. I think it would be safer to use a CString even if we have to duplicate it, no? Using ASCIILiteral can express that we require literal (ASCIILiteral("thread name")) since ASCIILiteral does not have implicit constructor from const char*. And I'm planning to add user-defined literal for ASCIILiteral and remove ASCIILiteral constructor. Then, we can enforce this! https://bugs.webkit.org/show_bug.cgi?id=186839 1434732 10 ysuzuki 2018-06-20 02:00:32 -0700 Committed r233006: <https://trac.webkit.org/changeset/233006> 1434734 11 webkit-bug-importer 2018-06-20 02:01:25 -0700 <rdar://problem/41281416> 343138 2018-06-20 00:57:50 -0700 2018-06-20 00:59:49 -0700 Patch bug-186836-20180620165749.patch text/plain 4890 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMDA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGE5Yzc5MWIyNDJiMjk4MjhkNjRiOGQ1 MWQ0YmQ2YWMyNTY4NjAwOGQuLjQwMzQxMjEwYzQ1YmU0OWNjNTc1MjU3ODU4M2Q0MWE4YzI1MDUx NDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMDYtMjAgIFl1c3VrZSBTdXp1a2kgIDx1dGF0 YW5lLnRlYUBnbWFpbC5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXVtOaWNvc2lhXSBBZGQgbmFt ZSBmb3IgTmljb3NpYSBQYWludGluZyBUaHJlYWRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODY4MzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBdXRvbWF0aWNUaHJlYWQgY2FuIHRha2UgYSBuYW1lIGZv ciB0aGUgZ2VuZXJhdGVkIHRocmVhZHMgbm93LgorICAgICAgICBUaGlzIHBhdGNoIGFkZHMgdGhl IGFib3ZlIGFiaWxpdHkgdG8gV29ya2VyUG9vbC4KKworICAgICAgICAqIHd0Zi9Xb3JrZXJQb29s LmNwcDoKKyAgICAgICAgKFdURjo6V29ya2VyUG9vbDo6V29ya2VyUG9vbCk6CisgICAgICAgICog d3RmL1dvcmtlclBvb2wuaDoKKyAgICAgICAgKFdURjo6V29ya2VyUG9vbDo6Y3JlYXRlKToKKyAg ICAgICAgKFdURjo6V29ya2VyUG9vbDo6bmFtZSBjb25zdCk6CisKIDIwMTgtMDYtMTggIEppZXdl biBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYSBncmFjZWZ1bCBl eGl0IGZvciBBdXRoZW50aWNhdGlvbk1hbmFnZXI6OmluaXRpYWxpemVDb25uZWN0aW9uCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKaW5kZXggMThiYTkyNTA4NjhiNTA2YzU1MWNiZmI1ZTA5MzQ5ZDE2MDJhYjFkZS4uYzYyYzQz Y2Y1YzJkZTA5ZDQzMzE1MGM2NDRmZDlkYmRlMGQ1N2FmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDE4LTA2LTIwICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29t PgorCisgICAgICAgIFtHVEtdW1dQRV1bTmljb3NpYV0gQWRkIG5hbWUgZm9yIE5pY29zaWEgUGFp bnRpbmcgVGhyZWFkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTg2ODM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVXNlICJQYWludGluZ1RocmVhZCIgbmFtZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL25pY29zaWEvTmljb3NpYVBhaW50aW5nRW5naW5lVGhyZWFkZWQuY3BwOgorICAgICAg ICAoTmljb3NpYTo6UGFpbnRpbmdFbmdpbmVUaHJlYWRlZDo6UGFpbnRpbmdFbmdpbmVUaHJlYWRl ZCk6CisKIDIwMTgtMDYtMTkgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KIAog ICAgICAgICBbV2ViIEFuaW1hdGlvbnNdIE1ha2UgaW1wb3J0ZWQvbW96aWxsYS9jc3MtYW5pbWF0 aW9ucy90ZXN0X3BzZXVkb0VsZW1lbnQtZ2V0LWFuaW1hdGlvbnMuaHRtbCBwYXNzIHJlbGlhYmx5 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9Xb3JrZXJQb29sLmNwcCBiL1NvdXJjZS9XVEYv d3RmL1dvcmtlclBvb2wuY3BwCmluZGV4IDNjY2I3YTJkZWU2NDg0YWY4NDI4NjFkYTU0MTk0Njdl ZWRhNWIwMDMuLmE5ZDI3MWRlMDU3ODMyNmY0ZTQzNzJiYWY0NjJkZGEyODI5NWY4NmMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1dvcmtlclBvb2wuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3Rm L1dvcmtlclBvb2wuY3BwCkBAIC03NSw3ICs3NSw3IEBAIGNsYXNzIFdvcmtlclBvb2w6Oldvcmtl ciBmaW5hbCA6IHB1YmxpYyBBdXRvbWF0aWNUaHJlYWQgewogCiAgICAgY29uc3QgY2hhciogbmFt ZSgpIGNvbnN0IG92ZXJyaWRlCiAgICAgewotICAgICAgICByZXR1cm4gIldvcmtlciBQb29sIjsK KyAgICAgICAgcmV0dXJuIG1fcG9vbC5uYW1lKCk7CiAgICAgfQogCiBwcml2YXRlOgpAQCAtODMs MTAgKzgzLDExIEBAIGNsYXNzIFdvcmtlclBvb2w6OldvcmtlciBmaW5hbCA6IHB1YmxpYyBBdXRv bWF0aWNUaHJlYWQgewogICAgIEZ1bmN0aW9uPHZvaWQoKT4gbV90YXNrOwogfTsKIAotV29ya2Vy UG9vbDo6V29ya2VyUG9vbCh1bnNpZ25lZCBudW1iZXJPZldvcmtlcnMsIFNlY29uZHMgdGltZW91 dCkKK1dvcmtlclBvb2w6OldvcmtlclBvb2woY29uc3QgY2hhciogbmFtZSwgdW5zaWduZWQgbnVt YmVyT2ZXb3JrZXJzLCBTZWNvbmRzIHRpbWVvdXQsIGNvbnN0IGNoYXIqKQogICAgIDogbV9sb2Nr KEJveDxMb2NrPjo6Y3JlYXRlKCkpCiAgICAgLCBtX2NvbmRpdGlvbihBdXRvbWF0aWNUaHJlYWRD b25kaXRpb246OmNyZWF0ZSgpKQogICAgICwgbV90aW1lb3V0KHRpbWVvdXQpCisgICAgLCBtX25h bWUobmFtZSkKIHsKICAgICBMb2NrSG9sZGVyIGxvY2tlcigqbV9sb2NrKTsKICAgICBmb3IgKHVu c2lnbmVkIGkgPSAwOyBpIDwgbnVtYmVyT2ZXb3JrZXJzOyArK2kpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV1RGL3d0Zi9Xb3JrZXJQb29sLmggYi9Tb3VyY2UvV1RGL3d0Zi9Xb3JrZXJQb29sLmgKaW5k ZXggYjVmNGQzNDVkYzE4YTY5YzMwMmM1OTg0MjU0ZDA5MzIyNDBlMmFmMy4uZTQ4ZmQ3OTFmNmIy ODdkNmZkYWU3OTI0OTdkMjMzNzM0NjU2NDA4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYv V29ya2VyUG9vbC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1dvcmtlclBvb2wuaApAQCAtNDAsMTcg KzQwLDE5IEBAIGNsYXNzIFdvcmtlclBvb2wgOiBwdWJsaWMgVGhyZWFkU2FmZVJlZkNvdW50ZWQ8 V29ya2VyUG9vbD4gewogICAgIFdURl9FWFBPUlRfUFJJVkFURSB+V29ya2VyUG9vbCgpOwogCiAg ICAgLy8gSWYgdGltZW91dCBpcyBpbmZpbml0eSwgaXQgbWVhbnMgQXV0b21hdGljVGhyZWFkIHdp bGwgYmUgbmV2ZXIgYXV0b21hdGljYWxseSBkZXN0cm95ZWQuCi0gICAgc3RhdGljIFJlZjxXb3Jr ZXJQb29sPiBjcmVhdGUodW5zaWduZWQgbnVtYmVyT2ZXb3JrZXJzICA9IFdURjo6bnVtYmVyT2ZQ cm9jZXNzb3JDb3JlcygpLCBTZWNvbmRzIHRpbWVvdXQgPSBTZWNvbmRzOjppbmZpbml0eSgpKQor ICAgIHN0YXRpYyBSZWY8V29ya2VyUG9vbD4gY3JlYXRlKGNvbnN0IGNoYXIqIG5hbWUsIHVuc2ln bmVkIG51bWJlck9mV29ya2VycyAgPSBXVEY6Om51bWJlck9mUHJvY2Vzc29yQ29yZXMoKSwgU2Vj b25kcyB0aW1lb3V0ID0gU2Vjb25kczo6aW5maW5pdHkoKSkKICAgICB7CiAgICAgICAgIEFTU0VS VChudW1iZXJPZldvcmtlcnMgPj0gMSk7Ci0gICAgICAgIHJldHVybiBhZG9wdFJlZigqbmV3IFdv cmtlclBvb2wobnVtYmVyT2ZXb3JrZXJzLCB0aW1lb3V0KSk7CisgICAgICAgIHJldHVybiBhZG9w dFJlZigqbmV3IFdvcmtlclBvb2wobmFtZSwgbnVtYmVyT2ZXb3JrZXJzLCB0aW1lb3V0KSk7CiAg ICAgfQogCisgICAgY29uc3QgY2hhciogbmFtZSgpIGNvbnN0IHsgcmV0dXJuIG1fbmFtZTsgfQor CiBwcml2YXRlOgogICAgIGNsYXNzIFdvcmtlcjsKICAgICBmcmllbmQgY2xhc3MgV29ya2VyOwog Ci0gICAgV1RGX0VYUE9SVF9QUklWQVRFIFdvcmtlclBvb2wodW5zaWduZWQgbnVtYmVyT2ZXb3Jr ZXJzLCBTZWNvbmRzIHRpbWVvdXQpOworICAgIFdURl9FWFBPUlRfUFJJVkFURSBXb3JrZXJQb29s KGNvbnN0IGNoYXIqIG5hbWUsIHVuc2lnbmVkIG51bWJlck9mV29ya2VycywgU2Vjb25kcyB0aW1l b3V0KTsKIAogICAgIGJvb2wgc2hvdWxkU2xlZXAoY29uc3QgQWJzdHJhY3RMb2NrZXImKTsKIApA QCAtNjEsNiArNjMsNyBAQCBjbGFzcyBXb3JrZXJQb29sIDogcHVibGljIFRocmVhZFNhZmVSZWZD b3VudGVkPFdvcmtlclBvb2w+IHsKICAgICB1bnNpZ25lZCBtX251bWJlck9mQWN0aXZlV29ya2Vy cyB7IDAgfTsKICAgICBWZWN0b3I8UmVmPFdvcmtlcj4+IG1fd29ya2VyczsKICAgICBEZXF1ZTxG dW5jdGlvbjx2b2lkKCk+PiBtX3Rhc2tzOworICAgIGNvbnN0IGNoYXIqIG1fbmFtZTsKIH07CiAK IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL25pY29zaWEv Tmljb3NpYVBhaW50aW5nRW5naW5lVGhyZWFkZWQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvbmljb3NpYS9OaWNvc2lhUGFpbnRpbmdFbmdpbmVUaHJlYWRlZC5jcHAKaW5k ZXggNjA5ZDFjMzAxYzNmMDAwYjkzZGUxN2NkOWU4OTA3NGMzYTQ1NzE2Ni4uNjBmZmJhYTAxOWRl ZmQzYjNhMDQxMWZkOTgxMjIyZjEwNWNiNmFlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvbmljb3NpYS9OaWNvc2lhUGFpbnRpbmdFbmdpbmVUaHJlYWRlZC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvbmljb3NpYS9OaWNvc2lh UGFpbnRpbmdFbmdpbmVUaHJlYWRlZC5jcHAKQEAgLTYwLDcgKzYwLDcgQEAgc3RhdGljIHZvaWQg cGFpbnRMYXllcihHcmFwaGljc0NvbnRleHQmIGNvbnRleHQsIEdyYXBoaWNzTGF5ZXImIGxheWVy LCBjb25zdCBJbnQKIH0KIAogUGFpbnRpbmdFbmdpbmVUaHJlYWRlZDo6UGFpbnRpbmdFbmdpbmVU aHJlYWRlZCh1bnNpZ25lZCBudW1UaHJlYWRzKQotICAgIDogbV93b3JrZXJQb29sKFdvcmtlclBv b2w6OmNyZWF0ZShudW1UaHJlYWRzKSkKKyAgICA6IG1fd29ya2VyUG9vbChXb3JrZXJQb29sOjpj cmVhdGUoIlBhaW50aW5nVGhyZWFkIiwgbnVtVGhyZWFkcykpCiB7CiB9CiAK 343139 2018-06-20 00:59:51 -0700 2018-06-20 01:48:51 -0700 Patch bug-186836-20180620165950.patch text/plain 6140 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMDA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGE5Yzc5MWIyNDJiMjk4MjhkNjRiOGQ1 MWQ0YmQ2YWMyNTY4NjAwOGQuLjQwMzQxMjEwYzQ1YmU0OWNjNTc1MjU3ODU4M2Q0MWE4YzI1MDUx NDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMDYtMjAgIFl1c3VrZSBTdXp1a2kgIDx1dGF0 YW5lLnRlYUBnbWFpbC5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXVtOaWNvc2lhXSBBZGQgbmFt ZSBmb3IgTmljb3NpYSBQYWludGluZyBUaHJlYWRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODY4MzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBdXRvbWF0aWNUaHJlYWQgY2FuIHRha2UgYSBuYW1lIGZv ciB0aGUgZ2VuZXJhdGVkIHRocmVhZHMgbm93LgorICAgICAgICBUaGlzIHBhdGNoIGFkZHMgdGhl IGFib3ZlIGFiaWxpdHkgdG8gV29ya2VyUG9vbC4KKworICAgICAgICAqIHd0Zi9Xb3JrZXJQb29s LmNwcDoKKyAgICAgICAgKFdURjo6V29ya2VyUG9vbDo6V29ya2VyUG9vbCk6CisgICAgICAgICog d3RmL1dvcmtlclBvb2wuaDoKKyAgICAgICAgKFdURjo6V29ya2VyUG9vbDo6Y3JlYXRlKToKKyAg ICAgICAgKFdURjo6V29ya2VyUG9vbDo6bmFtZSBjb25zdCk6CisKIDIwMTgtMDYtMTggIEppZXdl biBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYSBncmFjZWZ1bCBl eGl0IGZvciBBdXRoZW50aWNhdGlvbk1hbmFnZXI6OmluaXRpYWxpemVDb25uZWN0aW9uCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKaW5kZXggMThiYTkyNTA4NjhiNTA2YzU1MWNiZmI1ZTA5MzQ5ZDE2MDJhYjFkZS4uYzYyYzQz Y2Y1YzJkZTA5ZDQzMzE1MGM2NDRmZDlkYmRlMGQ1N2FmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDE4LTA2LTIwICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29t PgorCisgICAgICAgIFtHVEtdW1dQRV1bTmljb3NpYV0gQWRkIG5hbWUgZm9yIE5pY29zaWEgUGFp bnRpbmcgVGhyZWFkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTg2ODM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVXNlICJQYWludGluZ1RocmVhZCIgbmFtZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL25pY29zaWEvTmljb3NpYVBhaW50aW5nRW5naW5lVGhyZWFkZWQuY3BwOgorICAgICAg ICAoTmljb3NpYTo6UGFpbnRpbmdFbmdpbmVUaHJlYWRlZDo6UGFpbnRpbmdFbmdpbmVUaHJlYWRl ZCk6CisKIDIwMTgtMDYtMTkgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KIAog ICAgICAgICBbV2ViIEFuaW1hdGlvbnNdIE1ha2UgaW1wb3J0ZWQvbW96aWxsYS9jc3MtYW5pbWF0 aW9ucy90ZXN0X3BzZXVkb0VsZW1lbnQtZ2V0LWFuaW1hdGlvbnMuaHRtbCBwYXNzIHJlbGlhYmx5 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9Xb3JrZXJQb29sLmNwcCBiL1NvdXJjZS9XVEYv d3RmL1dvcmtlclBvb2wuY3BwCmluZGV4IDNjY2I3YTJkZWU2NDg0YWY4NDI4NjFkYTU0MTk0Njdl ZWRhNWIwMDMuLjdiOTIxMDU3ZjVjNjUwYWRmZGMwN2VlYmIzM2RlZDBiZGQ4MGExNTAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1dvcmtlclBvb2wuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3Rm L1dvcmtlclBvb2wuY3BwCkBAIC03NSw3ICs3NSw3IEBAIGNsYXNzIFdvcmtlclBvb2w6Oldvcmtl ciBmaW5hbCA6IHB1YmxpYyBBdXRvbWF0aWNUaHJlYWQgewogCiAgICAgY29uc3QgY2hhciogbmFt ZSgpIGNvbnN0IG92ZXJyaWRlCiAgICAgewotICAgICAgICByZXR1cm4gIldvcmtlciBQb29sIjsK KyAgICAgICAgcmV0dXJuIG1fcG9vbC5uYW1lKCk7CiAgICAgfQogCiBwcml2YXRlOgpAQCAtODMs MTAgKzgzLDExIEBAIGNsYXNzIFdvcmtlclBvb2w6OldvcmtlciBmaW5hbCA6IHB1YmxpYyBBdXRv bWF0aWNUaHJlYWQgewogICAgIEZ1bmN0aW9uPHZvaWQoKT4gbV90YXNrOwogfTsKIAotV29ya2Vy UG9vbDo6V29ya2VyUG9vbCh1bnNpZ25lZCBudW1iZXJPZldvcmtlcnMsIFNlY29uZHMgdGltZW91 dCkKK1dvcmtlclBvb2w6OldvcmtlclBvb2woY29uc3QgY2hhciogbmFtZSwgdW5zaWduZWQgbnVt YmVyT2ZXb3JrZXJzLCBTZWNvbmRzIHRpbWVvdXQpCiAgICAgOiBtX2xvY2soQm94PExvY2s+Ojpj cmVhdGUoKSkKICAgICAsIG1fY29uZGl0aW9uKEF1dG9tYXRpY1RocmVhZENvbmRpdGlvbjo6Y3Jl YXRlKCkpCiAgICAgLCBtX3RpbWVvdXQodGltZW91dCkKKyAgICAsIG1fbmFtZShuYW1lKQogewog ICAgIExvY2tIb2xkZXIgbG9ja2VyKCptX2xvY2spOwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7 IGkgPCBudW1iZXJPZldvcmtlcnM7ICsraSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1dv cmtlclBvb2wuaCBiL1NvdXJjZS9XVEYvd3RmL1dvcmtlclBvb2wuaAppbmRleCBiNWY0ZDM0NWRj MThhNjljMzAyYzU5ODQyNTRkMDkzMjI0MGUyYWYzLi5lNDhmZDc5MWY2YjI4N2Q2ZmRhZTc5MjQ5 N2QyMzM3MzQ2NTY0MDhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Xb3JrZXJQb29sLmgK KysrIGIvU291cmNlL1dURi93dGYvV29ya2VyUG9vbC5oCkBAIC00MCwxNyArNDAsMTkgQEAgY2xh c3MgV29ya2VyUG9vbCA6IHB1YmxpYyBUaHJlYWRTYWZlUmVmQ291bnRlZDxXb3JrZXJQb29sPiB7 CiAgICAgV1RGX0VYUE9SVF9QUklWQVRFIH5Xb3JrZXJQb29sKCk7CiAKICAgICAvLyBJZiB0aW1l b3V0IGlzIGluZmluaXR5LCBpdCBtZWFucyBBdXRvbWF0aWNUaHJlYWQgd2lsbCBiZSBuZXZlciBh dXRvbWF0aWNhbGx5IGRlc3Ryb3llZC4KLSAgICBzdGF0aWMgUmVmPFdvcmtlclBvb2w+IGNyZWF0 ZSh1bnNpZ25lZCBudW1iZXJPZldvcmtlcnMgID0gV1RGOjpudW1iZXJPZlByb2Nlc3NvckNvcmVz KCksIFNlY29uZHMgdGltZW91dCA9IFNlY29uZHM6OmluZmluaXR5KCkpCisgICAgc3RhdGljIFJl ZjxXb3JrZXJQb29sPiBjcmVhdGUoY29uc3QgY2hhciogbmFtZSwgdW5zaWduZWQgbnVtYmVyT2ZX b3JrZXJzICA9IFdURjo6bnVtYmVyT2ZQcm9jZXNzb3JDb3JlcygpLCBTZWNvbmRzIHRpbWVvdXQg PSBTZWNvbmRzOjppbmZpbml0eSgpKQogICAgIHsKICAgICAgICAgQVNTRVJUKG51bWJlck9mV29y a2VycyA+PSAxKTsKLSAgICAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgV29ya2VyUG9vbChudW1i ZXJPZldvcmtlcnMsIHRpbWVvdXQpKTsKKyAgICAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgV29y a2VyUG9vbChuYW1lLCBudW1iZXJPZldvcmtlcnMsIHRpbWVvdXQpKTsKICAgICB9CiAKKyAgICBj b25zdCBjaGFyKiBuYW1lKCkgY29uc3QgeyByZXR1cm4gbV9uYW1lOyB9CisKIHByaXZhdGU6CiAg ICAgY2xhc3MgV29ya2VyOwogICAgIGZyaWVuZCBjbGFzcyBXb3JrZXI7CiAKLSAgICBXVEZfRVhQ T1JUX1BSSVZBVEUgV29ya2VyUG9vbCh1bnNpZ25lZCBudW1iZXJPZldvcmtlcnMsIFNlY29uZHMg dGltZW91dCk7CisgICAgV1RGX0VYUE9SVF9QUklWQVRFIFdvcmtlclBvb2woY29uc3QgY2hhciog bmFtZSwgdW5zaWduZWQgbnVtYmVyT2ZXb3JrZXJzLCBTZWNvbmRzIHRpbWVvdXQpOwogCiAgICAg Ym9vbCBzaG91bGRTbGVlcChjb25zdCBBYnN0cmFjdExvY2tlciYpOwogCkBAIC02MSw2ICs2Myw3 IEBAIGNsYXNzIFdvcmtlclBvb2wgOiBwdWJsaWMgVGhyZWFkU2FmZVJlZkNvdW50ZWQ8V29ya2Vy UG9vbD4gewogICAgIHVuc2lnbmVkIG1fbnVtYmVyT2ZBY3RpdmVXb3JrZXJzIHsgMCB9OwogICAg IFZlY3RvcjxSZWY8V29ya2VyPj4gbV93b3JrZXJzOwogICAgIERlcXVlPEZ1bmN0aW9uPHZvaWQo KT4+IG1fdGFza3M7CisgICAgY29uc3QgY2hhciogbV9uYW1lOwogfTsKIAogfQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvbmljb3NpYS9OaWNvc2lhUGFpbnRp bmdFbmdpbmVUaHJlYWRlZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9u aWNvc2lhL05pY29zaWFQYWludGluZ0VuZ2luZVRocmVhZGVkLmNwcAppbmRleCA2MDlkMWMzMDFj M2YwMDBiOTNkZTE3Y2Q5ZTg5MDc0YzNhNDU3MTY2Li42MGZmYmFhMDE5ZGVmZDNiM2EwNDExZmQ5 ODEyMjJmMTA1Y2I2YWU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9uaWNvc2lhL05pY29zaWFQYWludGluZ0VuZ2luZVRocmVhZGVkLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9uaWNvc2lhL05pY29zaWFQYWludGluZ0VuZ2lu ZVRocmVhZGVkLmNwcApAQCAtNjAsNyArNjAsNyBAQCBzdGF0aWMgdm9pZCBwYWludExheWVyKEdy YXBoaWNzQ29udGV4dCYgY29udGV4dCwgR3JhcGhpY3NMYXllciYgbGF5ZXIsIGNvbnN0IEludAog fQogCiBQYWludGluZ0VuZ2luZVRocmVhZGVkOjpQYWludGluZ0VuZ2luZVRocmVhZGVkKHVuc2ln bmVkIG51bVRocmVhZHMpCi0gICAgOiBtX3dvcmtlclBvb2woV29ya2VyUG9vbDo6Y3JlYXRlKG51 bVRocmVhZHMpKQorICAgIDogbV93b3JrZXJQb29sKFdvcmtlclBvb2w6OmNyZWF0ZSgiUGFpbnRp bmdUaHJlYWQiLCBudW1UaHJlYWRzKSkKIHsKIH0KIApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdl TG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDQwOGY2ZjJmMmNmNzczNzVlOGE0YzI1NDc0NzIx Mjg3Y2EzNTY5MTguLjcyZGExMTc4NTJjMzBlMTdlYTJjYjBjNTU0ZGZmM2YzOTc5Mjg1MzMgMTAw NjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMyBAQAorMjAxOC0wNi0yMCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNv bT4KKworICAgICAgICBbR1RLXVtXUEVdW05pY29zaWFdIEFkZCBuYW1lIGZvciBOaWNvc2lhIFBh aW50aW5nIFRocmVhZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE4NjgzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvV29ya2VyUG9vbC5jcHA6CisgICAgICAg IChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAxOC0wNi0xOSAgTGVvIEJhbHRlciAgPGxlb25h cmRvLmJhbHRlckBnbWFpbC5jb20+CiAKICAgICAgICAgW3Rlc3QyNjItcnVubmVyXSBSZWR1Y2Ug Zmxha2luZXNzIG9mIHVuaXQgdGVzdHMgZm9yIHRoZSBydW5uZXIKZGlmZiAtLWdpdCBhL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1dvcmtlclBvb2wuY3BwIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XVEYvV29ya2VyUG9vbC5jcHAKaW5kZXggZjk4ZTI4YTFhN2EyYjFlZjI3MTdl YWM1MjQ0NzYwNDVhOWU2YzZiNS4uNjZlY2RjMGY3M2ViZGM4MmQxMTM3MGZjMDJiNDE2Y2U5ZDNm ZGEwNyAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvV29ya2VyUG9v bC5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvV29ya2VyUG9vbC5jcHAK QEAgLTM2LDcgKzM2LDcgQEAgVEVTVChXVEYsIFdvcmtlclBvb2xEZWNyZWFzZSkKIHsKICAgICBz dGQ6OmF0b21pYzx1bnNpZ25lZD4gY291bnRlciB7IDAgfTsKICAgICB7Ci0gICAgICAgIFJlZjxX b3JrZXJQb29sPiBwb29sID0gV29ya2VyUG9vbDo6Y3JlYXRlKCk7CisgICAgICAgIFJlZjxXb3Jr ZXJQb29sPiBwb29sID0gV29ya2VyUG9vbDo6Y3JlYXRlKCJXb3JrZXIgUG9vbCIpOwogICAgICAg ICBmb3IgKGludCBpID0gMDsgaSA8IDEwMDAwOyArK2kpIHsKICAgICAgICAgICAgIHBvb2wtPnBv c3RUYXNrKFsmXSB7CiAgICAgICAgICAgICAgICAgKytjb3VudGVyOwo=