186816 2018-06-19 13:54:52 -0700 Crash running check-webkit-style on webrtc/.../exceptions.py 2018-06-19 14:59:45 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin cgarcia commit-queue ddkilzer ews-watchlist glenn jbedard lforschler mcatanzaro webkit-bug-importer oldest_to_newest 1434538 0 krollin 2018-06-19 13:54:52 -0700 Running check-webkit-style on all of Source results in the following crash on Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/exceptions.py: Traceback (most recent call last): File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/style/main.py", line 149, in main file_reader.process_paths(paths) File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/style/filereader.py", line 147, in process_paths self._process_directory(directory=path) File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/style/filereader.py", line 142, in _process_directory self.process_file(file_path) File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/style/filereader.py", line 137, in process_file self._processor.process(lines, file_path, **kwargs) File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/style/checker.py", line 970, in process checker.check(lines) File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/style/checkers/python.py", line 43, in check self._check_pylint(lines) File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/style/checkers/python.py", line 71, in _check_pylint output = pylinter.run(['-E', self._file_path]) File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/style/checkers/python.py", line 106, in run lint.Run(['--rcfile', self._pylintrc] + argv, reporter=ParseableTextReporter(output=output), exit=False) File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 879, in __init__ linter.check(args) File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 502, in check self.check_astng_module(astng, walker, rawcheckers) File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 574, in check_astng_module walker.walk(astng) File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/utils.py", line 528, in walk self.walk(child) File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/utils.py", line 528, in walk self.walk(child) File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/utils.py", line 525, in walk cb(astng) File "/Volumes/Data/dev/webkit/OpenSource/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/checkers/variables.py", line 387, in visit_name assert not stmt.root().file.endswith('.py') AttributeError: 'NoneType' object has no attribute 'endswith' 1434539 1 webkit-bug-importer 2018-06-19 13:55:07 -0700 <rdar://problem/41262553> 1434541 2 krollin 2018-06-19 13:56:28 -0700 It's not apparent to me why the crash is occurring. Trying to write a unittest that checks this file in isolation does not reproduce the crash. But the crash goes away when updating to pylint-0.25.2. (Note that 0.25.2 is still seven years out-of-date, but I'm not sure if I want to try updating to 1.9.2 or 2.0-dev.) 1434550 3 343095 krollin 2018-06-19 14:02:29 -0700 Created attachment 343095 Patch 1434586 4 343095 commit-queue 2018-06-19 14:59:43 -0700 Comment on attachment 343095 Patch Clearing flags on attachment: 343095 Committed r232987: <https://trac.webkit.org/changeset/232987> 1434587 5 commit-queue 2018-06-19 14:59:45 -0700 All reviewed patches have been landed. Closing bug. 343095 2018-06-19 14:02:29 -0700 2018-06-19 14:59:43 -0700 Patch bug-186816-20180619140228.patch text/plain 2412 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyOTMzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjkyZWY1NWFhZmQ2ZmJkYzllOTRlZGZhMGFlOWQxMTBl Mzc2YzIyYS4uZjgwNjg1MGM1MGI2ZjkwZWE5OTljMjhlOWI1ZDJlNmNjMGJmODI5YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE4LTA2LTE5ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAg ICAgICBDcmFzaCBydW5uaW5nIGNoZWNrLXdlYmtpdC1zdHlsZSBvbiB3ZWJydGMvLi4uL2V4Y2Vw dGlvbnMucHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4NjgxNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDEyNjI1NTM+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQncyBub3QgYXBwYXJlbnQgdG8g bWUgd2h5IHRoZSBjcmFzaCBpcyBvY2N1cnJpbmcuIFRyeWluZyB0byB3cml0ZSBhCisgICAgICAg IHVuaXR0ZXN0IHRoYXQgY2hlY2tzIHRoaXMgZmlsZSBpbiBpc29sYXRpb24gZG9lcyBub3QgcmVw cm9kdWNlIHRoZQorICAgICAgICBjcmFzaC4gQnV0IHRoZSBjcmFzaCBnb2VzIGF3YXkgd2hlbiB1 cGRhdGluZyB0byBweWxpbnQtMC4yNS4yLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90 aGlyZHBhcnR5L19faW5pdF9fLnB5OgorICAgICAgICAoQXV0b2luc3RhbGxJbXBvcnRIb29rLl9p bnN0YWxsX3B5bGludCk6CisKIDIwMTgtMDYtMTggIEtlaXRoIFJvbGxpbiAgPGtyb2xsaW5AYXBw bGUuY29tPgogCiAgICAgICAgIGNwcCBzdHlsZSBjaGVja2VyIG5lZWRzIHRvIGtub3cgbW9yZSBh Ym91dCBOT0xJTlQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGhpcmRwYXJ0 eS9fX2luaXRfXy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRf Xy5weQppbmRleCA1ZjM4MTQ1NDhjYzE2MjY5YzMxM2MzMDAxYzU0ZGZhNTE2OTYxZDM4Li42Y2Ex MTdkZGJiMmQ3Y2I2Mzg4MzRmZjAxMzNiYzY2ZWIyNzQ2Nzc1IDEwMDY0NAotLS0gYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3RoaXJkcGFydHkvX19pbml0X18ucHkKKysrIGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS90aGlyZHBhcnR5L19faW5pdF9fLnB5CkBAIC0xNjAsNyArMTYwLDcgQEAgY2xh c3MgQXV0b2luc3RhbGxJbXBvcnRIb29rKG9iamVjdCk6CiAgICAgICAgICAgICAgICAgZmlsZXNf dG9fcmVtb3ZlID0gWyd0ZXN0L2RhdGEvd3JpdGVfcHJvdGVjdGVkX2ZpbGUudHh0J10KICAgICAg ICAgICAgIGluc3RhbGxlci5pbnN0YWxsKCJodHRwczovL3B5cGkucHl0aG9uLm9yZy9wYWNrYWdl cy9zb3VyY2UvbC9sb2dpbGFiLWNvbW1vbi9sb2dpbGFiLWNvbW1vbi0wLjU4LjEudGFyLmd6I21k NT03NzI5OGFiMmQ4YmI4YjRhZjkyMTk3OTFlN2NlZThjZSIsIHVybF9zdWJwYXRoPSJsb2dpbGFi LWNvbW1vbi0wLjU4LjEiLCB0YXJnZXRfbmFtZT0ibG9naWxhYi9jb21tb24iLCBmaWxlc190b19y ZW1vdmU9ZmlsZXNfdG9fcmVtb3ZlKQogICAgICAgICAgICAgaW5zdGFsbGVyLmluc3RhbGwoImh0 dHBzOi8vcHlwaS5weXRob24ub3JnL3BhY2thZ2VzL3NvdXJjZS9sL2xvZ2lsYWItYXN0bmcvbG9n aWxhYi1hc3RuZy0wLjI0LjEudGFyLmd6I21kNT1kZGFmNjZlNGQ4NTcxNGQ5YzQ3YTQ2ZDRiZWQ0 MDZkZSIsIHVybF9zdWJwYXRoPSJsb2dpbGFiLWFzdG5nLTAuMjQuMSIsIHRhcmdldF9uYW1lPSJs b2dpbGFiL2FzdG5nIikKLSAgICAgICAgICAgIGluc3RhbGxlci5pbnN0YWxsKCdodHRwczovL3B5 cGkucHl0aG9uLm9yZy9wYWNrYWdlcy9zb3VyY2UvcC9weWxpbnQvcHlsaW50LTAuMjUuMS50YXIu Z3ojbWQ1PTcyOGJiYzJiMzM5YmMzNzQ5YWYwMTM3MDlhN2Y4N2E1JywgdXJsX3N1YnBhdGg9InB5 bGludC0wLjI1LjEiLCB0YXJnZXRfbmFtZT0icHlsaW50IikKKyAgICAgICAgICAgIGluc3RhbGxl ci5pbnN0YWxsKCdodHRwczovL3B5cGkucHl0aG9uLm9yZy9wYWNrYWdlcy9zb3VyY2UvcC9weWxp bnQvcHlsaW50LTAuMjUuMi50YXIuZ3ojbWQ1PWQ4NzhkNzY4OGE0ZjUyOTBkYzViNTNhODM2ODcy NDAwJywgdXJsX3N1YnBhdGg9InB5bGludC0wLjI1LjIiLCB0YXJnZXRfbmFtZT0icHlsaW50IikK IAogICAgICMgYXV0b2luc3RhbGxlZC5idWlsZGJvdCBpcyB1c2VkIGJ5IEJ1aWxkU2xhdmVTdXBw b3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3RlcmNmZ191bml0dGVzdC5weQogICAgICMg YW5kIHNob3VsZCBpZGVhbGx5IG1hdGNoIHRoZSB2ZXJzaW9uIG9mIEJ1aWxkQm90IHVzZWQgYXQg YnVpbGQud2Via2l0Lm9yZy4K