186808 2018-06-19 11:13:03 -0700 [test262-runner] Always save the expectations file in full runs 2021-11-01 12:14:29 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified ASSIGNED P2 Normal --- 1 leo leo achristensen msaboff oldest_to_newest 1434452 0 leo 2018-06-19 11:13:03 -0700 [test262-runner] Always save the expectations file in full runs 1434453 1 343070 leo 2018-06-19 11:15:15 -0700 Created attachment 343070 Patch 1434457 2 msaboff 2018-06-19 11:34:12 -0700 So why do we want to always update the expectations file? Consider the scenario where one is trying to fix a bug found via a failing test262 test in JSC and they want to run all tests before committing that change. It takes several iterations to fix that bug. Only after fixing the bug do they want to update the expectations file. 1810740 3 343070 achristensen 2021-11-01 12:14:29 -0700 Comment on attachment 343070 Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review. 343070 2018-06-19 11:15:15 -0700 2021-11-01 12:14:29 -0700 Patch bug-186808-20180619141514.patch text/plain 4469 leo U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyOTY2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWQxZWM3MDE1OGQyNTkxMzJkM2ZjNDA1OTBkYzUzMjhj ODBmYzIwNy4uYmJiYzZhMzA2MjBlZGI5MWQ2M2UyMTRlNTFmYWRmOTAyOTIxMWRmMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE4LTA2LTE5ICBMZW8gQmFsdGVyICA8bGVvbmFyZG8uYmFsdGVyQGdtYWlsLmNvbT4K KworICAgICAgICBbdGVzdDI2Mi1ydW5uZXJdIEFsd2F5cyBzYXZlIHRoZSBleHBlY3RhdGlvbnMg ZmlsZSBpbiBmdWxsIHJ1bnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4NjgwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZSBydW5uZXIgc2hvdWxkIGFsd2F5cyBzYXZlIHRoZSBleHBlY3RhdGlvbnMg ZmlsZSBpbiBmdWxsIHJ1bnMsIHRoaXMgY2FuIGJlIGVhc2lseQorICAgICAgICBjb250cm9sbGVk IHVzaW5nIHZlcnNpb25pbmcgY29udHJvbCBhbmQgZW5mb3JjZXMgYSBnb29kIHByYWN0aWNlIHRv IGtlZXAgdGhlIGV4cGVjdGF0aW9ucworICAgICAgICBmaWxlIHVwIHRvIGRhdGUgd2l0aCB0aGUg bGF0ZXN0IHJ1bnMuCisgICAgICAgICogU2NyaXB0cy90ZXN0MjYyL1J1bm5lci5wbToKKyAgICAg ICAgKHByb2Nlc3NDTEkpOgorICAgICAgICAobWFpbik6CisKIDIwMTgtMDYtMTkgIFJvYmluIE1v cmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KIAogICAgICAgICBbV1NMXSBJbXByb3Zpbmcg dGhlIHR5cGluZyBydWxlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy90ZXN0MjYyL1J1bm5l ci5wbSBiL1Rvb2xzL1NjcmlwdHMvdGVzdDI2Mi9SdW5uZXIucG0KaW5kZXggN2M3M2Q1ZjEwMzVh OGE0MGYzZWQ3YTRkZjA5ZjBmMTJiNDdkMGRhNS4uZGMzOGI0MjExNzNkM2MzZThmOTkxY2Q0NWIw ZGIyNTVjNGNhZjMwZSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy90ZXN0MjYyL1J1bm5lci5w bQorKysgYi9Ub29scy9TY3JpcHRzL3Rlc3QyNjIvUnVubmVyLnBtCkBAIC04NCw3ICs4NCw2IEBA IG15ICRpZ25vcmVDb25maWc7CiBteSAkY29uZmlnOwogbXkgJWNvbmZpZ1NraXBIYXNoOwogbXkg JGV4cGVjdDsKLW15ICRzYXZlRXhwZWN0YXRpb25zOwogbXkgJGZhaWxpbmdPbmx5OwogbXkgJGxh dGVzdEltcG9ydDsKIG15ICRydW5uaW5nQWxsVGVzdHM7CkBAIC0xMzMsNyArMTMyLDYgQEAgc3Vi IHByb2Nlc3NDTEkgewogICAgICAgICAnZnxmZWF0dXJlcz1zQCcgPT4gXEBmZWF0dXJlcywKICAg ICAgICAgJ2N8Y29uZmlnPXMnID0+IFwkY29uZmlnRmlsZSwKICAgICAgICAgJ2l8aWdub3JlLWNv bmZpZycgPT4gXCRpZ25vcmVDb25maWcsCi0gICAgICAgICdzfHNhdmUnID0+IFwkc2F2ZUV4cGVj dGF0aW9ucywKICAgICAgICAgJ2V8ZXhwZWN0YXRpb25zPXMnID0+IFwkc3BlY2lmaWVkRXhwZWN0 YXRpb25zRmlsZSwKICAgICAgICAgJ3h8aWdub3JlLWV4cGVjdGF0aW9ucycgPT4gXCRpZ25vcmVF eHBlY3RhdGlvbnMsCiAgICAgICAgICdGfGZhaWxpbmctZmlsZXMnID0+IFwkZmFpbGluZ09ubHks CkBAIC0xNDEsNyArMTM5LDcgQEAgc3ViIHByb2Nlc3NDTEkgewogICAgICAgICAnc3RhdHMnID0+ IFwkc3RhdHMsCiAgICAgICAgICdyfHJlc3VsdHM9cycgPT4gXCRzcGVjaWZpZWRSZXN1bHRzRmls ZSwKICAgICAgICAgJ3RpbWVvdXQ9aScgPT4gXCR0aW1lb3V0LAotICAgICAgICAnU3xza2lwcGVk LWZpbGVzJyA9PiBcJHNraXBwZWRPbmx5LAorICAgICAgICAnc3xza2lwcGVkLWZpbGVzJyA9PiBc JHNraXBwZWRPbmx5LAogICAgICk7CiAKICAgICBpZiAoJGhlbHApIHsKQEAgLTI5MSw4ICsyODks MTEgQEAgc3ViIG1haW4gewogCiAgICAgcHJpbnQgJGRlZmZoIGdldEhhcm5lc3MoXEBkZWZhdWx0 SGFybmVzc0ZpbGVzKTsKIAotICAgICMgSWYgbm90IGNvbW1hbmRsaW5lIHRlc3QgcGF0aCBzdXBw bGllZCwgdXNlIHRoZSByb290IGRpcmVjdG9yeSBvZiBhbGwgdGVzdHMuCi0gICAgcHVzaChAY2xp VGVzdERpcnMsICd0ZXN0JykgaWYgbm90IEBjbGlUZXN0RGlyczsKKyAgICBpZiAoIUBjbGlUZXN0 RGlycykgeworICAgICAgICAjIFVzZSB0aGUgcm9vdCBkaXJlY3Rvcnkgb2YgYWxsIHRlc3RzIGlm IG5vdCB0ZXN0IHBhdGggc3VwcGxpZWQgZnJvbSB0aGUgY2xpLgorICAgICAgICBwdXNoKEBjbGlU ZXN0RGlycywgJ3Rlc3QnKTsKKyAgICAgICAgJHJ1bm5pbmdBbGxUZXN0cyA9IDE7CisgICAgfQog CiAgICAgaWYgKCRsYXRlc3RJbXBvcnQpIHsKICAgICAgICAgQGZpbGVzID0gbG9hZEltcG9ydEZp bGUoKTsKQEAgLTMwMCw3ICszMDEsNiBAQCBzdWIgbWFpbiB7CiAgICAgICAgICMgSWYgd2Ugb25s eSB3YW50IHRvIHJlLXJ1biBmYWlsdXJlLCBvbmx5IHJ1biB0ZXN0cyBpbiByZXN1bHRzIGZpbGUK ICAgICAgICAgZmluZEFsbEZhaWxpbmcoKTsKICAgICB9IGVsc2UgewotICAgICAgICAkcnVubmlu Z0FsbFRlc3RzID0gMTsKICAgICAgICAgIyBPdGhlcndpc2UsIGdldCBhbGwgZmlsZXMgZnJvbSBk aXJlY3RvcnkKICAgICAgICAgZm9yZWFjaCBteSAkdGVzdHNEaXIgKEBjbGlUZXN0RGlycykgewog ICAgICAgICAgICAgZmluZCgKQEAgLTQ0NywyMSArNDQ3LDIxIEBAIHN1YiBtYWluIHsKIAogICAg IHByaW50KCJcbiIpOwogCi0gICAgaWYgKCRzYXZlRXhwZWN0YXRpb25zKSB7CisgICAgaWYgKCRy dW5uaW5nQWxsVGVzdHMpIHsKICAgICAgICAgRHVtcEZpbGUoJGV4cGVjdGF0aW9uc0ZpbGUsIFwl ZmFpbGVkKTsKICAgICAgICAgcHJpbnQgIlNhdmVkIGV4cGVjdGF0aW9uIGZpbGUgaW46ICRleHBl Y3RhdGlvbnNGaWxlXG4iOwogICAgIH0KLSAgICBpZiAoJHJ1bm5pbmdBbGxUZXN0cykgewotICAg ICAgICBpZiAoISAtZSAkcmVzdWx0c0RpcikgewotICAgICAgICAgICAgbWtwYXRoKCRyZXN1bHRz RGlyKTsKLSAgICAgICAgfQotICAgICAgICAkcmVzdWx0c0ZpbGUgPSBhYnNfcGF0aCgiJHJlc3Vs dHNEaXIvcmVzdWx0cy55YW1sIik7CiAKLSAgICAgICAgRHVtcEZpbGUoJHJlc3VsdHNGaWxlLCBc QHJlc3VsdHMpOwotICAgICAgICBwcmludCAiU2F2ZWQgYWxsIHRoZSByZXN1bHRzIGluICRyZXN1 bHRzRmlsZVxuIjsKLSAgICAgICAgc3VtbWFyaXplUmVzdWx0cygpOworICAgIGlmICghIC1lICRy ZXN1bHRzRGlyKSB7CisgICAgICAgIG1rcGF0aCgkcmVzdWx0c0Rpcik7CiAgICAgfQogCisgICAg JHJlc3VsdHNGaWxlID0gYWJzX3BhdGgoIiRyZXN1bHRzRGlyL3Jlc3VsdHMueWFtbCIpOworICAg IER1bXBGaWxlKCRyZXN1bHRzRmlsZSwgXEByZXN1bHRzKTsKKyAgICBwcmludCAiU2F2ZWQgYWxs IHRoZSByZXN1bHRzIGluICRyZXN1bHRzRmlsZVxuIjsKKworICAgIHN1bW1hcml6ZVJlc3VsdHMo KTsKKwogICAgIG15ICR0b3RhbCA9IHNjYWxhciBAcmVzdWx0cyAtICRza2lwZmlsZWNvdW50Owog ICAgIHByaW50ICJcbiIgLiAkdG90YWwgLiAiIHRlc3RzIHJhblxuIjsKIApAQCAtMTA2OSwxMCAr MTA2OSw2IEBAIEZpbHRlciB0ZXN0IG9uIGxpc3Qgb2YgZmVhdHVyZXMgKG9ubHkgcnVucyB0ZXN0 cyBpbiBmZWF0dXJlIGxpc3QpLgogCiBTcGVjaWZ5IG9uZSBvciBtb3JlIHNwZWNpZmljIHRlc3Qy NjIgZGlyZWN0b3J5IG9mIHRlc3QgdG8gcnVuLCByZWxhdGl2ZSB0byB0aGUgcm9vdCB0ZXN0MjYy IGRpcmVjdG9yeS4gRm9yIGV4YW1wbGUsIC0tdGVzdC1vbmx5ICd0ZXN0L2J1aWx0LWlucy9OdW1i ZXIvcHJvdG90eXBlJwogCi09aXRlbSBCPC0tc2F2ZSwgLXM+Ci0KLU92ZXJ3cml0ZXMgdGhlIHRl c3QyNjItZXhwZWN0YXRpb25zLnlhbWwgZmlsZSB3aXRoIHRoZSBjdXJyZW50IGxpc3Qgb2YgdGVz dDI2MiBmaWxlcyBhbmQgdGVzdCByZXN1bHRzLgotCiA9aXRlbSBCPC0tZXhwZWN0YXRpb25zLCAt ZT4KIAogU3BlY2lmeSBhIGV4cGVjdGF0aW9ucyBmaWxlIGZvciBsb2FkaW5nIGFuZCBzYXZpbmcu ICBJZiBub3QgcHJvdmlkZWQsIHNjcmlwdCB3aWxsIGxvYWQgYW5kIHNhdmUgdG8gSlNUZXN0cy90 ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1sLgpAQCAtMTA4OSw3ICsxMDg1LDcgQEAgUnVucyBhbGwg dGVzdCBmaWxlcyB0aGF0IGZhaWxlZCBpbiBhIGdpdmVuIHJlc3VsdHMgZmlsZSAoc3BlY2lmYyB3 aXRoIC0tcmVzdWx0cykKIAogUnVucyB0aGUgdGVzdCBmaWxlcyBsaXN0ZWQgaW4gdGhlIGxhc3Qg aW1wb3J0ICguL0pTVGVzdHMvdGVzdDI2Mi9sYXRlc3QtY2hhbmdlcy1zdW1tYXJ5LnR4dCkuCiAK LT1pdGVtIEI8LS1za2lwcGVkLWZpbGVzLCAtUz4KKz1pdGVtIEI8LS1za2lwcGVkLWZpbGVzLCAt cz4KIAogUnVucyBhbGwgdGVzdCBmaWxlcyB0aGF0IGFyZSBza2lwcGVkIGFjY29yZGluZyB0byB0 aGUgY29uZmlnLnlhbWwgZmlsZS4KIAo=