186777 2018-06-18 10:35:48 -0700 Resource Load Statistics: Make sure to call callbacks even if there is no store (test infrastructure) 2018-06-19 00:48:52 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=183714 InRadar P2 Normal --- 1 wilander wilander bfulgham calvaris cdumez commit-queue webkit-bug-importer oldest_to_newest 1434053 0 wilander 2018-06-18 10:35:48 -0700 We have a couple of instances in WKWebsiteDataStoreRef.cpp where if there is no resource load statistics store we do an early return, like so: if (!store) return; These instances need to also call the callback if there is one. Note that these functions are used for testing and this change is part of addressing test flakiness, for instance in https://bugs.webkit.org/show_bug.cgi?id=183714. 1434061 1 webkit-bug-importer 2018-06-18 10:53:29 -0700 <rdar://problem/41216181> 1434062 2 wilander 2018-06-18 10:54:30 -0700 (For any GTK people who get notified of this bug: I accidentally chose GTK instead of Misc. Sorry about that.) 1434065 3 342952 wilander 2018-06-18 10:57:52 -0700 Created attachment 342952 Patch 1434185 4 342952 wilander 2018-06-18 15:00:17 -0700 Comment on attachment 342952 Patch Thanks, Chris! 1434197 5 342952 commit-queue 2018-06-18 15:27:04 -0700 Comment on attachment 342952 Patch Clearing flags on attachment: 342952 Committed r232950: <https://trac.webkit.org/changeset/232950> 1434198 6 commit-queue 2018-06-18 15:27:06 -0700 All reviewed patches have been landed. Closing bug. 342952 2018-06-18 10:57:52 -0700 2018-06-18 15:27:04 -0700 Patch bug-186777-20180618105751.patch text/plain 4028 wilander U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyOTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQyZjY0MjQ3ZTNlNmRjZGQy YTNjNzc4NTQzMjhlMzIxMjFhMjU2MjkuLmM1Y2UzYWRiZjI2ZGVkMjQ4MzJiMmY2NjRhMWE0Y2E0 NDUyYmI5NGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDYtMTggIEpvaG4gV2ls YW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmVzb3VyY2UgTG9hZCBTdGF0 aXN0aWNzOiBNYWtlIHN1cmUgdG8gY2FsbCBjYWxsYmFja3MgZXZlbiBpZiB0aGVyZSBpcyBubyBz dG9yZSAodGVzdCBpbmZyYXN0cnVjdHVyZSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4Njc3NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDEyMTYx ODE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL0MvV0tXZWJzaXRlRGF0YVN0b3JlUmVmLmNwcDoKKyAgICAgICAgKFdLV2Vi c2l0ZURhdGFTdG9yZVN0YXRpc3RpY3NVcGRhdGVDb29raWVQYXJ0aXRpb25pbmcpOgorICAgICAg ICAoV0tXZWJzaXRlRGF0YVN0b3JlU2V0U3RhdGlzdGljc1Nob3VsZFBhcnRpdGlvbkNvb2tpZXNG b3JIb3N0KToKKyAgICAgICAgKFdLV2Vic2l0ZURhdGFTdG9yZVN0YXRpc3RpY3NDbGVhckluTWVt b3J5QW5kUGVyc2lzdGVudFN0b3JlKToKKyAgICAgICAgKFdLV2Vic2l0ZURhdGFTdG9yZVN0YXRp c3RpY3NDbGVhckluTWVtb3J5QW5kUGVyc2lzdGVudFN0b3JlTW9kaWZpZWRTaW5jZUhvdXJzKToK KwogMjAxOC0wNi0xOCAgS2FybCBMZXBsYXQgIDxrYXJsLmxlcGxhdF9leHRAc29mdGF0aG9tZS5j b20+CiAKICAgICAgICAgW1RocmVhZGVkIHBhaW50aW5nRW5naW5lXSBGaXggcmVuZGVyaW5nIGds aXRjaGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS1dlYnNp dGVEYXRhU3RvcmVSZWYuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tXZWJz aXRlRGF0YVN0b3JlUmVmLmNwcAppbmRleCA3OTVjMzYzNGZhYjVjZDY2MTBiNjAyMDFjZjAzNDEy YjI5OTU1ZTdlLi4yZTk5OTI5ZjJjODk4MmE2MDIyZjU2MjJkZjgzNjJhZDlhOWMxYzhkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS1dlYnNpdGVEYXRhU3RvcmVS ZWYuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLV2Vic2l0ZURhdGFT dG9yZVJlZi5jcHAKQEAgLTI5Myw4ICsyOTMsMTAgQEAgdm9pZCBXS1dlYnNpdGVEYXRhU3RvcmVT dGF0aXN0aWNzUHJvY2Vzc1N0YXRpc3RpY3NBbmREYXRhUmVjb3JkcyhXS1dlYnNpdGVEYXRhU3QK IHZvaWQgV0tXZWJzaXRlRGF0YVN0b3JlU3RhdGlzdGljc1VwZGF0ZUNvb2tpZVBhcnRpdGlvbmlu ZyhXS1dlYnNpdGVEYXRhU3RvcmVSZWYgZGF0YVN0b3JlUmVmLCB2b2lkKiBjb250ZXh0LCBXS1dl YnNpdGVEYXRhU3RvcmVTdGF0aXN0aWNzVXBkYXRlQ29va2llUGFydGl0aW9uaW5nRnVuY3Rpb24g Y2FsbGJhY2spCiB7CiAgICAgYXV0byogc3RvcmUgPSBXZWJLaXQ6OnRvSW1wbChkYXRhU3RvcmVS ZWYpLT53ZWJzaXRlRGF0YVN0b3JlKCkucmVzb3VyY2VMb2FkU3RhdGlzdGljcygpOwotICAgIGlm ICghc3RvcmUpCisgICAgaWYgKCFzdG9yZSkgeworICAgICAgICBjYWxsYmFjayhjb250ZXh0KTsK ICAgICAgICAgcmV0dXJuOworICAgIH0KIAogICAgIHN0b3JlLT5zY2hlZHVsZUNvb2tpZVBhcnRp dGlvbmluZ1VwZGF0ZShbY29udGV4dCwgY2FsbGJhY2tdKCkgewogICAgICAgICBjYWxsYmFjayhj b250ZXh0KTsKQEAgLTMwNCw4ICszMDYsMTAgQEAgdm9pZCBXS1dlYnNpdGVEYXRhU3RvcmVTdGF0 aXN0aWNzVXBkYXRlQ29va2llUGFydGl0aW9uaW5nKFdLV2Vic2l0ZURhdGFTdG9yZVJlZgogdm9p ZCBXS1dlYnNpdGVEYXRhU3RvcmVTZXRTdGF0aXN0aWNzU2hvdWxkUGFydGl0aW9uQ29va2llc0Zv ckhvc3QoV0tXZWJzaXRlRGF0YVN0b3JlUmVmIGRhdGFTdG9yZVJlZiwgV0tTdHJpbmdSZWYgaG9z dCwgYm9vbCB2YWx1ZSwgdm9pZCogY29udGV4dCwgV0tXZWJzaXRlRGF0YVN0b3JlU2V0U3RhdGlz dGljc1Nob3VsZFBhcnRpdGlvbkNvb2tpZXNGb3JIb3N0RnVuY3Rpb24gY2FsbGJhY2spCiB7CiAg ICAgYXV0byogc3RvcmUgPSBXZWJLaXQ6OnRvSW1wbChkYXRhU3RvcmVSZWYpLT53ZWJzaXRlRGF0 YVN0b3JlKCkucmVzb3VyY2VMb2FkU3RhdGlzdGljcygpOwotICAgIGlmICghc3RvcmUpCisgICAg aWYgKCFzdG9yZSkgeworICAgICAgICBjYWxsYmFjayhjb250ZXh0KTsKICAgICAgICAgcmV0dXJu OworICAgIH0KIAogICAgIGlmICh2YWx1ZSkKICAgICAgICAgc3RvcmUtPnNjaGVkdWxlQ29va2ll UGFydGl0aW9uaW5nVXBkYXRlRm9yRG9tYWlucyh7IFdlYktpdDo6dG9JbXBsKGhvc3QpLT5zdHJp bmcoKSB9LCB7IH0sIHsgfSwgV2ViS2l0OjpTaG91bGRDbGVhckZpcnN0OjpObywgW2NvbnRleHQs IGNhbGxiYWNrXSgpIHsKQEAgLTM4OCw4ICszOTIsMTAgQEAgdm9pZCBXS1dlYnNpdGVEYXRhU3Rv cmVTZXRTdGF0aXN0aWNzUHJ1bmVFbnRyaWVzRG93blRvKFdLV2Vic2l0ZURhdGFTdG9yZVJlZiBk YXQKIHZvaWQgV0tXZWJzaXRlRGF0YVN0b3JlU3RhdGlzdGljc0NsZWFySW5NZW1vcnlBbmRQZXJz aXN0ZW50U3RvcmUoV0tXZWJzaXRlRGF0YVN0b3JlUmVmIGRhdGFTdG9yZVJlZiwgdm9pZCogY29u dGV4dCwgV0tXZWJzaXRlRGF0YVN0b3JlU3RhdGlzdGljc0NsZWFySW5NZW1vcnlBbmRQZXJzaXN0 ZW50U3RvcmVGdW5jdGlvbiBjYWxsYmFjaykKIHsKICAgICBhdXRvKiBzdG9yZSA9IFdlYktpdDo6 dG9JbXBsKGRhdGFTdG9yZVJlZiktPndlYnNpdGVEYXRhU3RvcmUoKS5yZXNvdXJjZUxvYWRTdGF0 aXN0aWNzKCk7Ci0gICAgaWYgKCFzdG9yZSkKKyAgICBpZiAoIXN0b3JlKSB7CisgICAgICAgIGNh bGxiYWNrKGNvbnRleHQpOwogICAgICAgICByZXR1cm47CisgICAgfQogCiAgICAgc3RvcmUtPnNj aGVkdWxlQ2xlYXJJbk1lbW9yeUFuZFBlcnNpc3RlbnQoV2ViS2l0OjpXZWJSZXNvdXJjZUxvYWRT dGF0aXN0aWNzU3RvcmU6OlNob3VsZEdyYW5kZmF0aGVyOjpZZXMsIFtjb250ZXh0LCBjYWxsYmFj a10oKSB7CiAgICAgICAgIGNhbGxiYWNrKGNvbnRleHQpOwpAQCAtMzk5LDggKzQwNSwxMCBAQCB2 b2lkIFdLV2Vic2l0ZURhdGFTdG9yZVN0YXRpc3RpY3NDbGVhckluTWVtb3J5QW5kUGVyc2lzdGVu dFN0b3JlKFdLV2Vic2l0ZURhdGFTdAogdm9pZCBXS1dlYnNpdGVEYXRhU3RvcmVTdGF0aXN0aWNz Q2xlYXJJbk1lbW9yeUFuZFBlcnNpc3RlbnRTdG9yZU1vZGlmaWVkU2luY2VIb3VycyhXS1dlYnNp dGVEYXRhU3RvcmVSZWYgZGF0YVN0b3JlUmVmLCB1bnNpZ25lZCBob3Vycywgdm9pZCogY29udGV4 dCwgV0tXZWJzaXRlRGF0YVN0b3JlU3RhdGlzdGljc0NsZWFySW5NZW1vcnlBbmRQZXJzaXN0ZW50 U3RvcmVNb2RpZmllZFNpbmNlSG91cnNGdW5jdGlvbiBjYWxsYmFjaykKIHsKICAgICBhdXRvKiBz dG9yZSA9IFdlYktpdDo6dG9JbXBsKGRhdGFTdG9yZVJlZiktPndlYnNpdGVEYXRhU3RvcmUoKS5y ZXNvdXJjZUxvYWRTdGF0aXN0aWNzKCk7Ci0gICAgaWYgKCFzdG9yZSkKKyAgICBpZiAoIXN0b3Jl KSB7CisgICAgICAgIGNhbGxiYWNrKGNvbnRleHQpOwogICAgICAgICByZXR1cm47CisgICAgfQog CiAgICAgc3RvcmUtPnNjaGVkdWxlQ2xlYXJJbk1lbW9yeUFuZFBlcnNpc3RlbnQoV2FsbFRpbWU6 Om5vdygpIC0gU2Vjb25kczo6ZnJvbUhvdXJzKGhvdXJzKSwgV2ViS2l0OjpXZWJSZXNvdXJjZUxv YWRTdGF0aXN0aWNzU3RvcmU6OlNob3VsZEdyYW5kZmF0aGVyOjpZZXMsIFtjb250ZXh0LCBjYWxs YmFja10oKSB7CiAgICAgICAgIGNhbGxiYWNrKGNvbnRleHQpOwo=