186738 2018-06-16 12:39:18 -0700 SourceProviderCache wastes 295KB of HashTable capacity on nytimes.com 2018-06-16 12:40:51 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 simon.fraser webkit-unassigned keith_miller saam simon.fraser oldest_to_newest 1433799 0 simon.fraser 2018-06-16 12:39:18 -0700 Using tooling from bug 186698, loading can and running "notifyutil -p com.apple.WebKit.dumpHashTableCapacity" shows: Wasted capacity: 294864 bytes (used 145584 of 440448 bytes, utilization: 33.05%) - 770 allocations 1 0x1166ce2d5 WTF::HashTable<int, WTF::KeyValuePair<int, std::__1::unique_ptr<JSC::SourceProviderCacheItem, std::__1::default_delete<JSC::SourceProviderCacheItem> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<int, std::__1::unique_ptr<JSC::SourceProviderCacheItem, std::__1::default_delete<JSC::SourceProviderCacheItem> > > >, WTF::IntHash<int>, WTF::HashMap<int, std::__1::unique_ptr<JSC::SourceProviderCacheItem, std::__1::default_delete<JSC::SourceProviderCacheItem> >, WTF::IntHash<int>, WTF::UnsignedWithZeroKeyHashTraits<int>, WTF::HashTraits<std::__1::unique_ptr<JSC::SourceProviderCacheItem, std::__1::default_delete<JSC::SourceProviderCacheItem> > > >::KeyValuePairTraits, WTF::UnsignedWithZeroKeyHashTraits<int> >::HashTable() 2 0x1166ce2b5 WTF::HashMap<int, std::__1::unique_ptr<JSC::SourceProviderCacheItem, std::__1::default_delete<JSC::SourceProviderCacheItem> >, WTF::IntHash<int>, WTF::UnsignedWithZeroKeyHashTraits<int>, WTF::HashTraits<std::__1::unique_ptr<JSC::SourceProviderCacheItem, std::__1::default_delete<JSC::SourceProviderCacheItem> > > >::HashMap() 3 0x1166ce295 WTF::HashMap<int, std::__1::unique_ptr<JSC::SourceProviderCacheItem, std::__1::default_delete<JSC::SourceProviderCacheItem> >, WTF::IntHash<int>, WTF::UnsignedWithZeroKeyHashTraits<int>, WTF::HashTraits<std::__1::unique_ptr<JSC::SourceProviderCacheItem, std::__1::default_delete<JSC::SourceProviderCacheItem> > > >::HashMap() 4 0x1166ce24f JSC::SourceProviderCache::SourceProviderCache() 5 0x1166c6755 JSC::SourceProviderCache::SourceProviderCache() 6 0x1166c6615 JSC::VM::addSourceProviderCache(JSC::SourceProvider*) 7 0x116293338 JSC::Parser<JSC::Lexer<unsigned char> >::Parser(JSC::VM*, JSC::SourceCode const&, JSC::JSParserBuiltinMode, JSC::JSParserStrictMode, JSC::JSParserScriptMode, JSC::SourceParseMode, JSC::SuperBinding, JSC::ConstructorKind, JSC::DerivedContextType, bool, JSC::EvalContextType, JSC::DebuggerParseData*) 8 0x116293d71 JSC::Parser<JSC::Lexer<unsigned char> >::Parser(JSC::VM*, JSC::SourceCode const&, JSC::JSParserBuiltinMode, JSC::JSParserStrictMode, JSC::JSParserScriptMode, JSC::SourceParseMode, JSC::SuperBinding, JSC::ConstructorKind, JSC::DerivedContextType, bool, JSC::EvalContextType, JSC::DebuggerParseData*) 1433802 1 simon.fraser 2018-06-16 12:40:51 -0700 More here: Wasted capacity: 204048 bytes (used 102640 of 306688 bytes, utilization: 33.47%) - 11 allocations 1 0x1166ce2d5 WTF::HashTable<int, WTF::KeyValuePair<int, std::__1::unique_ptr<JSC::SourceProviderCacheItem, std::__1::default_delete<JSC::SourceProviderCacheItem> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<int, std::__1::unique_ptr<JSC::SourceProviderCacheItem, std::__1::default_delete<JSC::SourceProviderCacheItem> > > >, WTF::IntHash<int>, WTF::HashMap<int, std::__1::unique_ptr<JSC::SourceProviderCacheItem, std::__1::default_delete<JSC::SourceProviderCacheItem> >, WTF::IntHash<int>, WTF::UnsignedWithZeroKeyHashTraits<int>, WTF::HashTraits<std::__1::unique_ptr<JSC::SourceProviderCacheItem, std::__1::default_delete<JSC::SourceProviderCacheItem> > > >::KeyValuePairTraits, WTF::UnsignedWithZeroKeyHashTraits<int> >::HashTable() 2 0x1166ce2b5 WTF::HashMap<int, std::__1::unique_ptr<JSC::SourceProviderCacheItem, std::__1::default_delete<JSC::SourceProviderCacheItem> >, WTF::IntHash<int>, WTF::UnsignedWithZeroKeyHashTraits<int>, WTF::HashTraits<std::__1::unique_ptr<JSC::SourceProviderCacheItem, std::__1::default_delete<JSC::SourceProviderCacheItem> > > >::HashMap() 3 0x1166ce295 WTF::HashMap<int, std::__1::unique_ptr<JSC::SourceProviderCacheItem, std::__1::default_delete<JSC::SourceProviderCacheItem> >, WTF::IntHash<int>, WTF::UnsignedWithZeroKeyHashTraits<int>, WTF::HashTraits<std::__1::unique_ptr<JSC::SourceProviderCacheItem, std::__1::default_delete<JSC::SourceProviderCacheItem> > > >::HashMap() 4 0x1166ce24f JSC::SourceProviderCache::SourceProviderCache() 5 0x1166c6755 JSC::SourceProviderCache::SourceProviderCache() 6 0x1166c6615 JSC::VM::addSourceProviderCache(JSC::SourceProvider*) 7 0x1162a2a98 JSC::Parser<JSC::Lexer<unsigned short> >::Parser(JSC::VM*, JSC::SourceCode const&, JSC::JSParserBuiltinMode, JSC::JSParserStrictMode, JSC::JSParserScriptMode, JSC::SourceParseMode, JSC::SuperBinding, JSC::ConstructorKind, JSC::DerivedContextType, bool, JSC::EvalContextType, JSC::DebuggerParseData*) 8 0x1162a2f81 JSC::Parser<JSC::Lexer<unsigned short> >::Parser(JSC::VM*, JSC::SourceCode const&, JSC::JSParserBuiltinMode, JSC::JSParserStrictMode, JSC::JSParserScriptMode, JSC::SourceParseMode, JSC::SuperBinding, JSC::ConstructorKind, JSC::DerivedContextType, bool, JSC::EvalContextType, JSC::DebuggerParseData*)