<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>186725</bug_id>
          
          <creation_ts>2018-06-16 12:17:54 -0700</creation_ts>
          <short_desc>InferredTypeTable wastes 2MB of HashTable capacity on cnn.com</short_desc>
          <delta_ts>2019-01-29 22:27:12 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>CONFIGURATION CHANGED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=190906</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Simon Fraser (smfr)">simon.fraser</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>keith_miller</cc>
    
    <cc>saam</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1433761</commentid>
    <comment_count>0</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-06-16 12:17:54 -0700</bug_when>
    <thetext>Using tooling from bug 186698, loading can and running &quot;notifyutil -p com.apple.WebKit.dumpHashTableCapacity&quot; shows:

Wasted capacity: 1 998 144 bytes (used 904640 of 2902784 bytes, utilization: 31.16%) - 8209 allocations
1   0x116495945 WTF::HashTable&lt;WTF::RefPtr&lt;WTF::UniquedStringImpl, WTF::DumbPtrTraits&lt;WTF::UniquedStringImpl&gt; &gt;, WTF::KeyValuePair&lt;WTF::RefPtr&lt;WTF::UniquedStringImpl, WTF::DumbPtrTraits&lt;WTF::UniquedStringImpl&gt; &gt;, JSC::WriteBarrier&lt;JSC::InferredType, WTF::DumbPtrTraits&lt;JSC::InferredType&gt; &gt; &gt;, WTF::KeyValuePairKeyExtractor&lt;WTF::KeyValuePair&lt;WTF::RefPtr&lt;WTF::UniquedStringImpl, WTF::DumbPtrTraits&lt;WTF::UniquedStringImpl&gt; &gt;, JSC::WriteBarrier&lt;JSC::InferredType, WTF::DumbPtrTraits&lt;JSC::InferredType&gt; &gt; &gt; &gt;, JSC::IdentifierRepHash, WTF::HashMap&lt;WTF::RefPtr&lt;WTF::UniquedStringImpl, WTF::DumbPtrTraits&lt;WTF::UniquedStringImpl&gt; &gt;, JSC::WriteBarrier&lt;JSC::InferredType, WTF::DumbPtrTraits&lt;JSC::InferredType&gt; &gt;, JSC::IdentifierRepHash, WTF::HashTraits&lt;WTF::RefPtr&lt;WTF::UniquedStringImpl, WTF::DumbPtrTraits&lt;WTF::UniquedStringImpl&gt; &gt; &gt;, WTF::HashTraits&lt;JSC::WriteBarrier&lt;JSC::InferredType, WTF::DumbPtrTraits&lt;JSC::InferredType&gt; &gt; &gt; &gt;::KeyValuePairTraits, WTF::HashTraits&lt;WTF::RefPtr&lt;WTF::UniquedStringImpl, WTF::DumbPtrTraits&lt;WTF::UniquedStringImpl&gt; &gt; &gt; &gt;::HashTable()
2   0x116495925 WTF::HashMap&lt;WTF::RefPtr&lt;WTF::UniquedStringImpl, WTF::DumbPtrTraits&lt;WTF::UniquedStringImpl&gt; &gt;, JSC::WriteBarrier&lt;JSC::InferredType, WTF::DumbPtrTraits&lt;JSC::InferredType&gt; &gt;, JSC::IdentifierRepHash, WTF::HashTraits&lt;WTF::RefPtr&lt;WTF::UniquedStringImpl, WTF::DumbPtrTraits&lt;WTF::UniquedStringImpl&gt; &gt; &gt;, WTF::HashTraits&lt;JSC::WriteBarrier&lt;JSC::InferredType, WTF::DumbPtrTraits&lt;JSC::InferredType&gt; &gt; &gt; &gt;::HashMap()
3   0x116489b15 WTF::HashMap&lt;WTF::RefPtr&lt;WTF::UniquedStringImpl, WTF::DumbPtrTraits&lt;WTF::UniquedStringImpl&gt; &gt;, JSC::WriteBarrier&lt;JSC::InferredType, WTF::DumbPtrTraits&lt;JSC::InferredType&gt; &gt;, JSC::IdentifierRepHash, WTF::HashTraits&lt;WTF::RefPtr&lt;WTF::UniquedStringImpl, WTF::DumbPtrTraits&lt;WTF::UniquedStringImpl&gt; &gt; &gt;, WTF::HashTraits&lt;JSC::WriteBarrier&lt;JSC::InferredType, WTF::DumbPtrTraits&lt;JSC::InferredType&gt; &gt; &gt; &gt;::HashMap()
4   0x116489aea JSC::InferredTypeTable::InferredTypeTable(JSC::VM&amp;)
5   0x11648894d JSC::InferredTypeTable::InferredTypeTable(JSC::VM&amp;)
6   0x1164888d1 JSC::InferredTypeTable::create(JSC::VM&amp;)
7   0x116675e46 JSC::Structure::willStoreValueSlow(JSC::VM&amp;, JSC::PropertyName, JSC::JSValue, bool, JSC::InferredTypeTable::StoredPropertyAge)
8   0x11536b938 JSC::Structure::willStoreValueForNewTransition(JSC::VM&amp;, JSC::PropertyName, JSC::JSValue, bool)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1433762</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-06-16 12:18:17 -0700</bug_when>
    <thetext>&lt;rdar://problem/41189073&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1499907</commentid>
    <comment_count>2</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-01-29 22:27:12 -0800</bug_when>
    <thetext>InferredTypeTable is now removed :)</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>