186717 2018-06-15 19:16:14 -0700 Better pack ResourceRequest 2018-06-19 09:27:40 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez commit-queue darin ggaren koivisto lforschler simon.fraser webkit-bug-importer oldest_to_newest 1433658 0 cdumez 2018-06-15 19:16:14 -0700 Better pack ResourceRequest to save some memory. 1433660 1 342867 cdumez 2018-06-15 19:19:33 -0700 Created attachment 342867 Patch 1433681 2 342867 simon.fraser 2018-06-15 21:55:54 -0700 Comment on attachment 342867 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342867&action=review > Source/WebCore/platform/network/ResourceRequestBase.h:245 > + String m_initiatorIdentifier; > + String m_cachePartition { emptyString() }; Wouldn't it be better to move the Strings before the bools? 1433754 3 342885 cdumez 2018-06-16 11:46:19 -0700 Created attachment 342885 Patch 1433755 4 cdumez 2018-06-16 11:46:38 -0700 (In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 342867 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342867&action=review > > > Source/WebCore/platform/network/ResourceRequestBase.h:245 > > + String m_initiatorIdentifier; > > + String m_cachePartition { emptyString() }; > > Wouldn't it be better to move the Strings before the bools? It does not help but I moved them for cleanliness. 1433891 5 342885 darin 2018-06-17 11:16:01 -0700 Comment on attachment 342885 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342885&action=review > Source/WebCore/ChangeLog:9 > + Better pack ResourceRequest to reduce its size from 240 to 232 bytes > + on Mac. What helps us monitor this in the future? I can easily imagine I might ruin the packing if it was invisible to me that I was doing that. Some kind of size static assertion? 1434188 6 342885 commit-queue 2018-06-18 15:14:39 -0700 Comment on attachment 342885 Patch Clearing flags on attachment: 342885 Committed r232949: <https://trac.webkit.org/changeset/232949> 1434189 7 commit-queue 2018-06-18 15:14:40 -0700 All reviewed patches have been landed. Closing bug. 1434409 8 webkit-bug-importer 2018-06-19 09:27:40 -0700 <rdar://problem/41252203> 342867 2018-06-15 19:19:33 -0700 2018-06-16 11:46:15 -0700 Patch bug-186717-20180615192002.patch text/plain 2392 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyODkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjlhMWY3NjNmNWQ1OThm NWIxM2ZiYmNmMzczMzc0NDU4OTYyZjM1Ni4uMTIyYjg0OGNhYTliN2QwYmYxODMwNDcxMWYyMDJj MTYwMjFiNzcxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA2LTE1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQmV0dGVyIHBhY2sgUmVzb3Vy Y2VSZXF1ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODY3MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCZXR0ZXIgcGFjayBSZXNvdXJjZVJlcXVlc3QgdG8gcmVkdWNlIGl0cyBzaXplIGZyb20gMjQw IHRvIDIzMiBieXRlcworICAgICAgICBvbiBNYWMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3 b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuaDoKKwogMjAxOC0wNi0xNSAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBBUEkgdGVzdCBjb3ZlcmFnZSBmb3IgU1cg UmVnaXN0cmF0aW9uRGF0YWJhc2UgZGVzdHJ1Y3Rpb24gYW5kIGZpeCBpc3N1ZXMgZm91bmQgYnkg dGhlIHRlc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVz b3VyY2VSZXF1ZXN0QmFzZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNv dXJjZVJlcXVlc3RCYXNlLmgKaW5kZXggNzUzNjAwOWUwOTY0MTYzZDZiYWZlYTNlNjNlODExOTBl Y2NiNDc0Ni4uODUwNGE5YzZjMTM4OWJiMjk3YTE0YTkwNTM1NmQzOTczZWNhODBlMyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RCYXNl LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RC YXNlLmgKQEAgLTIyNywyMiArMjI3LDIyIEBAIHByb3RlY3RlZDoKICAgICBWZWN0b3I8U3RyaW5n PiBtX3Jlc3BvbnNlQ29udGVudERpc3Bvc2l0aW9uRW5jb2RpbmdGYWxsYmFja0FycmF5OwogICAg IFJlZlB0cjxGb3JtRGF0YT4gbV9odHRwQm9keTsKICAgICBSZXNvdXJjZVJlcXVlc3RDYWNoZVBv bGljeSBtX2NhY2hlUG9saWN5IHsgVXNlUHJvdG9jb2xDYWNoZVBvbGljeSB9OworICAgIFNhbWVT aXRlRGlzcG9zaXRpb24gbV9zYW1lU2l0ZURpc3Bvc2l0aW9uIHsgU2FtZVNpdGVEaXNwb3NpdGlv bjo6VW5zcGVjaWZpZWQgfTsKKyAgICBSZXNvdXJjZUxvYWRQcmlvcml0eSBtX3ByaW9yaXR5IHsg UmVzb3VyY2VMb2FkUHJpb3JpdHk6OkxvdyB9OworICAgIFJlcXVlc3RlciBtX3JlcXVlc3RlciB7 IFJlcXVlc3Rlcjo6VW5zcGVjaWZpZWQgfTsKICAgICBib29sIG1fYWxsb3dDb29raWVzIHsgZmFs c2UgfTsKICAgICBtdXRhYmxlIGJvb2wgbV9yZXNvdXJjZVJlcXVlc3RVcGRhdGVkIHsgZmFsc2Ug fTsKICAgICBtdXRhYmxlIGJvb2wgbV9wbGF0Zm9ybVJlcXVlc3RVcGRhdGVkIHsgZmFsc2UgfTsK ICAgICBtdXRhYmxlIGJvb2wgbV9yZXNvdXJjZVJlcXVlc3RCb2R5VXBkYXRlZCB7IGZhbHNlIH07 CiAgICAgbXV0YWJsZSBib29sIG1fcGxhdGZvcm1SZXF1ZXN0Qm9keVVwZGF0ZWQgeyBmYWxzZSB9 OwogICAgIGJvb2wgbV9oaWRkZW5Gcm9tSW5zcGVjdG9yIHsgZmFsc2UgfTsKLSAgICBTYW1lU2l0 ZURpc3Bvc2l0aW9uIG1fc2FtZVNpdGVEaXNwb3NpdGlvbiB7IFNhbWVTaXRlRGlzcG9zaXRpb246 OlVuc3BlY2lmaWVkIH07CiAgICAgYm9vbCBtX2lzVG9wU2l0ZSB7IGZhbHNlIH07Ci0gICAgUmVz b3VyY2VMb2FkUHJpb3JpdHkgbV9wcmlvcml0eSB7IFJlc291cmNlTG9hZFByaW9yaXR5OjpMb3cg fTsKLSAgICBSZXF1ZXN0ZXIgbV9yZXF1ZXN0ZXIgeyBSZXF1ZXN0ZXI6OlVuc3BlY2lmaWVkIH07 Ci0gICAgU3RyaW5nIG1faW5pdGlhdG9ySWRlbnRpZmllcjsKLSAgICBTdHJpbmcgbV9jYWNoZVBh cnRpdGlvbiB7IGVtcHR5U3RyaW5nKCkgfTsKICNpZiBVU0UoU1lTVEVNX1BSRVZJRVcpCiAgICAg Ym9vbCBtX2lzU3lzdGVtUHJldmlldyB7IGZhbHNlIH07CiAgICAgSW50UmVjdCBtX3N5c3RlbVBy ZXZpZXdSZWN0OwogI2VuZGlmCisgICAgU3RyaW5nIG1faW5pdGlhdG9ySWRlbnRpZmllcjsKKyAg ICBTdHJpbmcgbV9jYWNoZVBhcnRpdGlvbiB7IGVtcHR5U3RyaW5nKCkgfTsKIAogcHJpdmF0ZToK ICAgICBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIGFzUmVzb3VyY2VSZXF1ZXN0KCkgY29uc3Q7Cg== 342885 2018-06-16 11:46:19 -0700 2018-06-18 15:14:39 -0700 Patch bug-186717-20180616114649.patch text/plain 2445 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyOTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzFhMzBmYzFmMmY3MTcz YTYzMmVmM2M2ZmIzOTU5MjNiOGEzZGEyNS4uYmFhZTRjMzEzZDFiYTVlNzA5ZWZlZTM3NWE3Njdm YTVmOTBhOGViMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA2LTE2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQmV0dGVyIHBhY2sgUmVzb3Vy Y2VSZXF1ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODY3MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCZXR0ZXIgcGFjayBSZXNvdXJjZVJlcXVlc3QgdG8gcmVkdWNlIGl0cyBzaXplIGZyb20gMjQw IHRvIDIzMiBieXRlcworICAgICAgICBvbiBNYWMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3 b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuaDoKKwogMjAxOC0wNi0xNSAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEJldHRlciBwYWNrIE1lZGlhUXVlcnkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXF1ZXN0QmFz ZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RCYXNl LmgKaW5kZXggNzUzNjAwOWUwOTY0MTYzZDZiYWZlYTNlNjNlODExOTBlY2NiNDc0Ni4uYzdjYjcy OWVhMmUxZDczNGYzNGEzOTk1NTk0MjE2ZjY0MDE2MThiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RCYXNlLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RCYXNlLmgKQEAgLTIyMywy MiArMjIzLDIyIEBAIHByb3RlY3RlZDoKICAgICBkb3VibGUgbV90aW1lb3V0SW50ZXJ2YWw7IC8v IDAgaXMgYSBtYWdpYyB2YWx1ZSBmb3IgcGxhdGZvcm0gZGVmYXVsdCBvbiBwbGF0Zm9ybXMgdGhh dCBoYXZlIG9uZS4KICAgICBVUkwgbV9maXJzdFBhcnR5Rm9yQ29va2llczsKICAgICBTdHJpbmcg bV9odHRwTWV0aG9kOworICAgIFN0cmluZyBtX2luaXRpYXRvcklkZW50aWZpZXI7CisgICAgU3Ry aW5nIG1fY2FjaGVQYXJ0aXRpb24geyBlbXB0eVN0cmluZygpIH07CiAgICAgSFRUUEhlYWRlck1h cCBtX2h0dHBIZWFkZXJGaWVsZHM7CiAgICAgVmVjdG9yPFN0cmluZz4gbV9yZXNwb25zZUNvbnRl bnREaXNwb3NpdGlvbkVuY29kaW5nRmFsbGJhY2tBcnJheTsKICAgICBSZWZQdHI8Rm9ybURhdGE+ IG1faHR0cEJvZHk7CiAgICAgUmVzb3VyY2VSZXF1ZXN0Q2FjaGVQb2xpY3kgbV9jYWNoZVBvbGlj eSB7IFVzZVByb3RvY29sQ2FjaGVQb2xpY3kgfTsKKyAgICBTYW1lU2l0ZURpc3Bvc2l0aW9uIG1f c2FtZVNpdGVEaXNwb3NpdGlvbiB7IFNhbWVTaXRlRGlzcG9zaXRpb246OlVuc3BlY2lmaWVkIH07 CisgICAgUmVzb3VyY2VMb2FkUHJpb3JpdHkgbV9wcmlvcml0eSB7IFJlc291cmNlTG9hZFByaW9y aXR5OjpMb3cgfTsKKyAgICBSZXF1ZXN0ZXIgbV9yZXF1ZXN0ZXIgeyBSZXF1ZXN0ZXI6OlVuc3Bl Y2lmaWVkIH07CiAgICAgYm9vbCBtX2FsbG93Q29va2llcyB7IGZhbHNlIH07CiAgICAgbXV0YWJs ZSBib29sIG1fcmVzb3VyY2VSZXF1ZXN0VXBkYXRlZCB7IGZhbHNlIH07CiAgICAgbXV0YWJsZSBi b29sIG1fcGxhdGZvcm1SZXF1ZXN0VXBkYXRlZCB7IGZhbHNlIH07CiAgICAgbXV0YWJsZSBib29s IG1fcmVzb3VyY2VSZXF1ZXN0Qm9keVVwZGF0ZWQgeyBmYWxzZSB9OwogICAgIG11dGFibGUgYm9v bCBtX3BsYXRmb3JtUmVxdWVzdEJvZHlVcGRhdGVkIHsgZmFsc2UgfTsKICAgICBib29sIG1faGlk ZGVuRnJvbUluc3BlY3RvciB7IGZhbHNlIH07Ci0gICAgU2FtZVNpdGVEaXNwb3NpdGlvbiBtX3Nh bWVTaXRlRGlzcG9zaXRpb24geyBTYW1lU2l0ZURpc3Bvc2l0aW9uOjpVbnNwZWNpZmllZCB9Owog ICAgIGJvb2wgbV9pc1RvcFNpdGUgeyBmYWxzZSB9OwotICAgIFJlc291cmNlTG9hZFByaW9yaXR5 IG1fcHJpb3JpdHkgeyBSZXNvdXJjZUxvYWRQcmlvcml0eTo6TG93IH07Ci0gICAgUmVxdWVzdGVy IG1fcmVxdWVzdGVyIHsgUmVxdWVzdGVyOjpVbnNwZWNpZmllZCB9OwotICAgIFN0cmluZyBtX2lu aXRpYXRvcklkZW50aWZpZXI7Ci0gICAgU3RyaW5nIG1fY2FjaGVQYXJ0aXRpb24geyBlbXB0eVN0 cmluZygpIH07CiAjaWYgVVNFKFNZU1RFTV9QUkVWSUVXKQogICAgIGJvb2wgbV9pc1N5c3RlbVBy ZXZpZXcgeyBmYWxzZSB9OwogICAgIEludFJlY3QgbV9zeXN0ZW1QcmV2aWV3UmVjdDsK