186708 2018-06-15 15:10:04 -0700 CSSFontFace wastes 59KB of Vector capacity on nytimes.com 2018-06-20 10:14:05 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser andersca commit-queue mmaxfield simon.fraser webkit-bug-importer oldest_to_newest 1433593 0 simon.fraser 2018-06-15 15:10:04 -0700 Tooling from bug 186698: Wasted capacity: 59000 bytes (used 13320 of 72320 bytes, utilization: 18.42%) - 565 allocations 1 0x107377885 WTF::VectorBuffer<std::__1::unique_ptr<WebCore::CSSFontFaceSource, std::__1::default_delete<WebCore::CSSFontFaceSource> >, 0ul>::VectorBuffer() 2 0x107377865 WTF::Vector<std::__1::unique_ptr<WebCore::CSSFontFaceSource, std::__1::default_delete<WebCore::CSSFontFaceSource> >, 0ul, WTF::CrashOnOverflow, 16ul>::Vector() 3 0x10735c535 WTF::Vector<std::__1::unique_ptr<WebCore::CSSFontFaceSource, std::__1::default_delete<WebCore::CSSFontFaceSource> >, 0ul, WTF::CrashOnOverflow, 16ul>::Vector() 4 0x10735c2f1 WebCore::CSSFontFace::CSSFontFace(WebCore::CSSFontSelector*, WebCore::StyleRuleFontFace*, WebCore::FontFace*, bool) 5 0x10735c63e WebCore::CSSFontFace::CSSFontFace(WebCore::CSSFontSelector*, WebCore::StyleRuleFontFace*, WebCore::FontFace*, bool) 6 0x10736559c WebCore::CSSFontFace::create(WebCore::CSSFontSelector*, WebCore::StyleRuleFontFace*, WebCore::FontFace*, bool) 7 0x10736ccd1 WebCore::CSSFontSelector::addFontFaceRule(WebCore::StyleRuleFontFace&, bool) 8 0x10736c6c9 WebCore::CSSFontSelector::buildCompleted() 1433594 1 webkit-bug-importer 2018-06-15 15:10:27 -0700 <rdar://problem/41173766> 1433852 2 342906 simon.fraser 2018-06-16 22:32:07 -0700 Created attachment 342906 Patch 1433876 3 342906 andersca 2018-06-17 08:57:42 -0700 Comment on attachment 342906 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342906&action=review > Source/WebCore/css/CSSFontFace.h:187 > + Vector<std::unique_ptr<CSSFontFaceSource>, 0, CrashOnOverflow, 0> m_sources; This declaration is really confusing, it's not at all clear what the zeroes mean. I wonder if it could be made more clear by adding a template alias declaration to Vector.h. 1434831 4 342906 commit-queue 2018-06-20 10:14:04 -0700 Comment on attachment 342906 Patch Clearing flags on attachment: 342906 Committed r233014: <https://trac.webkit.org/changeset/233014> 1434832 5 commit-queue 2018-06-20 10:14:05 -0700 All reviewed patches have been landed. Closing bug. 342906 2018-06-16 22:32:07 -0700 2018-06-20 10:14:04 -0700 Patch bug-186708-20180616223207.patch text/plain 1434 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyOTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODAyMjE5MDNhNTJlZjg2 ZGExMGUwZWJiNTgxNjFlZTBmNTMxZjg3ZC4uNjc2YjY4MGE2MjA0MThiZTU5MjA4ZTFhNjMxYTE4 YmNjZTk1ODA5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA2LTE2ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIENTU0ZvbnRGYWNl IHdhc3RlcyA1OUtCIG9mIFZlY3RvciBjYXBhY2l0eSBvbiBueXRpbWVzLmNvbQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2NzA4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW9zdCBDU1NGb250RmFjZSBo YXZlIG9uZSBvciB0d28gQ1NTRm9udEZhY2VTb3VyY2Ugc28gZG9uJ3QgYWxsb2NhdGUKKyAgICAg ICAgdmVjdG9yIGNhcGFjaXR5IGluIHRoZSBkZWZhdWx0IDE2LXNpemUgY2h1bmtzLgorCisgICAg ICAgICogY3NzL0NTU0ZvbnRGYWNlLmg6CisKIDIwMTgtMDYtMTUgIENocmlzIER1bWV6ICA8Y2R1 bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBTdHlsZVJ1bGVNZWRpYSB3YXN0ZXMgMTU4S0Igb2Yg VmVjdG9yIGNhcGFjaXR5IG9uIGNubi5jb20KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NGb250RmFjZS5oIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ZvbnRGYWNlLmgKaW5kZXgg MzQ2YTdiODYxYTdhZTM5ZmYwNWVlNmUzZTA1MzBjYWZiY2Y2NjA4Ny4uYWRlZmNiZWZhN2MxYzQ5 ODg2ZTZhZGY3ODRhOGFlYWFkZGE0NDVlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3Nz L0NTU0ZvbnRGYWNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ZvbnRGYWNlLmgKQEAg LTE4NCw3ICsxODQsNyBAQCBwcml2YXRlOgogICAgIEZvbnRGZWF0dXJlU2V0dGluZ3MgbV9mZWF0 dXJlU2V0dGluZ3M7CiAgICAgRm9udFZhcmlhbnRTZXR0aW5ncyBtX3ZhcmlhbnRTZXR0aW5nczsK ICAgICBUaW1lciBtX3RpbWVvdXRUaW1lcjsKLSAgICBWZWN0b3I8c3RkOjp1bmlxdWVfcHRyPENT U0ZvbnRGYWNlU291cmNlPj4gbV9zb3VyY2VzOworICAgIFZlY3RvcjxzdGQ6OnVuaXF1ZV9wdHI8 Q1NTRm9udEZhY2VTb3VyY2U+LCAwLCBDcmFzaE9uT3ZlcmZsb3csIDA+IG1fc291cmNlczsKICAg ICBSZWZQdHI8Q1NTRm9udFNlbGVjdG9yPiBtX2ZvbnRTZWxlY3RvcjsKICAgICBSZWZQdHI8U3R5 bGVSdWxlRm9udEZhY2U+IG1fY3NzQ29ubmVjdGlvbjsKICAgICBIYXNoU2V0PENsaWVudCo+IG1f Y2xpZW50czsK