186697 2018-06-15 14:48:05 -0700 AX: [macOS] When zoom is enabled, focus doesn't follow text cursor 2018-06-18 14:04:54 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 186783 1 n_wang webkit-unassigned cfleizach commit-queue darin n_wang realdawei rniwa ryanhaddad webkit-bug-importer oldest_to_newest 1433562 0 n_wang 2018-06-15 14:48:05 -0700 The point conversion is not working since NSScreen is not available in web process <rdar://problem/41053111> 1433566 1 342849 n_wang 2018-06-15 14:56:22 -0700 Created attachment 342849 patch 1433896 2 342849 darin 2018-06-17 11:58:55 -0700 Comment on attachment 342849 patch View in context: https://bugs.webkit.org/attachment.cgi?id=342849&action=review > Source/WebCore/editing/mac/FrameSelectionMac.mm:42 > + CGFloat screenHeight = screenRectForPrimaryScreen().height(); > + if (screenHeight > 0) > bounds.origin.y = (screenHeight - (bounds.origin.y + bounds.size.height)); > - } else > + else > bounds = CGRectZero; Might be even better to use the toUserSpaceForPrimaryScreen function instead of calling screenRectForPrimaryScreen directly. 1434078 3 n_wang 2018-06-18 11:20:39 -0700 (In reply to Darin Adler from comment #2) > Comment on attachment 342849 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342849&action=review > > > Source/WebCore/editing/mac/FrameSelectionMac.mm:42 > > + CGFloat screenHeight = screenRectForPrimaryScreen().height(); > > + if (screenHeight > 0) > > bounds.origin.y = (screenHeight - (bounds.origin.y + bounds.size.height)); > > - } else > > + else > > bounds = CGRectZero; > > Might be even better to use the toUserSpaceForPrimaryScreen function instead > of calling screenRectForPrimaryScreen directly. Great thanks! I'll update that 1434081 4 n_wang 2018-06-18 11:31:08 -0700 Committed r232935: <https://trac.webkit.org/changeset/232935> 1434099 5 realdawei 2018-06-18 11:49:08 -0700 Looks like we have build failures on macOS 32-bit after this patch: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20%2832-bit%20Build%29/builds/6741/steps/compile-webkit/logs/stdio ...... /Volumes/Data/slave/highsierra-32bit-release/build/Source/WebCore/platform/PlatformScreen.h:93:11: note: candidate function not viable: no known conversion from 'CGRect' to 'const NSRect' (aka 'const _NSRect') for 1st argument FloatRect toUserSpaceForPrimaryScreen(const NSRect&); ^ 2 errors generated. ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/slave/highsierra-32bit-release/build/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/i386/UnifiedSource12-mm.o /Volumes/Data/slave/highsierra-32bit-release/build/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource12-mm.mm normal i386 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) https://build.webkit.org/builders/Apple%20Sierra%20Release%20%2832-bit%20Build%29/builds/11856/steps/compile-webkit/logs/stdio .... /Volumes/Data/slave/sierra-32bit-release/build/Source/WebCore/platform/PlatformScreen.h:93:11: note: candidate function not viable: no known conversion from 'CGRect' to 'const NSRect' (aka 'const _NSRect') for 1st argument FloatRect toUserSpaceForPrimaryScreen(const NSRect&); ^ 2 errors generated. ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/slave/sierra-32bit-release/build/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/i386/UnifiedSource12-mm.o /Volumes/Data/slave/sierra-32bit-release/build/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource12-mm.mm normal i386 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) 1434103 6 n_wang 2018-06-18 11:55:38 -0700 It worked for me locally. I will revert this and take a look. 1434105 7 commit-queue 2018-06-18 11:57:59 -0700 Re-opened since this is blocked by bug 186783 1434120 8 342961 n_wang 2018-06-18 12:20:29 -0700 Created attachment 342961 patch This should fix the 32-bit build issue. 1434130 9 realdawei 2018-06-18 12:47:55 -0700 (In reply to Nan Wang from comment #8) > Created attachment 342961 [details] > patch > > This should fix the 32-bit build issue. great thanks! 1434146 10 342961 commit-queue 2018-06-18 13:38:32 -0700 Comment on attachment 342961 patch Rejecting attachment 342961 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 342961, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/8236008 1434159 11 n_wang 2018-06-18 14:04:54 -0700 Committed r232944: <https://trac.webkit.org/changeset/232944> 342849 2018-06-15 14:56:22 -0700 2018-06-17 11:57:29 -0700 patch patch.txt text/plain 1660 n_wang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMjg5NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA2LTE1ICBOYW4gV2Fu ZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFttYWNPU10gV2hlbiB6b29tIGlz IGVuYWJsZWQsIGZvY3VzIGRvZXNuJ3QgZm9sbG93IHRleHQgY3Vyc29yCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODY2OTcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOb3cgdGhhdCB3ZWIgcHJvY2VzcyBk b2Vzbid0IGhhdmUgYWNjZXNzIHRvIE5TU2NyZWVuLiBUaGUgY29udmVyc2lvbiBvZiB0aGUgCisg ICAgICAgIHJlY3RzIGlzIHdyb25nLiBGaXhlZCB0aGlzIGJ5IHVzaW5nIHRoZSByaWdodCBmdW5j dGlvbiB0aGF0J3MgYXZhaWxhYmxlIGluCisgICAgICAgIFdlYkNvcmUgdG8gZ2V0IHRoZSBzY3Jl ZW4gaGVpZ2h0LgorCisgICAgICAgICogZWRpdGluZy9tYWMvRnJhbWVTZWxlY3Rpb25NYWMubW06 CisgICAgICAgIChXZWJDb3JlOjphY2Nlc3NpYmlsaXR5Q29udmVydFNjcmVlblJlY3QpOgorCiAy MDE4LTA2LTE1ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBT ZW1hbnRpYyBjb2xvcnMgc2hvdWxkIG5vdCBiZSB0cmFuc2Zvcm1lZCBieSBjb2xvci1maWx0ZXIK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFjL0ZyYW1lU2VsZWN0aW9uTWFjLm1tCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFjL0ZyYW1lU2VsZWN0aW9uTWFj Lm1tCShyZXZpc2lvbiAyMzI3NzQpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hYy9GcmFt ZVNlbGVjdGlvbk1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMzUsMTEgKzM1LDEwIEBAIG5hbWVz cGFjZSBXZWJDb3JlIHsKICNpZiAhUExBVEZPUk0oSU9TKQogc3RhdGljIENHUmVjdCBhY2Nlc3Np YmlsaXR5Q29udmVydFNjcmVlblJlY3QoQ0dSZWN0IGJvdW5kcykKIHsKLSAgICBOU0FycmF5ICpz Y3JlZW5zID0gW05TU2NyZWVuIHNjcmVlbnNdOwotICAgIGlmIChbc2NyZWVucyBjb3VudF0pIHsK LSAgICAgICAgQ0dGbG9hdCBzY3JlZW5IZWlnaHQgPSBOU0hlaWdodChbKE5TU2NyZWVuICopW3Nj cmVlbnMgb2JqZWN0QXRJbmRleDowXSBmcmFtZV0pOworICAgIENHRmxvYXQgc2NyZWVuSGVpZ2h0 ID0gc2NyZWVuUmVjdEZvclByaW1hcnlTY3JlZW4oKS5oZWlnaHQoKTsKKyAgICBpZiAoc2NyZWVu SGVpZ2h0ID4gMCkKICAgICAgICAgYm91bmRzLm9yaWdpbi55ID0gKHNjcmVlbkhlaWdodCAtIChi b3VuZHMub3JpZ2luLnkgKyBib3VuZHMuc2l6ZS5oZWlnaHQpKTsKLSAgICB9IGVsc2UKKyAgICBl bHNlCiAgICAgICAgIGJvdW5kcyA9IENHUmVjdFplcm87ICAgIAogICAgIAogICAgIHJldHVybiBi b3VuZHM7Cg== 342961 2018-06-18 12:20:29 -0700 2018-06-18 13:38:32 -0700 patch patch.txt text/plain 2840 n_wang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMjg5NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA2LTE1ICBOYW4gV2Fu ZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFttYWNPU10gV2hlbiB6b29tIGlz IGVuYWJsZWQsIGZvY3VzIGRvZXNuJ3QgZm9sbG93IHRleHQgY3Vyc29yCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODY2OTcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOb3cgdGhhdCB3ZWIgcHJvY2VzcyBk b2Vzbid0IGhhdmUgYWNjZXNzIHRvIE5TU2NyZWVuLiBUaGUgY29udmVyc2lvbiBvZiB0aGUgCisg ICAgICAgIHJlY3RzIGlzIHdyb25nLiBGaXhlZCB0aGlzIGJ5IHVzaW5nIHRoZSByaWdodCBmdW5j dGlvbiB0aGF0J3MgYXZhaWxhYmxlIGluCisgICAgICAgIFdlYkNvcmUgdG8gZ2V0IHRoZSByZWN0 cy4KKworICAgICAgICAqIGVkaXRpbmcvbWFjL0ZyYW1lU2VsZWN0aW9uTWFjLm1tOgorICAgICAg ICAoV2ViQ29yZTo6YWNjZXNzaWJpbGl0eUNvbnZlcnRTY3JlZW5SZWN0KToKKwogMjAxOC0wNi0x NSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgU2VtYW50aWMg Y29sb3JzIHNob3VsZCBub3QgYmUgdHJhbnNmb3JtZWQgYnkgY29sb3ItZmlsdGVyCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hYy9GcmFtZVNlbGVjdGlvbk1hYy5tbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hYy9GcmFtZVNlbGVjdGlvbk1hYy5tbQkocmV2 aXNpb24gMjMyNzc0KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9tYWMvRnJhbWVTZWxlY3Rp b25NYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTMyLDIxICszMiw2IEBACiAKIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAotI2lmICFQTEFURk9STShJT1MpCi1zdGF0aWMgQ0dSZWN0IGFjY2Vzc2liaWxp dHlDb252ZXJ0U2NyZWVuUmVjdChDR1JlY3QgYm91bmRzKQotewotICAgIE5TQXJyYXkgKnNjcmVl bnMgPSBbTlNTY3JlZW4gc2NyZWVuc107Ci0gICAgaWYgKFtzY3JlZW5zIGNvdW50XSkgewotICAg ICAgICBDR0Zsb2F0IHNjcmVlbkhlaWdodCA9IE5TSGVpZ2h0KFsoTlNTY3JlZW4gKilbc2NyZWVu cyBvYmplY3RBdEluZGV4OjBdIGZyYW1lXSk7Ci0gICAgICAgIGJvdW5kcy5vcmlnaW4ueSA9IChz Y3JlZW5IZWlnaHQgLSAoYm91bmRzLm9yaWdpbi55ICsgYm91bmRzLnNpemUuaGVpZ2h0KSk7Ci0g ICAgfSBlbHNlCi0gICAgICAgIGJvdW5kcyA9IENHUmVjdFplcm87ICAgIAotICAgIAotICAgIHJl dHVybiBib3VuZHM7Ci19Ci0jZW5kaWYgLy8gIVBMQVRGT1JNKElPUykKLSAgICAKLSAgICAKIHZv aWQgRnJhbWVTZWxlY3Rpb246Om5vdGlmeUFjY2Vzc2liaWxpdHlGb3JTZWxlY3Rpb25DaGFuZ2Uo Y29uc3QgQVhUZXh0U3RhdGVDaGFuZ2VJbnRlbnQmIGludGVudCkKIHsKICAgICBEb2N1bWVudCog ZG9jdW1lbnQgPSBtX2ZyYW1lLT5kb2N1bWVudCgpOwpAQCAtNzMsMTAgKzU4LDEyIEBAIHZvaWQg RnJhbWVTZWxlY3Rpb246Om5vdGlmeUFjY2Vzc2liaWxpdHkKIAogICAgIHNlbGVjdGlvblJlY3Qg PSBmcmFtZVZpZXctPmNvbnRlbnRzVG9TY3JlZW4oc2VsZWN0aW9uUmVjdCk7CiAgICAgdmlld1Jl Y3QgPSBmcmFtZVZpZXctPmNvbnRlbnRzVG9TY3JlZW4odmlld1JlY3QpOwotICAgIENHUmVjdCBj Z0NhcmV0UmVjdCA9IENHUmVjdE1ha2Uoc2VsZWN0aW9uUmVjdC54KCksIHNlbGVjdGlvblJlY3Qu eSgpLCBzZWxlY3Rpb25SZWN0LndpZHRoKCksIHNlbGVjdGlvblJlY3QuaGVpZ2h0KCkpOwotICAg IENHUmVjdCBjZ1ZpZXdSZWN0ID0gQ0dSZWN0TWFrZSh2aWV3UmVjdC54KCksIHZpZXdSZWN0Lnko KSwgdmlld1JlY3Qud2lkdGgoKSwgdmlld1JlY3QuaGVpZ2h0KCkpOwotICAgIGNnQ2FyZXRSZWN0 ID0gYWNjZXNzaWJpbGl0eUNvbnZlcnRTY3JlZW5SZWN0KGNnQ2FyZXRSZWN0KTsKLSAgICBjZ1Zp ZXdSZWN0ID0gYWNjZXNzaWJpbGl0eUNvbnZlcnRTY3JlZW5SZWN0KGNnVmlld1JlY3QpOworICAg IE5TUmVjdCBuc0NhcmV0UmVjdCA9IE5TTWFrZVJlY3Qoc2VsZWN0aW9uUmVjdC54KCksIHNlbGVj dGlvblJlY3QueSgpLCBzZWxlY3Rpb25SZWN0LndpZHRoKCksIHNlbGVjdGlvblJlY3QuaGVpZ2h0 KCkpOworICAgIE5TUmVjdCBuc1ZpZXdSZWN0ID0gTlNNYWtlUmVjdCh2aWV3UmVjdC54KCksIHZp ZXdSZWN0LnkoKSwgdmlld1JlY3Qud2lkdGgoKSwgdmlld1JlY3QuaGVpZ2h0KCkpOworICAgIG5z Q2FyZXRSZWN0ID0gdG9Vc2VyU3BhY2VGb3JQcmltYXJ5U2NyZWVuKG5zQ2FyZXRSZWN0KTsKKyAg ICBuc1ZpZXdSZWN0ID0gdG9Vc2VyU3BhY2VGb3JQcmltYXJ5U2NyZWVuKG5zVmlld1JlY3QpOwor ICAgIENHUmVjdCBjZ0NhcmV0UmVjdCA9IE5TUmVjdFRvQ0dSZWN0KG5zQ2FyZXRSZWN0KTsKKyAg ICBDR1JlY3QgY2dWaWV3UmVjdCA9IE5TUmVjdFRvQ0dSZWN0KG5zVmlld1JlY3QpOwogCiAgICAg VUFab29tQ2hhbmdlRm9jdXMoJmNnVmlld1JlY3QsICZjZ0NhcmV0UmVjdCwga1VBWm9vbUZvY3Vz VHlwZUluc2VydGlvblBvaW50KTsKICNlbmRpZiAvLyAhUExBVEZPUk0oSU9TKQo=