186683 2018-06-15 10:42:40 -0700 DisplayRefreshMonitorMac should hold a weak pointer to WebPage. 2018-08-09 08:50:41 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 186891 1 pvollan pvollan bfulgham commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1433453 0 pvollan 2018-06-15 10:42:40 -0700 Instead of DisplayRefreshMonitorMac having a RefPtr to WebPage, it should have a weak pointer. Having a RefPtr could in theory create reference cycles. I have not seen any cases of this, but I think it would be better design to hold a weak pointer. 1433456 1 342828 pvollan 2018-06-15 10:48:40 -0700 Created attachment 342828 Patch 1433458 2 webkit-bug-importer 2018-06-15 10:49:31 -0700 <rdar://problem/41164502> 1433463 3 342828 bfulgham 2018-06-15 11:00:06 -0700 Comment on attachment 342828 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342828&action=review r=me > Source/WebKit/ChangeLog:10 > + observed in practice, but it is safer to use a weak pointer. Good point! 1433466 4 342828 pvollan 2018-06-15 11:05:35 -0700 Comment on attachment 342828 Patch Thanks for reviewing! 1433488 5 342828 commit-queue 2018-06-15 11:47:39 -0700 Comment on attachment 342828 Patch Clearing flags on attachment: 342828 Committed r232884: <https://trac.webkit.org/changeset/232884> 1433489 6 commit-queue 2018-06-15 11:47:40 -0700 All reviewed patches have been landed. Closing bug. 1435216 7 commit-queue 2018-06-21 13:21:10 -0700 Re-opened since this is blocked by bug 186891 1449007 8 pvollan 2018-08-09 08:50:41 -0700 Committed r234725: <https://trac.webkit.org/changeset/234725/webkit> 342828 2018-06-15 10:48:40 -0700 2018-06-15 11:47:39 -0700 Patch bug-186683-20180615104839.patch text/plain 3191 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzI4ODIpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA2LTE1ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBEaXNwbGF5UmVmcmVzaE1vbml0 b3JNYWMgc2hvdWxkIGhvbGQgYSB3ZWFrIHBvaW50ZXIgdG8gV2ViUGFnZS4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjY4MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluc3RlYWQgb2YgRGlzcGxheVJl ZnJlc2hNb25pdG9yTWFjIGhhdmluZyBhIFJlZlB0ciB0byBXZWJQYWdlLCBpdCBzaG91bGQgaGF2 ZSBhIHdlYWsgcG9pbnRlci4KKyAgICAgICAgSGF2aW5nIGEgUmVmUHRyIGNvdWxkIGluIHRoZW9y eSBjcmVhdGUgcmVmZXJlbmNlIGN5Y2xlcy4gVGhpcyBwb3RlbnRpYWwgcHJvYmxlbSBoYXMgbm90 IGJlZW4KKyAgICAgICAgb2JzZXJ2ZWQgaW4gcHJhY3RpY2UsIGJ1dCBpdCBpcyBzYWZlciB0byB1 c2UgYSB3ZWFrIHBvaW50ZXIuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFn ZS5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvRHJhd2luZ0FyZWFNYWMuY3Bw OgorICAgICAgICAoV2ViS2l0OjpEaXNwbGF5UmVmcmVzaE1vbml0b3JNYWM6OkRpc3BsYXlSZWZy ZXNoTW9uaXRvck1hYyk6CisgICAgICAgIChXZWJLaXQ6OkRpc3BsYXlSZWZyZXNoTW9uaXRvck1h Yzo6fkRpc3BsYXlSZWZyZXNoTW9uaXRvck1hYyk6CisgICAgICAgIChXZWJLaXQ6OkRpc3BsYXlS ZWZyZXNoTW9uaXRvck1hYzo6cmVxdWVzdFJlZnJlc2hDYWxsYmFjayk6CisKIDIwMTgtMDYtMTUg IENhcmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CiAKICAgICAg ICAgW0dUS11bV0tFXSBEaXNhYmxlIG1lbW9yeSBwcmVzc3VyZSBoYW5kbGluZyB3aGVuIHJ1bm5p bmcgbGF5b3V0IHRlc3RzIChXVFIpCkluZGV4OiBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5oCShyZXZpc2lvbiAyMzI4ODIpCisrKyBTb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgJKHdvcmtpbmcgY29weSkKQEAgLTI0Niw3ICsyNDYsNyBA QCBzdHJ1Y3QgV2Vic2l0ZVBvbGljaWVzRGF0YTsKIHVzaW5nIFNuYXBzaG90T3B0aW9ucyA9IHVp bnQzMl90OwogdXNpbmcgV0tFdmVudE1vZGlmaWVycyA9IHVpbnQzMl90OwogCi1jbGFzcyBXZWJQ YWdlIDogcHVibGljIEFQSTo6T2JqZWN0SW1wbDxBUEk6Ok9iamVjdDo6VHlwZTo6QnVuZGxlUGFn ZT4sIHB1YmxpYyBJUEM6Ok1lc3NhZ2VSZWNlaXZlciwgcHVibGljIElQQzo6TWVzc2FnZVNlbmRl ciB7CitjbGFzcyBXZWJQYWdlIDogcHVibGljIEFQSTo6T2JqZWN0SW1wbDxBUEk6Ok9iamVjdDo6 VHlwZTo6QnVuZGxlUGFnZT4sIHB1YmxpYyBJUEM6Ok1lc3NhZ2VSZWNlaXZlciwgcHVibGljIElQ Qzo6TWVzc2FnZVNlbmRlciwgcHVibGljIENhbk1ha2VXZWFrUHRyPFdlYlBhZ2U+IHsKIHB1Ymxp YzoKICAgICBzdGF0aWMgUmVmPFdlYlBhZ2U+IGNyZWF0ZSh1aW50NjRfdCBwYWdlSUQsIFdlYlBh Z2VDcmVhdGlvblBhcmFtZXRlcnMmJik7CiAgICAgdmlydHVhbCB+V2ViUGFnZSgpOwpJbmRleDog U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL0RyYXdpbmdBcmVhTWFjLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvRHJhd2lu Z0FyZWFNYWMuY3BwCShyZXZpc2lvbiAyMzI4ODIpCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvV2ViUGFnZS9tYWMvRHJhd2luZ0FyZWFNYWMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Nyw3 ICs1Nyw3IEBAIHByaXZhdGU6CiAgICAgCiAgICAgYm9vbCBoYXNSZXF1ZXN0ZWRSZWZyZXNoQ2Fs bGJhY2soKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiBtX2hhc1NlbnRNZXNzYWdlOyB9CiAKLSAg ICBSZWY8V2ViUGFnZT4gbV93ZWJQYWdlOworICAgIFdlYWtQdHI8V2ViUGFnZT4gbV93ZWJQYWdl OwogICAgIGJvb2wgbV9oYXNTZW50TWVzc2FnZSB7IGZhbHNlIH07CiAgICAgdW5zaWduZWQgbV9v YnNlcnZlcklEOwogICAgIHN0YXRpYyB1bnNpZ25lZCBtX2NvdW50ZXJJRDsKQEAgLTY5LDE4ICs2 OSwyNiBAQCB1bnNpZ25lZCBEaXNwbGF5UmVmcmVzaE1vbml0b3JNYWM6Om1fY291CiAKIERpc3Bs YXlSZWZyZXNoTW9uaXRvck1hYzo6RGlzcGxheVJlZnJlc2hNb25pdG9yTWFjKFBsYXRmb3JtRGlz cGxheUlEIGRpc3BsYXlJRCwgV2ViUGFnZSYgd2ViUGFnZSkKICAgICA6IERpc3BsYXlSZWZyZXNo TW9uaXRvcihkaXNwbGF5SUQpCi0gICAgLCBtX3dlYlBhZ2Uod2ViUGFnZSkKKyAgICAsIG1fd2Vi UGFnZShtYWtlV2Vha1B0cih3ZWJQYWdlKSkKICAgICAsIG1fb2JzZXJ2ZXJJRCgrK21fY291bnRl cklEKQogewogfQogCiBEaXNwbGF5UmVmcmVzaE1vbml0b3JNYWM6On5EaXNwbGF5UmVmcmVzaE1v bml0b3JNYWMoKQogeworICAgIEFTU0VSVChtX3dlYlBhZ2UpOworICAgIGlmICghbV93ZWJQYWdl KQorICAgICAgICByZXR1cm47CisgICAgCiAgICAgbV93ZWJQYWdlLT5zZW5kKE1lc3NhZ2VzOjpX ZWJQYWdlUHJveHk6OlN0b3BEaXNwbGF5TGluayhtX29ic2VydmVySUQpKTsKIH0KIAogYm9vbCBE aXNwbGF5UmVmcmVzaE1vbml0b3JNYWM6OnJlcXVlc3RSZWZyZXNoQ2FsbGJhY2soKQogeworICAg IEFTU0VSVChtX3dlYlBhZ2UpOworICAgIGlmICghbV93ZWJQYWdlKQorICAgICAgICByZXR1cm4g ZmFsc2U7CisKICAgICBpZiAoIWlzQWN0aXZlKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAo=