186663 2018-06-15 09:16:59 -0700 [GTK][WKE] Disable memory pressure handling when running layout tests (WTR) 2018-06-15 10:35:39 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=172693 https://bugs.webkit.org/show_bug.cgi?id=154254 P2 Normal --- 1 clopez clopez achristensen bugs-noreply calvaris cgarcia mcatanzaro pnormand oldest_to_newest 1433386 0 clopez 2018-06-15 09:16:59 -0700 It seems a good amount of flakiness in the GTK and WPE layout tests is caused by the in-webprocess memory pressure monitor. You can see that in the following logs: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r232868%20(7018)/results.html <-- the crash is our memory pressure killer https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r232867%20(7017)/results.html <-- second crash is our memory pressure killer https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r232866%20(7016)/results.html <-- the crash is our memory pressure killer https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r232864%20(7015)/results.html <-- first crash If it helped us find tests using too much memory, it might be useful, but it does not because the test that dies is probably just running in a process that previously leaked a bunch of memory... i.e. the test that is killed is probably not the test that has a real problem. The ideal solution would be to fix the cause of those leaks that accumulate over the course of those runs. But meanwhile we don't have that right fix a workaround that we can do now to avoid flakiness in our tests is to disable this memory pressure monitor when running with WTR. 1433419 1 342820 clopez 2018-06-15 10:01:33 -0700 Created attachment 342820 Patch 1433422 2 342820 mcatanzaro 2018-06-15 10:05:08 -0700 Comment on attachment 342820 Patch Thanks. I had been complaining about this all year. This is really only harmful when running layout tests. 1433449 3 clopez 2018-06-15 10:35:39 -0700 Committed r232881: <https://trac.webkit.org/changeset/232881> 342820 2018-06-15 10:01:33 -0700 2018-06-15 10:05:08 -0700 Patch bug-186663-20180615190132.patch text/plain 5044 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyODcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE4ODc3Njg1NzM5MDc2ZWU3 MGZkZjgzNTU1YTI2YWRjYmI4YWIwN2UuLjllYTAyZDRkZjFmZThkNGJmYTRiOGRiMmMxMzg0OGI0 MjBjYTZkMzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTgtMDYtMTUgIENhcmxvcyBB bGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11b V0tFXSBEaXNhYmxlIG1lbW9yeSBwcmVzc3VyZSBoYW5kbGluZyB3aGVuIHJ1bm5pbmcgbGF5b3V0 IHRlc3RzIChXVFIpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODY2NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICByMTk2OTQzIGFkZGVkIGEgbWVjaGFuaXNtIHRvIGRpc2FibGUgdGhlIG1lbW9yeSBwcmVz c3VyZSBoYW5kbGluZworICAgICAgICBvbiBNYWMuIFRoaXMgcGF0Y2ggZW5hYmxlcyB1c2luZyB0 aGF0IG1lY2hhbmlzbSBhbHNvIGZvciBHVEsvV1BFLgorICAgICAgICBUbyBkbyB0aGF0IHRoZSBl bnZpcm9ubWVudCB2YXJpYWJsZSBXRUJLSVRfRElTQUJMRV9NRU1PUllfUFJFU1NVUkVfTU9OSVRP UgorICAgICAgICBzaG91bGQgYmV0IHNldCB0byAxLgorICAgICAgICBXZSB3YW50IHRvIHVzZSB0 aGlzIG9uIHRoZSBsYXlvdXQgdGVzdHMgdG8gYXZvaWQgZmxha3kgdGVzdHMgY2F1c2VkCisgICAg ICAgIGJ5IGFjY3VtdWxhdGVkIGxlYWtzIG9uIHRoZSBXZWJQcm9jZXNzIGJ5IGRpZmZlcmVudCB0 ZXN0cy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9ndGsvV2ViUHJvY2Vzc1Bvb2xHdGsuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9vbDo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJv Y2Vzcyk6CisgICAgICAgICogVUlQcm9jZXNzL3dwZS9XZWJQcm9jZXNzUG9vbFdQRS5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQb29sOjpwbGF0Zm9ybUluaXRpYWxpemVXZWJQcm9j ZXNzKToKKwogMjAxOC0wNi0xNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAK ICAgICAgICAgTWFrZSBOZXR3b3JrUHJvY2VzcyBnZXQgY2FjaGUgc3RvcmFnZSBwYXJhbWV0ZXJz IGF0IGNyZWF0aW9uIG9mIHRoZSBDYWNoZVN0b3JhZ2UgZW5naW5lCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9ndGsvV2ViUHJvY2Vzc1Bvb2xHdGsuY3BwIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvZ3RrL1dlYlByb2Nlc3NQb29sR3RrLmNwcAppbmRleCBlNjJjODJhYjAx OTg2MDAyNThkNWI3OTk5MmIxMTBiNjJkMWFjNmQ0Li5hZGVkYjk4MzU4NjA4MjkxZTk0YmNlOGYx NTA4ODc1ZDk1ZDVhNzE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9ndGsv V2ViUHJvY2Vzc1Bvb2xHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0ay9X ZWJQcm9jZXNzUG9vbEd0ay5jcHAKQEAgLTk3LDYgKzk3LDEwIEBAIHZvaWQgV2ViUHJvY2Vzc1Bv b2w6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3MoV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1l dGVycyYKICAgICBpZiAoZm9yY2VDb21wbGV4VGV4dCAmJiAhc3RyY21wKGZvcmNlQ29tcGxleFRl eHQsICIwIikpCiAgICAgICAgIHBhcmFtZXRlcnMuc2hvdWxkQWx3YXlzVXNlQ29tcGxleFRleHRD b2RlUGF0aCA9IG1fYWx3YXlzVXNlc0NvbXBsZXhUZXh0Q29kZVBhdGg7CiAKKyAgICBjb25zdCBj aGFyKiBkaXNhYmxlTWVtb3J5UHJlc3N1cmVNb25pdG9yID0gZ2V0ZW52KCJXRUJLSVRfRElTQUJM RV9NRU1PUllfUFJFU1NVUkVfTU9OSVRPUiIpOworICAgIGlmIChkaXNhYmxlTWVtb3J5UHJlc3N1 cmVNb25pdG9yICYmICFzdHJjbXAoZGlzYWJsZU1lbW9yeVByZXNzdXJlTW9uaXRvciwgIjEiKSkK KyAgICAgICAgcGFyYW1ldGVycy5zaG91bGRTdXBwcmVzc01lbW9yeVByZXNzdXJlSGFuZGxlciA9 IHRydWU7CisKICNpZiBVU0UoR1NUUkVBTUVSKQogICAgIHBhcmFtZXRlcnMuZ3N0cmVhbWVyT3B0 aW9ucyA9IFdlYkNvcmU6OmV4dHJhY3RHU3RyZWFtZXJPcHRpb25zRnJvbUNvbW1hbmRMaW5lKCk7 CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL3dwZS9XZWJQcm9j ZXNzUG9vbFdQRS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy93cGUvV2ViUHJvY2Vzc1Bv b2xXUEUuY3BwCmluZGV4IDJjOTllNjMxNDczYWRjYTgwMTFmNjkwOWQzYTlkYTI5Mjg5NTQwZTgu LjdjYjg5NTFhYmVkN2MyZDQ2NWQ1NDg4MGVkNDk3NDEwYjM0YjQwM2EgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL3dwZS9XZWJQcm9jZXNzUG9vbFdQRS5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3Mvd3BlL1dlYlByb2Nlc3NQb29sV1BFLmNwcApAQCAtOTMsNiAr OTMsMTEgQEAgV1RGOjpTdHJpbmcgV2ViUHJvY2Vzc1Bvb2w6OmxlZ2FjeVBsYXRmb3JtRGVmYXVs dE1lZGlhQ2FjaGVEaXJlY3RvcnkoKQogdm9pZCBXZWJQcm9jZXNzUG9vbDo6cGxhdGZvcm1Jbml0 aWFsaXplV2ViUHJvY2VzcyhXZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzJiBwYXJhbWV0ZXJz KQogewogICAgIHBhcmFtZXRlcnMubWVtb3J5Q2FjaGVEaXNhYmxlZCA9IG1fbWVtb3J5Q2FjaGVE aXNhYmxlZCB8fCBjYWNoZU1vZGVsKCkgPT0gQ2FjaGVNb2RlbERvY3VtZW50Vmlld2VyOworCisg ICAgY29uc3QgY2hhciogZGlzYWJsZU1lbW9yeVByZXNzdXJlTW9uaXRvciA9IGdldGVudigiV0VC S0lUX0RJU0FCTEVfTUVNT1JZX1BSRVNTVVJFX01PTklUT1IiKTsKKyAgICBpZiAoZGlzYWJsZU1l bW9yeVByZXNzdXJlTW9uaXRvciAmJiAhc3RyY21wKGRpc2FibGVNZW1vcnlQcmVzc3VyZU1vbml0 b3IsICIxIikpCisgICAgICAgIHBhcmFtZXRlcnMuc2hvdWxkU3VwcHJlc3NNZW1vcnlQcmVzc3Vy ZUhhbmRsZXIgPSB0cnVlOworCiAjaWYgVVNFKEdTVFJFQU1FUikKICAgICBwYXJhbWV0ZXJzLmdz dHJlYW1lck9wdGlvbnMgPSBXZWJDb3JlOjpleHRyYWN0R1N0cmVhbWVyT3B0aW9uc0Zyb21Db21t YW5kTGluZSgpOwogI2VuZGlmCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9D aGFuZ2VMb2cKaW5kZXggNWY0MDEzODYyNTc3NTViN2QwODdhMzc1ZmNjYjM4MjUwNDEwMGVhOS4u ZjRmY2E1ZTc0YmUyNjMwNmUxMmMzMzIzNzI1YjY4OWEzODQ4YmE1MyAxMDA2NDQKLS0tIGEvVG9v bHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4 LTA2LTE1ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgor CisgICAgICAgIFtHVEtdW1dLRV0gRGlzYWJsZSBtZW1vcnkgcHJlc3N1cmUgaGFuZGxpbmcgd2hl biBydW5uaW5nIGxheW91dCB0ZXN0cyAoV1RSKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2NjYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRGlzYWJsZSBtZW1vcnkgcHJlc3N1cmUgaGFuZGxpbmcgd2hl biBydW5uaW5nIHRlc3RzIHZpYSBXVFIgYnkKKyAgICAgICAgc2V0dGluZyBXRUJLSVRfRElTQUJM RV9NRU1PUllfUFJFU1NVUkVfTU9OSVRPUj0xIG9uIHRoZSBlbnZpcm9ubWVudC4KKworICAgICAg ICAqIFdlYktpdFRlc3RSdW5uZXIvZ3RrL21haW4uY3BwOgorICAgICAgICAobWFpbik6CisgICAg ICAgICogV2ViS2l0VGVzdFJ1bm5lci93cGUvbWFpbi5jcHA6CisgICAgICAgIChtYWluKToKKwog MjAxOC0wNi0xNCAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBz dW4gc3BpZGVyIGNvbXBpbGUgdGltZSBiZW5jaG1hcmsgZmFpbHMgaW4gcnVuLWpzYy1iZW5jaG1h cmtzIHdpdGggSlNDX3ZhbGlkYXRlT3B0aW9ucz0xCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL2d0ay9tYWluLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL21haW4u Y3BwCmluZGV4IGUyOTE1MjUzZjE4MjcyYTU4ODdkZWJmZjI0MjJhYzA5M2EzNWI1ODQuLjc0MWFi MWVlNTk1OTYxOGQ0M2YzYzkwMjA0YmU2MzBiZTVjNmIwNGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvZ3RrL21haW4uY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv Z3RrL21haW4uY3BwCkBAIC0zMyw2ICszMyw3IEBACiBpbnQgbWFpbihpbnQgYXJnYywgY2hhcioq IGFyZ3YpCiB7CiAgICAgZ19zZXRlbnYoIldFQktJVF9GT1JDRV9DT01QTEVYX1RFWFQiLCAiMCIs IEZBTFNFKTsKKyAgICBnX3NldGVudigiV0VCS0lUX0RJU0FCTEVfTUVNT1JZX1BSRVNTVVJFX01P TklUT1IiLCAiMSIsIEZBTFNFKTsKIAogICAgIGd0a19pbml0KCZhcmdjLCAmYXJndik7CiAKZGlm ZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvd3BlL21haW4uY3BwIGIvVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci93cGUvbWFpbi5jcHAKaW5kZXggNmNmMmI3ZmYzMjFjNTY1MmJlYmUzYjVk NDhiMDE0NzRjOTViODAwYS4uNjFhZWQ4OTM3N2RmOTVjMDNiOGI5N2NmZmQzNWM3NWVhOWY2ZGUw ZCAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci93cGUvbWFpbi5jcHAKKysrIGIv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci93cGUvbWFpbi5jcHAKQEAgLTI5LDYgKzI5LDggQEAKIAog aW50IG1haW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogeworICAgIGdfc2V0ZW52KCJXRUJLSVRf RElTQUJMRV9NRU1PUllfUFJFU1NVUkVfTU9OSVRPUiIsICIxIiwgRkFMU0UpOworCiAgICAgV1RS OjpUZXN0Q29udHJvbGxlciBjb250cm9sbGVyKGFyZ2MsIGNvbnN0X2Nhc3Q8Y29uc3QgY2hhcioq Pihhcmd2KSk7CiAgICAgcmV0dXJuIDA7CiB9Cg==