186624 2018-06-14 10:19:47 -0700 svn-apply should handle svn property changes 2025-03-03 11:25:47 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified CLOSED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=190025 InRadar P2 Normal --- 1 rreapor webkit-unassigned aakash_jain ap lforschler webkit-bug-importer oldest_to_newest 1433012 0 rreapor 2018-06-14 10:19:47 -0700 svn-apply should handle svn property changes 1433014 1 webkit-bug-importer 2018-06-14 10:22:24 -0700 <rdar://problem/41129393> 1433224 2 ap 2018-06-14 20:41:48 -0700 I’m pretty sure that it always had. What happened? 1433388 3 rreapor 2018-06-15 09:19:05 -0700 (In reply to Alexey Proskuryakov from comment #2) > I’m pretty sure that it always had. What happened? I found it while investigating why bug 185949 is not Landin. The SVN pre-commit hook works. But I found that svn-apply doesn't handle property modifications. I also found the comment in svn-apply from 2010. $ svn blame svn-apply -v | grep property 57453 dbates@webkit.org 2010-04-11 12:09:29 -0700 (Sun, 11 Apr 2010) # Handle property changes. Correct patches will not be committed correctly if it contains svn property changes. 1464660 4 aakash_jain 2018-09-28 18:11:51 -0700 > $ svn blame svn-apply -v | grep property > 57453 dbates@webkit.org 2010-04-11 12:09:29 -0700 (Sun, 11 Apr 2010) # > Handle property changes. Just for future reference, here is svn-apply code mentioning about missing feature to "handle property changes": https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/svn-apply#L52 2099952 5 rreapor 2025-03-03 11:25:38 -0800 Closing because WebKit does not use `svn` anymore.