186424 2018-06-07 21:37:44 -0700 REGRESSION(macOS Mojave): move-by-word-visually-inline-block-positioned-element.html fails 2018-06-08 13:37:22 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa ap koivisto megan_gardner webkit-bug-importer wenson_hsieh zalan oldest_to_newest 1431137 0 rniwa 2018-06-07 21:37:44 -0700 The layout test fails on macOS Mojave. 1431138 1 342239 rniwa 2018-06-07 21:38:11 -0700 Created attachment 342239 WIP 1431157 2 342244 rniwa 2018-06-07 23:45:03 -0700 Created attachment 342244 Fixes the bug 1431160 3 megan_gardner 2018-06-08 00:08:32 -0700 Wow, that’s one crazy bug! R=me, unofficially. 1431161 4 342244 rniwa 2018-06-08 00:47:43 -0700 Comment on attachment 342244 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=342244&action=review > Source/WebCore/ChangeLog:32 > + wordBreakIteratorForMaxOffsetBoundary with visible position at offset 0 of "world", it thiss line and return nullptr. It should read "it skip this line and return nullptr." 1431250 5 ap 2018-06-08 09:04:18 -0700 Great work! Is it possible to add a test that verifies this bug fix in a more straightforward manner, and maybe even extends testing in similar edge cases? Seems like we got lucky that a mostly unrelated test caught this. 1431366 6 rniwa 2018-06-08 13:06:04 -0700 (In reply to Alexey Proskuryakov from comment #5) > Great work! > > Is it possible to add a test that verifies this bug fix in a more > straightforward manner, and maybe even extends testing in similar edge > cases? Seems like we got lucky that a mostly unrelated test caught this. I wouldn't say we got lucky since the failing test basically tests every word movement across divs with variety position values in order to catch exactly like the bug like this. Having said that, I can add a new test which tests this exact failure although it would still require macOS Mojave to test it. I'm not certain adding a new mostly redundant test like that is useful though... 1431377 7 ap 2018-06-08 13:29:58 -0700 Sounds like it would not be very useful given that. 1431379 8 rniwa 2018-06-08 13:31:03 -0700 (In reply to Alexey Proskuryakov from comment #7) > Sounds like it would not be very useful given that. Okay. I'll land the patch as is then. 1431381 9 rniwa 2018-06-08 13:36:11 -0700 Committed r232635: <https://trac.webkit.org/changeset/232635> 1431383 10 webkit-bug-importer 2018-06-08 13:37:22 -0700 <rdar://problem/40948830> 342239 2018-06-07 21:38:11 -0700 2018-06-07 23:45:01 -0700 WIP fix186424.patch text/plain 1282 rniwa ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVmlzaWJsZVVuaXRzLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2VkaXRpbmcvVmlzaWJsZVVuaXRzLmNwcAppbmRleCAyZDNhZDFmNTYyZC4u NTVmMmI3MDg2OTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVmlzaWJsZVVu aXRzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1Zpc2libGVVbml0cy5jcHAKQEAg LTM4NCw5ICszODQsOSBAQCBzdGF0aWMgVmlzaWJsZVBvc2l0aW9uIHZpc3VhbFdvcmRQb3NpdGlv bihjb25zdCBWaXNpYmxlUG9zaXRpb24mIHZpc2libGVQb3NpdGlvbgogICAgICAgICBib29sIG1v dmluZ0ludG9OZXdCb3ggPSBwcmV2aW91c2x5VmlzaXRlZEJveCAhPSBib3g7CiAKICAgICAgICAg aWYgKG9mZnNldEluQm94ID09IGJveC0+Y2FyZXRNaW5PZmZzZXQoKSkKLSAgICAgICAgICAgIGl0 ZXIgPSB3b3JkQnJlYWtJdGVyYXRvckZvck1pbk9mZnNldEJvdW5kYXJ5KHZpc2libGVQb3NpdGlv biwgJnRleHRCb3gsIHByZXZpb3VzQm94TGVuZ3RoLCBwcmV2aW91c0JveEluRGlmZmVyZW50Qmxv Y2ssIHN0cmluZywgbGVhZkJveGVzKTsKKyAgICAgICAgICAgIGl0ZXIgPSB3b3JkQnJlYWtJdGVy YXRvckZvck1pbk9mZnNldEJvdW5kYXJ5KGFkamFjZW50Q2hhcmFjdGVyUG9zaXRpb24sICZ0ZXh0 Qm94LCBwcmV2aW91c0JveExlbmd0aCwgcHJldmlvdXNCb3hJbkRpZmZlcmVudEJsb2NrLCBzdHJp bmcsIGxlYWZCb3hlcyk7CiAgICAgICAgIGVsc2UgaWYgKG9mZnNldEluQm94ID09IGJveC0+Y2Fy ZXRNYXhPZmZzZXQoKSkKLSAgICAgICAgICAgIGl0ZXIgPSB3b3JkQnJlYWtJdGVyYXRvckZvck1h eE9mZnNldEJvdW5kYXJ5KHZpc2libGVQb3NpdGlvbiwgJnRleHRCb3gsIG5leHRCb3hJbkRpZmZl cmVudEJsb2NrLCBzdHJpbmcsIGxlYWZCb3hlcyk7CisgICAgICAgICAgICBpdGVyID0gd29yZEJy ZWFrSXRlcmF0b3JGb3JNYXhPZmZzZXRCb3VuZGFyeShhZGphY2VudENoYXJhY3RlclBvc2l0aW9u LCAmdGV4dEJveCwgbmV4dEJveEluRGlmZmVyZW50QmxvY2ssIHN0cmluZywgbGVhZkJveGVzKTsK ICAgICAgICAgZWxzZSBpZiAobW92aW5nSW50b05ld0JveCkgewogICAgICAgICAgICAgaXRlciA9 IHdvcmRCcmVha0l0ZXJhdG9yKFN0cmluZ1ZpZXcodGV4dEJveC5yZW5kZXJlcigpLnRleHQoKSku c3Vic3RyaW5nKHRleHRCb3guc3RhcnQoKSwgdGV4dEJveC5sZW4oKSkpOwogICAgICAgICAgICAg cHJldmlvdXNseVZpc2l0ZWRCb3ggPSBib3g7Cg== 342244 2018-06-07 23:45:03 -0700 2018-06-08 07:57:02 -0700 Fixes the bug bug-186424-20180607234502.patch text/plain 4578 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMjYxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQ1IEBACisyMDE4LTA2LTA3ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04obWFjT1MgTW9q YXZlKTogbW92ZS1ieS13b3JkLXZpc3VhbGx5LWlubGluZS1ibG9jay1wb3NpdGlvbmVkLWVsZW1l bnQuaHRtbCBmYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTg2NDI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhlIHRlc3QgZmFpbHVyZSBpcyB1bHRpbWF0ZWx5IGNhdXNlZCBieSB0aGUgY2hhbmdl IGluIElDVSdzIGJlaGF2aW9yLiBXaXRoIHRoZSBDUFUgaW4gdGhlIGxhdGVzdCBtYWNPUyBNb2ph dmUsCisgICAgICAgIHVicmtfZ2V0UnVsZVN0YXR1cyByZXR1cm5zIDIwMCAvIFVCUktfV09SRF9M RVRURVIgYXQgdGhlIGVuZCBvZiBhIGJ1ZmZlciBnaXZlbiB0byBVQnJlYWtJdGVyYXRvci4gVGhp cyBjYXVzZWQKKyAgICAgICAgaXNXb3JkVGV4dEJyZWFrIHRvIHJldHVybiB0cnVlIGluc3RlYWQg b2YgZmFsc2UgaW4gaXNMb2dpY2FsU3RhcnRPZldvcmQgYXQgdGhlIGVuZCBvZiB0aGUgYnVmZmVy LgorCisgICAgICAgIFRoaXMgSUNVIGJlaGF2aW9yIHNob3VsZG4ndCBoYXZlIGNhdXNlZCBhIHBy b2JsZW0gaW4gdGhlb3J5LiBIb3dldmVyLCBXZWJLaXQgaGFkIGEgYnVnIGluIHZpc3VhbFdvcmRQ b3NpdGlvbiB3aGljaAorICAgICAgICBjYXVzZWQgVUJyZWFrSXRlcmF0b3IgdG8gbm90IGluY2x1 ZGUgdGhlIHN1Y2NlZWRpbmcgd29yZCB3aGVuIHRyYXZlcnNpbmcgd29yZHMgdG8gdGhlIGxlZnQg KGJhY2t3YXJkcyBpbiBMVFIgdGV4dCkKKyAgICAgICAgYXQgdGhlIGJlZ2lubmluZyBvZiB0aGUg bGFzdCBibG9jayBlbGVtZW50IHdpdGggZXhhY3RseSBvbmUgbGluZSBib3ggYWZ0ZXIgYW4gbm9u LXN0YXRpY2FsbHkgcG9zaXRpb25lZCBlbGVtZW50LgorCisgICAgICAgIEluIHRoaXMgY2FzZSwg dmlzdWFsV29yZFBvc2l0aW9uIGludm9rZXMgd29yZEJyZWFrSXRlcmF0b3JGb3JNYXhPZmZzZXRC b3VuZGFyeSAoYmVjYXVzZSBhZGphY2VudENoYXJhY3RlclBvc2l0aW9uCisgICAgICAgIGlzIG5v dyBhdCB0aGUgZW5kIG9mIHRoZSBsYXN0IHdvcmQgaW4gdGhlIG5vbi1zdGF0aWNhbGx5IHBvc2l0 aW9uZWQgZWxlbWVudCkgdG8gc2V0dXAgVUJyZWFrSXRlcmF0b3IuIEJlY2F1c2UKKyAgICAgICAg dGhlcmUgYXJlIG5vIGxpbmUgYm94ZXMgbGVmdCBpbiB0aGUgY3VycmVudCBsaW5lIChpbiB0aGUg bGFzdCBibG9jayBlbGVtZW50IHdpdGggZXhhY3RseSBvbmUgbGluZSBib3gpLAorICAgICAgICBs b2dpY2FsbHlOZXh0Qm94IGVudGVycyB0aGUgd2hpbGUgbG9vcCBhbmQgaW52b2tlIG5leHRSb290 SW5saW5lQm94Q2FuZGlkYXRlUG9zaXRpb24gdG8gZmluZCB0aGUgbmV4dCByb290IGxpbmUgYm94 LgorICAgICAgICBIb3dldmVyLCB0aGUgdmlzaWJsZSBwb3NpdGlvbiBnaXZlbiB0byB0aGlzIGZ1 bmN0aW9uIGlzIGF0IHRoZSBiZWdpbm5pbmcgb2YgdGhlIGZpcnN0IHdvcmQgaW4gdGhlIGJsb2Nr IGVsZW1lbnQuCisgICAgICAgIEFzIGEgcmVzdWx0LCBuZXh0Um9vdElubGluZUJveENhbmRpZGF0 ZVBvc2l0aW9uIHNraXBzIG92ZXIgdGhpcyBlbnRpcmUgbGluZSBhbmQgZmluZHMgbm8gbGluZSBi b3ggYWZ0ZXIgdGhlIG9uZQorICAgICAgICB3ZSBoYWQgaW4gdGhlIG5vbi1zdGF0aWNhbGx5IHBv c2l0aW9uZWQgZWxlbWVudC4KKworICAgICAgICBMZXQgdXMgY29uc2lkZXIgdGhlIGZvbGxvd2lu ZyBjb25jcmV0ZSBleGFtcGxlIGluIHdoaWNoIGEgcG9zaXRpb246IHN0YXRpYyBkaXYgaXMgZm9s bG93ZWQgYnkgYW5vdGhlciBkaXYsIGFuZCBlYWNoCisgICAgICAgIGRpdiBjb250YWlucyB0ZXh0 IG5vZGVzICJoZWxsbyIgYW5kICJ3b3JsZCIgcmVzcGVjdGl2ZWx5OgorICAgICAgICAtIGRpdiBw b3NpdGlvbjogc3RhdGljICgxKQorICAgICAgICAgICAgLSAiaGVsbG8iCisgICAgICAgIC0gZGl2 ICgyKQorICAgICAgICAgICAgLSAid29ybGQiCisgICAgICAgIFN1cHBvc2Ugd2UncmUgYXQgdGhl IG9mZnNldCAwIG9mICJ3b3JsZCIsIGFuZCB0cnlpbmcgdG8gbW92ZSB0byB0aGUgbGVmdC4gSW4g dGhpcyBjYXNlLCBhZGphY2VudENoYXJhY3RlclBvc2l0aW9uIGlzCisgICAgICAgIGF0IG9mZnNl dCA1IG9mICJ3b3JsZCIuIFRoZSBuZXh0IGxpbmUgYm94IHNob3VsZCBiZSB0aGF0IG9mICJ3b3Js ZCIuIEhvd2V2ZXIsIGJlY2F1c2Ugd2UgaW52b2tlIGxvZ2ljYWxseU5leHRCb3ggdmlhCisgICAg ICAgIHdvcmRCcmVha0l0ZXJhdG9yRm9yTWF4T2Zmc2V0Qm91bmRhcnkgd2l0aCB2aXNpYmxlIHBv c2l0aW9uIGF0IG9mZnNldCAwIG9mICJ3b3JsZCIsIGl0IHRoaXNzIGxpbmUgYW5kIHJldHVybiBu dWxscHRyLgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcmVzc2VzIHRoaXMgdGVzdCBmYWlsdXJl IGJ5IGZpeGluZyB2aXN1YWxXb3JkUG9zaXRpb24gYnkgcGFzc2luZyBhZGphY2VudENoYXJhY3Rl clBvc2l0aW9uIChhdCBvZmZzZXQgNQorICAgICAgICBvZiAiaGVsbG8iKSBhcyB0aGUgdmlzaWJs ZSBwb3NpdGlvbiB0byBmaW5kIHRoZSBuZXh0IHRleHQgYm94IHNvIHRoYXQgbmV4dFJvb3RJbmxp bmVCb3hDYW5kaWRhdGVQb3NpdGlvbiBpbnZva2VkIGluCisgICAgICAgIGxvZ2ljYWxseU5leHRC b3ggd291bGQgbm90IHNraXAgdGhlIGxpbmUgKCJ3b3JsZCIpIGZyb20gd2hpY2ggd2Ugc3RhcnRl ZCB0aGUgdHJhdmVyc2FsIHRvIGZpbmQgdGhlIG5leHQgbGluZSBib3guCisKKyAgICAgICAgVGVz dHM6IGVkaXRpbmcvc2VsZWN0aW9uL21vdmUtYnktd29yZC12aXN1YWxseS1pbmxpbmUtYmxvY2st cG9zaXRpb25lZC1lbGVtZW50Lmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvVmlzaWJsZVVuaXRz LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnZpc3VhbFdvcmRQb3NpdGlvbik6CisKIDIwMTgtMDYt MDcgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAg QWRkIGJhc2UgY2xhc3MgdG8gZ2V0IFdlYWtQdHJGYWN0b3J5IG1lbWJlciBhbmQgYXZvaWQgc29t ZSBib2lsZXJwbGF0ZSBjb2RlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1Zpc2libGVV bml0cy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9WaXNpYmxlVW5p dHMuY3BwCShyZXZpc2lvbiAyMzI2MTQpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1Zpc2li bGVVbml0cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM4NCw5ICszODQsOSBAQCBzdGF0aWMgVmlz aWJsZVBvc2l0aW9uIHZpc3VhbFdvcmRQb3NpdGlvCiAgICAgICAgIGJvb2wgbW92aW5nSW50b05l d0JveCA9IHByZXZpb3VzbHlWaXNpdGVkQm94ICE9IGJveDsKIAogICAgICAgICBpZiAob2Zmc2V0 SW5Cb3ggPT0gYm94LT5jYXJldE1pbk9mZnNldCgpKQotICAgICAgICAgICAgaXRlciA9IHdvcmRC cmVha0l0ZXJhdG9yRm9yTWluT2Zmc2V0Qm91bmRhcnkodmlzaWJsZVBvc2l0aW9uLCAmdGV4dEJv eCwgcHJldmlvdXNCb3hMZW5ndGgsIHByZXZpb3VzQm94SW5EaWZmZXJlbnRCbG9jaywgc3RyaW5n LCBsZWFmQm94ZXMpOworICAgICAgICAgICAgaXRlciA9IHdvcmRCcmVha0l0ZXJhdG9yRm9yTWlu T2Zmc2V0Qm91bmRhcnkoYWRqYWNlbnRDaGFyYWN0ZXJQb3NpdGlvbiwgJnRleHRCb3gsIHByZXZp b3VzQm94TGVuZ3RoLCBwcmV2aW91c0JveEluRGlmZmVyZW50QmxvY2ssIHN0cmluZywgbGVhZkJv eGVzKTsKICAgICAgICAgZWxzZSBpZiAob2Zmc2V0SW5Cb3ggPT0gYm94LT5jYXJldE1heE9mZnNl dCgpKQotICAgICAgICAgICAgaXRlciA9IHdvcmRCcmVha0l0ZXJhdG9yRm9yTWF4T2Zmc2V0Qm91 bmRhcnkodmlzaWJsZVBvc2l0aW9uLCAmdGV4dEJveCwgbmV4dEJveEluRGlmZmVyZW50QmxvY2ss IHN0cmluZywgbGVhZkJveGVzKTsKKyAgICAgICAgICAgIGl0ZXIgPSB3b3JkQnJlYWtJdGVyYXRv ckZvck1heE9mZnNldEJvdW5kYXJ5KGFkamFjZW50Q2hhcmFjdGVyUG9zaXRpb24sICZ0ZXh0Qm94 LCBuZXh0Qm94SW5EaWZmZXJlbnRCbG9jaywgc3RyaW5nLCBsZWFmQm94ZXMpOwogICAgICAgICBl bHNlIGlmIChtb3ZpbmdJbnRvTmV3Qm94KSB7CiAgICAgICAgICAgICBpdGVyID0gd29yZEJyZWFr SXRlcmF0b3IoU3RyaW5nVmlldyh0ZXh0Qm94LnJlbmRlcmVyKCkudGV4dCgpKS5zdWJzdHJpbmco dGV4dEJveC5zdGFydCgpLCB0ZXh0Qm94LmxlbigpKSk7CiAgICAgICAgICAgICBwcmV2aW91c2x5 VmlzaXRlZEJveCA9IGJveDsK