18638 2008-04-20 12:51:47 -0700 Add support for non X11 unix platforms 2015-05-07 16:31:26 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC OS X 10.5 RESOLVED DUPLICATE 81456 P2 Normal --- 1 mike.emmel webkit-unassigned andersca eric fishd jam mrobinson sriram.neelakandan stuartmorgan oldest_to_newest 78316 0 mike.emmel 2008-04-20 12:51:47 -0700 Added XP_X11 and XP_DIRECTFB ifdefs and platform support for DirectFB 78318 1 20702 mike.emmel 2008-04-20 12:54:19 -0700 Created attachment 20702 Add Platform definiontion and ifdefs for DirectFB add X11 specific def This is probably a bit controversial since I went the route of adding XP_X11 but it makes the most sense and follows the logic WebKit took for multiple graphics stacks and operating systems. 78321 2 20705 mike.emmel 2008-04-20 13:00:53 -0700 Created attachment 20705 Add changelog entry to original patch 82433 3 20705 eric 2008-06-06 10:07:56 -0700 Comment on attachment 20705 Add changelog entry to original patch Looks fine to me. 82630 4 20705 darin 2008-06-08 12:04:43 -0700 Comment on attachment 20705 Add changelog entry to original patch I'm not sure this patch is OK to land. It seems to change the npapi.h header so that it requires a new symbol, XP_X11 to be set to make it work as it did before. What is going to set that symbol outside the WebKit project? 82677 5 mike.emmel 2008-06-08 14:08:39 -0700 This would result in a proposed change to the plugin header that would need to be propagated back to Mozilla. I'd argue that its needed even in the case of Mozilla which is supported on gtk/directfb. I don't know who is responsible for the interaction between Mozilla and WebKit. 87033 6 20705 mrowe 2008-07-26 22:16:09 -0700 Comment on attachment 20705 Add changelog entry to original patch Setting as r- per Darin's concerns in Comment #4. We can't make changes like this to an API header file without them being discussed with Mozilla first. 602884 7 sriram.neelakandan 2012-04-15 21:20:22 -0700 Mozilla has already made some changes along these line to ensure inclusion of X11 headers under MOZ_X11; Please see the latest file here on the NPAPI SDK link that i found on the plugin-futures wiki page (https://wiki.mozilla.org/NPAPI#NPAPI_SDK) The Latest NPAPI Header as per Mozilla's NPAPI SDK http://code.google.com/p/npapi-sdk/source/browse/trunk/headers/npapi.h And this dates back to r2 on the Version trunk which already had MOZ_X11 protection flags http://code.google.com/p/npapi-sdk/source/diff?spec=svn2&r=2&format=side&path=/trunk/headers/npapi.h Interesting fact is the first version import of the NPAPI header has npapi.h:104 #define NP_VERSION_MINOR 27 where as webkit trunk is @ npapi.h:103 #define NP_VERSION_MINOR 24 So is there a policy on how often Webkit updates NPAPI headers ? Or should i just pull that file from npapi-SDK and submit as a patch for review ? 602887 8 eric 2012-04-15 21:25:58 -0700 I'm not sure who the right plugin people are for NPAPI these days, but not me. :) 602890 9 stuartmorgan 2012-04-15 21:47:46 -0700 (In reply to comment #7) > So is there a policy on how often Webkit updates NPAPI headers ? > Or should i just pull that file from npapi-SDK and submit as a patch for review ? The reason you see divergence is that the npapi-sdk project is quite new in the history of NPAPI; until recently, there was no single source, and each browser vendor had their own copies of the headers that had diverged a fair amount. Work has been done to bring WebKit much closer to the new upstream header, but it was never finished (see bug 38666, bug 77200, and the various bugs they reference). I'd recommend strongly against trying to check in the upstream headers directly as a single patch, and instead pick out the differences specifically related to the MOZ_X11 guard and reconcile just those in one patch. 602897 10 mike.emmel 2012-04-15 22:05:17 -0700 (In reply to comment #9) > (In reply to comment #7) > > So is there a policy on how often Webkit updates NPAPI headers ? > > Or should i just pull that file from npapi-SDK and submit as a patch for review ? > > The reason you see divergence is that the npapi-sdk project is quite new in the history of NPAPI; until recently, there was no single source, and each browser vendor had their own copies of the headers that had diverged a fair amount. Work has been done to bring WebKit much closer to the new upstream header, but it was never finished (see bug 38666, bug 77200, and the various bugs they reference). > > I'd recommend strongly against trying to check in the upstream headers directly as a single patch, and instead pick out the differences specifically related to the MOZ_X11 guard and reconcile just those in one patch. But why have platform types in this header ? They can readily be moved to a included platform header along with platform specific entry points. The EGL bindings do a fairly good job of isolating platform types and can server as a template. Where needed you have NativeDisplay. NativeWindow etc. On top of this both WebKit and Mozilla have and extensive porting layer very few plugins actually need direct access to the underlying platform. Exporting the porting layer as a target for plugins suffices for 90% or more of the plugins. Flash for example could be trivially ported to both browsers porting layers. With HTML 5 the api is effectively complete in the porting layer. This is perhaps going beyond this bug report. But recognize the need of and api for native extensions that makes far more sense then the current plugin concept. Almost all plugins should be ported to a new native extension api synchronized between browsers. A small number will need to bypass this. 602903 11 sriram.neelakandan 2012-04-15 22:49:13 -0700 (In reply to comment #9) > instead pick out the differences specifically related to the MOZ_X11 guard and reconcile just those in one patch. Then as a first step; I am preparing a patch which will have the MOZ_X11 changes against npapi-sdk@r14 for webkit's npapi.h, add upload the patch to bug#40785 Does that sound right ? 607517 12 sriram.neelakandan 2012-04-23 00:28:22 -0700 I guess this can be marked dup of https://bugs.webkit.org/show_bug.cgi?id=40785 1092835 13 mrobinson 2015-05-07 16:31:26 -0700 I don't think we are interested in DirectFB any longer, but Wayland support is still an issue. *** This bug has been marked as a duplicate of bug 81456 *** 20702 2008-04-20 12:54:19 -0700 2008-04-20 13:00:15 -0700 Add Platform definiontion and ifdefs for DirectFB add X11 specific def dfb.patch text/plain 2372 mike.emmel ZGlmZiAtLWdpdCBhL0dOVW1ha2VmaWxlLmFtIGIvR05VbWFrZWZpbGUuYW0KaW5kZXggYTBhZWZi Zi4uN2RlMDY5MyAxMDA2NDQKLS0tIGEvR05VbWFrZWZpbGUuYW0KKysrIGIvR05VbWFrZWZpbGUu YW0KQEAgLTI0MCw2ICsyNDAsMTQgQEAgZW5kaWYKIAogaWYgVEFSR0VUX1gxMQogZ2xvYmFsX2Nw cGZsYWdzICs9IC1EWFBfVU5JWAorZ2xvYmFsX2NwcGZsYWdzICs9IC1EWFBfWDExCitnbG9iYWxf Y3BwZmxhZ3MgKz0gLURCVUlMRElOR19YMTFfXworZW5kaWYKKworaWYgVEFSR0VUX0RJUkVDVEZC CitnbG9iYWxfY3BwZmxhZ3MgKz0gLURYUF9VTklYCitnbG9iYWxfY3BwZmxhZ3MgKz0gLURYUF9E SVJFQ1RGQgorZ2xvYmFsX2NwcGZsYWdzICs9IC1EQlVJTERJTkdfRElSRUNURkJfXwogZW5kaWYK IAogaWYgIUVOQUJMRV9ERUJVRwpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRm b3JtLmggYi9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAppbmRleCA1MjlhYTlmLi42MTg2 YzQwIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAorKysgYi9KYXZh U2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaApAQCAtMTAxLDYgKzEwMSwxNCBAQAogI2RlZmluZSBX VEZfUExBVEZPUk1fV0lOIDEKICNlbmRpZgogCisjaWYgZGVmaW5lZChCVUlMRElOR19ESVJFQ1RG Ql9fKQorI2RlZmluZSBXVEZfUExBVEZPUk1fRElSRUNURkIgMQorI2VuZGlmCisKKyNpZiBkZWZp bmVkKEJVSUxESU5HX1gxMV9fKQorI2RlZmluZSBXVEZfUExBVEZPUk1fWDExIDEKKyNlbmRpZgor CiAvKiBHcmFwaGljcyBlbmdpbmVzICovCiAKIC8qIFBMQVRGT1JNKENHKSAqLwpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9icmlkZ2UvbnBhcGkuaCBiL1dlYkNvcmUvYnJpZGdlL25wYXBpLmgKaW5kZXgg YmE4YjZjNy4uYjZjMjQ4YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9icmlkZ2UvbnBhcGkuaAorKysg Yi9XZWJDb3JlL2JyaWRnZS9ucGFwaS5oCkBAIC04Nyw4ICs4NywxMCBAQAogI2VuZGlmCiAKICNp ZmRlZiBYUF9VTklYCisjaWZkZWYgWFBfWDExCiAgICAgI2luY2x1ZGUgPFgxMS9YbGliLmg+CiAg ICAgI2luY2x1ZGUgPFgxMS9YdXRpbC5oPgorI2VuZGlmCiAgICAgI2luY2x1ZGUgPHN0ZGlvLmg+ CiAjZW5kaWYKIApAQCAtMjQ3LDExICsyNDksMTMgQEAgdHlwZWRlZiBzdHJ1Y3QKIAogdHlwZWRl ZiBzdHJ1Y3QKIHsKKyNpZmRlZiBYUF9YMTEKICAgICBpbnQzMiAgICAgICAgICAgdHlwZTsKICAg ICBEaXNwbGF5KiAgICAgICAgZGlzcGxheTsKICAgICBWaXN1YWwqICAgICAgICAgdmlzdWFsOwog ICAgIENvbG9ybWFwICAgICAgICBjb2xvcm1hcDsKICAgICB1bnNpZ25lZCBpbnQgICAgZGVwdGg7 CisjZW5kaWYKIH0gTlBTZXRXaW5kb3dDYWxsYmFja1N0cnVjdDsKIAogdHlwZWRlZiBzdHJ1Y3QK QEAgLTQ0OCw3ICs0NTIsNyBAQCB0eXBlZGVmIHN0cnVjdCBfTlBFdmVudAogICAgIHVpbnQzMiAg IHdQYXJhbTsKICAgICB1aW50MzIgICBsUGFyYW07CiB9IE5QRXZlbnQ7Ci0jZWxpZiBkZWZpbmVk IChYUF9VTklYKQorI2VsaWYgZGVmaW5lZCAoWFBfVU5JWCkgJiYgZGVmaW5lZChYUF9YMTEpCiB0 eXBlZGVmIFhFdmVudCBOUEV2ZW50OwogI2Vsc2UKIHR5cGVkZWYgdm9pZCogICAgICAgICAgICBO UEV2ZW50OwpAQCAtNDY5LDcgKzQ3Myw3IEBAIHR5cGVkZWYgUmduSGFuZGxlIE5QUURSZWdpb247 CiB0eXBlZGVmIENHUGF0aFJlZiBOUENHUmVnaW9uOwogI2VsaWYgZGVmaW5lZChYUF9XSU4pCiB0 eXBlZGVmIEhSR04gTlBSZWdpb247Ci0jZWxpZiBkZWZpbmVkKFhQX1VOSVgpCisjZWxpZiBkZWZp bmVkIChYUF9VTklYKSAmJiBkZWZpbmVkKFhQX1gxMSkKIHR5cGVkZWYgUmVnaW9uIE5QUmVnaW9u OwogI2Vsc2UKIHR5cGVkZWYgdm9pZCAqTlBSZWdpb247CmRpZmYgLS1naXQgYS9XZWJDb3JlL2Jy aWRnZS9ucHJ1bnRpbWVfaW50ZXJuYWwuaCBiL1dlYkNvcmUvYnJpZGdlL25wcnVudGltZV9pbnRl cm5hbC5oCmluZGV4IGUyY2NhYmUuLjNkODZkZDQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYnJpZGdl L25wcnVudGltZV9pbnRlcm5hbC5oCisrKyBiL1dlYkNvcmUvYnJpZGdlL25wcnVudGltZV9pbnRl cm5hbC5oCkBAIC0yOSw5ICsyOSw4IEBACiAjaW5jbHVkZSAibnBmdW5jdGlvbnMuaCIKICNpbmNs dWRlICJucHJ1bnRpbWUuaCIKIAotI2lmZGVmIFhQX1VOSVgKKyNpZmRlZiBYUF9YMTEgCiAgICAg I2luY2x1ZGUgPFgxMS9YcmVzb3VyY2UuaD4KLQogICAgICN1bmRlZiBOb25lCiAgICAgI3VuZGVm IEFib3ZlCiAgICAgI3VuZGVmIEJlbG93CkBAIC0zOSwzICszOCw0IEBACiAgICAgI3VuZGVmIENv bXBsZXgKICAgICAjdW5kZWYgU3RhdHVzCiAjZW5kaWYKKwo= 20705 2008-04-20 13:00:53 -0700 2010-06-10 15:49:04 -0700 Add changelog entry to original patch dfb.patch text/plain 2964 mike.emmel ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBhZmVlYjhhLi40NjIwYjhk IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMDgtMDMtMTIgIE1pY2hhZWwgRW1tZWwgIDxtaWtlLmVtbWVsQGdtYWlsLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSA/CisKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTg2MzgKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIG5vbiBYMTEgdW5peCBw bHVnaW5zIGFuZCB0aGUgZGlyZWN0ZmIgcGxhdGZvcm0KKworICAgICAgICAqIEdOVW1ha2VmaWxl LmFtOgorICAgICAgICAqIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oOgorICAgICAgICAq IFdlYkNvcmUvYnJpZGdlL25wYXBpLmg6CisgICAgICAgICogV2ViQ29yZS9icmlkZ2UvbnBydW50 aW1lX2ludGVybmFsLmgKKwogMjAwOC0wNC0xNyAgQWxwIFRva2VyICA8YWxwQGF0b2tlci5jb20+ CiAKICAgICAgICAgR1RLKyBidWlsZCBmaXguIEJhY2sgb3V0IHRoZSBsaWJqcGVnIGNoZWNrIHBh cnQgb2YgcjMyMDA4IGZyb20gYnVnCmRpZmYgLS1naXQgYS9HTlVtYWtlZmlsZS5hbSBiL0dOVW1h a2VmaWxlLmFtCmluZGV4IGEwYWVmYmYuLjdkZTA2OTMgMTAwNjQ0Ci0tLSBhL0dOVW1ha2VmaWxl LmFtCisrKyBiL0dOVW1ha2VmaWxlLmFtCkBAIC0yNDAsNiArMjQwLDE0IEBAIGVuZGlmCiAKIGlm IFRBUkdFVF9YMTEKIGdsb2JhbF9jcHBmbGFncyArPSAtRFhQX1VOSVgKK2dsb2JhbF9jcHBmbGFn cyArPSAtRFhQX1gxMQorZ2xvYmFsX2NwcGZsYWdzICs9IC1EQlVJTERJTkdfWDExX18KK2VuZGlm CisKK2lmIFRBUkdFVF9ESVJFQ1RGQgorZ2xvYmFsX2NwcGZsYWdzICs9IC1EWFBfVU5JWAorZ2xv YmFsX2NwcGZsYWdzICs9IC1EWFBfRElSRUNURkIKK2dsb2JhbF9jcHBmbGFncyArPSAtREJVSUxE SU5HX0RJUkVDVEZCX18KIGVuZGlmCiAKIGlmICFFTkFCTEVfREVCVUcKZGlmZiAtLWdpdCBhL0ph dmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oIGIvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3Jt LmgKaW5kZXggNTI5YWE5Zi4uNjE4NmM0MCAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3Rm L1BsYXRmb3JtLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKQEAgLTEwMSw2 ICsxMDEsMTQgQEAKICNkZWZpbmUgV1RGX1BMQVRGT1JNX1dJTiAxCiAjZW5kaWYKIAorI2lmIGRl ZmluZWQoQlVJTERJTkdfRElSRUNURkJfXykKKyNkZWZpbmUgV1RGX1BMQVRGT1JNX0RJUkVDVEZC IDEKKyNlbmRpZgorCisjaWYgZGVmaW5lZChCVUlMRElOR19YMTFfXykKKyNkZWZpbmUgV1RGX1BM QVRGT1JNX1gxMSAxCisjZW5kaWYKKwogLyogR3JhcGhpY3MgZW5naW5lcyAqLwogCiAvKiBQTEFU Rk9STShDRykgKi8KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYnJpZGdlL25wYXBpLmggYi9XZWJDb3Jl L2JyaWRnZS9ucGFwaS5oCmluZGV4IGJhOGI2YzcuLmI2YzI0OGEgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvYnJpZGdlL25wYXBpLmgKKysrIGIvV2ViQ29yZS9icmlkZ2UvbnBhcGkuaApAQCAtODcsOCAr ODcsMTAgQEAKICNlbmRpZgogCiAjaWZkZWYgWFBfVU5JWAorI2lmZGVmIFhQX1gxMQogICAgICNp bmNsdWRlIDxYMTEvWGxpYi5oPgogICAgICNpbmNsdWRlIDxYMTEvWHV0aWwuaD4KKyNlbmRpZgog ICAgICNpbmNsdWRlIDxzdGRpby5oPgogI2VuZGlmCiAKQEAgLTI0NywxMSArMjQ5LDEzIEBAIHR5 cGVkZWYgc3RydWN0CiAKIHR5cGVkZWYgc3RydWN0CiB7CisjaWZkZWYgWFBfWDExCiAgICAgaW50 MzIgICAgICAgICAgIHR5cGU7CiAgICAgRGlzcGxheSogICAgICAgIGRpc3BsYXk7CiAgICAgVmlz dWFsKiAgICAgICAgIHZpc3VhbDsKICAgICBDb2xvcm1hcCAgICAgICAgY29sb3JtYXA7CiAgICAg dW5zaWduZWQgaW50ICAgIGRlcHRoOworI2VuZGlmCiB9IE5QU2V0V2luZG93Q2FsbGJhY2tTdHJ1 Y3Q7CiAKIHR5cGVkZWYgc3RydWN0CkBAIC00NDgsNyArNDUyLDcgQEAgdHlwZWRlZiBzdHJ1Y3Qg X05QRXZlbnQKICAgICB1aW50MzIgICB3UGFyYW07CiAgICAgdWludDMyICAgbFBhcmFtOwogfSBO UEV2ZW50OwotI2VsaWYgZGVmaW5lZCAoWFBfVU5JWCkKKyNlbGlmIGRlZmluZWQgKFhQX1VOSVgp ICYmIGRlZmluZWQoWFBfWDExKQogdHlwZWRlZiBYRXZlbnQgTlBFdmVudDsKICNlbHNlCiB0eXBl ZGVmIHZvaWQqICAgICAgICAgICAgTlBFdmVudDsKQEAgLTQ2OSw3ICs0NzMsNyBAQCB0eXBlZGVm IFJnbkhhbmRsZSBOUFFEUmVnaW9uOwogdHlwZWRlZiBDR1BhdGhSZWYgTlBDR1JlZ2lvbjsKICNl bGlmIGRlZmluZWQoWFBfV0lOKQogdHlwZWRlZiBIUkdOIE5QUmVnaW9uOwotI2VsaWYgZGVmaW5l ZChYUF9VTklYKQorI2VsaWYgZGVmaW5lZCAoWFBfVU5JWCkgJiYgZGVmaW5lZChYUF9YMTEpCiB0 eXBlZGVmIFJlZ2lvbiBOUFJlZ2lvbjsKICNlbHNlCiB0eXBlZGVmIHZvaWQgKk5QUmVnaW9uOwpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9icmlkZ2UvbnBydW50aW1lX2ludGVybmFsLmggYi9XZWJDb3Jl L2JyaWRnZS9ucHJ1bnRpbWVfaW50ZXJuYWwuaAppbmRleCBlMmNjYWJlLi4zZDg2ZGQ0IDEwMDY0 NAotLS0gYS9XZWJDb3JlL2JyaWRnZS9ucHJ1bnRpbWVfaW50ZXJuYWwuaAorKysgYi9XZWJDb3Jl L2JyaWRnZS9ucHJ1bnRpbWVfaW50ZXJuYWwuaApAQCAtMjksOSArMjksOCBAQAogI2luY2x1ZGUg Im5wZnVuY3Rpb25zLmgiCiAjaW5jbHVkZSAibnBydW50aW1lLmgiCiAKLSNpZmRlZiBYUF9VTklY CisjaWZkZWYgWFBfWDExIAogICAgICNpbmNsdWRlIDxYMTEvWHJlc291cmNlLmg+Ci0KICAgICAj dW5kZWYgTm9uZQogICAgICN1bmRlZiBBYm92ZQogICAgICN1bmRlZiBCZWxvdwpAQCAtMzksMyAr MzgsNCBAQAogICAgICN1bmRlZiBDb21wbGV4CiAgICAgI3VuZGVmIFN0YXR1cwogI2VuZGlmCisK