186296 2018-06-04 18:38:28 -0700 [Win] REGRESSION(r232486) 'WebCore::RenderTheme::activeListBoxSelectionBackgroundColor': function does not take 0 arguments 2018-06-04 21:13:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=186288 InRadar P2 Normal --- 1 fujii timothy commit-queue timothy webkit-bug-importer oldest_to_newest 1429987 0 fujii 2018-06-04 18:38:28 -0700 [Win] REGRESSION(r232486) 'WebCore::RenderTheme::activeListBoxSelectionBackgroundColor': function does not take 0 arguments https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Build%29/builds/788 > ..\..\Source\WebCore\platform\win\PopupMenuWin.cpp(624): error C2660: 'WebCore::RenderTheme::activeListBoxSelectionBackgroundColor': function does not take 0 arguments > ..\..\Source\WebCore\platform\win\PopupMenuWin.cpp(625): error C2660: 'WebCore::RenderTheme::activeListBoxSelectionForegroundColor': function does not take 0 arguments 1429991 1 fujii 2018-06-04 19:03:22 -0700 >PopupMenuWin.cpp >c:\webkit\ga\source\webcore\platform\win\popupmenuwin.cpp(624): error C2660: 'WebCore::RenderTheme::activeListBoxSelectionBackgroundColor': function does not take 0 arguments >c:\webkit\ga\source\webcore\platform\win\popupmenuwin.cpp(625): error C2660: 'WebCore::RenderTheme::activeListBoxSelectionForegroundColor': function does not take 0 arguments >RenderThemeWin.cpp >c:\webkit\ga\source\webcore\rendering\renderthemewin.cpp(316): error C2660: 'WebCore::RenderThemeWin::platformActiveSelectionForegroundColor': function does not take 0 arguments 1429998 2 341947 timothy 2018-06-04 19:18:24 -0700 Created attachment 341947 Patch 1430002 3 341948 timothy 2018-06-04 19:29:28 -0700 Created attachment 341948 Patch 1430011 4 fujii 2018-06-04 20:57:51 -0700 I've confirmed your patch fixes the break in my PC. Thank you for working on this. 1430017 5 341948 commit-queue 2018-06-04 21:12:53 -0700 Comment on attachment 341948 Patch Clearing flags on attachment: 341948 Committed r232500: <https://trac.webkit.org/changeset/232500> 1430018 6 commit-queue 2018-06-04 21:12:54 -0700 All reviewed patches have been landed. Closing bug. 1430019 7 webkit-bug-importer 2018-06-04 21:13:19 -0700 <rdar://problem/40793328> 341947 2018-06-04 19:18:24 -0700 2018-06-04 19:29:27 -0700 Patch bug-186296-20180604191824.patch text/plain 1839 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTg1ZTViODhjNWY0YTI1 ZTZmOTI4Yjk5MDYzZWM0N2VjYWI3Y2E5Yi4uYTRkMjJkYWM2MjhlNDM2OTg3ZGNjNDQyYWU3ZDI3 Yzk3NWNjYmQ1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE4LTA2LTA0ICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBSRUdSRVNT SU9OKHIyMzI0ODYpICdXZWJDb3JlOjpSZW5kZXJUaGVtZTo6YWN0aXZlTGlzdEJveFNlbGVjdGlv bkJhY2tncm91bmRDb2xvcic6IGZ1bmN0aW9uIGRvZXMgbm90IHRha2UgMCBhcmd1bWVudHMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjI5NgorCisg ICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LgorCisgICAgICAgICogcGxhdGZvcm0vd2luL1Bv cHVwTWVudVdpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQb3B1cE1lbnVXaW46OnBhaW50KToK KwogMjAxOC0wNi0wNCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAg ICAgICAgU2VsZWN0aW9uIGNvbG9yIGlzIGRhcmsgd2hlbiB1c2luZyBTYWZhcmkgaW4gZGFyayBt b2RlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1BvcHVwTWVudVdp bi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUG9wdXBNZW51V2luLmNwcAppbmRl eCBmMjk0MDZhOTdmYTQxMzJlYjEzMDM0NjFiNDhlZjQ3ZTM0YjA2OWVmLi4wMmYwOTlkOWUyNTkz NmVjNmYwMWU3Mzg2NzQ0MDk1OGRlMDFlYmJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS93aW4vUG9wdXBNZW51V2luLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS93aW4vUG9wdXBNZW51V2luLmNwcApAQCAtNjIxLDggKzYyMSw4IEBAIHZvaWQgUG9wdXBNZW51 V2luOjpwYWludChjb25zdCBJbnRSZWN0JiBkYW1hZ2VSZWN0LCBIREMgaGRjKQogICAgICAgICBD b2xvciBvcHRpb25CYWNrZ3JvdW5kQ29sb3IsIG9wdGlvblRleHRDb2xvcjsKICAgICAgICAgUG9w dXBNZW51U3R5bGUgaXRlbVN0eWxlID0gY2xpZW50KCktPml0ZW1TdHlsZShpbmRleCk7CiAgICAg ICAgIGlmIChpbmRleCA9PSBmb2N1c2VkSW5kZXgoKSkgewotICAgICAgICAgICAgb3B0aW9uQmFj a2dyb3VuZENvbG9yID0gUmVuZGVyVGhlbWU6OnNpbmdsZXRvbigpLmFjdGl2ZUxpc3RCb3hTZWxl Y3Rpb25CYWNrZ3JvdW5kQ29sb3IoKTsKLSAgICAgICAgICAgIG9wdGlvblRleHRDb2xvciA9IFJl bmRlclRoZW1lOjpzaW5nbGV0b24oKS5hY3RpdmVMaXN0Qm94U2VsZWN0aW9uRm9yZWdyb3VuZENv bG9yKCk7CisgICAgICAgICAgICBvcHRpb25CYWNrZ3JvdW5kQ29sb3IgPSBSZW5kZXJUaGVtZTo6 c2luZ2xldG9uKCkuYWN0aXZlTGlzdEJveFNlbGVjdGlvbkJhY2tncm91bmRDb2xvcih7IH0pOwor ICAgICAgICAgICAgb3B0aW9uVGV4dENvbG9yID0gUmVuZGVyVGhlbWU6OnNpbmdsZXRvbigpLmFj dGl2ZUxpc3RCb3hTZWxlY3Rpb25Gb3JlZ3JvdW5kQ29sb3IoeyB9KTsKICAgICAgICAgfSBlbHNl IHsKICAgICAgICAgICAgIG9wdGlvbkJhY2tncm91bmRDb2xvciA9IGl0ZW1TdHlsZS5iYWNrZ3Jv dW5kQ29sb3IoKTsKICAgICAgICAgICAgIG9wdGlvblRleHRDb2xvciA9IGl0ZW1TdHlsZS5mb3Jl Z3JvdW5kQ29sb3IoKTsK 341948 2018-06-04 19:29:28 -0700 2018-06-04 21:12:53 -0700 Patch bug-186296-20180604192928.patch text/plain 2885 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTg1ZTViODhjNWY0YTI1 ZTZmOTI4Yjk5MDYzZWM0N2VjYWI3Y2E5Yi4uN2E5ZmYwOGFjZmQzNTgyZDg0NzNhOWQ3ZjE5YmQ5 MGYyZTRiYTA0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA2LTA0ICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBSRUdSRVNT SU9OKHIyMzI0ODYpICdXZWJDb3JlOjpSZW5kZXJUaGVtZTo6YWN0aXZlTGlzdEJveFNlbGVjdGlv bkJhY2tncm91bmRDb2xvcic6IGZ1bmN0aW9uIGRvZXMgbm90IHRha2UgMCBhcmd1bWVudHMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjI5NgorCisg ICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LgorCisgICAgICAgICogcGxhdGZvcm0vd2luL1Bv cHVwTWVudVdpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQb3B1cE1lbnVXaW46OnBhaW50KToK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyVGhlbWVXaW46OnBsYXRmb3JtSW5hY3RpdmVTZWxlY3Rpb25Gb3JlZ3JvdW5kQ29s b3IgY29uc3QpOgorCiAyMDE4LTA2LTA0ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxl LmNvbT4KIAogICAgICAgICBTZWxlY3Rpb24gY29sb3IgaXMgZGFyayB3aGVuIHVzaW5nIFNhZmFy aSBpbiBkYXJrIG1vZGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4v UG9wdXBNZW51V2luLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9Qb3B1cE1lbnVX aW4uY3BwCmluZGV4IGYyOTQwNmE5N2ZhNDEzMmViMTMwMzQ2MWI0OGVmNDdlMzRiMDY5ZWYuLjAy ZjA5OWQ5ZTI1OTM2ZWM2ZjAxZTczODY3NDQwOTU4ZGUwMWViYmIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9Qb3B1cE1lbnVXaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3dpbi9Qb3B1cE1lbnVXaW4uY3BwCkBAIC02MjEsOCArNjIxLDggQEAgdm9p ZCBQb3B1cE1lbnVXaW46OnBhaW50KGNvbnN0IEludFJlY3QmIGRhbWFnZVJlY3QsIEhEQyBoZGMp CiAgICAgICAgIENvbG9yIG9wdGlvbkJhY2tncm91bmRDb2xvciwgb3B0aW9uVGV4dENvbG9yOwog ICAgICAgICBQb3B1cE1lbnVTdHlsZSBpdGVtU3R5bGUgPSBjbGllbnQoKS0+aXRlbVN0eWxlKGlu ZGV4KTsKICAgICAgICAgaWYgKGluZGV4ID09IGZvY3VzZWRJbmRleCgpKSB7Ci0gICAgICAgICAg ICBvcHRpb25CYWNrZ3JvdW5kQ29sb3IgPSBSZW5kZXJUaGVtZTo6c2luZ2xldG9uKCkuYWN0aXZl TGlzdEJveFNlbGVjdGlvbkJhY2tncm91bmRDb2xvcigpOwotICAgICAgICAgICAgb3B0aW9uVGV4 dENvbG9yID0gUmVuZGVyVGhlbWU6OnNpbmdsZXRvbigpLmFjdGl2ZUxpc3RCb3hTZWxlY3Rpb25G b3JlZ3JvdW5kQ29sb3IoKTsKKyAgICAgICAgICAgIG9wdGlvbkJhY2tncm91bmRDb2xvciA9IFJl bmRlclRoZW1lOjpzaW5nbGV0b24oKS5hY3RpdmVMaXN0Qm94U2VsZWN0aW9uQmFja2dyb3VuZENv bG9yKHsgfSk7CisgICAgICAgICAgICBvcHRpb25UZXh0Q29sb3IgPSBSZW5kZXJUaGVtZTo6c2lu Z2xldG9uKCkuYWN0aXZlTGlzdEJveFNlbGVjdGlvbkZvcmVncm91bmRDb2xvcih7IH0pOwogICAg ICAgICB9IGVsc2UgewogICAgICAgICAgICAgb3B0aW9uQmFja2dyb3VuZENvbG9yID0gaXRlbVN0 eWxlLmJhY2tncm91bmRDb2xvcigpOwogICAgICAgICAgICAgb3B0aW9uVGV4dENvbG9yID0gaXRl bVN0eWxlLmZvcmVncm91bmRDb2xvcigpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRoZW1lV2luLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUaGVtZVdpbi5jcHAKaW5kZXggZjE0YTM4ZTE0N2I4MzAyZGQwYjNjMTY4OWU5NmEzNGFkMTcy ODI2OC4uOThjYjE1YWFiZjM4N2EyYTc5MTliYjA4YjcwZThmODdjYzQxMmQ5MyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uY3BwCkBAIC0zMTEsOSArMzExLDkg QEAgQ29sb3IgUmVuZGVyVGhlbWVXaW46OnBsYXRmb3JtQWN0aXZlU2VsZWN0aW9uRm9yZWdyb3Vu ZENvbG9yKE9wdGlvblNldDxTdHlsZUNvbG8KICAgICByZXR1cm4gQ29sb3IoR2V0UlZhbHVlKGNv bG9yKSwgR2V0R1ZhbHVlKGNvbG9yKSwgR2V0QlZhbHVlKGNvbG9yKSk7CiB9CiAKLUNvbG9yIFJl bmRlclRoZW1lV2luOjpwbGF0Zm9ybUluYWN0aXZlU2VsZWN0aW9uRm9yZWdyb3VuZENvbG9yKE9w dGlvblNldDxTdHlsZUNvbG9yOjpPcHRpb25zPikgY29uc3QKK0NvbG9yIFJlbmRlclRoZW1lV2lu OjpwbGF0Zm9ybUluYWN0aXZlU2VsZWN0aW9uRm9yZWdyb3VuZENvbG9yKE9wdGlvblNldDxTdHls ZUNvbG9yOjpPcHRpb25zPiBvcHRpb25zKSBjb25zdAogewotICAgIHJldHVybiBwbGF0Zm9ybUFj dGl2ZVNlbGVjdGlvbkZvcmVncm91bmRDb2xvcigpOworICAgIHJldHVybiBwbGF0Zm9ybUFjdGl2 ZVNlbGVjdGlvbkZvcmVncm91bmRDb2xvcihvcHRpb25zKTsKIH0KIAogc3RhdGljIHZvaWQgZmls bEZvbnREZXNjcmlwdGlvbihGb250Q2FzY2FkZURlc2NyaXB0aW9uJiBmb250RGVzY3JpcHRpb24s IExPR0ZPTlQmIGxvZ0ZvbnQsIGZsb2F0IGZvbnRTaXplKQo=