185950 2018-05-24 09:29:44 -0700 [ews-build] Unit-tests should run buildbot checkconfig 2021-02-19 08:51:28 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=185484 P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap dbates dean_johnson lforschler oldest_to_newest 1426950 0 aakash_jain 2018-05-24 09:29:44 -0700 Unit-tests should run buildbot checkconfig. Many times 'buildbot checkconfig' catches issues which are not catched by unit-tests. 1426951 1 341198 aakash_jain 2018-05-24 09:31:21 -0700 Created attachment 341198 Proposed patch 1426974 2 341205 aakash_jain 2018-05-24 10:31:58 -0700 Created attachment 341205 Updated patch 1632461 3 aakash_jain 2020-03-21 04:24:48 -0700 This change is no longer required. We now have 'services' EWS which runs 'buildbot checkconfig'. 341198 2018-05-24 09:31:21 -0700 2018-05-24 10:31:58 -0700 Proposed patch ews_buildbot_checkconfig.patch text/plain 1637 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMjE1MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE4LTA1LTI0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBVbml0LXRlc3RzIHNob3VsZCBydW4gYnVpbGRib3Qg Y2hlY2tjb25maWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4NTk1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWdfdW5pdHRlc3QucHk6 CisgICAgICAgIChCdWlsZGJvdENoZWNrY29uZmlnLnRlc3RfYnVpbGRib3RfY2hlY2tjb25maWcp OiBBZGRlZCB1bml0LXRlc3QgdG8gcnVuIGJ1aWxkYm90IGNoZWNrY29uZmlnLgorCiAyMDE4LTA1 LTI0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAg ICBXZWJEcml2ZXI6IGltcGxlbWVudCBtYXhpbWl6ZSwgbWluaW1pemUgYW5kIGZ1bGxzY3JlZW4g d2luZG93IGNvbW1hbmRzCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQv bG9hZENvbmZpZ191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvbG9hZENvbmZpZ191bml0dGVzdC5weQkocmV2aXNpb24gMjMyMTUzKQor KysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWdfdW5pdHRlc3Qu cHkJKHdvcmtpbmcgY29weSkKQEAgLTIzLDYgKzIzLDcgQEAKICMgT0YgVEhJUyBTT0ZUV0FSRSwg RVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KIAogCitp bXBvcnQgc3VicHJvY2VzcwogaW1wb3J0IHVuaXR0ZXN0CiAKIGltcG9ydCBsb2FkQ29uZmlnCkBA IC0zMyw2ICszNCwxMiBAQCBjbGFzcyBDb25maWdEb3RKU09OVGVzdCh1bml0dGVzdC5UZXN0Q2Fz CiAgICAgICAgIGxvYWRDb25maWcubG9hZEJ1aWxkZXJDb25maWcoe30pCiAKIAorY2xhc3MgQnVp bGRib3RDaGVja2NvbmZpZyh1bml0dGVzdC5UZXN0Q2FzZSk6CisgICAgZGVmIHRlc3RfYnVpbGRi b3RfY2hlY2tjb25maWcoc2VsZik6CisgICAgICAgIG91dHB1dCA9IHN1YnByb2Nlc3MuY2hlY2tf b3V0cHV0KFsnYnVpbGRib3QnLCAnY2hlY2tjb25maWcnXSkKKyAgICAgICAgc2VsZi5hc3NlcnRF cXVhbChvdXRwdXQsICdDb25maWcgZmlsZSBpcyBnb29kIVxuJykKKworCiBjbGFzcyBUYWdzRm9y QnVpbGRlclRlZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICBkZWYgdmVyaWZ5VGFncyhzZWxm LCBidWlsZGVyTmFtZSwgZXhwZWN0ZWRUYWdzKToKICAgICAgICAgdGFncyA9IGxvYWRDb25maWcu Z2V0VGFnc0ZvckJ1aWxkZXIoeyduYW1lJzogYnVpbGRlck5hbWV9KQo= 341205 2018-05-24 10:31:58 -0700 2021-02-19 08:51:28 -0800 Updated patch ews_buildbot_checkconfig_v2.patch text/plain 1894 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMjE1MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE4LTA1LTI0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBVbml0LXRlc3RzIHNob3VsZCBydW4gYnVpbGRib3Qg Y2hlY2tjb25maWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4NTk1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWdfdW5pdHRlc3QucHk6 CisgICAgICAgIChCdWlsZGJvdENoZWNrY29uZmlnLnRlc3RfYnVpbGRib3RfY2hlY2tjb25maWcp OiBBZGRlZCB1bml0LXRlc3QgdG8gcnVuIGJ1aWxkYm90IGNoZWNrY29uZmlnLgorCiAyMDE4LTA1 LTI0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAg ICBXZWJEcml2ZXI6IGltcGxlbWVudCBtYXhpbWl6ZSwgbWluaW1pemUgYW5kIGZ1bGxzY3JlZW4g d2luZG93IGNvbW1hbmRzCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQv bG9hZENvbmZpZ191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvbG9hZENvbmZpZ191bml0dGVzdC5weQkocmV2aXNpb24gMjMyMTUzKQor KysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWdfdW5pdHRlc3Qu cHkJKHdvcmtpbmcgY29weSkKQEAgLTIzLDYgKzIzLDggQEAKICMgT0YgVEhJUyBTT0ZUV0FSRSwg RVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KIAogCitp bXBvcnQgb3MKK2ltcG9ydCBzdWJwcm9jZXNzCiBpbXBvcnQgdW5pdHRlc3QKIAogaW1wb3J0IGxv YWRDb25maWcKQEAgLTMzLDYgKzM1LDE1IEBAIGNsYXNzIENvbmZpZ0RvdEpTT05UZXN0KHVuaXR0 ZXN0LlRlc3RDYXMKICAgICAgICAgbG9hZENvbmZpZy5sb2FkQnVpbGRlckNvbmZpZyh7fSkKIAog CitjbGFzcyBCdWlsZGJvdENoZWNrY29uZmlnKHVuaXR0ZXN0LlRlc3RDYXNlKToKKyAgICBkZWYg dGVzdF9idWlsZGJvdF9jaGVja2NvbmZpZyhzZWxmKToKKyAgICAgICAgY3dkID0gb3MucGF0aC5k aXJuYW1lKG9zLnBhdGguYWJzcGF0aChfX2ZpbGVfXykpCisgICAgICAgIGNoZWNrY29uZmlnX3By b2Nlc3MgPSBzdWJwcm9jZXNzLlBvcGVuKFsnYnVpbGRib3QnLCAnY2hlY2tjb25maWcnXSwgY3dk PWN3ZCwgc3Rkb3V0PXN1YnByb2Nlc3MuUElQRSwgc3RkZXJyPXN1YnByb2Nlc3MuU1RET1VUKQor ICAgICAgICAoc3Rkb3V0LCBzdGRlcnIpID0gY2hlY2tjb25maWdfcHJvY2Vzcy5jb21tdW5pY2F0 ZSgpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoY2hlY2tjb25maWdfcHJvY2Vzcy5yZXR1cm5j b2RlLCAwKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHN0ZG91dCwgJ0NvbmZpZyBmaWxlIGlz IGdvb2QhXG4nKQorCisKIGNsYXNzIFRhZ3NGb3JCdWlsZGVyVGVlc3QodW5pdHRlc3QuVGVzdENh c2UpOgogICAgIGRlZiB2ZXJpZnlUYWdzKHNlbGYsIGJ1aWxkZXJOYW1lLCBleHBlY3RlZFRhZ3Mp OgogICAgICAgICB0YWdzID0gbG9hZENvbmZpZy5nZXRUYWdzRm9yQnVpbGRlcih7J25hbWUnOiBi dWlsZGVyTmFtZX0pCg==