185947 2018-05-24 07:26:08 -0700 WebKit (JavaScriptCore) compilation error with Clang ≥ 6 2018-06-21 20:02:00 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=8209 InRadar P2 Normal --- 185198 1 lantw44 mark.lam clopez commit-queue ddkilzer mark.lam mcatanzaro saam webkit-bug-importer oldest_to_newest 1426923 0 lantw44 2018-05-24 07:26:08 -0700 Here are the error messages when compiling WebKitGTK+ 2.21.2 with Clang 6. The current WebKit trunk also has the same problem. In file included from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource26.cpp:6: /home/lantw44/gnome/source/webkitgtk-2.21.2/Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:109:12: error: functional-style cast from 'CodeLocationLabel<JSInternalPtrTag>' to 'CodeLocationJump<JSInternalPtrTag>' uses deleted function return CodeLocationJump<JSInternalPtrTag>(m_callReturnLocationOrPatchableJump); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/lantw44/gnome/source/webkitgtk-2.21.2/Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:336:5: note: candidate function [with T = JSC::CodeLocationJump<26432>, $1 = void] has been explicitly deleted operator T() = delete; ^ /home/lantw44/gnome/source/webkitgtk-2.21.2/Source/JavaScriptCore/assembler/CodeLocation.h:118:14: note: candidate constructor explicit CodeLocationJump(MacroAssemblerCodePtr<tag> location) ^ /home/lantw44/gnome/source/webkitgtk-2.21.2/Source/JavaScriptCore/assembler/CodeLocation.h:115:7: note: candidate is the implicit move constructor class CodeLocationJump : public CodeLocationCommon<tag> { ^ /home/lantw44/gnome/source/webkitgtk-2.21.2/Source/JavaScriptCore/assembler/CodeLocation.h:115:7: note: candidate is the implicit copy constructor /home/lantw44/gnome/source/webkitgtk-2.21.2/Source/JavaScriptCore/assembler/CodeLocation.h:120:14: note: candidate constructor explicit CodeLocationJump(void* location) ^ In file included from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource26.cpp:6: /home/lantw44/gnome/source/webkitgtk-2.21.2/Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:115:12: error: functional-style cast from 'CodeLocationLabel<JSInternalPtrTag>' to 'CodeLocationDataLabelPtr<JSInternalPtrTag>' uses deleted function return CodeLocationDataLabelPtr<JSInternalPtrTag>(m_hotPathBeginOrSlowPathStart); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/lantw44/gnome/source/webkitgtk-2.21.2/Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:336:5: note: candidate function [with T = JSC::CodeLocationDataLabelPtr<26432>, $1 = void] has been explicitly deleted operator T() = delete; ^ /home/lantw44/gnome/source/webkitgtk-2.21.2/Source/JavaScriptCore/assembler/CodeLocation.h:177:14: note: candidate constructor explicit CodeLocationDataLabelPtr(MacroAssemblerCodePtr<tag> location) ^ /home/lantw44/gnome/source/webkitgtk-2.21.2/Source/JavaScriptCore/assembler/CodeLocation.h:174:7: note: candidate is the implicit move constructor class CodeLocationDataLabelPtr : public CodeLocationCommon<tag> { ^ /home/lantw44/gnome/source/webkitgtk-2.21.2/Source/JavaScriptCore/assembler/CodeLocation.h:174:7: note: candidate is the implicit copy constructor /home/lantw44/gnome/source/webkitgtk-2.21.2/Source/JavaScriptCore/assembler/CodeLocation.h:179:14: note: candidate constructor explicit CodeLocationDataLabelPtr(void* location) ^ 2 errors generated. I also tested a few other Clang versions, and the results are: Clang 4 fails to compile with different error messages. I guess it is probably too old for C++17. Clang 5 works fine. Clang 6 fails to compile with the above error messages. Clang 7 git snapshot (commit 53dc71d2945a91fde75ec241f48776fc739d2f75, date 2018-05-06) also fails to compile with the same messages as Clang 6. 1426944 1 clopez 2018-05-24 09:17:47 -0700 *** This bug has been marked as a duplicate of bug 185198 *** 1430894 2 ddkilzer 2018-06-07 09:50:25 -0700 Reopening to fix the warnings from using the C++17 compiler in Clang 6.0. We will have to fix these eventually, so we might as well do it now that we know about it in case they point to real issues. 1430901 3 ddkilzer 2018-06-07 09:57:08 -0700 (In reply to David Kilzer (:ddkilzer) from comment #2) > Reopening to fix the warnings from using the C++17 compiler in Clang 6.0. > > We will have to fix these eventually, so we might as well do it now that we > know about it in case they point to real issues. If Bug 185198 is going to be used to fix the Clang 6.0+ warnings, then feel free to dupe this back to Bug 185198. 1430919 4 mcatanzaro 2018-06-07 10:36:17 -0700 Well, really only the error is reported here, it might be better to create a new bug for solving the warnings. 1430920 5 mcatanzaro 2018-06-07 10:36:48 -0700 (In reply to Michael Catanzaro from comment #4) > Well, really only the error is reported here, it might be better to create a > new bug for solving the warnings. (No warnings have been reported on Bugzilla thus far, to my knowledge.) 1435310 6 mark.lam 2018-06-21 17:03:37 -0700 <rdar://problem/40131933> 1435312 7 343292 mark.lam 2018-06-21 17:08:58 -0700 Created attachment 343292 proposed patch. 1435317 8 mark.lam 2018-06-21 17:11:29 -0700 Thanks. Will land once the EWS bots are green. 1435347 9 343292 commit-queue 2018-06-21 20:01:58 -0700 Comment on attachment 343292 proposed patch. Clearing flags on attachment: 343292 Committed r233070: <https://trac.webkit.org/changeset/233070> 1435348 10 commit-queue 2018-06-21 20:02:00 -0700 All reviewed patches have been landed. Closing bug. 343292 2018-06-21 17:08:58 -0700 2018-06-21 20:01:58 -0700 proposed patch. bug-185947.patch text/plain 1562 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjMzMDY4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE4LTA2LTIxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBX ZWJLaXQgKEphdmFTY3JpcHRDb3JlKSBjb21waWxhdGlvbiBlcnJvciB3aXRoIENsYW5nIOKJpSA2 LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1OTQ3 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MDEzMTkzMz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOZXdlciBDbGFuZyB2ZXJzaW9ucyAoZHVlIHRv IEMrKzE3IHN1cHBvcnQpIGlzIG5vdCBoYXBweSB3aXRoIGhvdyBJIGltcGxlbWVudGVkCisgICAg ICAgIGNvbnZlcnNpb25zIGJldHdlZW4gQ29kZUxvY2F0aW9uIHR5cGVzLiAgV2UnbGwgZml4IHRo aXMgYnkgYWRkaW5nIGEgY29udmVyc2lvbgorICAgICAgICBvcGVyYXRvciBmb3IgY29udmVydGlu ZyBiZXR3ZWVuIENvZGVMb2NhdGlvbiB0eXBlcy4KKworICAgICAgICAqIGFzc2VtYmxlci9Db2Rl TG9jYXRpb24uaDoKKyAgICAgICAgKEpTQzo6Q29kZUxvY2F0aW9uQ29tbW9uOjpvcGVyYXRvciBU KToKKwogMjAxOC0wNi0yMSAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAg ICAgICBEbyBzb21lIENvVyBjbGVhbnVwCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNz ZW1ibGVyL0NvZGVMb2NhdGlvbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvQ29kZUxvY2F0aW9uLmgJKHJldmlzaW9uIDIzMzA0MSkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQ29kZUxvY2F0aW9uLmgJKHdvcmtpbmcgY29weSkKQEAg LTcxLDYgKzcxLDEyIEBAIHB1YmxpYzoKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUID0gdm9pZCo+ CiAgICAgVCBkYXRhTG9jYXRpb24oKSBjb25zdCB7IHJldHVybiBCYXNlOjp0ZW1wbGF0ZSBkYXRh TG9jYXRpb248VD4oKTsgfQogCisgICAgdGVtcGxhdGU8dHlwZW5hbWUgVCwgdHlwZW5hbWUgPSBz dGQ6OmVuYWJsZV9pZl90PHN0ZDo6aXNfYmFzZV9vZjxDb2RlTG9jYXRpb25Db21tb248dGFnPiwg VD46OnZhbHVlPj4KKyAgICBvcGVyYXRvciBUKCkKKyAgICB7CisgICAgICAgIHJldHVybiBUKE1h Y3JvQXNzZW1ibGVyQ29kZVB0cjx0YWc+OjpjcmVhdGVGcm9tRXhlY3V0YWJsZUFkZHJlc3ModGhp cy0+ZXhlY3V0YWJsZUFkZHJlc3MoKSkpOworICAgIH0KKwogcHJvdGVjdGVkOgogICAgIENvZGVM b2NhdGlvbkNvbW1vbigpCiAgICAgewo=