185752 2018-05-17 15:49:38 -0700 Lazily create WebCore::Timer for WebCore::Image 2018-05-17 20:30:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 185330 1 ddkilzer ddkilzer cgarcia dino jonlee koivisto sabouhallawa simon.fraser thorton webkit-bug-importer zan oldest_to_newest 1424976 0 ddkilzer 2018-05-17 15:49:38 -0700 Not every image is an animated image, so lazily creating m_animationStartTimer saves 56 bytes per instance of WebCore::Image. 1424977 1 340663 ddkilzer 2018-05-17 15:54:03 -0700 Created attachment 340663 Patch v1 1424978 2 webkit-bug-importer 2018-05-17 16:02:37 -0700 <rdar://problem/40348570> 1424980 3 ddkilzer 2018-05-17 16:10:30 -0700 This bug improves the safety of using WebCore::Image in the UI Process since current uses do not include animated images. It also prevents a WebCore::Timer from being allocated for a nullImage. 1424985 4 340663 simon.fraser 2018-05-17 16:20:38 -0700 Comment on attachment 340663 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=340663&action=review > Source/WebCore/platform/graphics/Image.cpp:351 > + std::call_once(onceFlag, [this] { Don't need call_once. Just if (!m_animationStartTimer) > Source/WebCore/platform/graphics/Image.h:203 > + std::once_flag onceFlag; Don't need this here. 1425038 5 340663 ddkilzer 2018-05-17 19:39:28 -0700 Comment on attachment 340663 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=340663&action=review >> Source/WebCore/platform/graphics/Image.cpp:351 >> + std::call_once(onceFlag, [this] { > > Don't need call_once. Just if (!m_animationStartTimer) So we can assume Image::startAnimationAsynchronously() and Image::animationPending() are always called on the main thread? >> Source/WebCore/platform/graphics/Image.h:203 >> + std::once_flag onceFlag; > > Don't need this here. Saves another 8 bytes. WebCore::Image goes down from 104 bytes to just 40 bytes with this change. 1425044 6 ddkilzer 2018-05-17 20:29:43 -0700 Committed r231940: <https://trac.webkit.org/changeset/231940> 340663 2018-05-17 15:54:03 -0700 2018-05-17 20:30:04 -0700 Patch v1 bug-185752-20180517155403.patch text/plain 3350 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmQxNDJiNWViMjNhYTY3 ZGFiNDZmZTVhNTg2MzY4YmEyZjA2NmVkYi4uOTk4ZDhiMTM5Y2M0Mjc2ZTYxZDI4YWQ3YTc5MDBh NjNhNWU0MmEzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE4LTA1LTE3ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgTGF6aWx5IGNyZWF0ZSBX ZWJDb3JlOjpUaW1lciBmb3IgV2ViQ29yZTo6SW1hZ2UKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0 Lm9yZy9iLzE4NTc1Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBOb3QgZXZlcnkgaW1hZ2UgaXMgYW4gYW5pbWF0ZWQgaW1hZ2UsIHNvIGxhemlseSBj cmVhdGluZworICAgICAgICBtX2FuaW1hdGlvblN0YXJ0VGltZXIgc2F2ZXMgNTYgYnl0ZXMgcGVy IGluc3RhbmNlIG9mCisgICAgICAgIFdlYkNvcmU6OkltYWdlLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvSW1hZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2U6OkltYWdlKTog UmVtb3ZlIGRlZmF1bHQgaW5pdGlhbGl6ZXIgZm9yCisgICAgICAgIG1fYW5pbWF0aW9uU3RhcnRU aW1lci4KKyAgICAgICAgKFdlYkNvcmU6OkltYWdlOjpzdGFydEFuaW1hdGlvbkFzeW5jaHJvbm91 c2x5KTogVXNlCisgICAgICAgIHN0ZDo6Y2FsbF9vbmNlIHRvIGluaXRpYWxpemUgbV9hbmltYXRp b25TdGFydFRpbWVyLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdlLmg6CisgICAg ICAgIChXZWJDb3JlOjpJbWFnZTo6YW5pbWF0aW9uUGVuZGluZyBjb25zdCk6IFVwZGF0ZSB0byBj aGVjayBpZgorICAgICAgICBtX2FuaW1hdGlvblN0YXJ0VGltZXIgaGFzIGJlZW4gc2V0IGJlZm9y ZSBkZXJlZmVyZW5jaW5nIGl0LgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2U6Om1fYW5pbWF0aW9u U3RhcnRUaW1lcik6IENoYW5nZSB0eXBlIHRvCisgICAgICAgIHN0ZDo6dW5pcXVlX3B0cjxUaW1l cj4uCisKIDIwMTgtMDUtMDcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAg ICAgICBBU1NFUlQoIWNoaWxkSXRlbVdpdGhUYXJnZXQoY2hpbGQtPnRhcmdldCgpKSkgaXMgaGl0 IGluIEhpc3RvcnlJdGVtOjphZGRDaGlsZEl0ZW0oKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvSW1hZ2UuY3BwCmluZGV4IDkwZTgxNmYyN2Y2ZGQyNjY5ZGQwNDc2NThlMzBhYjUw YTQzODZhNGUuLmJmNGQ5ODgyOGE2Mjc4N2U4YmQ1ZDdmNGE2MzI3Yjk4NzZkODQzMzkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZS5jcHAKQEAgLTUwLDcgKzUwLDYg QEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBJbWFnZTo6SW1hZ2UoSW1hZ2VPYnNlcnZlciogb2Jz ZXJ2ZXIpCiAgICAgOiBtX2ltYWdlT2JzZXJ2ZXIob2JzZXJ2ZXIpCi0gICAgLCBtX2FuaW1hdGlv blN0YXJ0VGltZXIoKnRoaXMsICZJbWFnZTo6c3RhcnRBbmltYXRpb24pCiB7CiB9CiAKQEAgLTM0 OSw5ICszNDgsMTIgQEAgdm9pZCBJbWFnZTo6Y29tcHV0ZUludHJpbnNpY0RpbWVuc2lvbnMoTGVu Z3RoJiBpbnRyaW5zaWNXaWR0aCwgTGVuZ3RoJiBpbnRyaW5zaWMKIAogdm9pZCBJbWFnZTo6c3Rh cnRBbmltYXRpb25Bc3luY2hyb25vdXNseSgpCiB7Ci0gICAgaWYgKG1fYW5pbWF0aW9uU3RhcnRU aW1lci5pc0FjdGl2ZSgpKQorICAgIHN0ZDo6Y2FsbF9vbmNlKG9uY2VGbGFnLCBbdGhpc10gewor ICAgICAgICBtX2FuaW1hdGlvblN0YXJ0VGltZXIgPSBzdGQ6Om1ha2VfdW5pcXVlPFRpbWVyPigq dGhpcywgJkltYWdlOjpzdGFydEFuaW1hdGlvbik7CisgICAgfSk7CisgICAgaWYgKG1fYW5pbWF0 aW9uU3RhcnRUaW1lci0+aXNBY3RpdmUoKSkKICAgICAgICAgcmV0dXJuOwotICAgIG1fYW5pbWF0 aW9uU3RhcnRUaW1lci5zdGFydE9uZVNob3QoMF9zKTsKKyAgICBtX2FuaW1hdGlvblN0YXJ0VGlt ZXItPnN0YXJ0T25lU2hvdCgwX3MpOwogfQogCiB2b2lkIEltYWdlOjpkdW1wKFRleHRTdHJlYW0m IHRzKSBjb25zdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv SW1hZ2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlLmgKaW5kZXgg NjU5ODhmNzliZjI2ZWNmZThmOGQ1NTRjYjRjYTAzOGRmODA1Y2JmMC4uMjQ1MGM3ZDc2MDNjNzAz ZDRhNjVkMjZiMjgyMjQ1MjM0YjMyZDg1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvSW1hZ2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9JbWFnZS5oCkBAIC0xMzgsNyArMTM4LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9p ZCBzdG9wQW5pbWF0aW9uKCkge30KICAgICB2aXJ0dWFsIHZvaWQgcmVzZXRBbmltYXRpb24oKSB7 fQogICAgIHZpcnR1YWwgYm9vbCBpc0FuaW1hdGluZygpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9 Ci0gICAgYm9vbCBhbmltYXRpb25QZW5kaW5nKCkgY29uc3QgeyByZXR1cm4gbV9hbmltYXRpb25T dGFydFRpbWVyLmlzQWN0aXZlKCk7IH0KKyAgICBib29sIGFuaW1hdGlvblBlbmRpbmcoKSBjb25z dCB7IHJldHVybiBtX2FuaW1hdGlvblN0YXJ0VGltZXIgJiYgbV9hbmltYXRpb25TdGFydFRpbWVy LT5pc0FjdGl2ZSgpOyB9CiAKICAgICAvLyBUeXBpY2FsbHkgdGhlIENhY2hlZEltYWdlIHRoYXQg b3ducyB1cy4KICAgICBJbWFnZU9ic2VydmVyKiBpbWFnZU9ic2VydmVyKCkgY29uc3QgeyByZXR1 cm4gbV9pbWFnZU9ic2VydmVyOyB9CkBAIC0yMDAsNyArMjAwLDggQEAgcHJvdGVjdGVkOgogcHJp dmF0ZToKICAgICBSZWZQdHI8U2hhcmVkQnVmZmVyPiBtX2VuY29kZWRJbWFnZURhdGE7CiAgICAg SW1hZ2VPYnNlcnZlciogbV9pbWFnZU9ic2VydmVyOwotICAgIFRpbWVyIG1fYW5pbWF0aW9uU3Rh cnRUaW1lcjsKKyAgICBzdGQ6Om9uY2VfZmxhZyBvbmNlRmxhZzsKKyAgICBzdGQ6OnVuaXF1ZV9w dHI8VGltZXI+IG1fYW5pbWF0aW9uU3RhcnRUaW1lcjsKIH07CiAKIFdURjo6VGV4dFN0cmVhbSYg b3BlcmF0b3I8PChXVEY6OlRleHRTdHJlYW0mLCBjb25zdCBJbWFnZSYpOwo=