185505 2018-05-09 23:32:32 -0700 REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged 2018-05-10 13:51:00 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii cdumez webkit-bug-importer oldest_to_newest 1422645 0 fujii 2018-05-09 23:32:32 -0700 REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged Windows port crashes soon since Bug 184996. > WebKit.dll!WebView::notifyPreferencesChanged(IWebNotification * notification) Line 5201 C++ > WebKit.dll!WebView::onNotify(IWebNotification * notification) Line 5072 C++ > WebKit.dll!WebNotificationCenter::postNotificationInternal(IWebNotification * notification, wchar_t * notificationName, IUnknown * anObject) Line 131 C++ > WebKit.dll!WebNotificationCenter::postNotificationName(wchar_t * notificationName, IUnknown * anObject, IPropertyBag * userInfo) Line 181 C++ > WebKit.dll!WebPreferences::postPreferencesChangesNotification() Line 148 C++ > WebKit.dll!WebView::initWithFrame(tagRECT frame, wchar_t * frameName, wchar_t * groupName) Line 3164 C++ > MiniBrowserLib.dll!MiniBrowser::prepareViews(HWND__ * mainWnd, const tagRECT & clientRect, HWND__ * & viewHwnd) Line 183 C++ > MiniBrowserLib.dll!MiniBrowser::MiniBrowser(HWND__ * mainWnd, HWND__ * urlBarWnd, bool useLayeredWebView, bool pageLoadTesting) Line 140 C++ > [External Code] > MiniBrowserLib.dll!BrowserWindow::{ctor}::__l2::<lambda>(HWND__ * mainWnd, HWND__ * urlBarWnd, bool useLayeredWebView, bool pageLoadTesting) Line 111 C++ > MiniBrowserLib.dll!std::unique_ptr<ContentWindow,std::default_delete<ContentWindow> > <lambda>(HWND__ *, HWND__ *, bool, bool)::<lambda_invoker_cdecl>(HWND__ * mainWnd, HWND__ * urlBarWnd, bool useLayeredWebView, bool pageLoadTesting) Line 112 C++ > MiniBrowserLib.dll!BrowserWindow::BrowserWindow(int nCmdShow, bool usesLayeredWebView, bool pageLoadTesting, _bstr_t requestedURL, bool useWK2) Line 120 C++ > MiniBrowserLib.dll!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 75 C++ > MiniBrowserLib.dll!dllLauncherEntryPoint(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 109 C++ > MiniBrowser.exe!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 251 C++ > [External Code] 1422650 1 340073 fujii 2018-05-09 23:37:14 -0700 Created attachment 340073 WIP patch 1422664 2 340076 fujii 2018-05-10 00:08:16 -0700 Created attachment 340076 Patch 1422669 3 fujii 2018-05-10 00:16:44 -0700 Committed r231635: <https://trac.webkit.org/changeset/231635> 1422670 4 webkit-bug-importer 2018-05-10 00:17:20 -0700 <rdar://problem/40120805> 1422851 5 340076 cdumez 2018-05-10 13:51:00 -0700 Comment on attachment 340076 Patch Thanks for fixing! 340073 2018-05-09 23:37:14 -0700 2018-05-10 00:08:11 -0700 WIP patch wip.patch text/plain 1292 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL1dlYlByZWZlcmVuY2VzLmNwcCBi L1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL1dlYlByZWZlcmVuY2VzLmNwcAppbmRleCBiNzhjMzdh YTlmNS4uYTJmMDVjNzIxZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL1dl YlByZWZlcmVuY2VzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9XZWJQcmVmZXJl bmNlcy5jcHAKQEAgLTU3Niw2ICs1NzYsOCBAQCBIUkVTVUxUIFdlYlByZWZlcmVuY2VzOjpRdWVy eUludGVyZmFjZShfSW5fIFJFRklJRCByaWlkLCBfQ09NX091dHB0cl8gdm9pZCoqIHBwdgogICAg ICAgICAqcHB2T2JqZWN0ID0gc3RhdGljX2Nhc3Q8SVdlYlByZWZlcmVuY2VzUHJpdmF0ZTUqPih0 aGlzKTsKICAgICBlbHNlIGlmIChJc0VxdWFsR1VJRChyaWlkLCBJSURfSVdlYlByZWZlcmVuY2Vz UHJpdmF0ZTYpKQogICAgICAgICAqcHB2T2JqZWN0ID0gc3RhdGljX2Nhc3Q8SVdlYlByZWZlcmVu Y2VzUHJpdmF0ZTYqPih0aGlzKTsKKyAgICBlbHNlIGlmIChJc0VxdWFsR1VJRChyaWlkLCBJSURf SVdlYlByZWZlcmVuY2VzUHJpdmF0ZTcpKQorICAgICAgICAqcHB2T2JqZWN0ID0gc3RhdGljX2Nh c3Q8SVdlYlByZWZlcmVuY2VzUHJpdmF0ZTcqPih0aGlzKTsKICAgICBlbHNlIGlmIChJc0VxdWFs R1VJRChyaWlkLCBDTFNJRF9XZWJQcmVmZXJlbmNlcykpCiAgICAgICAgICpwcHZPYmplY3QgPSB0 aGlzOwogICAgIGVsc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL1dlYlBy ZWZlcmVuY2VzLmggYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9XZWJQcmVmZXJlbmNlcy5oCmlu ZGV4IGZjMzc4MmE3MzAwLi45ZDkzZmYyODE0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS93aW4vV2ViUHJlZmVyZW5jZXMuaAorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9X ZWJQcmVmZXJlbmNlcy5oCkBAIC0zMCw3ICszMCw3IEBACiAjaW5jbHVkZSA8V2ViQ29yZS9CU3Ry aW5nLmg+CiAjaW5jbHVkZSA8d3RmL1JldGFpblB0ci5oPgogCi1jbGFzcyBXZWJQcmVmZXJlbmNl cyA6IHB1YmxpYyBJV2ViUHJlZmVyZW5jZXMsIHB1YmxpYyBJV2ViUHJlZmVyZW5jZXNQcml2YXRl NiB7CitjbGFzcyBXZWJQcmVmZXJlbmNlcyA6IHB1YmxpYyBJV2ViUHJlZmVyZW5jZXMsIHB1Ymxp YyBJV2ViUHJlZmVyZW5jZXNQcml2YXRlNyB7CiBwdWJsaWM6CiAgICAgc3RhdGljIFdlYlByZWZl cmVuY2VzKiBjcmVhdGVJbnN0YW5jZSgpOwogcHJvdGVjdGVkOgo= 340076 2018-05-10 00:08:16 -0700 2018-05-10 00:08:56 -0700 Patch bug-185505-20180510160815.patch text/plain 2402 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNjI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L3dpbi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9DaGFuZ2VMb2cKaW5k ZXggZjJjY2U4NDg3NWI4OWY4ZjU2Zjk3ODZkN2RmNzhkZjgwMTFhNzJlYi4uNzgxNDRjNWMyNDJl NmQ2NTVhZTNhZTk3MDU2ZGNiNWFhNjQ3MjdmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS93aW4vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA1LTEwICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3Jp LkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIzMTYyMikgW1dpbl0gQ3Jh c2hlcyBmb3IgbnVsbCBkZXJlZmVyZW5jZSBvZiBwcmVmc1ByaXZhdGUgaW4gV2ViVmlldzo6bm90 aWZ5UHJlZmVyZW5jZXNDaGFuZ2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODU1MDUKKworICAgICAgICBVbnJldmlld2VkIHNlcmlvdXMgY3Jhc2gg Zml4CisKKyAgICAgICAgV2luZG93cyBwb3J0IGNyYXNoZXMgc29vbiBzaW5jZSBCdWcgMTg0OTk2 LgorCisgICAgICAgICogV2ViUHJlZmVyZW5jZXMuY3BwOgorICAgICAgICAoV2ViUHJlZmVyZW5j ZXM6OlF1ZXJ5SW50ZXJmYWNlKTogQWRkZWQgSUlEX0lXZWJQcmVmZXJlbmNlc1ByaXZhdGU3Lgor ICAgICAgICAqIFdlYlByZWZlcmVuY2VzLmg6IEluaGVyaXQgSVdlYlByZWZlcmVuY2VzUHJpdmF0 ZTcgaW5zdGVhZCBvZiBJV2ViUHJlZmVyZW5jZXNQcml2YXRlNi4KKwogMjAxOC0wNS0wNyAgRGFu aWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgU3Vic3RpdHV0ZSBDcm9z c09yaWdpblByZWZsaWdodFJlc3VsdENhY2hlOjpjbGVhcigpIGZvciBDcm9zc09yaWdpblByZWZs aWdodFJlc3VsdENhY2hlOjplbXB0eSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5 L3dpbi9XZWJQcmVmZXJlbmNlcy5jcHAgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9XZWJQcmVm ZXJlbmNlcy5jcHAKaW5kZXggYjc4YzM3YWE5ZjVlNzU0ZmQyYjkzMWVhNWM0ZTQxMjJkMzYzMDM1 Mi4uYTJmMDVjNzIxZTZjYTExN2MzZDQ0OTMwZTMyYmQ4NjQ1MzMyMTI0YSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdExlZ2FjeS93aW4vV2ViUHJlZmVyZW5jZXMuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXRMZWdhY3kvd2luL1dlYlByZWZlcmVuY2VzLmNwcApAQCAtNTc2LDYgKzU3Niw4IEBAIEhS RVNVTFQgV2ViUHJlZmVyZW5jZXM6OlF1ZXJ5SW50ZXJmYWNlKF9Jbl8gUkVGSUlEIHJpaWQsIF9D T01fT3V0cHRyXyB2b2lkKiogcHB2CiAgICAgICAgICpwcHZPYmplY3QgPSBzdGF0aWNfY2FzdDxJ V2ViUHJlZmVyZW5jZXNQcml2YXRlNSo+KHRoaXMpOwogICAgIGVsc2UgaWYgKElzRXF1YWxHVUlE KHJpaWQsIElJRF9JV2ViUHJlZmVyZW5jZXNQcml2YXRlNikpCiAgICAgICAgICpwcHZPYmplY3Qg PSBzdGF0aWNfY2FzdDxJV2ViUHJlZmVyZW5jZXNQcml2YXRlNio+KHRoaXMpOworICAgIGVsc2Ug aWYgKElzRXF1YWxHVUlEKHJpaWQsIElJRF9JV2ViUHJlZmVyZW5jZXNQcml2YXRlNykpCisgICAg ICAgICpwcHZPYmplY3QgPSBzdGF0aWNfY2FzdDxJV2ViUHJlZmVyZW5jZXNQcml2YXRlNyo+KHRo aXMpOwogICAgIGVsc2UgaWYgKElzRXF1YWxHVUlEKHJpaWQsIENMU0lEX1dlYlByZWZlcmVuY2Vz KSkKICAgICAgICAgKnBwdk9iamVjdCA9IHRoaXM7CiAgICAgZWxzZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdExlZ2FjeS93aW4vV2ViUHJlZmVyZW5jZXMuaCBiL1NvdXJjZS9XZWJLaXRMZWdh Y3kvd2luL1dlYlByZWZlcmVuY2VzLmgKaW5kZXggZmMzNzgyYTczMDAzYzk5Y2MwOWQzMzEwNjA5 YTE5Y2NkMjMzOGFhMi4uOWQ5M2ZmMjgxNDY3NGFjZWI5NDdkMDM5NGRhYzViNzhkMTcxMWY0NCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS93aW4vV2ViUHJlZmVyZW5jZXMuaAorKysg Yi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9XZWJQcmVmZXJlbmNlcy5oCkBAIC0zMCw3ICszMCw3 IEBACiAjaW5jbHVkZSA8V2ViQ29yZS9CU3RyaW5nLmg+CiAjaW5jbHVkZSA8d3RmL1JldGFpblB0 ci5oPgogCi1jbGFzcyBXZWJQcmVmZXJlbmNlcyA6IHB1YmxpYyBJV2ViUHJlZmVyZW5jZXMsIHB1 YmxpYyBJV2ViUHJlZmVyZW5jZXNQcml2YXRlNiB7CitjbGFzcyBXZWJQcmVmZXJlbmNlcyA6IHB1 YmxpYyBJV2ViUHJlZmVyZW5jZXMsIHB1YmxpYyBJV2ViUHJlZmVyZW5jZXNQcml2YXRlNyB7CiBw dWJsaWM6CiAgICAgc3RhdGljIFdlYlByZWZlcmVuY2VzKiBjcmVhdGVJbnN0YW5jZSgpOwogcHJv dGVjdGVkOgo=