<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>185326</bug_id>
          
          <creation_ts>2018-05-04 14:53:41 -0700</creation_ts>
          <short_desc>[Win] LoggingWin is missing includes</short_desc>
          <delta_ts>2018-05-07 11:08:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>174003</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Don Olmstead">don.olmstead</reporter>
          <assigned_to name="Don Olmstead">don.olmstead</assigned_to>
          <cc>achristensen</cc>
    
    <cc>annulen</cc>
    
    <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>pvollan</cc>
    
    <cc>rniwa</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1420894</commentid>
    <comment_count>0</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-05-04 14:53:41 -0700</bug_when>
    <thetext>LoggingWin.cpp should be including &lt;windows.h&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1420895</commentid>
    <comment_count>1</comment_count>
      <attachid>339598</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-05-04 14:56:34 -0700</bug_when>
    <thetext>Created attachment 339598
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1421320</commentid>
    <comment_count>2</comment_count>
      <attachid>339598</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2018-05-07 10:36:54 -0700</bug_when>
    <thetext>Comment on attachment 339598
Patch

R=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1421343</commentid>
    <comment_count>3</comment_count>
      <attachid>339598</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-05-07 11:07:34 -0700</bug_when>
    <thetext>Comment on attachment 339598
Patch

Clearing flags on attachment: 339598

Committed r231446: &lt;https://trac.webkit.org/changeset/231446&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1421344</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-05-07 11:07:35 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1421345</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-05-07 11:08:20 -0700</bug_when>
    <thetext>&lt;rdar://problem/40028988&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>339598</attachid>
            <date>2018-05-04 14:56:34 -0700</date>
            <delta_ts>2018-05-07 11:07:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-185326.diff</filename>
            <type>text/plain</type>
            <size>964</size>
            <attacher name="Don Olmstead">don.olmstead</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu
Z2VMb2cKaW5kZXggMzJhY2VjYThkZTQuLmRkZGI1MzZjMmExIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx
LDEyIEBACisyMDE4LTA1LTA0ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+
CisKKyAgICAgICAgW1dpbl0gTG9nZ2luZ1dpbiBpcyBtaXNzaW5nIGluY2x1ZGVzCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODUzMjYKKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBsYXRmb3JtL3dpbi9M
b2dnaW5nV2luLmNwcDoKKwogMjAxOC0wNS0wNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUu
Y29tPgogCiAgICAgICAgIFtpT1NdIEFwcHMgdGhhdCBhcmUgbm90IHZpc2libGUgbWF5IG5vdCBn
ZXQgc3VzcGVuZGVkIGlmIHRoZXkgdHJpZ2dlciBwYWdlIGxvYWRzIHdoaWxlIGluIHRoZSBiYWNr
Z3JvdW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3dpbi9Mb2dnaW5nV2lu
LmNwcCBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vd2luL0xvZ2dpbmdXaW4uY3BwCmluZGV4IGQw
NjM4ZDMxM2E2Li5lNGVkOTZiYjFhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9y
bS93aW4vTG9nZ2luZ1dpbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS93aW4vTG9n
Z2luZ1dpbi5jcHAKQEAgLTI5LDYgKzI5LDcgQEAKIAogI2lmICFMT0dfRElTQUJMRUQgfHwgIVJF
TEVBU0VfTE9HX0RJU0FCTEVECiAKKyNpbmNsdWRlIDx3aW5kb3dzLmg+CiAjaW5jbHVkZSA8d3Rm
L1N0ZExpYkV4dHJhcy5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>