185169 2018-05-01 11:46:01 -0700 Fix build error after r231194 2018-05-01 23:26:42 -0700 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=183442 InRadar P2 Normal --- 1 gskachkov gskachkov commit-queue jfbastien ryanhaddad saam webkit-bug-importer ysuzuki oldest_to_newest 1419358 0 gskachkov 2018-05-01 11:46:01 -0700 he iOS Simulator debug build is broken by this change. ./bindings/js/JSDOMWindowBase.cpp:495:1: error: function 'compileStreaming' could be declared with attribute 'noreturn' [-Werror,-Wmissing-noreturn] { ^ ./bindings/js/JSDOMWindowBase.cpp:499:1: error: function 'instantiateStreaming' could be declared with attribute 'noreturn' [-Werror,-Wmissing-noreturn] { ^ https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Debug%20%28Build%29/builds/5600 1419363 1 339210 gskachkov 2018-05-01 11:53:13 -0700 Created attachment 339210 Patch Fix iOS Simulator debug build 1419377 2 339210 jfbastien 2018-05-01 12:46:08 -0700 Comment on attachment 339210 Patch You should tag the function with NO_RETURN instead. 1419385 3 saam 2018-05-01 12:55:44 -0700 Also name of this bug is wrong, it should start w/ a 2 maybe? 1419398 4 339219 gskachkov 2018-05-01 13:12:54 -0700 Created attachment 339219 Patch Fix comments 1419399 5 gskachkov 2018-05-01 13:15:12 -0700 (In reply to Saam Barati from comment #3) > Also name of this bug is wrong, it should start w/ a 2 maybe? Sorry not sure if I get, could you please fix name as it should be 1419400 6 saam 2018-05-01 13:16:10 -0700 r339098 is not a real revision 1419401 7 ryanhaddad 2018-05-01 13:16:33 -0700 (In reply to Saam Barati from comment #6) > r339098 is not a real revision Fixed. 1419403 8 339220 gskachkov 2018-05-01 13:21:34 -0700 Created attachment 339220 Patch Upload patch with correct issue name 1419404 9 gskachkov 2018-05-01 13:22:29 -0700 (In reply to Saam Barati from comment #6) > r339098 is not a real revision Ohh, my bad, it was attachment-id :-( 1419405 10 339220 jfbastien 2018-05-01 13:27:12 -0700 Comment on attachment 339220 Patch It's a bit weird to have it on the definition instead of the declaration (as the warning complained), but it keeps the code simpler and seems to keep clang happy (I just checked https://godbolt.org/g/iF3sMd). So r=me 1419423 11 339220 commit-queue 2018-05-01 14:27:11 -0700 Comment on attachment 339220 Patch Clearing flags on attachment: 339220 Committed r231210: <https://trac.webkit.org/changeset/231210> 1419424 12 commit-queue 2018-05-01 14:27:13 -0700 All reviewed patches have been landed. Closing bug. 1419425 13 webkit-bug-importer 2018-05-01 14:28:20 -0700 <rdar://problem/39878773> 1419577 14 ysuzuki 2018-05-01 23:26:42 -0700 Committed r231226: <https://trac.webkit.org/changeset/231226> 339210 2018-05-01 11:53:13 -0700 2018-05-01 13:12:50 -0700 Patch bug-185169-20180501215311.patch text/plain 1912 gskachkov U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmE1YWI3MzQzMGJlOTk4 MmNlYzNhZGY1ZWZiZTllNDBjNDVkZDgxNi4uMWRlZmNjNDEyNDhmOTQzZWVmOWM3MTRlNDMwODc3 MjgxY2I3MjNkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA1LTAxICBPbGVr c2FuZHIgU2thY2hrb3YgIDxnc2thY2hrb3ZAZ21haWwuY29tPgorCisgICAgICAgIEZpeCBidWls ZCBlcnJvciBhZnRlciByMzM5MDk4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODUxNjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBDb21tZW50IEFTU0VSVF9OT1RfUkVBQ0hFRCB0byBwcmV2ZW50IGNvbXBp bGUgZXJyb3IgCisgICAgICAgIGluIGlPUyBTaW11bGF0b3IgZGVidWcgYnVpbGQKKworICAgICAg ICAqIGJpbmRpbmdzL2pzL0pTRE9NV2luZG93QmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpK U0RPTVdpbmRvd0Jhc2U6OmNvbXBpbGVTdHJlYW1pbmcpOgorICAgICAgICAoV2ViQ29yZTo6SlNE T01XaW5kb3dCYXNlOjppbnN0YW50aWF0ZVN0cmVhbWluZyk6CisKIDIwMTgtMDUtMDEgIE9sZWtz YW5kciBTa2FjaGtvdiAgPGdza2FjaGtvdkBnbWFpbC5jb20+CiAKICAgICAgICAgV2ViQXNzZW1i bHk6IGFkZCBzdXBwb3J0IGZvciBzdHJlYW0gQVBJcyAtIEphdmFTY3JpcHQgQVBJCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0Jhc2UuY3BwIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dCYXNlLmNwcAppbmRleCA4ZjQwOTc1 NmQ0NjYyNTBmM2RiMjdhMmZiMWQ5MzczZmU3NDg4MmQ3Li41Mzc4NWRkZTUwODExMTY2NjUzNGYx NDg1NDkwNWViZjk0ZDgzMzY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU0RPTVdpbmRvd0Jhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pT RE9NV2luZG93QmFzZS5jcHAKQEAgLTQ5MywxMSArNDkzLDE1IEBAIHZvaWQgSlNET01XaW5kb3dC YXNlOjppbnN0YW50aWF0ZVN0cmVhbWluZyhKU0M6OkpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmpl Y3QsIEpTCiAjZWxzZQogdm9pZCBKU0RPTVdpbmRvd0Jhc2U6OmNvbXBpbGVTdHJlYW1pbmcoSlND OjpKU0dsb2JhbE9iamVjdCosIEpTQzo6RXhlY1N0YXRlKiwgSlNDOjpKU1Byb21pc2VEZWZlcnJl ZCosIEpTQzo6SlNWYWx1ZSkKIHsKLSAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAvLyBX ZSB3b3VsZCBoYXZlIHJlYWxseSB1c2VmdWwgYXNzZXJ0aW9ucyBoZXJlIGlmIGl0IHdhc24ndCBm b3IgdGhlIGNvbXBpbGVyJ3MKKyAgICAvLyBpbnNpc3RlbmNlIG9uIGF0dHJpYnV0ZSBub3JldHVy bi4KKyAgICAvLyBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKIH0KIHZvaWQgSlNET01XaW5kb3dCYXNl OjppbnN0YW50aWF0ZVN0cmVhbWluZyhKU0M6OkpTR2xvYmFsT2JqZWN0KiwgSlNDOjpFeGVjU3Rh dGUqLCBKU0M6OkpTUHJvbWlzZURlZmVycmVkKiwgSlNDOjpKU1ZhbHVlLCBKU0M6OkpTT2JqZWN0 KikKIHsKLSAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAvLyBXZSB3b3VsZCBoYXZlIHJl YWxseSB1c2VmdWwgYXNzZXJ0aW9ucyBoZXJlIGlmIGl0IHdhc24ndCBmb3IgdGhlIGNvbXBpbGVy J3MKKyAgICAvLyBpbnNpc3RlbmNlIG9uIGF0dHJpYnV0ZSBub3JldHVybi4KKyAgICAvLyBBU1NF UlRfTk9UX1JFQUNIRUQoKTsKIH0KICNlbmRpZgogCg== 339219 2018-05-01 13:12:54 -0700 2018-05-01 13:21:29 -0700 Patch bug-185169-20180501231253.patch text/plain 1762 gskachkov U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmE1YWI3MzQzMGJlOTk4 MmNlYzNhZGY1ZWZiZTllNDBjNDVkZDgxNi4uZjMzMTU3Mzk4MjkxMDFmYjU2OGQ4ZDk3MTdhNmQ4 MWNiZTU2YTM1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA1LTAxICBPbGVr c2FuZHIgU2thY2hrb3YgIDxnc2thY2hrb3ZAZ21haWwuY29tPgorCisgICAgICAgIEZpeCBidWls ZCBlcnJvciBhZnRlciByMzM5MDk4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODUxNjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBQcmV2ZW50IGNvbXBpbGUgZXJyb3IgaW4gaU9TIFNpbXVsYXRvciBkZWJ1 ZyBidWlsZAorICAgICAgICBieSB0YWdnaW5nIGZ1bmN0aW9uCisKKyAgICAgICAgKiBiaW5kaW5n cy9qcy9KU0RPTVdpbmRvd0Jhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNET01XaW5kb3dC YXNlOjpjb21waWxlU3RyZWFtaW5nKToKKyAgICAgICAgKFdlYkNvcmU6OkpTRE9NV2luZG93QmFz ZTo6aW5zdGFudGlhdGVTdHJlYW1pbmcpOgorCiAyMDE4LTA1LTAxICBPbGVrc2FuZHIgU2thY2hr b3YgIDxnc2thY2hrb3ZAZ21haWwuY29tPgogCiAgICAgICAgIFdlYkFzc2VtYmx5OiBhZGQgc3Vw cG9ydCBmb3Igc3RyZWFtIEFQSXMgLSBKYXZhU2NyaXB0IEFQSQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dCYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2pzL0pTRE9NV2luZG93QmFzZS5jcHAKaW5kZXggOGY0MDk3NTZkNDY2MjUwZjNk YjI3YTJmYjFkOTM3M2ZlNzQ4ODJkNy4uMDExOGM1NmFmMGQyMzZiYTAxMmZiODVjNWNiMDk4M2I4 OWY2OThjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5k b3dCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0Jh c2UuY3BwCkBAIC00OTEsMTAgKzQ5MSwxMyBAQCB2b2lkIEpTRE9NV2luZG93QmFzZTo6aW5zdGFu dGlhdGVTdHJlYW1pbmcoSlNDOjpKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBKUwogICAg ICAgICBwcm9taXNlLT5yZWplY3QoZXhlYywgY3JlYXRlVHlwZUVycm9yKGV4ZWMsIEFTQ0lJTGl0 ZXJhbCgiZmlyc3QgYXJndW1lbnQgbXVzdCBiZSBhbiBSZXNwb25zZSBvciBQcm9taXNlIGZvciBS ZXNwb25zZSIpKSk7CiB9CiAjZWxzZQorTk9fUkVUVVJOX0RVRV9UT19BU1NFUlQKIHZvaWQgSlNE T01XaW5kb3dCYXNlOjpjb21waWxlU3RyZWFtaW5nKEpTQzo6SlNHbG9iYWxPYmplY3QqLCBKU0M6 OkV4ZWNTdGF0ZSosIEpTQzo6SlNQcm9taXNlRGVmZXJyZWQqLCBKU0M6OkpTVmFsdWUpCiB7CiAg ICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiB9CisKK05PX1JFVFVSTl9EVUVfVE9fQVNTRVJUCiB2 b2lkIEpTRE9NV2luZG93QmFzZTo6aW5zdGFudGlhdGVTdHJlYW1pbmcoSlNDOjpKU0dsb2JhbE9i amVjdCosIEpTQzo6RXhlY1N0YXRlKiwgSlNDOjpKU1Byb21pc2VEZWZlcnJlZCosIEpTQzo6SlNW YWx1ZSwgSlNDOjpKU09iamVjdCopCiB7CiAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Cg== 339220 2018-05-01 13:21:34 -0700 2018-05-01 14:27:11 -0700 Patch bug-185169-20180501232132.patch text/plain 1762 gskachkov U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmE1YWI3MzQzMGJlOTk4 MmNlYzNhZGY1ZWZiZTllNDBjNDVkZDgxNi4uMTEzODM3Yjc2OTY1NTA0YjRlMmJjYzFmNDg0NTAz M2M5NTI0OTkwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA1LTAxICBPbGVr c2FuZHIgU2thY2hrb3YgIDxnc2thY2hrb3ZAZ21haWwuY29tPgorCisgICAgICAgIEZpeCBidWls ZCBlcnJvciBhZnRlciByMjMxMTk0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODUxNjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBQcmV2ZW50IGNvbXBpbGUgZXJyb3IgaW4gaU9TIFNpbXVsYXRvciBkZWJ1 ZyBidWlsZAorICAgICAgICBieSB0YWdnaW5nIGZ1bmN0aW9uCisKKyAgICAgICAgKiBiaW5kaW5n cy9qcy9KU0RPTVdpbmRvd0Jhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNET01XaW5kb3dC YXNlOjpjb21waWxlU3RyZWFtaW5nKToKKyAgICAgICAgKFdlYkNvcmU6OkpTRE9NV2luZG93QmFz ZTo6aW5zdGFudGlhdGVTdHJlYW1pbmcpOgorCiAyMDE4LTA1LTAxICBPbGVrc2FuZHIgU2thY2hr b3YgIDxnc2thY2hrb3ZAZ21haWwuY29tPgogCiAgICAgICAgIFdlYkFzc2VtYmx5OiBhZGQgc3Vw cG9ydCBmb3Igc3RyZWFtIEFQSXMgLSBKYXZhU2NyaXB0IEFQSQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dCYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2pzL0pTRE9NV2luZG93QmFzZS5jcHAKaW5kZXggOGY0MDk3NTZkNDY2MjUwZjNk YjI3YTJmYjFkOTM3M2ZlNzQ4ODJkNy4uMDExOGM1NmFmMGQyMzZiYTAxMmZiODVjNWNiMDk4M2I4 OWY2OThjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5k b3dCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0Jh c2UuY3BwCkBAIC00OTEsMTAgKzQ5MSwxMyBAQCB2b2lkIEpTRE9NV2luZG93QmFzZTo6aW5zdGFu dGlhdGVTdHJlYW1pbmcoSlNDOjpKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBKUwogICAg ICAgICBwcm9taXNlLT5yZWplY3QoZXhlYywgY3JlYXRlVHlwZUVycm9yKGV4ZWMsIEFTQ0lJTGl0 ZXJhbCgiZmlyc3QgYXJndW1lbnQgbXVzdCBiZSBhbiBSZXNwb25zZSBvciBQcm9taXNlIGZvciBS ZXNwb25zZSIpKSk7CiB9CiAjZWxzZQorTk9fUkVUVVJOX0RVRV9UT19BU1NFUlQKIHZvaWQgSlNE T01XaW5kb3dCYXNlOjpjb21waWxlU3RyZWFtaW5nKEpTQzo6SlNHbG9iYWxPYmplY3QqLCBKU0M6 OkV4ZWNTdGF0ZSosIEpTQzo6SlNQcm9taXNlRGVmZXJyZWQqLCBKU0M6OkpTVmFsdWUpCiB7CiAg ICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiB9CisKK05PX1JFVFVSTl9EVUVfVE9fQVNTRVJUCiB2 b2lkIEpTRE9NV2luZG93QmFzZTo6aW5zdGFudGlhdGVTdHJlYW1pbmcoSlNDOjpKU0dsb2JhbE9i amVjdCosIEpTQzo6RXhlY1N0YXRlKiwgSlNDOjpKU1Byb21pc2VEZWZlcnJlZCosIEpTQzo6SlNW YWx1ZSwgSlNDOjpKU09iamVjdCopCiB7CiAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Cg==