<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>185100</bug_id>
          
          <creation_ts>2018-04-27 17:13:18 -0700</creation_ts>
          <short_desc>Add logging when SpringBoard enables WebThread</short_desc>
          <delta_ts>2018-06-18 18:33:50 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=186793</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Kilzer (:ddkilzer)">ddkilzer</reporter>
          <assigned_to name="David Kilzer (:ddkilzer)">ddkilzer</assigned_to>
          <cc>aestes</cc>
    
    <cc>benjamin</cc>
    
    <cc>cdumez</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dbates</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1418688</commentid>
    <comment_count>0</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2018-04-27 17:13:18 -0700</bug_when>
    <thetext>Add logging when SpringBoard enables WebThread.

&lt;rdar://problem/39746542&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1418690</commentid>
    <comment_count>1</comment_count>
      <attachid>339043</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2018-04-27 17:19:08 -0700</bug_when>
    <thetext>Created attachment 339043
Patch v1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1418728</commentid>
    <comment_count>2</comment_count>
      <attachid>339043</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-04-27 19:34:59 -0700</bug_when>
    <thetext>Comment on attachment 339043
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=339043&amp;action=review

&gt; Source/WTF/ChangeLog:5
&gt; +        &lt;rdar://problem/39746542&gt;

I assume if I were to look at this bug that it would explain why it is beneficial to add this logging.

&gt; Source/WTF/wtf/Platform.h:-1266
&gt; -/* FIXME: Enable USE_OS_LOG when building with the public iOS 10 SDK once we fix &lt;rdar://problem/27758343&gt;. */

Not at my computer. I am assuming we fixed the referenced radar and hence we can enable this. The ChangeLog didn’t mention this fact and EWS failed to compile this patch for iOS due to another issue below.

&gt; Source/WebCore/platform/ios/wak/WebCoreThread.mm:880
&gt; +        RELEASE_LOG_FAULT(Threading, &quot;SpringBoard enabled WebThread.&quot;);

According to the EWS we don’t have a logging channel called Threading.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1418736</commentid>
    <comment_count>3</comment_count>
      <attachid>339043</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2018-04-27 20:14:16 -0700</bug_when>
    <thetext>Comment on attachment 339043
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=339043&amp;action=review

&gt;&gt; Source/WTF/ChangeLog:5
&gt;&gt; +        &lt;rdar://problem/39746542&gt;
&gt; 
&gt; I assume if I were to look at this bug that it would explain why it is beneficial to add this logging.

Correct.  Added more detail just now as well.

&gt;&gt; Source/WTF/wtf/Platform.h:-1266
&gt;&gt; -/* FIXME: Enable USE_OS_LOG when building with the public iOS 10 SDK once we fix &lt;rdar://problem/27758343&gt;. */
&gt; 
&gt; Not at my computer. I am assuming we fixed the referenced radar and hence we can enable this. The ChangeLog didn’t mention this fact and EWS failed to compile this patch for iOS due to another issue below.

Yes, it&apos;s fixed.  I&apos;ll add a comment to the ChangeLog.

&gt;&gt; Source/WebCore/platform/ios/wak/WebCoreThread.mm:880
&gt;&gt; +        RELEASE_LOG_FAULT(Threading, &quot;SpringBoard enabled WebThread.&quot;);
&gt; 
&gt; According to the EWS we don’t have a logging channel called Threading.

Weird.  I thought it was defined here:  Source/WebCore/platform/Logging.h

Maybe I forgot to #include that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1418740</commentid>
    <comment_count>4</comment_count>
      <attachid>339053</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2018-04-27 20:30:15 -0700</bug_when>
    <thetext>Created attachment 339053
Patch v2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1418746</commentid>
    <comment_count>5</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2018-04-27 20:38:37 -0700</bug_when>
    <thetext>(In reply to David Kilzer (:ddkilzer) from comment #4)
&gt; Created attachment 339053 [details]
&gt; Patch v2

Added missing #import &quot;Logging.h&quot; to WebCoreThread.mm to fix the iOS build failures.

Also updated Source/WTF/ChangeLog with info about the fixed radar.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1418769</commentid>
    <comment_count>6</comment_count>
      <attachid>339053</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-04-27 22:53:09 -0700</bug_when>
    <thetext>Comment on attachment 339053
Patch v2

Clearing flags on attachment: 339053

Committed r231130: &lt;https://trac.webkit.org/changeset/231130&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1418770</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-04-27 22:53:10 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>339043</attachid>
            <date>2018-04-27 17:19:08 -0700</date>
            <delta_ts>2018-04-27 20:30:13 -0700</delta_ts>
            <desc>Patch v1</desc>
            <filename>bug-185100-20180427171907.patch</filename>
            <type>text/plain</type>
            <size>5704</size>
            <attacher name="David Kilzer (:ddkilzer)">ddkilzer</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDZjYjBjMGUzYzIwZjhiNTQyNGU3ZTJj
YTI1MTFiODA2NzYxNTJlYTQuLjVjMjkzMWE2NzhhZDNjNjk3NzBhYmNkYWU5MzczZWI0Y2Y0MGYx
ZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDQtMjcgIERhdmlkIEtpbHplciAgPGRka2ls
emVyQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgbG9nZ2luZyB3aGVuIFNwcmluZ0JvYXJkIGVu
YWJsZXMgV2ViVGhyZWFkCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xODUxMDA+Cisg
ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zOTc0NjU0Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9Bc3NlcnRpb25zLmg6CisgICAgICAgIChS
RUxFQVNFX0xPR19GQVVMVCk6IEFkZCBtYWNybyB0byBjYWxsIG9zX2xvZ19mYXVsdCgpLgorICAg
ICAgICAqIHd0Zi9QbGF0Zm9ybS5oOiBEcml2ZS1ieSBmaXggdG8gZW5hYmxlIFVTRShPU19MT0cp
IG9uCisgICAgICAgIHB1YmxpYyBpT1MgU0RLcy4KKwogMjAxOC0wNC0yNiAgTWFyayBMYW0gIDxt
YXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgR2FyZGVuaW5nOiBTcGVjdWxhdGl2ZSBidWls
ZCBmaXggZm9yIFdpbmRvd3MuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg
Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjU1ZDBhMWU2NjJlZDg2YTNmMWY3ZjQx
ZWQ1YjY0YTZjNjJiN2ZmNS4uZGI4ZTcwYWJiZjYzODU2ZjVhNGIzYjA5NDNkNmI4MTdjM2YxOWU5
YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD
b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA0LTI3ICBEYXZpZCBLaWx6ZXIg
IDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGxvZ2dpbmcgd2hlbiBTcHJpbmdC
b2FyZCBlbmFibGVzIFdlYlRocmVhZAorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTg1
MTAwPgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzk3NDY1NDI+CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9SdW50aW1lQXBwbGlj
YXRpb25DaGVja3MuaDoKKyAgICAgICAgKFdlYkNvcmU6OklPU0FwcGxpY2F0aW9uOjppc1Nwcmlu
Z0JvYXJkKTogQWRkIGRlY2xhcmF0aW9uLgorICAgICAgICAqIHBsYXRmb3JtL2NvY29hL1J1bnRp
bWVBcHBsaWNhdGlvbkNoZWNrc0NvY29hLm1tOgorICAgICAgICAoV2ViQ29yZTo6SU9TQXBwbGlj
YXRpb246OmlzU3ByaW5nQm9hcmQpOiBBZGQgaW1wbGVtZW50YXRpb24uCisgICAgICAgICogcGxh
dGZvcm0vaW9zL3dhay9XZWJDb3JlVGhyZWFkLm1tOgorICAgICAgICAoV2ViVGhyZWFkRW5hYmxl
KTogQ2FsbCBSRUxFQVNFX0xPR19GQVVMVCgpIGlmIHRoaXMgaXMgY2FsbGVkIGJ5CisgICAgICAg
IFNwcmluZ0JvYXJkLgorCiAyMDE4LTA0LTI3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5j
b20+CiAKICAgICAgICAgVXNlIFdpbmRvd1Byb3h5IGluc3RlYWQgb2YgRE9NV2luZG93IGluIG91
ciBJREwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaCBiL1NvdXJjZS9X
VEYvd3RmL0Fzc2VydGlvbnMuaAppbmRleCBlYTAwMjRiMWYxNGY2NTRjMWE2ZDFjNGJiOTllZTE2
ZGIxMjNmMTU1Li5kODIzZjdjNWZlM2M4MmQ3ZTMwMzExZDcyODhhM2RjZDMzMmNhYmFhIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgKKysrIGIvU291cmNlL1dURi93dGYv
QXNzZXJ0aW9ucy5oCkBAIC00NDUsNiArNDQ1LDcgQEAgV1RGX0VYUE9SVF9QUklWQVRFIE5PX1JF
VFVSTl9EVUVfVE9fQ1JBU0ggdm9pZCBXVEZDcmFzaFdpdGhTZWN1cml0eUltcGxpY2F0aW9uKHYK
ICNpZiBSRUxFQVNFX0xPR19ESVNBQkxFRAogI2RlZmluZSBSRUxFQVNFX0xPRyhjaGFubmVsLCAu
Li4pICgodm9pZCkwKQogI2RlZmluZSBSRUxFQVNFX0xPR19FUlJPUihjaGFubmVsLCAuLi4pIExP
R19FUlJPUihfX1ZBX0FSR1NfXykKKyNkZWZpbmUgUkVMRUFTRV9MT0dfRkFVTFQoY2hhbm5lbCwg
Li4uKSBMT0dfRVJST1IoX19WQV9BUkdTX18pCiAKICNkZWZpbmUgUkVMRUFTRV9MT0dfSUYoaXNB
bGxvd2VkLCBjaGFubmVsLCAuLi4pICgodm9pZCkwKQogI2RlZmluZSBSRUxFQVNFX0xPR19FUlJP
Ul9JRihpc0FsbG93ZWQsIGNoYW5uZWwsIC4uLikgZG8geyBpZiAoaXNBbGxvd2VkKSBSRUxFQVNF
X0xPR19FUlJPUihjaGFubmVsLCBfX1ZBX0FSR1NfXyk7IH0gd2hpbGUgKDApCkBAIC00NTQsNiAr
NDU1LDcgQEAgV1RGX0VYUE9SVF9QUklWQVRFIE5PX1JFVFVSTl9EVUVfVE9fQ1JBU0ggdm9pZCBX
VEZDcmFzaFdpdGhTZWN1cml0eUltcGxpY2F0aW9uKHYKICNlbHNlCiAjZGVmaW5lIFJFTEVBU0Vf
TE9HKGNoYW5uZWwsIC4uLikgb3NfbG9nKExPR19DSEFOTkVMKGNoYW5uZWwpLm9zTG9nQ2hhbm5l
bCwgX19WQV9BUkdTX18pCiAjZGVmaW5lIFJFTEVBU0VfTE9HX0VSUk9SKGNoYW5uZWwsIC4uLikg
b3NfbG9nX2Vycm9yKExPR19DSEFOTkVMKGNoYW5uZWwpLm9zTG9nQ2hhbm5lbCwgX19WQV9BUkdT
X18pCisjZGVmaW5lIFJFTEVBU0VfTE9HX0ZBVUxUKGNoYW5uZWwsIC4uLikgb3NfbG9nX2ZhdWx0
KExPR19DSEFOTkVMKGNoYW5uZWwpLm9zTG9nQ2hhbm5lbCwgX19WQV9BUkdTX18pCiAjZGVmaW5l
IFJFTEVBU0VfTE9HX0lORk8oY2hhbm5lbCwgLi4uKSBvc19sb2dfaW5mbyhMT0dfQ0hBTk5FTChj
aGFubmVsKS5vc0xvZ0NoYW5uZWwsIF9fVkFfQVJHU19fKQogCiAjZGVmaW5lIFJFTEVBU0VfTE9H
X0lGKGlzQWxsb3dlZCwgY2hhbm5lbCwgLi4uKSBkbyB7IGlmIChpc0FsbG93ZWQpIFJFTEVBU0Vf
TE9HKCAgICAgIGNoYW5uZWwsIF9fVkFfQVJHU19fKTsgfSB3aGlsZSAoMCkKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmlu
ZGV4IGQ5YmExNzY2NmNmZjg5YzM0NGU1YWU5NjdjMzQwZTBiZjFhYWIyZWUuLjVlYTcxOWIxNmEw
MDEyZGQ2ZTkzMDhiY2I5NWMxY2FlZDcxMDRjNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3Rm
L1BsYXRmb3JtLmgKKysrIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaApAQCAtMTI2Myw4ICsx
MjYzLDcgQEAKICNkZWZpbmUgVVNFX01FRElBVE9PTEJPWCAxCiAjZW5kaWYKIAotLyogRklYTUU6
IEVuYWJsZSBVU0VfT1NfTE9HIHdoZW4gYnVpbGRpbmcgd2l0aCB0aGUgcHVibGljIGlPUyAxMCBT
REsgb25jZSB3ZSBmaXggPHJkYXI6Ly9wcm9ibGVtLzI3NzU4MzQzPi4gKi8KLSNpZiBQTEFURk9S
TShNQUMpIHx8IChQTEFURk9STShJT1MpICYmIFVTRShBUFBMRV9JTlRFUk5BTF9TREspKQorI2lm
IFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0oSU9TKQogI2RlZmluZSBVU0VfT1NfTE9HIDEKICNp
ZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQogI2RlZmluZSBVU0VfT1NfU1RBVEUgMQpkaWZmIC0t
Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzLmgg
Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SdW50aW1lQXBwbGljYXRpb25DaGVja3MuaAppbmRl
eCBhZjQ4OTBkNTU4NDE2MGRjMDg2ZjQ1M2RiZjBhMzAyNjU4ZjQ1M2ExLi45NGUyOGY4NTkyZTE1
NDgzMzhmMjgxMTYwMDllZGM1NDQ0ZTllYzk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9SdW50aW1lQXBwbGljYXRpb25DaGVja3MuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9SdW50aW1lQXBwbGljYXRpb25DaGVja3MuaApAQCAtNzgsNiArNzgsNyBAQCBXRUJD
T1JFX0VYUE9SVCBib29sIGlzTW9iaWxlU2FmYXJpKCk7CiBXRUJDT1JFX0VYUE9SVCBib29sIGlz
V2ViQm9va21hcmtzRCgpOwogYm9vbCBpc0R1bXBSZW5kZXJUcmVlKCk7CiBib29sIGlzTW9iaWxl
U3RvcmUoKTsKK2Jvb2wgaXNTcHJpbmdCb2FyZCgpOwogV0VCQ09SRV9FWFBPUlQgYm9vbCBpc1dl
YkFwcCgpOwogV0VCQ09SRV9FWFBPUlQgYm9vbCBpc1dlYlByb2Nlc3MoKTsKIGJvb2wgaXNJQm9v
a3MoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1J1bnRpbWVB
cHBsaWNhdGlvbkNoZWNrc0NvY29hLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2Ev
UnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzQ29jb2EubW0KaW5kZXggNTg2MjZlZWNjMzM4MjQxMmNi
NWNjNTA4ZDE4NWFkMzcyMDU4MmJhZi4uMzc3ZGNhYTFlMGQ0OGRkODBhMWY1Y2U1MjU1ZTkxMWMx
NTdlMzdhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUnVudGlt
ZUFwcGxpY2F0aW9uQ2hlY2tzQ29jb2EubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
Y29jb2EvUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzQ29jb2EubW0KQEAgLTIwNiw2ICsyMDYsMTIg
QEAgYm9vbCBJT1NBcHBsaWNhdGlvbjo6aXNNb2JpbGVTdG9yZSgpCiAgICAgcmV0dXJuIGlzTW9i
aWxlU3RvcmU7CiB9CiAKK2Jvb2wgSU9TQXBwbGljYXRpb246OmlzU3ByaW5nQm9hcmQoKQorewor
ICAgIHN0YXRpYyBib29sIGlzU3ByaW5nQm9hcmQgPSBhcHBsaWNhdGlvbkJ1bmRsZUlzRXF1YWxU
bygiY29tLmFwcGxlLnNwcmluZ2JvYXJkIik7CisgICAgcmV0dXJuIGlzU3ByaW5nQm9hcmQ7Cit9
CisKIGJvb2wgSU9TQXBwbGljYXRpb246OmlzV2ViQXBwKCkKIHsKICAgICBzdGF0aWMgYm9vbCBp
c1dlYkFwcCA9IGFwcGxpY2F0aW9uQnVuZGxlSXNFcXVhbFRvKCJjb20uYXBwbGUud2ViYXBwIik7
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dlYkNvcmVUaHJl
YWQubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dlYkNvcmVUaHJlYWQubW0K
aW5kZXggYjI4MWVjZGE3OTk2YTEwOTYwM2MwNTRlZGQ3MjU4ODNhNjgzZDU5NS4uYTk2MTBhMDY2
YmNlYmE4OGE5NTUwYjlmYzM4YmM1ZThhODY2ZDE5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vaW9zL3dhay9XZWJDb3JlVGhyZWFkLm1tCisrKyBiL1NvdXJjZS9XZWJDb3Jl
L3BsYXRmb3JtL2lvcy93YWsvV2ViQ29yZVRocmVhZC5tbQpAQCAtODc2LDYgKzg3Niw4IEBAIFdl
YlRocmVhZENvbnRleHQqIFdlYlRocmVhZEN1cnJlbnRDb250ZXh0KHZvaWQpCiB2b2lkIFdlYlRo
cmVhZEVuYWJsZSh2b2lkKQogewogICAgIFJFTEVBU0VfQVNTRVJUX1dJVEhfTUVTU0FHRSghV2Vi
Q29yZTo6SU9TQXBwbGljYXRpb246OmlzV2ViUHJvY2VzcygpLCAiVGhlIFdlYlByb2Nlc3Mgc2hv
dWxkIG5ldmVyIHJ1biBhIFdlYiBUaHJlYWQiKTsKKyAgICBpZiAoV2ViQ29yZTo6SU9TQXBwbGlj
YXRpb246OmlzU3ByaW5nQm9hcmQoKSkKKyAgICAgICAgUkVMRUFTRV9MT0dfRkFVTFQoVGhyZWFk
aW5nLCAiU3ByaW5nQm9hcmQgZW5hYmxlZCBXZWJUaHJlYWQuIik7CiAKICAgICBzdGF0aWMgc3Rk
OjpvbmNlX2ZsYWcgZmxhZzsKICAgICBzdGQ6OmNhbGxfb25jZShmbGFnLCBTdGFydFdlYlRocmVh
ZCk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>339053</attachid>
            <date>2018-04-27 20:30:15 -0700</date>
            <delta_ts>2018-04-27 22:53:09 -0700</delta_ts>
            <desc>Patch v2</desc>
            <filename>bug-185100-20180427203014.patch</filename>
            <type>text/plain</type>
            <size>5959</size>
            <attacher name="David Kilzer (:ddkilzer)">ddkilzer</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDZjYjBjMGUzYzIwZjhiNTQyNGU3ZTJj
YTI1MTFiODA2NzYxNTJlYTQuLmMxN2ZiZmYyZDNiNzBkYzcwNDNkY2ZiYWE1ZGRmZjY1ZmVmMDUy
MzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDQtMjcgIERhdmlkIEtpbHplciAgPGRka2ls
emVyQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgbG9nZ2luZyB3aGVuIFNwcmluZ0JvYXJkIGVu
YWJsZXMgV2ViVGhyZWFkCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xODUxMDA+Cisg
ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zOTc0NjU0Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9Bc3NlcnRpb25zLmg6CisgICAgICAgIChS
RUxFQVNFX0xPR19GQVVMVCk6IEFkZCBtYWNybyB0byBjYWxsIG9zX2xvZ19mYXVsdCgpLgorICAg
ICAgICAqIHd0Zi9QbGF0Zm9ybS5oOiBEcml2ZS1ieSBmaXggdG8gZW5hYmxlIFVTRShPU19MT0cp
IG9uCisgICAgICAgIHB1YmxpYyBpT1MgU0RLcyBzaW5jZSA8cmRhcjovL3Byb2JsZW0vMjc3NTgz
NDM+IHdhcworICAgICAgICBmaXhlZCBpbiBpT1MgMTEuMC4KKwogMjAxOC0wNC0yNiAgTWFyayBM
YW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgR2FyZGVuaW5nOiBTcGVjdWxhdGl2
ZSBidWlsZCBmaXggZm9yIFdpbmRvd3MuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFu
Z2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjU1ZDBhMWU2NjJlZDg2YTNm
MWY3ZjQxZWQ1YjY0YTZjNjJiN2ZmNS4uZGI4ZTcwYWJiZjYzODU2ZjVhNGIzYjA5NDNkNmI4MTdj
M2YxOWU5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA0LTI3ICBEYXZpZCBL
aWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGxvZ2dpbmcgd2hlbiBT
cHJpbmdCb2FyZCBlbmFibGVzIFdlYlRocmVhZAorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3Jn
L2IvMTg1MTAwPgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzk3NDY1NDI+CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9SdW50aW1l
QXBwbGljYXRpb25DaGVja3MuaDoKKyAgICAgICAgKFdlYkNvcmU6OklPU0FwcGxpY2F0aW9uOjpp
c1NwcmluZ0JvYXJkKTogQWRkIGRlY2xhcmF0aW9uLgorICAgICAgICAqIHBsYXRmb3JtL2NvY29h
L1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNrc0NvY29hLm1tOgorICAgICAgICAoV2ViQ29yZTo6SU9T
QXBwbGljYXRpb246OmlzU3ByaW5nQm9hcmQpOiBBZGQgaW1wbGVtZW50YXRpb24uCisgICAgICAg
ICogcGxhdGZvcm0vaW9zL3dhay9XZWJDb3JlVGhyZWFkLm1tOgorICAgICAgICAoV2ViVGhyZWFk
RW5hYmxlKTogQ2FsbCBSRUxFQVNFX0xPR19GQVVMVCgpIGlmIHRoaXMgaXMgY2FsbGVkIGJ5Cisg
ICAgICAgIFNwcmluZ0JvYXJkLgorCiAyMDE4LTA0LTI3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBh
cHBsZS5jb20+CiAKICAgICAgICAgVXNlIFdpbmRvd1Byb3h5IGluc3RlYWQgb2YgRE9NV2luZG93
IGluIG91ciBJREwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaCBiL1Nv
dXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAppbmRleCBlYTAwMjRiMWYxNGY2NTRjMWE2ZDFjNGJi
OTllZTE2ZGIxMjNmMTU1Li5kODIzZjdjNWZlM2M4MmQ3ZTMwMzExZDcyODhhM2RjZDMzMmNhYmFh
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgKKysrIGIvU291cmNlL1dU
Ri93dGYvQXNzZXJ0aW9ucy5oCkBAIC00NDUsNiArNDQ1LDcgQEAgV1RGX0VYUE9SVF9QUklWQVRF
IE5PX1JFVFVSTl9EVUVfVE9fQ1JBU0ggdm9pZCBXVEZDcmFzaFdpdGhTZWN1cml0eUltcGxpY2F0
aW9uKHYKICNpZiBSRUxFQVNFX0xPR19ESVNBQkxFRAogI2RlZmluZSBSRUxFQVNFX0xPRyhjaGFu
bmVsLCAuLi4pICgodm9pZCkwKQogI2RlZmluZSBSRUxFQVNFX0xPR19FUlJPUihjaGFubmVsLCAu
Li4pIExPR19FUlJPUihfX1ZBX0FSR1NfXykKKyNkZWZpbmUgUkVMRUFTRV9MT0dfRkFVTFQoY2hh
bm5lbCwgLi4uKSBMT0dfRVJST1IoX19WQV9BUkdTX18pCiAKICNkZWZpbmUgUkVMRUFTRV9MT0df
SUYoaXNBbGxvd2VkLCBjaGFubmVsLCAuLi4pICgodm9pZCkwKQogI2RlZmluZSBSRUxFQVNFX0xP
R19FUlJPUl9JRihpc0FsbG93ZWQsIGNoYW5uZWwsIC4uLikgZG8geyBpZiAoaXNBbGxvd2VkKSBS
RUxFQVNFX0xPR19FUlJPUihjaGFubmVsLCBfX1ZBX0FSR1NfXyk7IH0gd2hpbGUgKDApCkBAIC00
NTQsNiArNDU1LDcgQEAgV1RGX0VYUE9SVF9QUklWQVRFIE5PX1JFVFVSTl9EVUVfVE9fQ1JBU0gg
dm9pZCBXVEZDcmFzaFdpdGhTZWN1cml0eUltcGxpY2F0aW9uKHYKICNlbHNlCiAjZGVmaW5lIFJF
TEVBU0VfTE9HKGNoYW5uZWwsIC4uLikgb3NfbG9nKExPR19DSEFOTkVMKGNoYW5uZWwpLm9zTG9n
Q2hhbm5lbCwgX19WQV9BUkdTX18pCiAjZGVmaW5lIFJFTEVBU0VfTE9HX0VSUk9SKGNoYW5uZWws
IC4uLikgb3NfbG9nX2Vycm9yKExPR19DSEFOTkVMKGNoYW5uZWwpLm9zTG9nQ2hhbm5lbCwgX19W
QV9BUkdTX18pCisjZGVmaW5lIFJFTEVBU0VfTE9HX0ZBVUxUKGNoYW5uZWwsIC4uLikgb3NfbG9n
X2ZhdWx0KExPR19DSEFOTkVMKGNoYW5uZWwpLm9zTG9nQ2hhbm5lbCwgX19WQV9BUkdTX18pCiAj
ZGVmaW5lIFJFTEVBU0VfTE9HX0lORk8oY2hhbm5lbCwgLi4uKSBvc19sb2dfaW5mbyhMT0dfQ0hB
Tk5FTChjaGFubmVsKS5vc0xvZ0NoYW5uZWwsIF9fVkFfQVJHU19fKQogCiAjZGVmaW5lIFJFTEVB
U0VfTE9HX0lGKGlzQWxsb3dlZCwgY2hhbm5lbCwgLi4uKSBkbyB7IGlmIChpc0FsbG93ZWQpIFJF
TEVBU0VfTE9HKCAgICAgIGNoYW5uZWwsIF9fVkFfQVJHU19fKTsgfSB3aGlsZSAoMCkKZGlmZiAt
LWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9y
bS5oCmluZGV4IGQ5YmExNzY2NmNmZjg5YzM0NGU1YWU5NjdjMzQwZTBiZjFhYWIyZWUuLjVlYTcx
OWIxNmEwMDEyZGQ2ZTkzMDhiY2I5NWMxY2FlZDcxMDRjNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
VEYvd3RmL1BsYXRmb3JtLmgKKysrIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaApAQCAtMTI2
Myw4ICsxMjYzLDcgQEAKICNkZWZpbmUgVVNFX01FRElBVE9PTEJPWCAxCiAjZW5kaWYKIAotLyog
RklYTUU6IEVuYWJsZSBVU0VfT1NfTE9HIHdoZW4gYnVpbGRpbmcgd2l0aCB0aGUgcHVibGljIGlP
UyAxMCBTREsgb25jZSB3ZSBmaXggPHJkYXI6Ly9wcm9ibGVtLzI3NzU4MzQzPi4gKi8KLSNpZiBQ
TEFURk9STShNQUMpIHx8IChQTEFURk9STShJT1MpICYmIFVTRShBUFBMRV9JTlRFUk5BTF9TREsp
KQorI2lmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0oSU9TKQogI2RlZmluZSBVU0VfT1NfTE9H
IDEKICNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQogI2RlZmluZSBVU0VfT1NfU1RBVEUgMQpk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVudGltZUFwcGxpY2F0aW9uQ2hl
Y2tzLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SdW50aW1lQXBwbGljYXRpb25DaGVja3Mu
aAppbmRleCBhZjQ4OTBkNTU4NDE2MGRjMDg2ZjQ1M2RiZjBhMzAyNjU4ZjQ1M2ExLi45NGUyOGY4
NTkyZTE1NDgzMzhmMjgxMTYwMDllZGM1NDQ0ZTllYzk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi
Q29yZS9wbGF0Zm9ybS9SdW50aW1lQXBwbGljYXRpb25DaGVja3MuaAorKysgYi9Tb3VyY2UvV2Vi
Q29yZS9wbGF0Zm9ybS9SdW50aW1lQXBwbGljYXRpb25DaGVja3MuaApAQCAtNzgsNiArNzgsNyBA
QCBXRUJDT1JFX0VYUE9SVCBib29sIGlzTW9iaWxlU2FmYXJpKCk7CiBXRUJDT1JFX0VYUE9SVCBi
b29sIGlzV2ViQm9va21hcmtzRCgpOwogYm9vbCBpc0R1bXBSZW5kZXJUcmVlKCk7CiBib29sIGlz
TW9iaWxlU3RvcmUoKTsKK2Jvb2wgaXNTcHJpbmdCb2FyZCgpOwogV0VCQ09SRV9FWFBPUlQgYm9v
bCBpc1dlYkFwcCgpOwogV0VCQ09SRV9FWFBPUlQgYm9vbCBpc1dlYlByb2Nlc3MoKTsKIGJvb2wg
aXNJQm9va3MoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1J1
bnRpbWVBcHBsaWNhdGlvbkNoZWNrc0NvY29hLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
Y29jb2EvUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzQ29jb2EubW0KaW5kZXggNTg2MjZlZWNjMzM4
MjQxMmNiNWNjNTA4ZDE4NWFkMzcyMDU4MmJhZi4uMzc3ZGNhYTFlMGQ0OGRkODBhMWY1Y2U1MjU1
ZTkxMWMxNTdlMzdhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2Ev
UnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzQ29jb2EubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vY29jb2EvUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzQ29jb2EubW0KQEAgLTIwNiw2ICsy
MDYsMTIgQEAgYm9vbCBJT1NBcHBsaWNhdGlvbjo6aXNNb2JpbGVTdG9yZSgpCiAgICAgcmV0dXJu
IGlzTW9iaWxlU3RvcmU7CiB9CiAKK2Jvb2wgSU9TQXBwbGljYXRpb246OmlzU3ByaW5nQm9hcmQo
KQoreworICAgIHN0YXRpYyBib29sIGlzU3ByaW5nQm9hcmQgPSBhcHBsaWNhdGlvbkJ1bmRsZUlz
RXF1YWxUbygiY29tLmFwcGxlLnNwcmluZ2JvYXJkIik7CisgICAgcmV0dXJuIGlzU3ByaW5nQm9h
cmQ7Cit9CisKIGJvb2wgSU9TQXBwbGljYXRpb246OmlzV2ViQXBwKCkKIHsKICAgICBzdGF0aWMg
Ym9vbCBpc1dlYkFwcCA9IGFwcGxpY2F0aW9uQnVuZGxlSXNFcXVhbFRvKCJjb20uYXBwbGUud2Vi
YXBwIik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dlYkNv
cmVUaHJlYWQubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dlYkNvcmVUaHJl
YWQubW0KaW5kZXggYjI4MWVjZGE3OTk2YTEwOTYwM2MwNTRlZGQ3MjU4ODNhNjgzZDU5NS4uNGE5
MmJjNjg1M2I2MjZlODhmY2YyNDVlMjRmOWJkN2EyNjc3OTFmZSAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XZWJDb3JlVGhyZWFkLm1tCisrKyBiL1NvdXJjZS9X
ZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV2ViQ29yZVRocmVhZC5tbQpAQCAtMzAsNiArMzAsNyBA
QAogCiAjaW1wb3J0ICJDb21tb25WTS5oIgogI2ltcG9ydCAiRmxvYXRpbmdQb2ludEVudmlyb25t
ZW50LmgiCisjaW1wb3J0ICJMb2dnaW5nLmgiCiAjaW1wb3J0ICJSdW50aW1lQXBwbGljYXRpb25D
aGVja3MuaCIKICNpbXBvcnQgIlRocmVhZEdsb2JhbERhdGEuaCIKICNpbXBvcnQgIldBS1dpbmRv
dy5oIgpAQCAtODc2LDYgKzg3Nyw4IEBAIFdlYlRocmVhZENvbnRleHQqIFdlYlRocmVhZEN1cnJl
bnRDb250ZXh0KHZvaWQpCiB2b2lkIFdlYlRocmVhZEVuYWJsZSh2b2lkKQogewogICAgIFJFTEVB
U0VfQVNTRVJUX1dJVEhfTUVTU0FHRSghV2ViQ29yZTo6SU9TQXBwbGljYXRpb246OmlzV2ViUHJv
Y2VzcygpLCAiVGhlIFdlYlByb2Nlc3Mgc2hvdWxkIG5ldmVyIHJ1biBhIFdlYiBUaHJlYWQiKTsK
KyAgICBpZiAoV2ViQ29yZTo6SU9TQXBwbGljYXRpb246OmlzU3ByaW5nQm9hcmQoKSkKKyAgICAg
ICAgUkVMRUFTRV9MT0dfRkFVTFQoVGhyZWFkaW5nLCAiU3ByaW5nQm9hcmQgZW5hYmxlZCBXZWJU
aHJlYWQuIik7CiAKICAgICBzdGF0aWMgc3RkOjpvbmNlX2ZsYWcgZmxhZzsKICAgICBzdGQ6OmNh
bGxfb25jZShmbGFnLCBTdGFydFdlYlRocmVhZCk7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>