<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>185087</bug_id>
          
          <creation_ts>2018-04-27 13:33:49 -0700</creation_ts>
          <short_desc>Refactor filter list checking code</short_desc>
          <delta_ts>2019-06-16 21:07:47 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Compositing</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>REOPENED</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Simon Fraser (smfr)">simon.fraser</reporter>
          <assigned_to name="Simon Fraser (smfr)">simon.fraser</assigned_to>
          <cc>ews-watchlist</cc>
    
    <cc>fred.wang</cc>
    
    <cc>mmaxfield</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1418599</commentid>
    <comment_count>0</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-04-27 13:33:49 -0700</bug_when>
    <thetext>Refactor filter list checking code</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1418600</commentid>
    <comment_count>1</comment_count>
      <attachid>339018</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-04-27 13:35:24 -0700</bug_when>
    <thetext>Created attachment 339018
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1418642</commentid>
    <comment_count>2</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-04-27 15:02:17 -0700</bug_when>
    <thetext>https://trac.webkit.org/changeset/231112/webkit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1418643</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-04-27 15:03:36 -0700</bug_when>
    <thetext>&lt;rdar://problem/39805938&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1457479</commentid>
    <comment_count>4</comment_count>
      <attachid>339018</attachid>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-09-07 07:50:41 -0700</bug_when>
    <thetext>Comment on attachment 339018
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339018&amp;action=review

&gt; Source/WebCore/animation/KeyframeEffectReadOnly.h:153
&gt; +    bool checkForMatchingFilterFunctionLists(CSSPropertyID, const std::function&lt;const FilterOperations&amp; (const RenderStyle&amp;)&gt;&amp;) const;

@smfr: I think we should really forward-declare FilterOperations here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1457583</commentid>
    <comment_count>5</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-09-07 11:23:37 -0700</bug_when>
    <thetext>Sure.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1457609</commentid>
    <comment_count>6</comment_count>
      <attachid>349173</attachid>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-09-07 12:05:52 -0700</bug_when>
    <thetext>Created attachment 349173
Follow-up fix of possible build failure

(In reply to Simon Fraser (smfr) from comment #5)
&gt; Sure.

For the record, I&apos;m found this after getting a build failure with a patch for bug 188043 ; probably because of the unified build thing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1458083</commentid>
    <comment_count>7</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-09-09 23:23:20 -0700</bug_when>
    <thetext>smfr: review ping?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1458119</commentid>
    <comment_count>8</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-09-10 05:01:06 -0700</bug_when>
    <thetext>Committed r235847: &lt;https://trac.webkit.org/changeset/235847&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1458438</commentid>
    <comment_count>9</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-09-11 03:00:38 -0700</bug_when>
    <thetext>(In reply to Simon Fraser (smfr) from comment #2)
&gt; https://trac.webkit.org/changeset/231112/webkit

Mmh, that commit adds one more change with respect to the patch in Source/WebCore/page/animation/KeyframeAnimation.h that requires similar fixup.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1458448</commentid>
    <comment_count>10</comment_count>
      <attachid>349392</attachid>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-09-11 05:42:51 -0700</bug_when>
    <thetext>Created attachment 349392
Another follow-up fix of potential build failure</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1458449</commentid>
    <comment_count>11</comment_count>
      <attachid>349392</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2018-09-11 05:46:22 -0700</bug_when>
    <thetext>Comment on attachment 349392
Another follow-up fix of potential build failure

rs=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1458452</commentid>
    <comment_count>12</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-09-11 05:48:43 -0700</bug_when>
    <thetext>Committed r235894: &lt;https://trac.webkit.org/changeset/235894&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1458962</commentid>
    <comment_count>13</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-09-12 09:03:01 -0700</bug_when>
    <thetext>Reopening to attach new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1458963</commentid>
    <comment_count>14</comment_count>
      <attachid>349552</attachid>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-09-12 09:03:04 -0700</bug_when>
    <thetext>Created attachment 349552
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1458997</commentid>
    <comment_count>15</comment_count>
      <attachid>349552</attachid>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2018-09-12 09:57:12 -0700</bug_when>
    <thetext>Comment on attachment 349552
Patch

We often inline functions for performance, and fonts are used pretty often. Is this a performance regression?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1458998</commentid>
    <comment_count>16</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2018-09-12 09:58:22 -0700</bug_when>
    <thetext>r=me if this isn’t a performance regression</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1459022</commentid>
    <comment_count>17</comment_count>
      <attachid>349552</attachid>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-09-12 11:30:27 -0700</bug_when>
    <thetext>Comment on attachment 349552
Patch

Mmh, wrong bug sorry...</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>339018</attachid>
            <date>2018-04-27 13:35:24 -0700</date>
            <delta_ts>2018-09-13 03:55:04 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-185087-20180427133523.patch</filename>
            <type>text/plain</type>
            <size>6323</size>
            <attacher name="Simon Fraser (smfr)">simon.fraser</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2Q5OTg0NmIwOWU4Mjg3
MTliYTAwMTAzY2EzMmRjYWY4YWE4MGNkMi4uYWZmMDk2Mjg2YjIwY2U1YzM2NDMzMzAzOTkzYTNk
MjU3YjY1ZTIxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA0LTI3ICBTaW1v
biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJlZmFjdG9yIGZp
bHRlciBsaXN0IGNoZWNraW5nIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTE4NTA4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgIERlZHVwbGljYXRlIGNvZGUgYmV0d2VlbiBmaWx0ZXIgYW5kIGJhY2tk
cm9wLWZpbHRlciBmb3IgY2hlY2tpbmcgd2hldGhlciBmdW5jdGlvbiBsaXN0cworICAgICAgICBt
YXRjaCwgYnkgbWFraW5nIGEgc2hhcmVkIGZ1bmN0aW9uIHRoYXQgdGFrZXMgYSBzdGQ6OmZ1bmN0
aW9uLgorICAgICAgICAKKyAgICAgICAgVGhlIGNhbGwgc2l0ZXMgaGF2ZSB0byBkZWNsYXJlIHRo
ZSByZXR1cm4gdHlwZSAoLT4gY29uc3QgRmlsdGVyT3BlcmF0aW9ucyYpIHRvIGF2b2lkIHN0ZDo6
ZnVuY3Rpb24KKyAgICAgICAgY29udmVydGluZyB0aGUgcmV0dXJuIHR5cGUgaW50byBhIHZhbHVl
LgorCisgICAgICAgICogYW5pbWF0aW9uL0tleWZyYW1lRWZmZWN0UmVhZE9ubHkuY3BwOgorICAg
ICAgICAoV2ViQ29yZTo6S2V5ZnJhbWVFZmZlY3RSZWFkT25seTo6Y2hlY2tGb3JNYXRjaGluZ0Zp
bHRlckZ1bmN0aW9uTGlzdHMgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6S2V5ZnJhbWVFZmZl
Y3RSZWFkT25seTo6Y2hlY2tGb3JNYXRjaGluZ0ZpbHRlckZ1bmN0aW9uTGlzdHMpOgorICAgICAg
ICAoV2ViQ29yZTo6S2V5ZnJhbWVFZmZlY3RSZWFkT25seTo6Y2hlY2tGb3JNYXRjaGluZ0JhY2tk
cm9wRmlsdGVyRnVuY3Rpb25MaXN0cyk6CisgICAgICAgICogYW5pbWF0aW9uL0tleWZyYW1lRWZm
ZWN0UmVhZE9ubHkuaDoKKwogMjAxOC0wNC0yNyAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUu
Y29tPgogCiAgICAgICAgIFtMRkNdIEltcGxlbWVudCBCbG9ja0Zvcm1hdHRpbmdDb250ZXh0Ojps
YXlvdXQgbG9naWMgYW5kIGl0cyBkZXBlbmRlbmNpZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL2FuaW1hdGlvbi9LZXlmcmFtZUVmZmVjdFJlYWRPbmx5LmNwcCBiL1NvdXJjZS9XZWJDb3Jl
L2FuaW1hdGlvbi9LZXlmcmFtZUVmZmVjdFJlYWRPbmx5LmNwcAppbmRleCA4NDNiYWI2NTExYmQy
YjA5MWYwMzBiNmJlY2RhNTc2NWFkYjBlNjg1Li5lZmFkNjQ3YmJkODg0MWVlNzZhYTQ2NDM5ZDNj
N2JjNWI0YWQ1NWM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vS2V5ZnJh
bWVFZmZlY3RSZWFkT25seS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0tleWZy
YW1lRWZmZWN0UmVhZE9ubHkuY3BwCkBAIC03NjQsNzcgKzc2NCw1MyBAQCB2b2lkIEtleWZyYW1l
RWZmZWN0UmVhZE9ubHk6OmNoZWNrRm9yTWF0Y2hpbmdUcmFuc2Zvcm1GdW5jdGlvbkxpc3RzKCkK
ICAgICBtX3RyYW5zZm9ybUZ1bmN0aW9uTGlzdHNNYXRjaCA9IHRydWU7CiB9CiAKLXZvaWQgS2V5
ZnJhbWVFZmZlY3RSZWFkT25seTo6Y2hlY2tGb3JNYXRjaGluZ0ZpbHRlckZ1bmN0aW9uTGlzdHMo
KQorYm9vbCBLZXlmcmFtZUVmZmVjdFJlYWRPbmx5OjpjaGVja0Zvck1hdGNoaW5nRmlsdGVyRnVu
Y3Rpb25MaXN0cyhDU1NQcm9wZXJ0eUlEIHByb3BlcnR5SUQsIGNvbnN0IHN0ZDo6ZnVuY3Rpb248
Y29uc3QgRmlsdGVyT3BlcmF0aW9ucyYgKGNvbnN0IFJlbmRlclN0eWxlJik+JiBmaWx0ZXJzR2V0
dGVyKSBjb25zdAogewotICAgIG1fZmlsdGVyRnVuY3Rpb25MaXN0c01hdGNoID0gZmFsc2U7Ci0K
LSAgICBpZiAobV9ibGVuZGluZ0tleWZyYW1lcy5zaXplKCkgPCAyIHx8ICFtX2JsZW5kaW5nS2V5
ZnJhbWVzLmNvbnRhaW5zUHJvcGVydHkoQ1NTUHJvcGVydHlGaWx0ZXIpKQotICAgICAgICByZXR1
cm47CisgICAgaWYgKG1fYmxlbmRpbmdLZXlmcmFtZXMuc2l6ZSgpIDwgMiB8fCAhbV9ibGVuZGlu
Z0tleWZyYW1lcy5jb250YWluc1Byb3BlcnR5KHByb3BlcnR5SUQpKQorICAgICAgICByZXR1cm4g
ZmFsc2U7CiAKICAgICAvLyBFbXB0eSBmaWx0ZXJzIG1hdGNoIGFueXRoaW5nLCBzbyBmaW5kIHRo
ZSBmaXJzdCBub24tZW1wdHkgZW50cnkgYXMgdGhlIHJlZmVyZW5jZS4KICAgICBzaXplX3QgbnVt
S2V5ZnJhbWVzID0gbV9ibGVuZGluZ0tleWZyYW1lcy5zaXplKCk7Ci0gICAgc2l6ZV90IGZpcnN0
Tm9uRW1wdHlGaWx0ZXJLZXlmcmFtZUluZGV4ID0gbnVtS2V5ZnJhbWVzOworICAgIHNpemVfdCBm
aXJzdE5vbkVtcHR5S2V5ZnJhbWVJbmRleCA9IG51bUtleWZyYW1lczsKIAogICAgIGZvciAoc2l6
ZV90IGkgPSAwOyBpIDwgbnVtS2V5ZnJhbWVzOyArK2kpIHsKLSAgICAgICAgaWYgKG1fYmxlbmRp
bmdLZXlmcmFtZXNbaV0uc3R5bGUoKS0+ZmlsdGVyKCkub3BlcmF0aW9ucygpLnNpemUoKSkgewot
ICAgICAgICAgICAgZmlyc3ROb25FbXB0eUZpbHRlcktleWZyYW1lSW5kZXggPSBpOworICAgICAg
ICBpZiAoZmlsdGVyc0dldHRlcigqbV9ibGVuZGluZ0tleWZyYW1lc1tpXS5zdHlsZSgpKS5vcGVy
YXRpb25zKCkuc2l6ZSgpKSB7CisgICAgICAgICAgICBmaXJzdE5vbkVtcHR5S2V5ZnJhbWVJbmRl
eCA9IGk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogICAgIH0KIAotICAgIGlmIChm
aXJzdE5vbkVtcHR5RmlsdGVyS2V5ZnJhbWVJbmRleCA9PSBudW1LZXlmcmFtZXMpCi0gICAgICAg
IHJldHVybjsKKyAgICBpZiAoZmlyc3ROb25FbXB0eUtleWZyYW1lSW5kZXggPT0gbnVtS2V5ZnJh
bWVzKQorICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBhdXRvJiBmaXJzdFZhbCA9IG1fYmxl
bmRpbmdLZXlmcmFtZXNbZmlyc3ROb25FbXB0eUZpbHRlcktleWZyYW1lSW5kZXhdLnN0eWxlKCkt
PmZpbHRlcigpOwotICAgIGZvciAoc2l6ZV90IGkgPSBmaXJzdE5vbkVtcHR5RmlsdGVyS2V5ZnJh
bWVJbmRleCArIDE7IGkgPCBudW1LZXlmcmFtZXM7ICsraSkgewotICAgICAgICBhdXRvJiB2YWx1
ZSA9IG1fYmxlbmRpbmdLZXlmcmFtZXNbaV0uc3R5bGUoKS0+ZmlsdGVyKCk7CisgICAgYXV0byYg
Zmlyc3RWYWwgPSBmaWx0ZXJzR2V0dGVyKCptX2JsZW5kaW5nS2V5ZnJhbWVzW2ZpcnN0Tm9uRW1w
dHlLZXlmcmFtZUluZGV4XS5zdHlsZSgpKTsKKyAgICBmb3IgKHNpemVfdCBpID0gZmlyc3ROb25F
bXB0eUtleWZyYW1lSW5kZXggKyAxOyBpIDwgbnVtS2V5ZnJhbWVzOyArK2kpIHsKKyAgICAgICAg
YXV0byYgdmFsdWUgPSBmaWx0ZXJzR2V0dGVyKCptX2JsZW5kaW5nS2V5ZnJhbWVzW2ldLnN0eWxl
KCkpOwogCiAgICAgICAgIC8vIEFuIGVtcHR5IGZpbHRlciBsaXN0IG1hdGNoZXMgYW55dGhpbmcu
CiAgICAgICAgIGlmICh2YWx1ZS5vcGVyYXRpb25zKCkuaXNFbXB0eSgpKQogICAgICAgICAgICAg
Y29udGludWU7CiAKICAgICAgICAgaWYgKCFmaXJzdFZhbC5vcGVyYXRpb25zTWF0Y2godmFsdWUp
KQotICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0K
IAotICAgIG1fZmlsdGVyRnVuY3Rpb25MaXN0c01hdGNoID0gdHJ1ZTsKKyAgICByZXR1cm4gdHJ1
ZTsKK30KKwordm9pZCBLZXlmcmFtZUVmZmVjdFJlYWRPbmx5OjpjaGVja0Zvck1hdGNoaW5nRmls
dGVyRnVuY3Rpb25MaXN0cygpCit7CisgICAgbV9maWx0ZXJGdW5jdGlvbkxpc3RzTWF0Y2ggPSBj
aGVja0Zvck1hdGNoaW5nRmlsdGVyRnVuY3Rpb25MaXN0cyhDU1NQcm9wZXJ0eUZpbHRlciwgW10g
KGNvbnN0IFJlbmRlclN0eWxlJiBzdHlsZSkgLT4gY29uc3QgRmlsdGVyT3BlcmF0aW9ucyYgewor
ICAgICAgICByZXR1cm4gc3R5bGUuZmlsdGVyKCk7CisgICAgfSk7CiB9CiAKICNpZiBFTkFCTEUo
RklMVEVSU19MRVZFTF8yKQogdm9pZCBLZXlmcmFtZUVmZmVjdFJlYWRPbmx5OjpjaGVja0Zvck1h
dGNoaW5nQmFja2Ryb3BGaWx0ZXJGdW5jdGlvbkxpc3RzKCkKIHsKLSAgICBtX2JhY2tkcm9wRmls
dGVyRnVuY3Rpb25MaXN0c01hdGNoID0gZmFsc2U7Ci0KLSAgICBpZiAobV9ibGVuZGluZ0tleWZy
YW1lcy5zaXplKCkgPCAyIHx8ICFtX2JsZW5kaW5nS2V5ZnJhbWVzLmNvbnRhaW5zUHJvcGVydHko
Q1NTUHJvcGVydHlXZWJraXRCYWNrZHJvcEZpbHRlcikpCi0gICAgICAgIHJldHVybjsKLQotICAg
IC8vIEVtcHR5IGZpbHRlcnMgbWF0Y2ggYW55dGhpbmcsIHNvIGZpbmQgdGhlIGZpcnN0IG5vbi1l
bXB0eSBlbnRyeSBhcyB0aGUgcmVmZXJlbmNlLgotICAgIHNpemVfdCBudW1LZXlmcmFtZXMgPSBt
X2JsZW5kaW5nS2V5ZnJhbWVzLnNpemUoKTsKLSAgICBzaXplX3QgZmlyc3ROb25FbXB0eUZpbHRl
cktleWZyYW1lSW5kZXggPSBudW1LZXlmcmFtZXM7Ci0KLSAgICBmb3IgKHNpemVfdCBpID0gMDsg
aSA8IG51bUtleWZyYW1lczsgKytpKSB7Ci0gICAgICAgIGlmIChtX2JsZW5kaW5nS2V5ZnJhbWVz
W2ldLnN0eWxlKCktPmJhY2tkcm9wRmlsdGVyKCkub3BlcmF0aW9ucygpLnNpemUoKSkgewotICAg
ICAgICAgICAgZmlyc3ROb25FbXB0eUZpbHRlcktleWZyYW1lSW5kZXggPSBpOwotICAgICAgICAg
ICAgYnJlYWs7Ci0gICAgICAgIH0KLSAgICB9Ci0KLSAgICBpZiAoZmlyc3ROb25FbXB0eUZpbHRl
cktleWZyYW1lSW5kZXggPT0gbnVtS2V5ZnJhbWVzKQotICAgICAgICByZXR1cm47Ci0KLSAgICBh
dXRvJiBmaXJzdFZhbCA9IG1fYmxlbmRpbmdLZXlmcmFtZXNbZmlyc3ROb25FbXB0eUZpbHRlcktl
eWZyYW1lSW5kZXhdLnN0eWxlKCktPmJhY2tkcm9wRmlsdGVyKCk7Ci0gICAgZm9yIChzaXplX3Qg
aSA9IGZpcnN0Tm9uRW1wdHlGaWx0ZXJLZXlmcmFtZUluZGV4ICsgMTsgaSA8IG51bUtleWZyYW1l
czsgKytpKSB7Ci0gICAgICAgIGF1dG8mIHZhbHVlID0gbV9ibGVuZGluZ0tleWZyYW1lc1tpXS5z
dHlsZSgpLT5iYWNrZHJvcEZpbHRlcigpOwotCi0gICAgICAgIC8vIEFuIGVtcHR5IGZpbHRlciBs
aXN0IG1hdGNoZXMgYW55dGhpbmcuCi0gICAgICAgIGlmICh2YWx1ZS5vcGVyYXRpb25zKCkuaXNF
bXB0eSgpKQotICAgICAgICAgICAgY29udGludWU7Ci0KLSAgICAgICAgaWYgKCFmaXJzdFZhbC5v
cGVyYXRpb25zTWF0Y2godmFsdWUpKQotICAgICAgICAgICAgcmV0dXJuOwotICAgIH0KLQotICAg
IG1fYmFja2Ryb3BGaWx0ZXJGdW5jdGlvbkxpc3RzTWF0Y2ggPSB0cnVlOworICAgIG1fYmFja2Ry
b3BGaWx0ZXJGdW5jdGlvbkxpc3RzTWF0Y2ggPSBjaGVja0Zvck1hdGNoaW5nRmlsdGVyRnVuY3Rp
b25MaXN0cyhDU1NQcm9wZXJ0eVdlYmtpdEJhY2tkcm9wRmlsdGVyLCBbXSAoY29uc3QgUmVuZGVy
U3R5bGUmIHN0eWxlKSAtPiBjb25zdCBGaWx0ZXJPcGVyYXRpb25zJiB7CisgICAgICAgIHJldHVy
biBzdHlsZS5iYWNrZHJvcEZpbHRlcigpOworICAgIH0pOwogfQogI2VuZGlmCiAKZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9LZXlmcmFtZUVmZmVjdFJlYWRPbmx5LmggYi9T
b3VyY2UvV2ViQ29yZS9hbmltYXRpb24vS2V5ZnJhbWVFZmZlY3RSZWFkT25seS5oCmluZGV4IGNl
NDQwNDA2MTYxM2YyYTZkNjFkOWM2MjY3ZmUwOGQwYmM1Mjk2YTEuLjU5ZDIyMjkzOGIyM2ZjOTYz
OTYxMjM5N2ZhNzhlY2U1MGEzYzNlOGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FuaW1h
dGlvbi9LZXlmcmFtZUVmZmVjdFJlYWRPbmx5LmgKKysrIGIvU291cmNlL1dlYkNvcmUvYW5pbWF0
aW9uL0tleWZyYW1lRWZmZWN0UmVhZE9ubHkuaApAQCAtMTUwLDYgKzE1MCw4IEBAIHByaXZhdGU6
CiAgICAgdm9pZCBjaGVja0Zvck1hdGNoaW5nQmFja2Ryb3BGaWx0ZXJGdW5jdGlvbkxpc3RzKCk7
CiAjZW5kaWYKIAorICAgIGJvb2wgY2hlY2tGb3JNYXRjaGluZ0ZpbHRlckZ1bmN0aW9uTGlzdHMo
Q1NTUHJvcGVydHlJRCwgY29uc3Qgc3RkOjpmdW5jdGlvbjxjb25zdCBGaWx0ZXJPcGVyYXRpb25z
JiAoY29uc3QgUmVuZGVyU3R5bGUmKT4mKSBjb25zdDsKKwogICAgIGJvb2wgbV9zaG91bGRSdW5B
Y2NlbGVyYXRlZCB7IGZhbHNlIH07CiAgICAgYm9vbCBtX25lZWRzRm9yY2VkTGF5b3V0IHsgZmFs
c2UgfTsKICAgICBib29sIG1fdHJpZ2dlcnNTdGFja2luZ0NvbnRleHQgeyBmYWxzZSB9Owo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>349173</attachid>
            <date>2018-09-07 12:05:52 -0700</date>
            <delta_ts>2018-09-13 03:55:15 -0700</delta_ts>
            <desc>Follow-up fix of possible build failure</desc>
            <filename>185087-follow-up.patch</filename>
            <type>text/plain</type>
            <size>1098</size>
            <attacher name="Frédéric Wang Nélar">fred.wang</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA3MWUxYmRjM2M3Yy4uMmNhOThmNWU1ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNCBAQAorMjAxOC0wOS0wNyAgRnJlZGVyaWMgV2FuZyAgPGZ3YW5nQGlnYWxpYS5jb20+
CisKKyAgICAgICAgUmVmYWN0b3IgZmlsdGVyIGxpc3QgY2hlY2tpbmcgY29kZQorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1MDg3CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBiZWhh
dmlvciB1bmNoYW5nZWQuCisKKyAgICAgICAgKiBhbmltYXRpb24vS2V5ZnJhbWVFZmZlY3RSZWFk
T25seS5oOiBBZGQgbWlzc2luZyBmb3J3YXJkLWRlY2xhcmF0aW9uIEZpbHRlck9wZXJhdGlvbnMu
CisKIDIwMTgtMDktMDcgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAg
ICBbTEZDXSBSZXBsYWNlICJjb21wdXRlZCIgdmFsdWUgd2l0aCAidXNlZCIgdmFsdWUgdG8gbWF0
Y2ggc3BlYyBsYW5ndWFnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0tl
eWZyYW1lRWZmZWN0UmVhZE9ubHkuaCBiL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9LZXlmcmFt
ZUVmZmVjdFJlYWRPbmx5LmgKaW5kZXggZWVhYjAxNDcwYzcuLjBmZWIxOWRlODgxIDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vS2V5ZnJhbWVFZmZlY3RSZWFkT25seS5oCisr
KyBiL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9LZXlmcmFtZUVmZmVjdFJlYWRPbmx5LmgKQEAg
LTQwLDYgKzQwLDcgQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgRWxlbWVudDsKK2Ns
YXNzIEZpbHRlck9wZXJhdGlvbnM7CiAKIGNsYXNzIEtleWZyYW1lRWZmZWN0UmVhZE9ubHkgOiBw
dWJsaWMgQW5pbWF0aW9uRWZmZWN0UmVhZE9ubHkKICAgICAsIHB1YmxpYyBDU1NQcm9wZXJ0eUJs
ZW5kaW5nQ2xpZW50IHsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>349392</attachid>
            <date>2018-09-11 05:42:51 -0700</date>
            <delta_ts>2018-09-13 03:55:26 -0700</delta_ts>
            <desc>Another follow-up fix of potential build failure</desc>
            <filename>185087.patch</filename>
            <type>text/plain</type>
            <size>1006</size>
            <attacher name="Frédéric Wang Nélar">fred.wang</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBlNjBhYmVlNDE4OS4uY2FmNmMyYWZhN2IgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEg
KzEsMTIgQEAKKzIwMTgtMDktMTEgIEZyZWRlcmljIFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgor
CisgICAgICAgIFJlZmFjdG9yIGZpbHRlciBsaXN0IGNoZWNraW5nIGNvZGUKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTA4NworCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVoYXZp
b3IgdW5jaGFuZ2VkLgorCisgICAgICAgICogcGFnZS9hbmltYXRpb24vS2V5ZnJhbWVBbmltYXRp
b24uaDogQWRkIG1pc3NpbmcgZm9yd2FyZC1kZWNsYXJhdGlvbiBGaWx0ZXJPcGVyYXRpb25zLgor
CiA9PSBSb2xsZWQgb3ZlciB0byBDaGFuZ2VMb2ctMjAxOC0wOS0xMSA9PQpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vS2V5ZnJhbWVBbmltYXRpb24uaCBiL1NvdXJj
ZS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0tleWZyYW1lQW5pbWF0aW9uLmgKaW5kZXggNDZmYjdk
MjVmM2QuLjgzN2RkMzk3MTc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2FuaW1h
dGlvbi9LZXlmcmFtZUFuaW1hdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvYW5pbWF0
aW9uL0tleWZyYW1lQW5pbWF0aW9uLmgKQEAgLTM0LDYgKzM0LDcgQEAKIAogbmFtZXNwYWNlIFdl
YkNvcmUgewogCitjbGFzcyBGaWx0ZXJPcGVyYXRpb25zOwogY2xhc3MgUmVuZGVyU3R5bGU7CiAK
IC8vIEEgS2V5ZnJhbWVBbmltYXRpb24gdHJhY2tzIHRoZSBzdGF0ZSBvZiBhbiBleHBsaWNpdCBh
bmltYXRpb24gZm9yIGEgc2luZ2xlIFJlbmRlckVsZW1lbnQuCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>349552</attachid>
            <date>2018-09-12 09:03:04 -0700</date>
            <delta_ts>2018-09-12 11:30:27 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-185087-20180912180302.patch</filename>
            <type>text/plain</type>
            <size>3514</size>
            <attacher name="Frédéric Wang Nélar">fred.wang</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1OTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWVjODMzYWNmZDUxOTY3
N2FiZDc2YWE4ZjAwMGUyNjUzOTBlNjNkYi4uNzA5OTYzM2VhZWU3MTU3NmQwYTM5ZWE5ZTc2ZjNl
MTFlOTliNDYxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA5LTEyICBGcmVk
ZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KKworICAgICAgICBNb3ZlIEZvbnREZXNjcmlw
dGlvbktleTo6Y29tcHV0ZUhhc2ggaW50byB0aGUgY29ycmVzcG9uZGluZyBpbXBsZW1lbnRhdGlv
biBmaWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x
ODUwODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG
b250RGVzY3JpcHRpb25LZXk6OmNvbXB1dGVIYXNoIHJlcXVpcmVzIGltcGxpY2l0IGluc3RhbnRp
YXRpb24gb2YgdGhlIEZvbnRUYWdnZWRTZXR0aW5ncyB0ZW1wbGF0ZS4gU2luY2UgdGhlCisgICAg
ICAgIGZ1bmN0aW9uIGlzIGltcGxlbWVudGVkIGRpcmVjdGx5IGluIHRoZSBoZWFkZXIsIHRoaXMg
aW5zdGFudGlhdGlvbiBtYXkgaGFwcGVuIGJlZm9yZSBGb250VGFnZ2VkU2V0dGluZ3M6Omhhc2go
KSBpcworICAgICAgICBhY3R1YWxseSBzcGVjaWFsaXplZCBpbiBGb250RmVhdHVyZVNldHRpbmdz
LmNwcCBvciBGb250VmFyaWF0aW9uU2V0dGluZ3MuY3BwLiBUbyBhdm9pZCBjb21waWxlciBlcnJv
cnMsIHRoZQorICAgICAgICBpbXBsZW1lbnRhdGlvbiBpcyBtb3ZlZCBpbnRvIEZvbnRDYWNoZS5j
cHAuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBiZWhhdmlvciB1bmNoYW5nZWQuCisKKyAgICAg
ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FjaGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6
Rm9udERlc2NyaXB0aW9uS2V5Ojpjb21wdXRlSGFzaCBjb25zdCk6CisgICAgICAgICogcGxhdGZv
cm0vZ3JhcGhpY3MvRm9udENhY2hlLmg6CisgICAgICAgIChXZWJDb3JlOjpGb250RGVzY3JpcHRp
b25LZXk6OmNvbXB1dGVIYXNoIGNvbnN0KTogRGVsZXRlZC4KKwogMjAxOC0wOS0xMiAgUGFibG8g
U2FhdmVkcmEgIDxwc2FhdmVkcmFAaWdhbGlhLmNvbT4KIAogICAgICAgICBMaW5raW5nIGFnYWlu
c3QgbGliV1BFV2ViS2l0LTAuMS5zbyBpcyBub3QgcG9zaWJsZSB3aGVuIFdQRSBpcyBidWlsZCB3
aXRoIEVOQUJMRV9WSURFTz1PRkYgYW5kIEVOQUJMRV9XRUJfQVVESU89T0ZGCmRpZmYgLS1naXQg
YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FjaGUuY3BwIGIvU291cmNl
L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhY2hlLmNwcAppbmRleCA1ODc3M2JlNzNj
MjZjMzc5MTM5ODA5MGJkNTQwYjNhOTIwYWQ1NmJmLi4yZGRkM2NlODE5YmRkY2YxYzI0YWM2MmY3
NmExMzVlNmVkMjIzODZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw
aGljcy9Gb250Q2FjaGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz
L0ZvbnRDYWNoZS5jcHAKQEAgLTQ4OCw0ICs0ODgsMjEgQEAgUmVmUHRyPEZvbnQ+IEZvbnRDYWNo
ZTo6c2ltaWxhckZvbnQoY29uc3QgRm9udERlc2NyaXB0aW9uJiwgY29uc3QgQXRvbWljU3RyaW5n
JikKIH0KICNlbmRpZgogCit1bnNpZ25lZCBGb250RGVzY3JpcHRpb25LZXk6OmNvbXB1dGVIYXNo
KCkgY29uc3QKK3sKKyAgICBJbnRlZ2VySGFzaGVyIGhhc2hlcjsKKyAgICBoYXNoZXIuYWRkKG1f
c2l6ZSk7CisgICAgaGFzaGVyLmFkZChtX2ZvbnRTZWxlY3Rpb25SZXF1ZXN0LndlaWdodCk7Cisg
ICAgaGFzaGVyLmFkZChtX2ZvbnRTZWxlY3Rpb25SZXF1ZXN0LndpZHRoKTsKKyAgICBoYXNoZXIu
YWRkKG1fZm9udFNlbGVjdGlvblJlcXVlc3Quc2xvcGUudmFsdWVfb3Iobm9ybWFsSXRhbGljVmFs
dWUoKSkpOworICAgIGhhc2hlci5hZGQobV9sb2NhbGUuZXhpc3RpbmdIYXNoKCkpOworICAgIGZv
ciAodW5zaWduZWQgZmxhZ0l0ZW0gOiBtX2ZsYWdzKQorICAgICAgICBoYXNoZXIuYWRkKGZsYWdJ
dGVtKTsKKyAgICBoYXNoZXIuYWRkKG1fZmVhdHVyZVNldHRpbmdzLmhhc2goKSk7CisjaWYgRU5B
QkxFKFZBUklBVElPTl9GT05UUykKKyAgICBoYXNoZXIuYWRkKG1fdmFyaWF0aW9uU2V0dGluZ3Mu
aGFzaCgpKTsKKyNlbmRpZgorICAgIHJldHVybiBoYXNoZXIuaGFzaCgpOworfQorCiB9IC8vIG5h
bWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw
aGljcy9Gb250Q2FjaGUuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRD
YWNoZS5oCmluZGV4IDg1NjRkYjljMWUwZjI1ZTA4NDY3ZjQ4YTg0MGEyZWExYjE4Y2MxY2EuLmMz
NTRhOTAxMTY3ZWMzYmIwNDQwNzI5NjQ0OGY0ZDRkNTIzODY5OWUgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRDYWNoZS5oCisrKyBiL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRDYWNoZS5oCkBAIC0xMDQsMjIgKzEwNCw3IEBAIHN0
cnVjdCBGb250RGVzY3JpcHRpb25LZXkgewogCiAgICAgYm9vbCBpc0hhc2hUYWJsZURlbGV0ZWRW
YWx1ZSgpIGNvbnN0IHsgcmV0dXJuIG1fc2l6ZSA9PSBjSGFzaFRhYmxlRGVsZXRlZFNpemU7IH0K
IAotICAgIGlubGluZSB1bnNpZ25lZCBjb21wdXRlSGFzaCgpIGNvbnN0Ci0gICAgewotICAgICAg
ICBJbnRlZ2VySGFzaGVyIGhhc2hlcjsKLSAgICAgICAgaGFzaGVyLmFkZChtX3NpemUpOwotICAg
ICAgICBoYXNoZXIuYWRkKG1fZm9udFNlbGVjdGlvblJlcXVlc3Qud2VpZ2h0KTsKLSAgICAgICAg
aGFzaGVyLmFkZChtX2ZvbnRTZWxlY3Rpb25SZXF1ZXN0LndpZHRoKTsKLSAgICAgICAgaGFzaGVy
LmFkZChtX2ZvbnRTZWxlY3Rpb25SZXF1ZXN0LnNsb3BlLnZhbHVlX29yKG5vcm1hbEl0YWxpY1Zh
bHVlKCkpKTsKLSAgICAgICAgaGFzaGVyLmFkZChtX2xvY2FsZS5leGlzdGluZ0hhc2goKSk7Ci0g
ICAgICAgIGZvciAodW5zaWduZWQgZmxhZ0l0ZW0gOiBtX2ZsYWdzKQotICAgICAgICAgICAgaGFz
aGVyLmFkZChmbGFnSXRlbSk7Ci0gICAgICAgIGhhc2hlci5hZGQobV9mZWF0dXJlU2V0dGluZ3Mu
aGFzaCgpKTsKLSNpZiBFTkFCTEUoVkFSSUFUSU9OX0ZPTlRTKQotICAgICAgICBoYXNoZXIuYWRk
KG1fdmFyaWF0aW9uU2V0dGluZ3MuaGFzaCgpKTsKLSNlbmRpZgotICAgICAgICByZXR1cm4gaGFz
aGVyLmhhc2goKTsKLSAgICB9CisgICAgdW5zaWduZWQgY29tcHV0ZUhhc2goKSBjb25zdDsKIAog
cHJpdmF0ZToKICAgICBzdGF0aWMgc3RkOjphcnJheTx1bnNpZ25lZCwgMj4gbWFrZUZsYWdzS2V5
KGNvbnN0IEZvbnREZXNjcmlwdGlvbiYgZGVzY3JpcHRpb24pCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>