184580 2018-04-13 00:07:23 -0700 [Web Animations] Fix animations/stop-animation-on-suspend.html 2020-02-10 09:11:19 -0800 1 1 1 Unclassified WebKit Animations WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=49182 InRadar P2 Normal --- 1 graouts graouts ap commit-queue dino graouts simon.fraser webkit-bug-importer oldest_to_newest 1414325 0 graouts 2018-04-13 00:07:23 -0700 The test at animations/stop-animation-on-suspend.html fails reliably on iOS with the new animation engine. 1414326 1 webkit-bug-importer 2018-04-13 00:07:40 -0700 <rdar://problem/39406014> 1414426 2 graouts 2018-04-13 09:08:23 -0700 This isn't specific to iOS actually, it also fails on Mac but it was already marked as a flaky Failure for that platform so the error was not reported. 1616681 3 graouts 2020-02-09 10:19:52 -0800 This test has always been problematic, see https://bugs.webkit.org/show_bug.cgi?id=49182. 1616813 4 graouts 2020-02-10 02:38:36 -0800 I believe the expectations of this test to be incorrect. The test animates a transform from 0 to 400px across 400ms with a linear timing function. The test suspends animations from 100ms to 300ms with timers, and polls animations at 200ms and 400ms. At 200ms, it expects a value of 100px, which is correct since the animation is suspended and so the value at 100ms (when it was suspended) is expected. However, the test expected the value at 400ms to be 200px, which leads me to think this test assumes that animations, when resumed, account for the time suspended and subtracts it from the page time. This is incorrect: when animations resume, they resume at the current time, no matter how long they were suspended. So the expected value should be 400px. I will file a patch with this change in expectation. 1616814 5 390238 graouts 2020-02-10 02:41:33 -0800 Created attachment 390238 Patch 1616887 6 390238 commit-queue 2020-02-10 09:11:18 -0800 Comment on attachment 390238 Patch Clearing flags on attachment: 390238 Committed r256177: <https://trac.webkit.org/changeset/256177> 1616888 7 commit-queue 2020-02-10 09:11:19 -0800 All reviewed patches have been landed. Closing bug. 390238 2020-02-10 02:41:33 -0800 2020-02-10 09:11:18 -0800 Patch bug-184580-20200210114132.patch text/plain 3945 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MTAwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTM3YmRjZGYwZjgzMzZhY2I0ZWZk ODIyYThiYzA1ZTEwODk4ODNlMy4uMjYwMDcxZDBkZTgyZGJjYjFlZTlmY2MzYjliOGJmMjI0Mjkx NTM0ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIwLTAyLTEwICBBbnRvaW5lIFF1aW50ICA8 Z3Jhb3V0c0B3ZWJraXQub3JnPgorCisgICAgICAgIFtXZWIgQW5pbWF0aW9uc10gRml4IGFuaW1h dGlvbnMvc3RvcC1hbmltYXRpb24tb24tc3VzcGVuZC5odG1sCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ1ODAKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzM5NDA2MDE0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZSBleHBlY3RhdGlvbnMgb2YgdGhpcyB0ZXN0IHdlcmUgaW5jb3JyZWN0LiBUaGUg dGVzdCBhbmltYXRlcyBhIHRyYW5zZm9ybSBmcm9tIDAgdG8gNDAwcHggYWNyb3NzIDQwMG1zIHdp dGggYSBsaW5lYXIgdGltaW5nIGZ1bmN0aW9uLiBUaGUgdGVzdCBzdXNwZW5kcworICAgICAgICBh bmltYXRpb25zIGZyb20gMTAwbXMgdG8gMzAwbXMgd2l0aCB0aW1lcnMsIGFuZCBwb2xscyBhbmlt YXRpb25zIGF0IDIwMG1zIGFuZCA0MDBtcy4gQXQgMjAwbXMsIGl0IGV4cGVjdHMgYSB2YWx1ZSBv ZiAxMDBweCwgd2hpY2ggaXMgY29ycmVjdCBzaW5jZSB0aGUgYW5pbWF0aW9uCisgICAgICAgIGlz IHN1c3BlbmRlZCBhbmQgc28gdGhlIHZhbHVlIGF0IDEwMG1zICh3aGVuIGl0IHdhcyBzdXNwZW5k ZWQpIGlzIGV4cGVjdGVkLgorCisgICAgICAgIEhvd2V2ZXIsIHRoZSB0ZXN0IGV4cGVjdGVkIHRo ZSB2YWx1ZSBhdCA0MDBtcyB0byBiZSAyMDBweCwgd2hpY2ggbGVhZHMgbWUgdG8gdGhpbmsgdGhp cyB0ZXN0IGFzc3VtZXMgdGhhdCBhbmltYXRpb25zLCB3aGVuIHJlc3VtZWQsIGFjY291bnQgZm9y IHRoZSB0aW1lIHN1c3BlbmRlZAorICAgICAgICBhbmQgc3VidHJhY3RzIGl0IGZyb20gdGhlIHBh Z2UgdGltZS4gVGhpcyBpcyBpbmNvcnJlY3Q6IHdoZW4gYW5pbWF0aW9ucyByZXN1bWUsIHRoZXkg cmVzdW1lIGF0IHRoZSBjdXJyZW50IHRpbWUsIG5vIG1hdHRlciBob3cgbG9uZyB0aGV5IHdlcmUg c3VzcGVuZGVkLiBTbyB0aGUgZXhwZWN0ZWQKKyAgICAgICAgdmFsdWUgc2hvdWxkIGJlIDQwMHB4 LgorCisgICAgICAgICogYW5pbWF0aW9ucy9zdG9wLWFuaW1hdGlvbi1vbi1zdXNwZW5kLWV4cGVj dGVkLnR4dDoKKyAgICAgICAgKiBhbmltYXRpb25zL3N0b3AtYW5pbWF0aW9uLW9uLXN1c3BlbmQu aHRtbDoKKwogMjAyMC0wMi0wOCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv bT4KIAogICAgICAgICBFeHRlbnQgb2YgYSBjb21wb3NpdGVkIGFuaW1hdGlvbiBzaG91bGQgbm90 IGluY2x1ZGUgdGhlIHVudHJhbnNmb3JtZWQgcG9zaXRpb24KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2FuaW1hdGlvbnMvc3RvcC1hbmltYXRpb24tb24tc3VzcGVuZC1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9hbmltYXRpb25zL3N0b3AtYW5pbWF0aW9uLW9uLXN1c3BlbmQtZXhwZWN0ZWQu dHh0CmluZGV4IDc3MDBjODk3MzE1YTFhZGY0ZWNjYjI3YzFmZDNkMzI2ZjcxOGExZTkuLmFmNTUx ZTgyYTdlMmUwMzE4OTg3M2NiYTY4NGNlOTUwMWMzZDg2Y2YgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2FuaW1hdGlvbnMvc3RvcC1hbmltYXRpb24tb24tc3VzcGVuZC1leHBlY3RlZC50eHQKKysr IGIvTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9zdG9wLWFuaW1hdGlvbi1vbi1zdXNwZW5kLWV4cGVj dGVkLnR4dApAQCAtMSw2ICsxLDYgQEAKIAogUEFTUyAtICJ3ZWJraXRUcmFuc2Zvcm0iIHByb3Bl cnR5IGZvciAiYm94IiBlbGVtZW50IGF0IDAuMnMgc2F3IHNvbWV0aGluZyBjbG9zZSB0bzogMSww LDAsMSwxMDAsMAogUEFTUyAtICJ3ZWJraXRUcmFuc2Zvcm0iIHByb3BlcnR5IGZvciAiaWZyYW1l LnN1YmZyYW1lLWJveCIgZWxlbWVudCBhdCAwLjJzIHNhdyBzb21ldGhpbmcgY2xvc2UgdG86IDEs MCwwLDEsMTAwLDAKLVBBU1MgLSAid2Via2l0VHJhbnNmb3JtIiBwcm9wZXJ0eSBmb3IgImJveCIg ZWxlbWVudCBhdCAwLjRzIHNhdyBzb21ldGhpbmcgY2xvc2UgdG86IDEsMCwwLDEsMjAwLDAKLVBB U1MgLSAid2Via2l0VHJhbnNmb3JtIiBwcm9wZXJ0eSBmb3IgImlmcmFtZS5zdWJmcmFtZS1ib3gi IGVsZW1lbnQgYXQgMC40cyBzYXcgc29tZXRoaW5nIGNsb3NlIHRvOiAxLDAsMCwxLDIwMCwwCitQ QVNTIC0gIndlYmtpdFRyYW5zZm9ybSIgcHJvcGVydHkgZm9yICJib3giIGVsZW1lbnQgYXQgMC40 cyBzYXcgc29tZXRoaW5nIGNsb3NlIHRvOiAxLDAsMCwxLDQwMCwwCitQQVNTIC0gIndlYmtpdFRy YW5zZm9ybSIgcHJvcGVydHkgZm9yICJpZnJhbWUuc3ViZnJhbWUtYm94IiBlbGVtZW50IGF0IDAu NHMgc2F3IHNvbWV0aGluZyBjbG9zZSB0bzogMSwwLDAsMSw0MDAsMAogCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9hbmltYXRpb25zL3N0b3AtYW5pbWF0aW9uLW9uLXN1c3BlbmQuaHRtbCBiL0xh eW91dFRlc3RzL2FuaW1hdGlvbnMvc3RvcC1hbmltYXRpb24tb24tc3VzcGVuZC5odG1sCmluZGV4 IGY3ODczODRjOWUwZWZjNWRhODVhMWYxZTkzMzEyMmJlNmFmYTA5Y2MuLmFkYmYwODliZTNlMDI2 MDJiNjQ5MzYyZWM5NWRiY2E2YjY3MjM1OTAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2FuaW1h dGlvbnMvc3RvcC1hbmltYXRpb24tb24tc3VzcGVuZC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Fu aW1hdGlvbnMvc3RvcC1hbmltYXRpb24tb24tc3VzcGVuZC5odG1sCkBAIC0zMSwxMSArMzEsMTQg QEAKICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIGNoYXJzZXQ9InV0Zi04Ij4KICAg CiAgICAgY29uc3QgZXhwZWN0ZWRWYWx1ZXMgPSBbCisgICAgICAvLyBBbmltYXRpb25zIGFyZSBw YXVzZWQgZnJvbSAxMDBtcyB0byAzMDBtcyBieSB0aW1lcnMuIFdlIHBvbGwgYXQgMjAwbXMgYW5k IGV4cGVjdCB0aGUgc2FtZSB2YWx1ZSBhcyBhdCAxMDBtcyBzaW5jZSB3ZSdyZSBwb2xsaW5nCisg ICAgICAvLyB3aGlsZSBwYXVzZWQgYXQgMTAwbXMuIFRoZW4sIHdlIHBvbGwgYWdhaW4gYXQgNDAw bXMgYW5kIGV4cGVjdCB2YWx1ZSBhcyBpZiB0aGUgYW5pbWF0aW9uIGhhZG4ndCBiZWVuIHN1c3Bl bmRlZCBzaW5jZSBpdCBoYXMgcmVzdW1lZAorICAgICAgLy8gYnkgdGhlbi4KICAgICAgIC8vIFth bmltYXRpb24tbmFtZSwgdGltZSwgZWxlbWVudC1pZCwgcHJvcGVydHksIGV4cGVjdGVkLXZhbHVl LCB0b2xlcmFuY2VdCiAgICAgICBbIm1vdmUiLCAwLjIsICJib3giLCAid2Via2l0VHJhbnNmb3Jt IiwgWzEsMCwwLDEsIDEwMCwgMF0sIDMwXSwKICAgICAgIFsibW92ZSIsIDAuMiwgImlmcmFtZS5z dWJmcmFtZS1ib3giLCAid2Via2l0VHJhbnNmb3JtIiwgWzEsMCwwLDEsIDEwMCwgMF0sIDMwXSwK LSAgICAgIFsibW92ZSIsIDAuNCwgImJveCIsICJ3ZWJraXRUcmFuc2Zvcm0iLCBbMSwwLDAsMSwg MjAwLCAwXSwgMzBdLAotICAgICAgWyJtb3ZlIiwgMC40LCAiaWZyYW1lLnN1YmZyYW1lLWJveCIs ICJ3ZWJraXRUcmFuc2Zvcm0iLCBbMSwwLDAsMSwgMjAwLCAwXSwgMzBdLAorICAgICAgWyJtb3Zl IiwgMC40LCAiYm94IiwgIndlYmtpdFRyYW5zZm9ybSIsIFsxLDAsMCwxLCA0MDAsIDBdLCAzMF0s CisgICAgICBbIm1vdmUiLCAwLjQsICJpZnJhbWUuc3ViZnJhbWUtYm94IiwgIndlYmtpdFRyYW5z Zm9ybSIsIFsxLDAsMCwxLCA0MDAsIDBdLCAzMF0sCiAgICAgXTsKICAgICAKICAgICBmdW5jdGlv biBzdXNwZW5kKCkK