184525 2018-04-11 19:40:59 -0700 [Win][WebKit] Implement InjectedBundleWin.cpp 2018-04-18 00:35:24 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 174003 1 fujii fujii achristensen annulen bfulgham pvollan rniwa webkit-bug-importer oldest_to_newest 1413906 0 fujii 2018-04-11 19:40:59 -0700 [Win][WebKit] Implement InjectedBundleWin.cpp 1413911 1 337770 fujii 2018-04-11 19:53:14 -0700 Created attachment 337770 Patch 1414760 2 337770 annulen 2018-04-16 06:38:36 -0700 Comment on attachment 337770 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337770&action=review > Source/WebKit/WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:36 > + HMODULE lib = ::LoadLibrary(m_path.charactersWithNullTermination().data()); LoadLibrary needs wchar_t, not UChar, so you should use WTF::stringToNullTerminatedWChar here 1415021 3 338076 fujii 2018-04-16 21:01:20 -0700 Created attachment 338076 Patch Thank you for the review. Addressed the review feedback. 1415095 4 338076 annulen 2018-04-17 04:14:31 -0700 Comment on attachment 338076 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338076&action=review > Source/WebKit/WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:45 > + (*proc)(toAPI(this), toAPI(initializationUserData)); You can write it simply as proc(toAPI(this), toAPI(initializationUserData)); 1415420 5 338177 fujii 2018-04-17 18:40:46 -0700 Created attachment 338177 Patch to land Thank you. Addressed the review feedback. 1415498 6 fujii 2018-04-18 00:34:07 -0700 Committed r230754: <https://trac.webkit.org/changeset/230754> 1415499 7 webkit-bug-importer 2018-04-18 00:35:24 -0700 <rdar://problem/39520256> 337770 2018-04-11 19:53:14 -0700 2018-04-16 21:01:17 -0700 Patch bug-184525-20180412115313.patch text/plain 1950 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI0YzBkMmYwMzhiMGI0Mzdl Mzk3ODBjOTc5NmIwMmI3MDUxNTliNTYuLjM4NzZlMTA0OTg2Zjg4ZDMxYTM2NzNiMjMwN2NiOWVi ZjVhNTQ1MGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDQtMTEgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl1bV2ViS2l0 XSBJbXBsZW1lbnQgSW5qZWN0ZWRCdW5kbGVXaW4uY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ1MjUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvd2lu L0luamVjdGVkQnVuZGxlV2luLmNwcDoKKyAgICAgICAgKFdlYktpdDo6SW5qZWN0ZWRCdW5kbGU6 OmluaXRpYWxpemUpOgorCiAyMDE4LTA0LTExICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1 amlpQHNvbnkuY29tPgogCiAgICAgICAgIFtjdXJsXVtXZWJLaXRdIEltcGxlbWVudCBOZXR3b3Jr RGF0YVRhc2tDdXJsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0 ZWRCdW5kbGUvd2luL0luamVjdGVkQnVuZGxlV2luLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9JbmplY3RlZEJ1bmRsZS93aW4vSW5qZWN0ZWRCdW5kbGVXaW4uY3BwCmluZGV4IGQyNWNi ZmI2MTU4MzUyODg3OWRkMjk1OWE3NGVkYzM2MmMwMmE0YjIuLjY3OGMwNzI4M2E5MTYwNTdiYmY0 MGQ0NWYzZjFlN2VlNTA0ODk5MzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9JbmplY3RlZEJ1bmRsZS93aW4vSW5qZWN0ZWRCdW5kbGVXaW4uY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS93aW4vSW5qZWN0ZWRCdW5kbGVXaW4uY3Bw CkBAIC0yOCwxOCArMjgsMjEgQEAKIAogI2luY2x1ZGUgIldLQnVuZGxlQVBJQ2FzdC5oIgogI2lu Y2x1ZGUgIldLQnVuZGxlSW5pdGlhbGl6ZS5oIgotI2luY2x1ZGUgPFdlYkNvcmUvRmlsZVN5c3Rl bS5oPgotI2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KLQotdXNpbmcgbmFtZXNwYWNlIFdl YkNvcmU7CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCi10eXBlZGVmIHZvaWQgKCpCdW5kbGVJbml0 aWFsaXplRnVuY3Rpb24pKFdLQnVuZGxlUmVmLCBXS1R5cGVSZWYpOwotCiBib29sIEluamVjdGVk QnVuZGxlOjppbml0aWFsaXplKGNvbnN0IFdlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMmLCBB UEk6Ok9iamVjdCogaW5pdGlhbGl6YXRpb25Vc2VyRGF0YSkKIHsKLSAgICByZXR1cm4gZmFsc2U7 CisgICAgSE1PRFVMRSBsaWIgPSA6OkxvYWRMaWJyYXJ5KG1fcGF0aC5jaGFyYWN0ZXJzV2l0aE51 bGxUZXJtaW5hdGlvbigpLmRhdGEoKSk7CisgICAgaWYgKCFsaWIpCisgICAgICAgIHJldHVybiBm YWxzZTsKKworICAgIFdLQnVuZGxlSW5pdGlhbGl6ZUZ1bmN0aW9uUHRyIHByb2MgPSByZWludGVy cHJldF9jYXN0PFdLQnVuZGxlSW5pdGlhbGl6ZUZ1bmN0aW9uUHRyPig6OkdldFByb2NBZGRyZXNz KGxpYiwgIldLQnVuZGxlSW5pdGlhbGl6ZSIpKTsKKyAgICBpZiAoIXByb2MpCisgICAgICAgIHJl dHVybiBmYWxzZTsKKworICAgICgqcHJvYykodG9BUEkodGhpcyksIHRvQVBJKGluaXRpYWxpemF0 aW9uVXNlckRhdGEpKTsKKyAgICByZXR1cm4gdHJ1ZTsKIH0KIAogdm9pZCBJbmplY3RlZEJ1bmRs ZTo6c2V0QnVuZGxlUGFyYW1ldGVyKFdURjo6U3RyaW5nIGNvbnN0JiwgSVBDOjpEYXRhUmVmZXJl bmNlIGNvbnN0JikK 338076 2018-04-16 21:01:20 -0700 2018-04-17 18:40:43 -0700 Patch bug-184525-20180417130118.patch text/plain 1970 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNjk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUyMzQzMWY0NDBlNmM2YTBl MDlmMDgzNTY2YTQ5OGI2ZDdiZGZkM2QuLjc4ZDljYWYyM2ZlZTZhOGE1NjI5YTEyZDFlZmViZjRh MDdjYzJhNzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDQtMTYgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl1bV2ViS2l0 XSBJbXBsZW1lbnQgSW5qZWN0ZWRCdW5kbGVXaW4uY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ1MjUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvd2lu L0luamVjdGVkQnVuZGxlV2luLmNwcDoKKyAgICAgICAgKFdlYktpdDo6SW5qZWN0ZWRCdW5kbGU6 OmluaXRpYWxpemUpOgorCiAyMDE4LTA0LTE2ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNv bT4KIAogICAgICAgICBbaU9TXSBFbmFibGUgV0tQREZWaWV3IGJ5IGRlZmF1bHQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS93aW4vSW5qZWN0ZWRC dW5kbGVXaW4uY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL3dp bi9JbmplY3RlZEJ1bmRsZVdpbi5jcHAKaW5kZXggZDI1Y2JmYjYxNTgzNTI4ODc5ZGQyOTU5YTc0 ZWRjMzYyYzAyYTRiMi4uNWE4ZTZiNWU0ZWVhZGVkMTkzM2M0MjhmZjU3NjRmY2I5ZDc0NmVhYSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL3dpbi9J bmplY3RlZEJ1bmRsZVdpbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVj dGVkQnVuZGxlL3dpbi9JbmplY3RlZEJ1bmRsZVdpbi5jcHAKQEAgLTI4LDE4ICsyOCwyMiBAQAog CiAjaW5jbHVkZSAiV0tCdW5kbGVBUElDYXN0LmgiCiAjaW5jbHVkZSAiV0tCdW5kbGVJbml0aWFs aXplLmgiCi0jaW5jbHVkZSA8V2ViQ29yZS9GaWxlU3lzdGVtLmg+Ci0jaW5jbHVkZSA8d3RmL3Rl eHQvQ1N0cmluZy5oPgotCi11c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKKyNpbmNsdWRlIDx3dGYv dGV4dC93aW4vV0NoYXJTdHJpbmdFeHRyYXMuaD4KIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKLXR5 cGVkZWYgdm9pZCAoKkJ1bmRsZUluaXRpYWxpemVGdW5jdGlvbikoV0tCdW5kbGVSZWYsIFdLVHlw ZVJlZik7Ci0KIGJvb2wgSW5qZWN0ZWRCdW5kbGU6OmluaXRpYWxpemUoY29uc3QgV2ViUHJvY2Vz c0NyZWF0aW9uUGFyYW1ldGVycyYsIEFQSTo6T2JqZWN0KiBpbml0aWFsaXphdGlvblVzZXJEYXRh KQogewotICAgIHJldHVybiBmYWxzZTsKKyAgICBITU9EVUxFIGxpYiA9IDo6TG9hZExpYnJhcnko c3RyaW5nVG9OdWxsVGVybWluYXRlZFdDaGFyKG1fcGF0aCkuZGF0YSgpKTsKKyAgICBpZiAoIWxp YikKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgV0tCdW5kbGVJbml0aWFsaXplRnVuY3Rp b25QdHIgcHJvYyA9IHJlaW50ZXJwcmV0X2Nhc3Q8V0tCdW5kbGVJbml0aWFsaXplRnVuY3Rpb25Q dHI+KDo6R2V0UHJvY0FkZHJlc3MobGliLCAiV0tCdW5kbGVJbml0aWFsaXplIikpOworICAgIGlm ICghcHJvYykKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgKCpwcm9jKSh0b0FQSSh0aGlz KSwgdG9BUEkoaW5pdGlhbGl6YXRpb25Vc2VyRGF0YSkpOworICAgIHJldHVybiB0cnVlOwogfQog CiB2b2lkIEluamVjdGVkQnVuZGxlOjpzZXRCdW5kbGVQYXJhbWV0ZXIoV1RGOjpTdHJpbmcgY29u c3QmLCBJUEM6OkRhdGFSZWZlcmVuY2UgY29uc3QmKQo= 338177 2018-04-17 18:40:46 -0700 2018-04-17 18:40:58 -0700 Patch to land bug-184525-20180418104044.patch text/plain 1980 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ1NWYyZTk3YTQ4ODVhOWJl ZmU1NTg0NmYyYTBkYTIyYWE5ODM1NTEuLjdiYmY1ODk2NjY0MzhlYjA0OGVjYTBkMTA0ZjQ0OWRj NTZjYjkwNTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDQtMTcgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl1bV2ViS2l0 XSBJbXBsZW1lbnQgSW5qZWN0ZWRCdW5kbGVXaW4uY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ1MjUKKworICAgICAgICBSZXZpZXdlZCBieSBL b25zdGFudGluIFRva2FyZXYuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxl L3dpbi9JbmplY3RlZEJ1bmRsZVdpbi5jcHA6CisgICAgICAgIChXZWJLaXQ6OkluamVjdGVkQnVu ZGxlOjppbml0aWFsaXplKToKKwogMjAxOC0wNC0xNiAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9y aS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBbV2luQ2Fpcm9dIEFkZCBXS1ZpZXcgYW5kIFdL QVBJCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUv d2luL0luamVjdGVkQnVuZGxlV2luLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9Jbmpl Y3RlZEJ1bmRsZS93aW4vSW5qZWN0ZWRCdW5kbGVXaW4uY3BwCmluZGV4IGQyNWNiZmI2MTU4MzUy ODg3OWRkMjk1OWE3NGVkYzM2MmMwMmE0YjIuLmY5ODdlYjdhMzEyY2E2MjI1Yzg1ZTlhYjFlNzll ZjA1ZTJkYmY2MjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3Rl ZEJ1bmRsZS93aW4vSW5qZWN0ZWRCdW5kbGVXaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS93aW4vSW5qZWN0ZWRCdW5kbGVXaW4uY3BwCkBAIC0yOCwx OCArMjgsMjIgQEAKIAogI2luY2x1ZGUgIldLQnVuZGxlQVBJQ2FzdC5oIgogI2luY2x1ZGUgIldL QnVuZGxlSW5pdGlhbGl6ZS5oIgotI2luY2x1ZGUgPFdlYkNvcmUvRmlsZVN5c3RlbS5oPgotI2lu Y2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KLQotdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7Cisj aW5jbHVkZSA8d3RmL3RleHQvd2luL1dDaGFyU3RyaW5nRXh0cmFzLmg+CiAKIG5hbWVzcGFjZSBX ZWJLaXQgewogCi10eXBlZGVmIHZvaWQgKCpCdW5kbGVJbml0aWFsaXplRnVuY3Rpb24pKFdLQnVu ZGxlUmVmLCBXS1R5cGVSZWYpOwotCiBib29sIEluamVjdGVkQnVuZGxlOjppbml0aWFsaXplKGNv bnN0IFdlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMmLCBBUEk6Ok9iamVjdCogaW5pdGlhbGl6 YXRpb25Vc2VyRGF0YSkKIHsKLSAgICByZXR1cm4gZmFsc2U7CisgICAgSE1PRFVMRSBsaWIgPSA6 OkxvYWRMaWJyYXJ5KHN0cmluZ1RvTnVsbFRlcm1pbmF0ZWRXQ2hhcihtX3BhdGgpLmRhdGEoKSk7 CisgICAgaWYgKCFsaWIpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIFdLQnVuZGxlSW5p dGlhbGl6ZUZ1bmN0aW9uUHRyIHByb2MgPSByZWludGVycHJldF9jYXN0PFdLQnVuZGxlSW5pdGlh bGl6ZUZ1bmN0aW9uUHRyPig6OkdldFByb2NBZGRyZXNzKGxpYiwgIldLQnVuZGxlSW5pdGlhbGl6 ZSIpKTsKKyAgICBpZiAoIXByb2MpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIHByb2Mo dG9BUEkodGhpcyksIHRvQVBJKGluaXRpYWxpemF0aW9uVXNlckRhdGEpKTsKKyAgICByZXR1cm4g dHJ1ZTsKIH0KIAogdm9pZCBJbmplY3RlZEJ1bmRsZTo6c2V0QnVuZGxlUGFyYW1ldGVyKFdURjo6 U3RyaW5nIGNvbnN0JiwgSVBDOjpEYXRhUmVmZXJlbmNlIGNvbnN0JikK