184503 2018-04-11 08:30:31 -0700 [GTK] imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method.html fails 2020-05-31 02:23:55 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya rbuis bugs-noreply mcatanzaro rbuis oldest_to_newest 1413688 0 aboya 2018-04-11 08:30:31 -0700 The following tests fail on GTK since W3C tests were updated in r230330: imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method.html imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-worker.html --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-worker-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-worker-actual.txt @@ -10,6 +10,7 @@ PASS Redirect 303 with POST PASS Redirect 303 with HEAD PASS Redirect 307 with GET -PASS Redirect 307 with POST +PASS Redirect 307 with POST (string body) +FAIL Redirect 307 with POST (blob body) assert_equals: request body expected "it's me the blob! and more blob!" but got "" PASS Redirect 307 with HEAD 1451643 1 rbuis 2018-08-20 11:25:45 -0700 This passes for GTK. Close? 1451647 2 mcatanzaro 2018-08-20 11:30:45 -0700 Not yet, there are still failure expectations in platform/gtk/TestExpectations. 1451694 3 347530 rbuis 2018-08-20 12:32:33 -0700 Created attachment 347530 Patch 1451702 4 347530 mcatanzaro 2018-08-20 12:46:08 -0700 Comment on attachment 347530 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347530&action=review All three tests are still failing on the GTK release bot: --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-actual.txt @@ -10,6 +10,7 @@ PASS Redirect 303 with POST PASS Redirect 303 with HEAD PASS Redirect 307 with GET -PASS Redirect 307 with POST +PASS Redirect 307 with POST (string body) +FAIL Redirect 307 with POST (blob body) assert_equals: request body expected "it's me the blob! and more blob!" but got "" PASS Redirect 307 with HEAD --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-worker-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-worker-actual.txt @@ -10,6 +10,7 @@ PASS Redirect 303 with POST PASS Redirect 303 with HEAD PASS Redirect 307 with GET -PASS Redirect 307 with POST +PASS Redirect 307 with POST (string body) +FAIL Redirect 307 with POST (blob body) assert_equals: request body expected "it's me the blob! and more blob!" but got "" PASS Redirect 307 with HEAD --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/fetch/api/request/request-keepalive-quota-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/fetch/api/request/request-keepalive-quota-actual.txt @@ -9,6 +9,6 @@ PASS A Keep-Alive fetch() with a body at the Quota Limit should succeed. PASS A Keep-Alive fetch() with a body over the Quota Limit should reject. PASS A Keep-Alive fetch() should return its allocated Quota upon promise resolution. -PASS A Keep-Alive fetch() should return only its allocated Quota upon promise resolution. +FAIL A Keep-Alive fetch() should return only its allocated Quota upon promise resolution. assert_unreached: Should have rejected: undefined Reached unreachable code PASS A Keep-Alive fetch() should not be allowed if the Quota is used up. I think you've perhaps made the mistake of trying to run the tests locally. The results when run locally often do not match the test bots. Generally this occurs when some dependency is missing from the JHBuild environment. Anyway, our expectations need to match what the bots are reporting. If you've been following today's conversation in our internal Matrix, we've been discussing switching the bots over to run the tests inside a flatpak environment, which should for the first time allow for consistent test results when running locally. Hopefully this can happen in the next day or two.... > LayoutTests/ChangeLog:8 > + Unskip these tests since they pass now. Well there is a difference between [ Skip ], which actually prevents the tests from running, and [ Failure ], which runs the tests and verifies that the test does not match the expected result. 1451705 5 rbuis 2018-08-20 12:55:00 -0700 (In reply to Michael Catanzaro from comment #4) > I think you've perhaps made the mistake of trying to run the tests locally. Right! I kind of missed the /home/slave/ hint. Ok I'll wait for the flatpack change. 1483536 6 356180 rbuis 2018-11-30 08:26:36 -0800 Created attachment 356180 Patch 1657762 7 rbuis 2020-05-31 02:23:55 -0700 This was fixed in the gardening process. 347530 2018-08-20 12:32:33 -0700 2018-11-30 08:26:29 -0800 Patch bug-184503-20180820213231.patch text/plain 2036 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1MDkwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOTI0MDY2YzdhNDIyNWUyZWM4YWUx YThkYWZhOWRkMzBhY2M5NWE4Ni4uMjhmMTFjZGQzNTU1Yzg5MGViOWM3OTBiYzAyMTU4MDI2ZTZj ZmM0OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA4LTIwICBSb2IgQnVpcyAgPHJidWlz QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy9mZXRjaC9hcGkvcmVkaXJlY3QvcmVkaXJlY3QtbWV0aG9kLmh0bWwuLi4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDUwMworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuc2tpcCB0aGVzZSB0ZXN0 cyBzaW5jZSB0aGV5IHBhc3Mgbm93LgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBl Y3RhdGlvbnM6CisKIDIwMTgtMDgtMjAgIEp1c3RpbiBGYW4gIDxqdXN0aW5fZmFuQGFwcGxlLmNv bT4KIAogICAgICAgICBVcGRhdGUgd2Via2l0LXdlYmdsLXRlc3QtaGFybmVzcy5qcyB0byBwcm92 aWRlIG1vcmUgaW5mbyBvbiBmYWlsaW5nIGFuZCBwYXJ0aWFsbHkgcGFzc2luZyB0ZXN0cwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBhNGRjODkwZTQ1MTYx MGEzYmNhMzBiODM0MjM3MjAwYjE3OTAxMGU0Li5jMzgxN2Q5NmM2OWU5YzFlNzgzNDk0NzNhNGU3 MDk4ZjRhZDg5OThkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4 cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9u cwpAQCAtMzQyOCwxMCArMzQyOCw2IEBAIHdlYmtpdC5vcmcvYi8xODQwODAgYW5pbWF0aW9ucy90 cmFuc2Zvcm0tbm9uLWFjY2VsZXJhdGVkLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8x ODQwODYgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWItYW5pbWF0aW9ucy9hbmlt YXRpb24tbW9kZWwvYW5pbWF0aW9uLXR5cGVzL2FjY3VtdWxhdGlvbi1wZXItcHJvcGVydHkuaHRt bCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE4NDA4NiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL3dlYi1hbmltYXRpb25zL2FuaW1hdGlvbi1tb2RlbC9hbmltYXRpb24tdHlwZXMv aW50ZXJwb2xhdGlvbi1wZXItcHJvcGVydHkuaHRtbCBbIEZhaWx1cmUgXQogCi13ZWJraXQub3Jn L2IvMTg0NTAzIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBpL3JlZGly ZWN0L3JlZGlyZWN0LW1ldGhvZC5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTg0NTAz IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBpL3JlZGlyZWN0L3JlZGly ZWN0LW1ldGhvZC13b3JrZXIuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzE4NDUwNCBp bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNoL2FwaS9yZXF1ZXN0L3JlcXVlc3Qt a2VlcGFsaXZlLXF1b3RhLmh0bWwgWyBGYWlsdXJlIF0KLQogd2Via2l0Lm9yZy9iLzE4NDc3NSBp bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL21lZGlhY2FwdHVyZS1zdHJlYW1zL01lZGlh U3RyZWFtVHJhY2stTWVkaWFFbGVtZW50LWRpc2FibGVkLWF1ZGlvLWlzLXNpbGVuY2UuaHR0cHMu aHRtbCBbIEZhaWx1cmUgXQogCiB3ZWJraXQub3JnL2IvMTg0Nzc2IGltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZm9ybXMvdGV4dGZpZWxkc2VsZWN0aW9uL3Nl bGVjdGlvbi1ub3QtYXBwbGljYXRpb24uaHRtbCBbIEZhaWx1cmUgXQo= 356180 2018-11-30 08:26:36 -0800 2018-11-30 08:26:36 -0800 Patch bug-184503-20181130172635.patch text/plain 2010 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NzM4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOTliYmIxNGNmYTM1NDQ3NGU1MDk4 MGQzMGI3MjhiMjBhMGRjMmIzZS4uMjRmYjk4ZTFjYzE1YzIwNzIyNTM0ZjBiYjNkODRhNmY3MzA3 ODc0OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTExLTMwICBSb2IgQnVpcyAgPHJidWlz QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy9mZXRjaC9hcGkvcmVkaXJlY3QvcmVkaXJlY3QtbWV0aG9kLmh0bWwuLi4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDUwMworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuc2tpcCB0aGVzZSB0ZXN0 cyBzaW5jZSB0aGV5IHBhc3Mgbm93LgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBl Y3RhdGlvbnM6CisKIDIwMTgtMTEtMzAgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4K IAogICAgICAgICBbTEZDXVtCRkNdIENvbXB1dGUgbWluL21heEhlaWdodCBtYXJnaW5zIG9ubHkg d2hlbiB0aGV5IGFyZSBuZWVkZWQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9n dGsvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0 YXRpb25zCmluZGV4IDU2ODlkODhhOGNjNTAxOGQ5ZDJhODZiZDU5MGI0OTNkMjQwMDhmNWQuLmZm ZjFlYjNmZDFjNDhkN2FhMDQ5MTQ1MjRlZTEzNGUxOTYxNzQzNzEgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCkBAIC0zNDQwLDEwICszNDQwLDYgQEAgd2Via2l0 Lm9yZy9iLzE4MzkwMiBmYXN0L2RvbS9mcmFtZS1sb2FkaW5nLXZpYS1kb2N1bWVudC13cml0ZS5o dG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTg0MDg2IGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvd2ViLWFuaW1hdGlvbnMvYW5pbWF0aW9uLW1vZGVsL2FuaW1hdGlvbi10eXBl cy9hY2N1bXVsYXRpb24tcGVyLXByb3BlcnR5Lmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcv Yi8xODQwODYgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWItYW5pbWF0aW9ucy9h bmltYXRpb24tbW9kZWwvYW5pbWF0aW9uLXR5cGVzL2ludGVycG9sYXRpb24tcGVyLXByb3BlcnR5 Lmh0bWwgWyBGYWlsdXJlIF0KIAotd2Via2l0Lm9yZy9iLzE4NDUwMyBpbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL2ZldGNoL2FwaS9yZWRpcmVjdC9yZWRpcmVjdC1tZXRob2QuaHRtbCBb IEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzE4NDUwMyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2ZldGNoL2FwaS9yZWRpcmVjdC9yZWRpcmVjdC1tZXRob2Qtd29ya2VyLmh0bWwgWyBG YWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xODQ1MDQgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy9mZXRjaC9hcGkvcmVxdWVzdC9yZXF1ZXN0LWtlZXBhbGl2ZS1xdW90YS5odG1sIFsgRmFp bHVyZSBdCi0KIHdlYmtpdC5vcmcvYi8xODQ3NzUgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy9tZWRpYWNhcHR1cmUtc3RyZWFtcy9NZWRpYVN0cmVhbVRyYWNrLU1lZGlhRWxlbWVudC1k aXNhYmxlZC1hdWRpby1pcy1zaWxlbmNlLmh0dHBzLmh0bWwgWyBGYWlsdXJlIF0KIAogd2Via2l0 Lm9yZy9iLzE4NDc3NiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50 aWNzL2Zvcm1zL3RleHRmaWVsZHNlbGVjdGlvbi9zZWxlY3Rpb24tbm90LWFwcGxpY2F0aW9uLmh0 bWwgWyBGYWlsdXJlIF0K