184431 2018-04-09 16:03:09 -0700 Add Justin Fan to list of WebKit contributors 2018-08-27 14:39:03 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 justin_fan justin_fan ews-feeder ews-watchlist glenn justin_fan lforschler webkit-bug-importer oldest_to_newest 1413058 0 justin_fan 2018-04-09 16:03:09 -0700 hello world? 1413060 1 webkit-bug-importer 2018-04-09 16:04:07 -0700 <rdar://problem/39297019> 1454031 2 348186 justin_fan 2018-08-27 12:36:12 -0700 Created attachment 348186 Patch 1454034 3 348186 ews-feeder 2018-08-27 12:37:58 -0700 Comment on attachment 348186 Patch Rejecting attachment 348186 from commit-queue. justin_fan@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1454036 4 ews-watchlist 2018-08-27 12:39:41 -0700 Attachment 348186 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1454092 5 justin_fan 2018-08-27 14:38:23 -0700 Manually committed r235402: <https://trac.webkit.org/changeset/235402> 348186 2018-08-27 12:36:12 -0700 2018-08-27 14:38:31 -0700 Patch bug-184431-20180827123612.patch text/plain 1240 justin_fan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1MzM3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjNkY2Y0ZWQxYjcwYmJjM2QzYzU1Y2MwNmZmNjE0MWMz NzQ1NmM2NS4uZTU1OGY4ZDg4MGMwOGJkODM0OTJlOGQ4YzYzNjdlYmQ1NjE1MWIyMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE4LTA4LTI3ICBKdXN0aW4gRmFuICA8anVzdGluX2ZhbkBhcHBsZS5jb20+CisKKyAg ICAgICAgQWRkIEp1c3RpbiBGYW4gdG8gbGlzdCBvZiBXZWJLaXQgY29udHJpYnV0b3JzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ0MzEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL2NvbmZpZy9jb250cmlidXRvcnMuanNvbjoKKwogMjAxOC0wOC0yNCAgQWxl eCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEludHJv ZHVjZSBfV0tJbnNwZWN0b3IKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29t bW9uL2NvbmZpZy9jb250cmlidXRvcnMuanNvbiBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29t bW9uL2NvbmZpZy9jb250cmlidXRvcnMuanNvbgppbmRleCAxYjY4MTc5NzU4ODU4OTg4YmYwZTgx ZmM0ZGRmY2UyODI5MDVlZGY1Li5iZmI0MDI1MWU2ODQwZjYzODE3MDQ4ZDNlNTk3OWJlOTQ5MTcx MDNhIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29u dHJpYnV0b3JzLmpzb24KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmln L2NvbnRyaWJ1dG9ycy5qc29uCkBAIC0zMjcxLDYgKzMyNzEsMTMgQEAKICAgICAgIF0sCiAgICAg ICAic3RhdHVzIiA6ICJjb21taXR0ZXIiCiAgICB9LAorICAgIkp1c3RpbiBGYW4iIDogeworICAg ICAgImVtYWlscyIgOiBbCisgICAgICAgICAianVzdGluX2ZhbkBhcHBsZS5jb20iCisgICAgICBd LAorICAgICAgImV4cGVydGlzZSIgOiAiV2ViR0wsIENhbnZhcyIsCisgICAgICAic3RhdHVzIiA6 ICJjb21taXR0ZXIiCisgICB9LAogICAgIkp1c3RpbiBHYXJjaWEiIDogewogICAgICAgImVtYWls cyIgOiBbCiAgICAgICAgICAianVzdGluLmdhcmNpYUBhcHBsZS5jb20iCg==