184076 2018-03-28 03:07:07 -0700 [Win] Assertions.h: VC doesn't support GCC extension ##__VA_ARGS__ 2018-03-28 16:15:25 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 174003 1 fujii fujii achristensen benjamin cdumez cmarcelo commit-queue dbates eric.carlson ews-watchlist krollin webkit-bug-importer oldest_to_newest 1409813 0 fujii 2018-03-28 03:07:07 -0700 [Win] Assertions.h: VC doesn't support GCC extension ##__VA_ARGS__ > ------ Build started: Project: WebKit (WebKit\WebKit), Configuration: Debug x64 ------ > ChildProcess.cpp > c:\webkit\gb\source\webkit\shared\childprocess.cpp(63): error C2059: syntax error: ')' > WebLoaderStrategy.cpp > c:\webkit\gb\source\webkit\webprocess\network\webloaderstrategy.cpp(388): error C2059: syntax error: ')' > WebPage.cpp > c:\webkit\gb\source\webkit\webprocess\webpage\webpage.cpp(2226): error C2059: syntax error: ')' > Done building project "WebKit.vcxproj" -- FAILED. > ========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ========== [GCC] The C Preprocessor: Variadic Macros https://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html 1409814 1 336649 fujii 2018-03-28 03:32:19 -0700 Created attachment 336649 Patch 1409917 2 krollin 2018-03-28 10:50:45 -0700 How is it that this is not working in VC? We've been building under Windows for years without issue. Why is only Assertions.h affected? ##__VA_ARGS__ is used in many other places in WebKit, too. 1409977 3 krollin 2018-03-28 12:40:00 -0700 I've verified that the patch builds debug and release versions of Safari and that the expected logging is still emitted. 1410075 4 fujii 2018-03-28 15:13:24 -0700 Thank you for reviewing and testing my patch. There are two reasons. The difference between ##__VA_ARGS__ and __VA_ARGS__ is ##__VA_ARGS__ removes a preceding comma if the number of variadic arguments is zero. MSVC treats ##__VA_ARGS__ as same as __VA_ARGS__. Then, there is no problem if the number of variadic arguments is greater than zero. I'm now trying to build WebKit2 for Windows port. Compilation errors of comment#0 are observed only in WebKit2. 1410104 5 336649 commit-queue 2018-03-28 16:14:10 -0700 Comment on attachment 336649 Patch Clearing flags on attachment: 336649 Committed r230058: <https://trac.webkit.org/changeset/230058> 1410105 6 commit-queue 2018-03-28 16:14:11 -0700 All reviewed patches have been landed. Closing bug. 1410106 7 webkit-bug-importer 2018-03-28 16:15:25 -0700 <rdar://problem/38976831> 336649 2018-03-28 03:32:19 -0700 2018-03-28 16:14:10 -0700 Patch bug-184076-20180328193218.patch text/plain 4841 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMDI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGY0YzY1MTk3ZWQ5OThjZmVmZTk1YzA5 N2RkMDg0MDIyYzc3YzdlZjMuLjQxNzZmMjRkYmE2NTY4NzIwYWUyYWI5ODNmYTJkNjJiMmE2Mzgx ZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTgtMDMtMjggIEZ1amlpIEhpcm9ub3JpICA8SGly b25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl0gQXNzZXJ0aW9ucy5oOiBWQyBk b2Vzbid0IHN1cHBvcnQgR0NDIGV4dGVuc2lvbiAjI19fVkFfQVJHU19fCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQwNzYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAjI19fVkFfQVJHU19fIGlzIHVzZWQg dG8gZGVmaW5lIFJFTEVBU0VfTE9HLCBSRUxFQVNFX0xPR19FUlJPUiwKKyAgICAgICAgUkVMRUFT RV9MT0dfSUYsIFJFTEVBU0VfTE9HX0VSUk9SX0lGLCBSRUxFQVNFX0xPR19XSVRIX0xFVkVMLAor ICAgICAgICBSRUxFQVNFX0xPR19XSVRIX0xFVkVMX0lGIGFuZCBSRUxFQVNFX0xPR19JTkZPX0lG LgorCisgICAgICAgIEEgbWFjcm8gdXNpbmcgIyNfX1ZBX0FSR1NfXywKKworICAgICAgICAgICNk ZWZpbmUgZm9vKGZvcm1hdCwgLi4uKSBiYXIoZm9ybWF0LCAjI19fVkFfQVJHU19fKQorCisgICAg ICAgIGNhbiBiZSBkZWZpbmVkIHdpdGhvdXQgIyNfX1ZBX0FSR1NfXzoKKworICAgICAgICAgICNk ZWZpbmUgZm9vKC4uLikgYmFyKF9fVkFfQVJHU19fKQorCisgICAgICAgICogd3RmL0Fzc2VydGlv bnMuaDogVXNlIF9fVkFfQVJHU19fIGluc3RlYWQgb2YgIyNfX1ZBX0FSR1NfXy4KKwogMjAxOC0w My0yOCAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUuY29tPgogCiAgICAgICAgIGFw cGVuZFF1b3RlZEpTT05TdHJpbmcgc3RvcHMgb24gYXJpdGhtZXRpYyBvdmVyZmxvdyBpbnN0ZWFk IG9mIHByb3BhZ2F0aW5nIGl0IHVwd2FyZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Fz c2VydGlvbnMuaCBiL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAppbmRleCA2NGFhYTBkZDVj OWIyY2JkODFmY2JkNjJiYzMxZTRiNzBkN2E1YjY0Li5iNmM4NTJmYTVmNmE3M2JiMWYxOTA1MjUw NDBhYTIxYWY1MDU2YjI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgK KysrIGIvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oCkBAIC00NDcsMzEgKzQ0NywzMSBAQCBX VEZfRVhQT1JUX1BSSVZBVEUgTk9fUkVUVVJOX0RVRV9UT19DUkFTSCB2b2lkIFdURkNyYXNoV2l0 aFNlY3VyaXR5SW1wbGljYXRpb24odgogLyogUkVMRUFTRV9MT0cgKi8KIAogI2lmIFJFTEVBU0Vf TE9HX0RJU0FCTEVECi0jZGVmaW5lIFJFTEVBU0VfTE9HKCAgICAgIGNoYW5uZWwsIGZvcm1hdCwg Li4uKSAoKHZvaWQpMCkKLSNkZWZpbmUgUkVMRUFTRV9MT0dfRVJST1IoY2hhbm5lbCwgZm9ybWF0 LCAuLi4pIExPR19FUlJPUihmb3JtYXQsICMjX19WQV9BUkdTX18pCisjZGVmaW5lIFJFTEVBU0Vf TE9HKGNoYW5uZWwsIC4uLikgKCh2b2lkKTApCisjZGVmaW5lIFJFTEVBU0VfTE9HX0VSUk9SKGNo YW5uZWwsIC4uLikgTE9HX0VSUk9SKF9fVkFfQVJHU19fKQogCi0jZGVmaW5lIFJFTEVBU0VfTE9H X0lGKCAgICAgIGlzQWxsb3dlZCwgY2hhbm5lbCwgZm9ybWF0LCAuLi4pICgodm9pZCkwKQotI2Rl ZmluZSBSRUxFQVNFX0xPR19FUlJPUl9JRihpc0FsbG93ZWQsIGNoYW5uZWwsIGZvcm1hdCwgLi4u KSBkbyB7IGlmIChpc0FsbG93ZWQpIFJFTEVBU0VfTE9HX0VSUk9SKGNoYW5uZWwsIGZvcm1hdCwg IyNfX1ZBX0FSR1NfXyk7IH0gd2hpbGUgKDApCisjZGVmaW5lIFJFTEVBU0VfTE9HX0lGKGlzQWxs b3dlZCwgY2hhbm5lbCwgLi4uKSAoKHZvaWQpMCkKKyNkZWZpbmUgUkVMRUFTRV9MT0dfRVJST1Jf SUYoaXNBbGxvd2VkLCBjaGFubmVsLCAuLi4pIGRvIHsgaWYgKGlzQWxsb3dlZCkgUkVMRUFTRV9M T0dfRVJST1IoY2hhbm5lbCwgX19WQV9BUkdTX18pOyB9IHdoaWxlICgwKQogCi0jZGVmaW5lIFJF TEVBU0VfTE9HX1dJVEhfTEVWRUwoICAgICAgICAgICAgICBjaGFubmVsLCBsZXZlbCwgZm9ybWF0 LCAuLi4pICgodm9pZCkwKQotI2RlZmluZSBSRUxFQVNFX0xPR19XSVRIX0xFVkVMX0lGKGlzQWxs b3dlZCwgY2hhbm5lbCwgbGV2ZWwsIGZvcm1hdCwgLi4uKSBkbyB7IGlmIChpc0FsbG93ZWQpIFJF TEVBU0VfTE9HX1dJVEhfTEVWRUwoY2hhbm5lbCwgbGV2ZWwsIGZvcm1hdCwgIyNfX1ZBX0FSR1Nf Xyk7IH0gd2hpbGUgKDApCisjZGVmaW5lIFJFTEVBU0VfTE9HX1dJVEhfTEVWRUwoY2hhbm5lbCwg bGV2ZWwsIC4uLikgKCh2b2lkKTApCisjZGVmaW5lIFJFTEVBU0VfTE9HX1dJVEhfTEVWRUxfSUYo aXNBbGxvd2VkLCBjaGFubmVsLCBsZXZlbCwgLi4uKSBkbyB7IGlmIChpc0FsbG93ZWQpIFJFTEVB U0VfTE9HX1dJVEhfTEVWRUwoY2hhbm5lbCwgbGV2ZWwsIF9fVkFfQVJHU19fKTsgfSB3aGlsZSAo MCkKICNlbHNlCi0jZGVmaW5lIFJFTEVBU0VfTE9HKCAgICAgIGNoYW5uZWwsIGZvcm1hdCwgLi4u KSBvc19sb2coICAgICAgTE9HX0NIQU5ORUwoY2hhbm5lbCkub3NMb2dDaGFubmVsLCBmb3JtYXQs ICMjX19WQV9BUkdTX18pCi0jZGVmaW5lIFJFTEVBU0VfTE9HX0VSUk9SKGNoYW5uZWwsIGZvcm1h dCwgLi4uKSBvc19sb2dfZXJyb3IoTE9HX0NIQU5ORUwoY2hhbm5lbCkub3NMb2dDaGFubmVsLCBm b3JtYXQsICMjX19WQV9BUkdTX18pCi0jZGVmaW5lIFJFTEVBU0VfTE9HX0lORk8oY2hhbm5lbCwg Zm9ybWF0LCAuLi4pIG9zX2xvZ19pbmZvKExPR19DSEFOTkVMKGNoYW5uZWwpLm9zTG9nQ2hhbm5l bCwgZm9ybWF0LCAjI19fVkFfQVJHU19fKQorI2RlZmluZSBSRUxFQVNFX0xPRyhjaGFubmVsLCAu Li4pIG9zX2xvZyhMT0dfQ0hBTk5FTChjaGFubmVsKS5vc0xvZ0NoYW5uZWwsIF9fVkFfQVJHU19f KQorI2RlZmluZSBSRUxFQVNFX0xPR19FUlJPUihjaGFubmVsLCAuLi4pIG9zX2xvZ19lcnJvcihM T0dfQ0hBTk5FTChjaGFubmVsKS5vc0xvZ0NoYW5uZWwsIF9fVkFfQVJHU19fKQorI2RlZmluZSBS RUxFQVNFX0xPR19JTkZPKGNoYW5uZWwsIC4uLikgb3NfbG9nX2luZm8oTE9HX0NIQU5ORUwoY2hh bm5lbCkub3NMb2dDaGFubmVsLCBfX1ZBX0FSR1NfXykKIAotI2RlZmluZSBSRUxFQVNFX0xPR19J RiggICAgICBpc0FsbG93ZWQsIGNoYW5uZWwsIGZvcm1hdCwgLi4uKSBkbyB7IGlmIChpc0FsbG93 ZWQpIFJFTEVBU0VfTE9HKCAgICAgIGNoYW5uZWwsIGZvcm1hdCwgIyNfX1ZBX0FSR1NfXyk7IH0g d2hpbGUgKDApCi0jZGVmaW5lIFJFTEVBU0VfTE9HX0VSUk9SX0lGKGlzQWxsb3dlZCwgY2hhbm5l bCwgZm9ybWF0LCAuLi4pIGRvIHsgaWYgKGlzQWxsb3dlZCkgUkVMRUFTRV9MT0dfRVJST1IoY2hh bm5lbCwgZm9ybWF0LCAjI19fVkFfQVJHU19fKTsgfSB3aGlsZSAoMCkKLSNkZWZpbmUgUkVMRUFT RV9MT0dfSU5GT19JRihpc0FsbG93ZWQsIGNoYW5uZWwsIGZvcm1hdCwgLi4uKSBkbyB7IGlmIChp c0FsbG93ZWQpIFJFTEVBU0VfTE9HX0lORk8oY2hhbm5lbCwgZm9ybWF0LCAjI19fVkFfQVJHU19f KTsgfSB3aGlsZSAoMCkKKyNkZWZpbmUgUkVMRUFTRV9MT0dfSUYoaXNBbGxvd2VkLCBjaGFubmVs LCAuLi4pIGRvIHsgaWYgKGlzQWxsb3dlZCkgUkVMRUFTRV9MT0coICAgICAgY2hhbm5lbCwgX19W QV9BUkdTX18pOyB9IHdoaWxlICgwKQorI2RlZmluZSBSRUxFQVNFX0xPR19FUlJPUl9JRihpc0Fs bG93ZWQsIGNoYW5uZWwsIC4uLikgZG8geyBpZiAoaXNBbGxvd2VkKSBSRUxFQVNFX0xPR19FUlJP UihjaGFubmVsLCBfX1ZBX0FSR1NfXyk7IH0gd2hpbGUgKDApCisjZGVmaW5lIFJFTEVBU0VfTE9H X0lORk9fSUYoaXNBbGxvd2VkLCBjaGFubmVsLCAuLi4pIGRvIHsgaWYgKGlzQWxsb3dlZCkgUkVM RUFTRV9MT0dfSU5GTyhjaGFubmVsLCBfX1ZBX0FSR1NfXyk7IH0gd2hpbGUgKDApCiAKLSNkZWZp bmUgUkVMRUFTRV9MT0dfV0lUSF9MRVZFTChjaGFubmVsLCBsb2dMZXZlbCwgZm9ybWF0LCAuLi4p IGRvIHsgXAorI2RlZmluZSBSRUxFQVNFX0xPR19XSVRIX0xFVkVMKGNoYW5uZWwsIGxvZ0xldmVs LCAuLi4pIGRvIHsgXAogICAgIGlmIChMT0dfQ0hBTk5FTChjaGFubmVsKS5sZXZlbCA+PSAobG9n TGV2ZWwpKSBcCi0gICAgICAgIG9zX2xvZyhMT0dfQ0hBTk5FTChjaGFubmVsKS5vc0xvZ0NoYW5u ZWwsIGZvcm1hdCwgIyNfX1ZBX0FSR1NfXyk7IFwKKyAgICAgICAgb3NfbG9nKExPR19DSEFOTkVM KGNoYW5uZWwpLm9zTG9nQ2hhbm5lbCwgX19WQV9BUkdTX18pOyBcCiB9IHdoaWxlICgwKQogCi0j ZGVmaW5lIFJFTEVBU0VfTE9HX1dJVEhfTEVWRUxfSUYoaXNBbGxvd2VkLCBjaGFubmVsLCBsb2dM ZXZlbCwgZm9ybWF0LCAuLi4pIGRvIHsgXAorI2RlZmluZSBSRUxFQVNFX0xPR19XSVRIX0xFVkVM X0lGKGlzQWxsb3dlZCwgY2hhbm5lbCwgbG9nTGV2ZWwsIC4uLikgZG8geyBcCiAgICAgaWYgKChp c0FsbG93ZWQpICYmIExPR19DSEFOTkVMKGNoYW5uZWwpLmxldmVsID49IChsb2dMZXZlbCkpIFwK LSAgICAgICAgb3NfbG9nKExPR19DSEFOTkVMKGNoYW5uZWwpLm9zTG9nQ2hhbm5lbCwgZm9ybWF0 LCAjI19fVkFfQVJHU19fKTsgXAorICAgICAgICBvc19sb2coTE9HX0NIQU5ORUwoY2hhbm5lbCku b3NMb2dDaGFubmVsLCBfX1ZBX0FSR1NfXyk7IFwKIH0gd2hpbGUgKDApCiAjZW5kaWYKIAo=