183995 2018-03-25 10:22:41 -0700 r228149 accidentally removed code that resets m_emptyCursor at the end of a GC 2018-03-25 12:10:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=182227 InRadar P2 Normal --- 1 saam saam ap benjamin commit-queue fpizlo ggaren gskachkov jfbastien jlewis3 keith_miller mark.lam msaboff rmorisset ryanhaddad ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1409180 0 saam 2018-03-25 10:22:41 -0700 ... 1409181 1 saam 2018-03-25 10:23:25 -0700 The consequence here is that we end up monotonically growing that cursor, which will eventually lead to us never stealing empty blocks. 1409183 2 336495 saam 2018-03-25 10:42:22 -0700 Created attachment 336495 patch 1409187 3 ap 2018-03-25 11:25:30 -0700 Is that a known flaky test? ** The following JSC stress test failures have been introduced: stress/ftl-put-by-id-setter-exception-interesting-live-state.js.no-cjit-collect-continuously 1409188 4 336495 commit-queue 2018-03-25 11:26:37 -0700 Comment on attachment 336495 patch Clearing flags on attachment: 336495 Committed r229962: <https://trac.webkit.org/changeset/229962> 1409189 5 commit-queue 2018-03-25 11:26:38 -0700 All reviewed patches have been landed. Closing bug. 1409190 6 webkit-bug-importer 2018-03-25 11:27:19 -0700 <rdar://problem/38843812> 1409191 7 saam 2018-03-25 11:30:51 -0700 (In reply to Alexey Proskuryakov from comment #3) > Is that a known flaky test? > > > ** The following JSC stress test failures have been introduced: > stress/ftl-put-by-id-setter-exception-interesting-live-state.js.no-cjit- > collect-continuously Yes. I've seen it flake before. Do you know how to grab the crashlog from the bots? I'll file a bug or you can and assign it to me. 1409194 8 ap 2018-03-25 12:09:20 -0700 There is no crash log on the bot, looks like the test aborts the process without crashing. Running stress/ftl-put-by-id-slow-exception-no-catch.js.no-cjit-collect-continuously stress/ftl-put-by-id-setter-exception-interesting-live-state.js.no-cjit-collect-continuously: Exception: Error42 Running stress/ftl-put-by-id-slow-exception-no-catch.js.dfg-eager Running stress/ftl-put-by-id-slow-exception-no-catch.js.dfg-eager-no-cjit-validate stress/ftl-put-by-id-setter-exception-interesting-live-state.js.no-cjit-collect-continuously: ERROR: Unexpected exit code: 3 FAIL: stress/ftl-put-by-id-setter-exception-interesting-live-state.js.no-cjit-collect-continuously 1409195 9 ap 2018-03-25 12:10:30 -0700 Found an existing bug for that, bug 183266. 336495 2018-03-25 10:42:22 -0700 2018-03-25 11:26:37 -0700 patch a-backup.diff text/plain 1538 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI5OTYxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE4LTAzLTI1ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IHIyMjgxNDkgYWNjaWRlbnRhbGx5IHJlbW92ZWQgY29kZSB0aGF0IHJlc2V0cyBtX2VtcHR5Q3Vy c29yIGF0IHRoZSBlbmQgb2YgYSBHQworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTgzOTk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhlIHJlbW92YWwgb2YgdGhpcyBsaW5lIG9mIGNvZGUgd2FzIHVuaW50 ZW5kZWQgYW5kIGhhcHBlbmVkIGR1cmluZyBzb21lCisgICAgICAgIHJlZmFjdG9yaW5nIEZpbCB3 YXMgZG9pbmcuIFRoZSBjb25zZXF1ZW5jZSBvZiByZW1vdmluZyB0aGlzIGxpbmUgb2YgY29kZQor ICAgICAgICBpcyB0aGF0IHRoZSBtX2VtcHR5Q3Vyc29yIGJlY2FtZSBhIG1vbm90b25pY2FsbHkg aW5jcmVhc2luZyBpbnRlZ2VyLCBsZWFkaW5nCisgICAgICAgIHRoZSBjdXJzb3IgdG8gdXN1YWxs eSBiZWluZyBvdXQgb2YgYm91bmRzIG9mIHRoZSBibG9jayByYW5nZSAoZGVwZW5kaW5nIG9uCisg ICAgICAgIHdoYXQgdGhlIHByb2dyYW0gaXMgZG9pbmcpLiBUaGlzIG1hZGUgdGhlIGZ1bmN0aW9u YWxpdHkgb2YgZmluZGluZyBhbiBlbXB0eQorICAgICAgICBibG9jayB0byBzdGVhbCBhbG1vc3Qg YWx3YXlzIGZhaWwuCisKKyAgICAgICAgKiBoZWFwL0Jsb2NrRGlyZWN0b3J5LmNwcDoKKyAgICAg ICAgKEpTQzo6QmxvY2tEaXJlY3Rvcnk6OnByZXBhcmVGb3JBbGxvY2F0aW9uKToKKwogMjAxOC0w My0yMiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBb REZHXSBJbnRyb2R1Y2VzIGZ1c2VkIGNvbXBhcmUgYW5kIGp1bXAKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9oZWFwL0Jsb2NrRGlyZWN0b3J5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaGVhcC9CbG9ja0RpcmVjdG9yeS5jcHAJKHJldmlzaW9uIDIyOTk2MSkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0Jsb2NrRGlyZWN0b3J5LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTkwLDYgKzE5MCw3IEBAIHZvaWQgQmxvY2tEaXJlY3Rvcnk6OnByZXBhcmVG b3JBbGxvY2F0aW8KICAgICAgICAgfSk7CiAgICAgCiAgICAgbV91bnN3ZXB0Q3Vyc29yID0gMDsK KyAgICBtX2VtcHR5Q3Vyc29yID0gMDsKICAgICAKICAgICBtX2VkZW4uY2xlYXJBbGwoKTsKIAo=