183931 2018-03-23 04:05:08 -0700 connectedCallback is invoked by the HTML parser after child nodes had been inserted 2018-08-22 03:02:58 -0700 1 1 1 Unclassified WebKit UI Events WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 188336 154907 1 andrea.giammarchi rniwa achristensen cdumez esprehn+autocc ews-watchlist fred.wang gyuyoung.kim rniwa rwlbuis tkent webkit-bug-importer oldest_to_newest 1408644 0 andrea.giammarchi 2018-03-23 04:05:08 -0700 Accordingly with this Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=821831 It looks like Webkit/Safari have a bug related to Custom Elements and their connectedCallback invoke, always triggered *after* DOMContentLoaded, even if the definition of the element is known, and the page is also already served. Accordingly, using this test page as reference: https://webreflection.github.io/eyeo/tests/ce.html The correct result should most likely the following one: ``` constructor: 0 attributeChangedCallback: 0 a b c connectedCallback: 3 ready: 3 ``` In Webkit/Safari the result is instead this one: ``` constructor: 0 a b c ready: 3 attributeChangedCallback: 3 connectedCallback: 3 ``` 1409184 1 webkit-bug-importer 2018-03-25 10:51:20 -0700 <rdar://problem/38843548> 1411023 2 tkent 2018-04-02 01:55:24 -0700 We're adding test cases for this issue to WPT. https://github.com/w3c/web-platform-tests/pull/10251 1450160 3 rniwa 2018-08-14 16:33:19 -0700 We pass almost all test cases once the patch for the bug 188189 is landed but there's one test case in custom-elements/parser/parser-sets-attributes-and-children.html we fail: HTML parser should call connectedCallback before appending child nodes 1450236 4 347149 rniwa 2018-08-14 21:42:55 -0700 Created attachment 347149 Fixes the bug 1450307 5 347149 achristensen 2018-08-15 09:01:13 -0700 Comment on attachment 347149 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=347149&action=review > Source/WebCore/ChangeLog:19 > + (WebCore::HTMLConstructionSite::insertCustomElement): Fixed the bug by manually executign the scheduled tasks. executing 1450382 6 rniwa 2018-08-15 11:59:21 -0700 Committed r234893: <https://trac.webkit.org/changeset/234893> 1452565 7 347149 fred.wang 2018-08-22 03:02:58 -0700 Comment on attachment 347149 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=347149&action=review > Source/WebCore/ChangeLog:9 > + Invoke the custom element reactions after constructing and inserting a custom element as specifed in step 3.3 of: nit: specified 347149 2018-08-14 21:42:55 -0700 2018-08-15 09:01:13 -0700 Fixes the bug bug-183931-20180814214255.patch text/plain 4012 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNDg3NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE4LTA4LTE0ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIGNvbm5lY3RlZENhbGxiYWNrIGlz IGludm9rZWQgYnkgdGhlIEhUTUwgcGFyc2VyIGFmdGVyIGNoaWxkIG5vZGVzIGhhZCBiZWVuIGlu c2VydGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODM5MzEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM4ODQzNTQ4PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEludm9rZSB0aGUgY3VzdG9tIGVsZW1l bnQgcmVhY3Rpb25zIGFmdGVyIGNvbnN0cnVjdGluZyBhbmQgaW5zZXJ0aW5nIGEgY3VzdG9tIGVs ZW1lbnQgYXMgc3BlY2lmZWQgaW4gc3RlcCAzLjMgb2Y6CisgICAgICAgIGh0dHBzOi8vaHRtbC5z cGVjLndoYXR3Zy5vcmcvbXVsdGlwYWdlL3BhcnNpbmcuaHRtbCNpbnNlcnQtYS1mb3JlaWduLWVs ZW1lbnQKKworICAgICAgICBUaGUgYnVnIGhlcmUgd2FzIHRoYXQgSFRNTENvbnN0cnVjdGlvblNp dGU6Omluc2VydEN1c3RvbUVsZW1lbnQgdXNlcyBhdHRhY2hMYXRlciBzbyB0aGF0IGV2ZW4gdGhv dWdoIHRoZSB0YXNrCisgICAgICAgIHRvIGluc2VydCB0aGUgY3VzdG9tIGVsZW1lbnQgd2FzIGNy ZWF0ZWQsIGl0IGRpZG4ndCBnZXQgZXhlY3V0ZWQgdW50aWwgYWZ0ZXIgQ3VzdG9tRWxlbWVudFJl YWN0aW9uU3RhY2sgaW4KKyAgICAgICAgSFRNTERvY3VtZW50UGFyc2VyOjpydW5TY3JpcHRzRm9y UGF1c2VkVHJlZUJ1aWxkZXIgaGFkIGJlZW4gcG9wcGVkIG9mZiBvZiB0aGUgc3RhY2suCisKKyAg ICAgICAgVGVzdDogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jdXN0b20tZWxlbWVu dHMvcGFyc2VyL3BhcnNlci1zZXRzLWF0dHJpYnV0ZXMtYW5kLWNoaWxkcmVuLmh0bWwKKworICAg ICAgICAqIGh0bWwvcGFyc2VyL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxDb25zdHJ1Y3Rpb25TaXRlOjppbnNlcnRDdXN0b21FbGVtZW50KTogRml4ZWQg dGhlIGJ1ZyBieSBtYW51YWxseSBleGVjdXRpZ24gdGhlIHNjaGVkdWxlZCB0YXNrcy4KKyAgICAg ICAgVGhpcyB3aWxsIGVucXVldWUgYW55IGN1c3RvbSBlbGVtZW50IHJlYWN0aW9ucyB3aGlsZSBD dXN0b21FbGVtZW50UmVhY3Rpb25TdGFjayBpbiBydW5TY3JpcHRzRm9yUGF1c2VkVHJlZUJ1aWxk ZXIKKyAgICAgICAgaXMgc3RpbGwgaW4gdGhlIHN0YWNrLgorCiAyMDE4LTA4LTE0ICBZdXN1a2Ug U3V6dWtpICA8eXVzdWtlc3V6dWtpQHNsb3dzdGFydC5vcmc+CiAKICAgICAgICAgW0pTQ10gQWRk IEdQUlJlZzo6SW52YWxpZEdQUlJlZyBhbmQgRlBSUmVnOjpJbnZhbGlkRlBSUmVnCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MQ29uc3RydWN0aW9uU2l0ZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTENvbnN0cnVjdGlvblNpdGUu Y3BwCShyZXZpc2lvbiAyMzQ4NzYpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1M Q29uc3RydWN0aW9uU2l0ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUxNCw2ICs1MTQsNyBAQCB2 b2lkIEhUTUxDb25zdHJ1Y3Rpb25TaXRlOjppbnNlcnRDdXN0b21FCiAgICAgc2V0QXR0cmlidXRl cyhlbGVtZW50LCBhdHRyaWJ1dGVzLCBtX3BhcnNlckNvbnRlbnRQb2xpY3kpOwogICAgIGF0dGFj aExhdGVyKGN1cnJlbnROb2RlKCksIGVsZW1lbnQuY29weVJlZigpKTsKICAgICBtX29wZW5FbGVt ZW50cy5wdXNoKEhUTUxTdGFja0l0ZW06OmNyZWF0ZShXVEZNb3ZlKGVsZW1lbnQpLCBsb2NhbE5h bWUsIFdURk1vdmUoYXR0cmlidXRlcykpKTsKKyAgICBleGVjdXRlUXVldWVkVGFza3MoKTsKIH0K IAogdm9pZCBIVE1MQ29uc3RydWN0aW9uU2l0ZTo6aW5zZXJ0U2VsZkNsb3NpbmdIVE1MRWxlbWVu dChBdG9taWNIVE1MVG9rZW4mJiB0b2tlbikKSW5kZXg6IExheW91dFRlc3RzL2ltcG9ydGVkL3cz Yy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5n ZUxvZwkocmV2aXNpb24gMjM0ODc5KQorKysgTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA4LTE0ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIGNvbm5lY3RlZENhbGxiYWNrIGlz IGludm9rZWQgYnkgdGhlIEhUTUwgcGFyc2VyIGFmdGVyIGNoaWxkIG5vZGVzIGhhZCBiZWVuIGlu c2VydGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODM5MzEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM4ODQzNTQ4PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlYmFzZWxpbmVkIHRoZSB0ZXN0IG5v dyB0aGF0IGFsbCB0ZXN0IGNhc2VzIHBhc3MuCisKKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVz dHMvY3VzdG9tLWVsZW1lbnRzL3BhcnNlci9wYXJzZXItc2V0cy1hdHRyaWJ1dGVzLWFuZC1jaGls ZHJlbi1leHBlY3RlZC50eHQ6CisKIDIwMTgtMDgtMTQgIFl1c3VrZSBTdXp1a2kgIDx5dXN1a2Vz dXp1a2lAc2xvd3N0YXJ0Lm9yZz4KIAogICAgICAgICBVbmhhbmRsZWQgUHJvbWlzZSBSZWplY3Rp b24gbG9nZ2luZyBpbiB3b3JrZXJzIHNob3VsZCBub3QgZW1pdCBFcnJvckV2ZW50IHRvIGhvc3Qg V29ya2VyIG9iamVjdApJbmRleDogTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y bS10ZXN0cy9jdXN0b20tZWxlbWVudHMvcGFyc2VyL3BhcnNlci1zZXRzLWF0dHJpYnV0ZXMtYW5k LWNoaWxkcmVuLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9pbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2N1c3RvbS1lbGVtZW50cy9wYXJzZXIvcGFyc2VyLXNl dHMtYXR0cmlidXRlcy1hbmQtY2hpbGRyZW4tZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAyMzQ4NzYp CisrKyBMYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2N1c3RvbS1l bGVtZW50cy9wYXJzZXIvcGFyc2VyLXNldHMtYXR0cmlidXRlcy1hbmQtY2hpbGRyZW4tZXhwZWN0 ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0yLDYgKzIsNiBAQAogUEFTUyBIVE1MIHBhcnNlciBt dXN0IHNldCB0aGUgYXR0cmlidXRlcyAKIFBBU1MgSFRNTCBwYXJzZXIgbXVzdCBhcHBlbmQgY2hp bGQgbm9kZXMgCiBQQVNTIEhUTUwgcGFyc2VyIG11c3Qgc2V0IHRoZSBhdHRyaWJ1dGVzIG9yIGFw cGVuZCBjaGlsZHJlbiBiZWZvcmUgY2FsbGluZyBjb25zdHJ1Y3RvciAKLUZBSUwgSFRNTCBwYXJz ZXIgc2hvdWxkIGNhbGwgY29ubmVjdGVkQ2FsbGJhY2sgYmVmb3JlIGFwcGVuZGluZyBjaGlsZCBu b2Rlcy4gYXNzZXJ0X2VxdWFsczogZXhwZWN0ZWQgMCBidXQgZ290IDIKK1BBU1MgSFRNTCBwYXJz ZXIgc2hvdWxkIGNhbGwgY29ubmVjdGVkQ2FsbGJhY2sgYmVmb3JlIGFwcGVuZGluZyBjaGlsZCBu b2Rlcy4gCiBQQVNTIEhUTUwgcGFyc2VyIG11c3QgZW5xdWV1ZSBhdHRyaWJ1dGVDaGFuZ2VkIHJl YWN0aW9ucyAKIGhlbGxvIHdvcmxkCg==