183450 2018-03-08 06:24:46 -0800 [Win] Use __debugbreak for WTFBreakpointTrap 2018-03-08 07:48:34 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki achristensen benjamin cdumez cmarcelo darin dbates don.olmstead ews-watchlist mark.lam saam webkit-bug-importer oldest_to_newest 1404720 0 ysuzuki 2018-03-08 06:24:46 -0800 [Win] Use __debugbreak for WTFBreakpointTrap 1404721 1 335296 ysuzuki 2018-03-08 06:25:51 -0800 Created attachment 335296 Patch 1404728 2 335296 mark.lam 2018-03-08 07:24:54 -0800 Comment on attachment 335296 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335296&action=review r=me > Source/WTF/wtf/Assertions.h:212 > +#else > #if ASAN_ENABLED Change this into an "#elif ASAN_ENABLED" because these cases should all be mutually exclusive. > Source/WTF/wtf/Assertions.h:223 > +#endif // COMPILER(MSVC) Remove this. 1404729 3 335296 ysuzuki 2018-03-08 07:43:35 -0800 Comment on attachment 335296 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335296&action=review Thank you! >> Source/WTF/wtf/Assertions.h:212 >> #if ASAN_ENABLED > > Change this into an "#elif ASAN_ENABLED" because these cases should all be mutually exclusive. OK, changed. >> Source/WTF/wtf/Assertions.h:223 >> +#endif // COMPILER(MSVC) > > Remove this. Fixed. 1404730 4 ysuzuki 2018-03-08 07:47:31 -0800 Committed r229409: <https://trac.webkit.org/changeset/229409> 1404731 5 webkit-bug-importer 2018-03-08 07:48:34 -0800 <rdar://problem/38262145> 335296 2018-03-08 06:25:51 -0800 2018-03-08 07:24:54 -0800 Patch bug-183450-20180308232550.patch text/plain 1549 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NDA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGI4ODhkODFhOWMxZTJiNjVmODc1NzM0 ZjU5ZDBlMjM2ZmU4MjA2ZGYuLjA4MGI0N2Y0NjZmY2UxNDk4YWQ4YjI2NGI0ZDQyOTU1ZWE4MDI5 NDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDMtMDggIFl1c3VrZSBTdXp1a2kgIDx1dGF0 YW5lLnRlYUBnbWFpbC5jb20+CisKKyAgICAgICAgW1dpbl0gVXNlIF9fZGVidWdicmVhayBmb3Ig V1RGQnJlYWtwb2ludFRyYXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4MzQ1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBXVEZCcmVha3BvaW50VHJhcCgpIGltcGxlbWVudGF0 aW9uIGZvciBNU1ZDIGJ5IHVzaW5nCisgICAgICAgIF9fZGVidWdicmVhay4gSXQgZml4ZXMgYnVp bGQgZmFpbHVyZSBpbiBXaW5kb3dzIGR1ZSB0byB0aGUgdXNlIG9mCisgICAgICAgIFdURkJyZWFr cG9pbnRUcmFwKCkuCisKKyAgICAgICAgKiB3dGYvQXNzZXJ0aW9ucy5oOgorCiAyMDE4LTAzLTA4 ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR0xpYl0g UnVuTG9vcDo6d2FrZVVwKCk6IHVzZSBhIHplcm8gdmFsdWUgaW5zdGVhZCBvZiB0aGUgbW9ub3Rv bmljIHRpbWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaCBiL1NvdXJj ZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAppbmRleCAwZGExYjc3MTk5OGQ5ZTQ1ZmQwYmUyMjZhOTM0 YWRiNzRjYzg3YmJmLi44NzJmNGY5NjY2ZmQ0MTJiMzk1YWFmNWY2MGRkZDEzMzNkY2IzNjU4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgKKysrIGIvU291cmNlL1dURi93 dGYvQXNzZXJ0aW9ucy5oCkBAIC0yMDYsNiArMjA2LDkgQEAgV1RGX0VYUE9SVF9QUklWQVRFIHZv aWQgV1RGSW5zdGFsbFJlcG9ydEJhY2t0cmFjZU9uQ3Jhc2hIb29rKHZvaWQpOwogCiBXVEZfRVhQ T1JUX1BSSVZBVEUgYm9vbCBXVEZJc0RlYnVnZ2VyQXR0YWNoZWQodm9pZCk7CiAKKyNpZiBDT01Q SUxFUihNU1ZDKQorI2RlZmluZSBXVEZCcmVha3BvaW50VHJhcCgpICBfX2RlYnVnYnJlYWsoKQor I2Vsc2UKICNpZiBBU0FOX0VOQUJMRUQKICNkZWZpbmUgV1RGQnJlYWtwb2ludFRyYXAoKSAgX19i dWlsdGluX3RyYXAoKQogI2VsaWYgQ1BVKFg4Nl82NCkgfHwgQ1BVKFg4NikKQEAgLTIxNyw2ICsy MjAsNyBAQCBXVEZfRVhQT1JUX1BSSVZBVEUgYm9vbCBXVEZJc0RlYnVnZ2VyQXR0YWNoZWQodm9p ZCk7CiAjZWxzZQogI2RlZmluZSBXVEZCcmVha3BvaW50VHJhcCgpIFdURkNyYXNoKCkgLy8gTm90 IGltcGxlbWVudGVkLgogI2VuZGlmCisjZW5kaWYgLy8gQ09NUElMRVIoTVNWQykKIAogI2lmbmRl ZiBDUkFTSAogCg==