183288 2018-03-02 05:28:18 -0800 offlineasm: Use temporary file for generating assembly code 2021-11-01 12:43:59 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 dominik.infuehr webkit-unassigned achristensen dominik.infuehr ews-watchlist fpizlo guijemont jfbastien keith_miller mark.lam msaboff saam oldest_to_newest 1403210 0 dominik.infuehr 2018-03-02 05:28:18 -0800 offlineasm: Use temporary file for generating assembly code 1403213 1 334897 dominik.infuehr 2018-03-02 05:37:19 -0800 Created attachment 334897 Patch 1403249 2 334897 jfbastien 2018-03-02 09:13:59 -0800 Comment on attachment 334897 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334897&action=review One suggestion, otherwise r=me > Source/JavaScriptCore/offlineasm/asm.rb:398 > +FileUtils.cp(tempFile, outputFlnm) I think you want rename, not copy: http://ruby-doc.org/core-2.1.1/File.html#method-c-rename If it follows UNIX convention then it'll be atomic. 1403566 3 334988 dominik.infuehr 2018-03-04 23:52:25 -0800 Created attachment 334988 Patch 1403568 4 dominik.infuehr 2018-03-04 23:55:21 -0800 Thanks for the review and the suggestion. I've updated the patch to use File.rename but fall back to FileUtils.cp if the rename should fail. This happens to be the case on my system, where /tmp is on another file system. 1403649 5 jfbastien 2018-03-05 09:51:42 -0800 (In reply to Dominik Inführ from comment #4) > Thanks for the review and the suggestion. I've updated the patch to use > File.rename but fall back to FileUtils.cp if the rename should fail. This > happens to be the case on my system, where /tmp is on another file system. Hmm interesting... Your backup isn't atomic then, and you're trying to remove potentially truncated files. Maybe instead, when it fails, you should cp to a tempname in the same directory (so it'll be the same mount point), and then rename that. That would keep the actual file atomic. WDYT? r=me if you think that's overkill, but it should be simple. 1487871 6 357306 dominik.infuehr 2018-12-14 00:21:30 -0800 Created attachment 357306 Patch 1487873 7 dominik.infuehr 2018-12-14 00:24:18 -0800 Could you please take a look again? I am now always generating the temporary file in the same directory of the output file. Then rename'ing should work and Tempfile isn't necessary anymore. 1810773 8 357306 achristensen 2021-11-01 12:43:59 -0700 Comment on attachment 357306 Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review. 334897 2018-03-02 05:37:19 -0800 2018-03-04 23:52:20 -0800 Patch bug-183288-20180302143718.patch text/plain 1815 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5MTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj ZDQyYzliYWIwNjIzMjk4MGE1OTgwMDJiZmYxNDlkYzhiMDhjNWFjLi4zNjNlOTQwMWNiZWYyZmYz NWNiMjZiMjdiMjcwY2IzODQ3YTdhMTNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOC0wMy0wMiAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlh LmNvbT4KKworICAgICAgICBvZmZsaW5lYXNtOiBVc2UgdGVtcG9yYXJ5IGZpbGUgZm9yIGdlbmVy YXRpbmcgYXNzZW1ibHkgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTgzMjg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSWYgb2ZmbGluZWFzbSBjcmFzaGVzLCBpdCBsZWF2ZXMgYSBicm9rZW4gZmls ZSBiZWhpbmQuIExldAorICAgICAgICBvZmZsaW5lYXNtIGZpcnN0IHdyaXRlIGludG8gYSB0ZW1w b3JhcnkgZmlsZS4gV2hlbiBvZmZsaW5lYXNtIGZpbmlzaGVzCisgICAgICAgIHN1Y2Nlc3NmdWxs eSBjb3B5IHRoZSB0ZW1wb3JhcnkgZmlsZSBpbnRvIHRoZSBzcGVjaWZpZWQgdGFyZ2V0IGZpbGUu CisgICAgICAgIFRoaXMgd29ya2Fyb3VuZCBwcmV2ZW50cyB0aGUgYnVpbGQgc3lzdGVtIGZyb20g Y29udGludWluZyB3aXRoIGEgYnJva2VuCisgICAgICAgIGZpbGUuCisKKyAgICAgICAgKiBvZmZs aW5lYXNtL2FzbS5yYjogV3JpdGUgaW50byB0ZW1wb3JhcnkgZmlsZSBmaXJzdC4KKwogMjAxOC0w My0wMSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBB U1NFUlRJT04gRkFJTEVEOiBtYXRjaENvbnRleHR1YWxLZXl3b3JkKG1fdm0tPnByb3BlcnR5TmFt ZXMtPmFzeW5jKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20v YXNtLnJiIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXNtLnJiCmluZGV4IDAy NDA0OWI2NjA2NzVjODdjODExZmI1YWYxMmY5ZmIwNjJmNTU3MjIuLjgzZDUxYTU5MDMwMjZmMzQy ZTNlNzQ1NzNkMmUyMjQzYjlhMWY4NzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9vZmZsaW5lYXNtL2FzbS5yYgorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFz bS9hc20ucmIKQEAgLTM0LDYgKzM0LDcgQEAgcmVxdWlyZSAicGFyc2VyIgogcmVxdWlyZSAic2Vs Zl9oYXNoIgogcmVxdWlyZSAic2V0dGluZ3MiCiByZXF1aXJlICJ0cmFuc2Zvcm0iCityZXF1aXJl ICJ0ZW1wZmlsZSIKIAogY2xhc3MgQXNzZW1ibGVyCiAgICAgZGVmIGluaXRpYWxpemUob3V0cCkK QEAgLTM1OCw3ICszNTksOSBAQCBpZiBGaWxlVGVzdC5leGlzdD8gb3V0cHV0RmxubQogICAgIH0K IGVuZAogCi1GaWxlLm9wZW4ob3V0cHV0RmxubSwgInciKSB7Cit0ZW1wRmlsZSA9IFRlbXBmaWxl Lm5ldygnb2ZmbGluZWFzbScpCisKK0ZpbGUub3Blbih0ZW1wRmlsZSwgInciKSB7CiAgICAgfCBv dXRwIHwKICAgICAkb3V0cHV0ID0gb3V0cAogICAgICRvdXRwdXQucHV0cyBpbnB1dEhhc2gKQEAg LTM5MSwzICszOTQsNSBAQCBGaWxlLm9wZW4ob3V0cHV0RmxubSwgInciKSB7CiAgICAgICAgIH0K ICAgICB9CiB9CisKK0ZpbGVVdGlscy5jcCh0ZW1wRmlsZSwgb3V0cHV0RmxubSkK 334988 2018-03-04 23:52:25 -0800 2018-12-14 00:21:26 -0800 Patch bug-183288-20180305085223.patch text/plain 2081 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5MTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj ZDQyYzliYWIwNjIzMjk4MGE1OTgwMDJiZmYxNDlkYzhiMDhjNWFjLi4zNjNlOTQwMWNiZWYyZmYz NWNiMjZiMjdiMjcwY2IzODQ3YTdhMTNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOC0wMy0wMiAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlh LmNvbT4KKworICAgICAgICBvZmZsaW5lYXNtOiBVc2UgdGVtcG9yYXJ5IGZpbGUgZm9yIGdlbmVy YXRpbmcgYXNzZW1ibHkgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTgzMjg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSWYgb2ZmbGluZWFzbSBjcmFzaGVzLCBpdCBsZWF2ZXMgYSBicm9rZW4gZmls ZSBiZWhpbmQuIExldAorICAgICAgICBvZmZsaW5lYXNtIGZpcnN0IHdyaXRlIGludG8gYSB0ZW1w b3JhcnkgZmlsZS4gV2hlbiBvZmZsaW5lYXNtIGZpbmlzaGVzCisgICAgICAgIHN1Y2Nlc3NmdWxs eSBjb3B5IHRoZSB0ZW1wb3JhcnkgZmlsZSBpbnRvIHRoZSBzcGVjaWZpZWQgdGFyZ2V0IGZpbGUu CisgICAgICAgIFRoaXMgd29ya2Fyb3VuZCBwcmV2ZW50cyB0aGUgYnVpbGQgc3lzdGVtIGZyb20g Y29udGludWluZyB3aXRoIGEgYnJva2VuCisgICAgICAgIGZpbGUuCisKKyAgICAgICAgKiBvZmZs aW5lYXNtL2FzbS5yYjogV3JpdGUgaW50byB0ZW1wb3JhcnkgZmlsZSBmaXJzdC4KKwogMjAxOC0w My0wMSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBB U1NFUlRJT04gRkFJTEVEOiBtYXRjaENvbnRleHR1YWxLZXl3b3JkKG1fdm0tPnByb3BlcnR5TmFt ZXMtPmFzeW5jKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20v YXNtLnJiIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXNtLnJiCmluZGV4IDAy NDA0OWI2NjA2NzVjODdjODExZmI1YWYxMmY5ZmIwNjJmNTU3MjIuLjczNjc4Njk0MmEyYzQ3NWJj MGFkNmQ1NDkxOTI2NDRhZjBhY2UzOGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9vZmZsaW5lYXNtL2FzbS5yYgorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFz bS9hc20ucmIKQEAgLTM0LDYgKzM0LDcgQEAgcmVxdWlyZSAicGFyc2VyIgogcmVxdWlyZSAic2Vs Zl9oYXNoIgogcmVxdWlyZSAic2V0dGluZ3MiCiByZXF1aXJlICJ0cmFuc2Zvcm0iCityZXF1aXJl ICJ0ZW1wZmlsZSIKIAogY2xhc3MgQXNzZW1ibGVyCiAgICAgZGVmIGluaXRpYWxpemUob3V0cCkK QEAgLTM1OCw3ICszNTksOSBAQCBpZiBGaWxlVGVzdC5leGlzdD8gb3V0cHV0RmxubQogICAgIH0K IGVuZAogCi1GaWxlLm9wZW4ob3V0cHV0RmxubSwgInciKSB7Cit0ZW1wRmlsZSA9IFRlbXBmaWxl Lm5ldygnb2ZmbGluZWFzbScpCisKK0ZpbGUub3Blbih0ZW1wRmlsZSwgInciKSB7CiAgICAgfCBv dXRwIHwKICAgICAkb3V0cHV0ID0gb3V0cAogICAgICRvdXRwdXQucHV0cyBpbnB1dEhhc2gKQEAg LTM5MSwzICszOTQsMTIgQEAgRmlsZS5vcGVuKG91dHB1dEZsbm0sICJ3IikgewogICAgICAgICB9 CiAgICAgfQogfQorCitiZWdpbgorICAgICMgVHJ5IHRvIHJlbmFtZS9tb3ZlIHRoZSB0ZW1wb3Jh cnkgZmlsZSB0byB0aGUgb3V0cHV0IGZpbGUuCisgICAgRmlsZS5yZW5hbWUodGVtcEZpbGUsIG91 dHB1dEZsbm0pCityZXNjdWUgU3lzdGVtQ2FsbEVycm9yCisgICAgIyBGYWxsIGJhY2sgdG8gY29w eSBpZiB0aGlzIGlzbid0IHBvc3NpYmxlIChlLmcuIHNvdXJjZSBhbmQKKyAgICAjIGRlc3RpbmF0 aW9uIGZpbGVzIGFyZSBvbiBkaWZmZXJlbnQgZmlsZSBzeXN0ZW1zKQorICAgIEZpbGVVdGlscy5j cCh0ZW1wRmlsZSwgb3V0cHV0RmxubSkKK2VuZAo= 357306 2018-12-14 00:21:30 -0800 2021-11-01 12:43:59 -0700 Patch bug-183288-20181214092129.patch text/plain 1673 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MjAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 YmQyNDEyMzUxZTA2NmJmYmEyMzFmNTU5Y2I1NjU5NzczMDE4MzE2Li40NGFlMmYwYzUxN2EyMTU5 YjkzZjE2MDcyMWZhM2RkOGNlNDQ3NzM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOC0xMi0xNCAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlh LmNvbT4KKworICAgICAgICBvZmZsaW5lYXNtOiBVc2UgdGVtcG9yYXJ5IGZpbGUgZm9yIGdlbmVy YXRpbmcgYXNzZW1ibHkgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTgzMjg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSWYgb2ZmbGluZWFzbSBjcmFzaGVzLCBpdCBsZWF2ZXMgYSBicm9rZW4gZmls ZSBiZWhpbmQuIExldCBvZmZsaW5lYXNtCisgICAgICAgIGZpcnN0IHdyaXRlIGludG8gYSB0ZW1w b3JhcnkgZmlsZS4gV2hlbiBvZmZsaW5lYXNtIGZpbmlzaGVzIHN1Y2Nlc3NmdWxseQorICAgICAg ICBjb3B5IHRoZSB0ZW1wb3JhcnkgZmlsZSBpbnRvIHRoZSBzcGVjaWZpZWQgdGFyZ2V0IGZpbGUu IFRoaXMgd29ya2Fyb3VuZAorICAgICAgICBwcmV2ZW50cyB0aGUgYnVpbGQgc3lzdGVtIGZyb20g Y29udGludWluZyB3aXRoIGEgYnJva2VuIGZpbGUuCisKKyAgICAgICAgKiBvZmZsaW5lYXNtL2Fz bS5yYjoKKwogMjAxOC0xMi0xMyAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255 LmNvbT4KIAogICAgICAgICBbV2luQ2Fpcm9dW0NsYW5nXSBETExMYXVuY2hlck1haW4uY3BwOiB3 YXJuaW5nOiB1bnVzZWQgZnVuY3Rpb24gJ3ByZXBlbmRQYXRoJyBhbmQgJ2FwcGxlQXBwbGljYXRp b25TdXBwb3J0RGlyZWN0b3J5JwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29m ZmxpbmVhc20vYXNtLnJiIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXNtLnJi CmluZGV4IGVjZjE0Y2JiM2ZmMmIyNzU3MmQzMWQ3YzE5ZWU5ZjBmOTU5NjFhMGQuLjBhOGU1YzY5 NzAzODA4ZjViNDk2ZTMyYTgyODY3Zjk2MzFlMTE0ODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9vZmZsaW5lYXNtL2FzbS5yYgorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv b2ZmbGluZWFzbS9hc20ucmIKQEAgLTM3Myw3ICszNzMsOSBAQCBpZiBGaWxlVGVzdC5leGlzdD8g b3V0cHV0RmxubQogICAgIH0KIGVuZAogCi1GaWxlLm9wZW4ob3V0cHV0RmxubSwgInciKSB7Cit0 ZW1wT3V0cHV0RmxubSA9ICIje291dHB1dEZsbm19LnRlbXAiCisKK0ZpbGUub3Blbih0ZW1wT3V0 cHV0RmxubSwgInciKSB7CiAgICAgfCBvdXRwIHwKICAgICAkb3V0cHV0ID0gb3V0cAogICAgICRv dXRwdXQucHV0cyBpbnB1dEhhc2gKQEAgLTQwOSwzICs0MTEsNSBAQCBGaWxlLm9wZW4ob3V0cHV0 RmxubSwgInciKSB7CiAgICAgICAgIH0KICAgICB9CiB9CisKK0ZpbGUucmVuYW1lKHRlbXBPdXRw dXRGbG5tLCBvdXRwdXRGbG5tKQo=