<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>183251</bug_id>
          
          <creation_ts>2018-03-01 11:37:48 -0800</creation_ts>
          <short_desc>[CMake] Split JSC header copying into public and private targets</short_desc>
          <delta_ts>2018-03-05 10:48:59 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Don Olmstead">don.olmstead</reporter>
          <assigned_to name="Don Olmstead">don.olmstead</assigned_to>
          <cc>achristensen</cc>
    
    <cc>annulen</cc>
    
    <cc>commit-queue</cc>
    
    <cc>fujii</cc>
    
    <cc>lforschler</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>pvollan</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1402964</commentid>
    <comment_count>0</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-03-01 11:37:48 -0800</bug_when>
    <thetext>Currently there is no way to set the name of the target for copying of headers.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1402965</commentid>
    <comment_count>1</comment_count>
      <attachid>334830</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-03-01 11:38:59 -0800</bug_when>
    <thetext>Created attachment 334830
Patch

Add TARGET_NAME parameter</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1402971</commentid>
    <comment_count>2</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2018-03-01 11:52:07 -0800</bug_when>
    <thetext>Please add usage to the patch to demonstrate need of such complications</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1402977</commentid>
    <comment_count>3</comment_count>
      <attachid>334835</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-03-01 12:02:32 -0800</bug_when>
    <thetext>Created attachment 334835
Patch

This patch splits the copying of headers into 2 separate targets, one for public and one for private.

JavaScriptCore and WebKit have both public and private headers that need to be installed. In this case LLIntOffsets technically needs access to the public headers of JavaScriptCore before it is built. This makes the dependencies more explicit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1402986</commentid>
    <comment_count>4</comment_count>
      <attachid>334837</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-03-01 12:25:06 -0800</bug_when>
    <thetext>Created attachment 334837
Patch

Rename target in Tools</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1403098</commentid>
    <comment_count>5</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-03-01 16:32:07 -0800</bug_when>
    <thetext>I don&apos;t like this TARGET_NAME idea.

How do you think a following style?

WEBKIT_MAKE_FORWARDING_HEADERS(JavaScriptCore
    PUBLIC_HEADERS ${JavaScriptCore_PUBLIC_FRAMEWORK_HEADERS}
    PRIVATE_HEADERS ${JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS}
    DERIVED_SOURCE_DIRECTORIES
        ${DERIVED_SOURCES_DIR}/JavaScriptCore
        ${DERIVED_SOURCES_DIR}/JavaScriptCore/inspector
    FLATTENED)

And, it should be unified into WEBKIT_FRAMEWORK in the future (Bug 182593 Comment 8).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1403100</commentid>
    <comment_count>6</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-03-01 16:36:00 -0800</bug_when>
    <thetext>(In reply to Fujii Hironori from comment #5)
&gt; I don&apos;t like this TARGET_NAME idea.
&gt; 
&gt; How do you think a following style?
&gt; 
&gt; WEBKIT_MAKE_FORWARDING_HEADERS(JavaScriptCore
&gt;     PUBLIC_HEADERS ${JavaScriptCore_PUBLIC_FRAMEWORK_HEADERS}
&gt;     PRIVATE_HEADERS ${JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS}
&gt;     DERIVED_SOURCE_DIRECTORIES
&gt;         ${DERIVED_SOURCES_DIR}/JavaScriptCore
&gt;         ${DERIVED_SOURCES_DIR}/JavaScriptCore/inspector
&gt;     FLATTENED)
&gt; 
&gt; And, it should be unified into WEBKIT_FRAMEWORK in the future (Bug 182593
&gt; Comment 8).

I was thinking that at a later time the current WEBKIT_MAKE_FORWARDING_HEADERS is turned into a private CMake function that would be invoked either in WEBKIT_FRAMEWORK or in something like what you are suggesting here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1403599</commentid>
    <comment_count>7</comment_count>
      <attachid>334837</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-03-05 05:28:49 -0800</bug_when>
    <thetext>Comment on attachment 334837
Patch

Rejecting attachment 334837 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.webkit.org&apos;, &apos;--bot-id=webkit-cq-01&apos;, &apos;land-attachment&apos;, &apos;--force-clean&apos;, &apos;--non-interactive&apos;, &apos;--parent-command=commit-queue&apos;, 334837, &apos;--port=mac&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
rdparty/autoinstalled/mechanize/_urllib2_fork.py&quot;, line 332, in _call_chain
    result = func(*args)
  File &quot;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py&quot;, line 1170, in https_open
    return self.do_open(conn_factory, req)
  File &quot;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py&quot;, line 1118, in do_open
    raise URLError(err)
urllib2.URLError: &lt;urlopen error [Errno 60] Operation timed out&gt;

Full output: http://webkit-queues.webkit.org/results/6812439</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1403676</commentid>
    <comment_count>8</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2018-03-05 10:47:04 -0800</bug_when>
    <thetext>Committed https://trac.webkit.org/r229282</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1403677</commentid>
    <comment_count>9</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-03-05 10:48:59 -0800</bug_when>
    <thetext>&lt;rdar://problem/38145595&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>334830</attachid>
            <date>2018-03-01 11:38:59 -0800</date>
            <delta_ts>2018-03-01 12:02:32 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-183251.diff</filename>
            <type>text/plain</type>
            <size>1823</size>
            <attacher name="Don Olmstead">don.olmstead</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzODgzNTVlYjhkMy4uNjM2
ZGI5YTEyOWUgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwxMiBAQAorMjAxOC0wMy0wMSAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29t
PgorCisgICAgICAgIFtDTWFrZV0gQWxsb3cgZXhwbGljaXQgbmFtaW5nIG9mIGhlYWRlcnMgY29w
eWluZyB0YXJnZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTE4MzI1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgICogU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZToKKwogMjAxOC0wMi0yNiAgWW91
c3VrZSBLaW1vdG8gIDx5b3VzdWtlLmtpbW90b0Bzb255LmNvbT4KIAogICAgICAgICBbV2luQ2Fp
cm9dIFdlYktpdDJfQy5oIHNob3VsZCBiZSBpbmNsdWRlZCBmb3IgVGVzdFdlYktpdApkaWZmIC0t
Z2l0IGEvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJL
aXRNYWNyb3MuY21ha2UKaW5kZXggYTFlN2U4ZjVhNzUuLjM2ZTVhMDIwMGM5IDEwMDY0NAotLS0g
YS9Tb3VyY2UvY21ha2UvV2ViS2l0TWFjcm9zLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJL
aXRNYWNyb3MuY21ha2UKQEAgLTIxNyw3ICsyMTcsNyBAQCBlbmRtYWNybygpCiAKIGZ1bmN0aW9u
KFdFQktJVF9NQUtFX0ZPUldBUkRJTkdfSEVBREVSUyBmcmFtZXdvcmspCiAgICAgc2V0KG9wdGlv
bnMgRkxBVFRFTkVEKQotICAgIHNldChvbmVWYWx1ZUFyZ3MgREVTVElOQVRJT04pCisgICAgc2V0
KG9uZVZhbHVlQXJncyBERVNUSU5BVElPTiBUQVJHRVRfTkFNRSkKICAgICBzZXQobXVsdGlWYWx1
ZUFyZ3MgRElSRUNUT1JJRVMgRVhUUkFfRElSRUNUT1JJRVMgREVSSVZFRF9TT1VSQ0VfRElSRUNU
T1JJRVMgRklMRVMpCiAgICAgY21ha2VfcGFyc2VfYXJndW1lbnRzKG9wdCAiJHtvcHRpb25zfSIg
IiR7b25lVmFsdWVBcmdzfSIgIiR7bXVsdGlWYWx1ZUFyZ3N9IiAke0FSR059KQogICAgIHNldCho
ZWFkZXJzICR7b3B0X0ZJTEVTfSkKQEAgLTI2Myw4ICsyNjMsMTMgQEAgZnVuY3Rpb24oV0VCS0lU
X01BS0VfRk9SV0FSRElOR19IRUFERVJTIGZyYW1ld29yaykKICAgICAgICAgICAgIGxpc3QoQVBQ
RU5EIGZ3ZF9oZWFkZXJzICR7ZndkX2hlYWRlcn0pCiAgICAgICAgIGVuZGZvcmVhY2ggKCkKICAg
ICBlbmRmb3JlYWNoICgpCi0gICAgYWRkX2N1c3RvbV90YXJnZXQoJHtmcmFtZXdvcmt9Rm9yd2Fy
ZGluZ0hlYWRlcnMgREVQRU5EUyAke2Z3ZF9oZWFkZXJzfSkKLSAgICBhZGRfZGVwZW5kZW5jaWVz
KCR7ZnJhbWV3b3JrfSAke2ZyYW1ld29ya31Gb3J3YXJkaW5nSGVhZGVycykKKyAgICBpZiAob3B0
X1RBUkdFVF9OQU1FKQorICAgICAgICBzZXQodGFyZ2V0X25hbWUgJHtvcHRfVEFSR0VUX05BTUV9
KQorICAgIGVsc2UgKCkKKyAgICAgICAgc2V0KHRhcmdldF9uYW1lICR7ZnJhbWV3b3JrfUZvcndh
cmRpbmdIZWFkZXJzKQorICAgIGVuZGlmICgpCisgICAgYWRkX2N1c3RvbV90YXJnZXQoJHt0YXJn
ZXRfbmFtZX0gREVQRU5EUyAke2Z3ZF9oZWFkZXJzfSkKKyAgICBhZGRfZGVwZW5kZW5jaWVzKCR7
ZnJhbWV3b3JrfSAke3RhcmdldF9uYW1lfSkKICAgICBpZiAob3B0X0RFUklWRURfU09VUkNFX0RJ
UkVDVE9SSUVTKQogICAgICAgICBzZXQoc2NyaXB0ICR7Q01BS0VfQ1VSUkVOVF9CSU5BUllfRElS
fS9tYWtlRm9yd2FyZGluZ0hlYWRlcnMuY21ha2UpCiAgICAgICAgIHNldChjb250ZW50ICIiKQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>334835</attachid>
            <date>2018-03-01 12:02:32 -0800</date>
            <delta_ts>2018-03-01 12:25:06 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-183251.diff</filename>
            <type>text/plain</type>
            <size>3788</size>
            <attacher name="Don Olmstead">don.olmstead</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzODgzNTVlYjhkMy4uNmUw
ZmJjZGYwZmYgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwxMiBAQAorMjAxOC0wMy0wMSAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29t
PgorCisgICAgICAgIFtDTWFrZV0gU3BsaXQgSlNDIGhlYWRlciBjb3B5aW5nIGludG8gcHVibGlj
IGFuZCBwcml2YXRlIHRhcmdldHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTE4MzI1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZToKKwogMjAxOC0w
Mi0yNiAgWW91c3VrZSBLaW1vdG8gIDx5b3VzdWtlLmtpbW90b0Bzb255LmNvbT4KIAogICAgICAg
ICBbV2luQ2Fpcm9dIFdlYktpdDJfQy5oIHNob3VsZCBiZSBpbmNsdWRlZCBmb3IgVGVzdFdlYktp
dApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291
cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4IDcxYmRmYmMyOTM1Li5lZGE1
ZWViOTY5MiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0
CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMjUzLDYgKzI1
Myw3IEBAIGFkZF9leGVjdXRhYmxlKExMSW50T2Zmc2V0c0V4dHJhY3RvcgogICAgICR7REVSSVZF
RF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vTExJbnREZXNpcmVkT2Zmc2V0cy5oICR7REVS
SVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vQnl0ZWNvZGVzLmggJHtERVJJVkVEX1NP
VVJDRVNfSkFWQVNDUklQVENPUkVfRElSfS9CeXRlY29kZVN0cnVjdHMuaAogKQogdGFyZ2V0X2xp
bmtfbGlicmFyaWVzKExMSW50T2Zmc2V0c0V4dHJhY3RvciBXVEYpCithZGRfZGVwZW5kZW5jaWVz
KExMSW50T2Zmc2V0c0V4dHJhY3RvciBKYXZhU2NyaXB0Q29yZUZvcndhcmRpbmdIZWFkZXJzKQog
CiAjIFRoZSBidWlsZCBzeXN0ZW0gd2lsbCBleGVjdXRlIGFzbS5yYiBldmVyeSB0aW1lIExMSW50
T2Zmc2V0c0V4dHJhY3RvcidzIG10aW1lIGlzIG5ld2VyIHRoYW4KICMgTExJbnRBc3NlbWJseS5o
J3MgbXRpbWUuIFRoZSBwcm9ibGVtIHdlIGhhdmUgaGVyZSBpczogYXNtLnJiIGhhcyBzb21lIGJ1
aWx0LWluIG9wdGltaXphdGlvbgpAQCAtMTE3Myw3ICsxMTc0LDEzIEBAIFdFQktJVF9GUkFNRVdP
UktfREVDTEFSRShKYXZhU2NyaXB0Q29yZSkKIFdFQktJVF9JTkNMVURFX0NPTkZJR19GSUxFU19J
Rl9FWElTVFMoKQogCiBXRUJLSVRfTUFLRV9GT1JXQVJESU5HX0hFQURFUlMoSmF2YVNjcmlwdENv
cmUKLSAgICBGSUxFUyAke0phdmFTY3JpcHRDb3JlX1BVQkxJQ19GUkFNRVdPUktfSEVBREVSU30g
JHtKYXZhU2NyaXB0Q29yZV9QUklWQVRFX0ZSQU1FV09SS19IRUFERVJTfQorICAgIEZJTEVTICR7
SmF2YVNjcmlwdENvcmVfUFVCTElDX0ZSQU1FV09SS19IRUFERVJTfQorICAgIEZMQVRURU5FRAor
KQorCitXRUJLSVRfTUFLRV9GT1JXQVJESU5HX0hFQURFUlMoSmF2YVNjcmlwdENvcmUKKyAgICBU
QVJHRVRfTkFNRSBKYXZhU2NyaXB0Q29yZVByaXZhdGVGb3J3YXJkaW5nSGVhZGVycworICAgIEZJ
TEVTICR7SmF2YVNjcmlwdENvcmVfUFJJVkFURV9GUkFNRVdPUktfSEVBREVSU30KICAgICBERVJJ
VkVEX1NPVVJDRV9ESVJFQ1RPUklFUyAke0RFUklWRURfU09VUkNFU19ESVJ9L0phdmFTY3JpcHRD
b3JlICR7REVSSVZFRF9TT1VSQ0VTX0RJUn0vSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yCiAgICAg
RkxBVFRFTkVECiApCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n
IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBjNWRlOGI2OGRjZC4uZjBm
YjAzNGFlYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysr
IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE4
LTAzLTAxICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAgICAgICAg
W0NNYWtlXSBTcGxpdCBKU0MgaGVhZGVyIGNvcHlpbmcgaW50byBwdWJsaWMgYW5kIHByaXZhdGUg
dGFyZ2V0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTgzMjUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
KiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxOC0wMy0wMSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUu
dGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXggZXhjZXB0aW9uIGNoZWNr
IGZvciBFeGNlcHRpb25TY29wZQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jv
cy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UKaW5kZXggYTFlN2U4ZjVh
NzUuLjM2ZTVhMDIwMGM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0TWFjcm9zLmNt
YWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UKQEAgLTIxNyw3ICsyMTcs
NyBAQCBlbmRtYWNybygpCiAKIGZ1bmN0aW9uKFdFQktJVF9NQUtFX0ZPUldBUkRJTkdfSEVBREVS
UyBmcmFtZXdvcmspCiAgICAgc2V0KG9wdGlvbnMgRkxBVFRFTkVEKQotICAgIHNldChvbmVWYWx1
ZUFyZ3MgREVTVElOQVRJT04pCisgICAgc2V0KG9uZVZhbHVlQXJncyBERVNUSU5BVElPTiBUQVJH
RVRfTkFNRSkKICAgICBzZXQobXVsdGlWYWx1ZUFyZ3MgRElSRUNUT1JJRVMgRVhUUkFfRElSRUNU
T1JJRVMgREVSSVZFRF9TT1VSQ0VfRElSRUNUT1JJRVMgRklMRVMpCiAgICAgY21ha2VfcGFyc2Vf
YXJndW1lbnRzKG9wdCAiJHtvcHRpb25zfSIgIiR7b25lVmFsdWVBcmdzfSIgIiR7bXVsdGlWYWx1
ZUFyZ3N9IiAke0FSR059KQogICAgIHNldChoZWFkZXJzICR7b3B0X0ZJTEVTfSkKQEAgLTI2Myw4
ICsyNjMsMTMgQEAgZnVuY3Rpb24oV0VCS0lUX01BS0VfRk9SV0FSRElOR19IRUFERVJTIGZyYW1l
d29yaykKICAgICAgICAgICAgIGxpc3QoQVBQRU5EIGZ3ZF9oZWFkZXJzICR7ZndkX2hlYWRlcn0p
CiAgICAgICAgIGVuZGZvcmVhY2ggKCkKICAgICBlbmRmb3JlYWNoICgpCi0gICAgYWRkX2N1c3Rv
bV90YXJnZXQoJHtmcmFtZXdvcmt9Rm9yd2FyZGluZ0hlYWRlcnMgREVQRU5EUyAke2Z3ZF9oZWFk
ZXJzfSkKLSAgICBhZGRfZGVwZW5kZW5jaWVzKCR7ZnJhbWV3b3JrfSAke2ZyYW1ld29ya31Gb3J3
YXJkaW5nSGVhZGVycykKKyAgICBpZiAob3B0X1RBUkdFVF9OQU1FKQorICAgICAgICBzZXQodGFy
Z2V0X25hbWUgJHtvcHRfVEFSR0VUX05BTUV9KQorICAgIGVsc2UgKCkKKyAgICAgICAgc2V0KHRh
cmdldF9uYW1lICR7ZnJhbWV3b3JrfUZvcndhcmRpbmdIZWFkZXJzKQorICAgIGVuZGlmICgpCisg
ICAgYWRkX2N1c3RvbV90YXJnZXQoJHt0YXJnZXRfbmFtZX0gREVQRU5EUyAke2Z3ZF9oZWFkZXJz
fSkKKyAgICBhZGRfZGVwZW5kZW5jaWVzKCR7ZnJhbWV3b3JrfSAke3RhcmdldF9uYW1lfSkKICAg
ICBpZiAob3B0X0RFUklWRURfU09VUkNFX0RJUkVDVE9SSUVTKQogICAgICAgICBzZXQoc2NyaXB0
ICR7Q01BS0VfQ1VSUkVOVF9CSU5BUllfRElSfS9tYWtlRm9yd2FyZGluZ0hlYWRlcnMuY21ha2Up
CiAgICAgICAgIHNldChjb250ZW50ICIiKQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>334837</attachid>
            <date>2018-03-01 12:25:06 -0800</date>
            <delta_ts>2018-03-05 05:28:49 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-183251.diff</filename>
            <type>text/plain</type>
            <size>4848</size>
            <attacher name="Don Olmstead">don.olmstead</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzODgzNTVlYjhkMy4uNmUw
ZmJjZGYwZmYgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwxMiBAQAorMjAxOC0wMy0wMSAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29t
PgorCisgICAgICAgIFtDTWFrZV0gU3BsaXQgSlNDIGhlYWRlciBjb3B5aW5nIGludG8gcHVibGlj
IGFuZCBwcml2YXRlIHRhcmdldHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTE4MzI1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZToKKwogMjAxOC0w
Mi0yNiAgWW91c3VrZSBLaW1vdG8gIDx5b3VzdWtlLmtpbW90b0Bzb255LmNvbT4KIAogICAgICAg
ICBbV2luQ2Fpcm9dIFdlYktpdDJfQy5oIHNob3VsZCBiZSBpbmNsdWRlZCBmb3IgVGVzdFdlYktp
dApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291
cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4IDcxYmRmYmMyOTM1Li5lZGE1
ZWViOTY5MiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0
CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMjUzLDYgKzI1
Myw3IEBAIGFkZF9leGVjdXRhYmxlKExMSW50T2Zmc2V0c0V4dHJhY3RvcgogICAgICR7REVSSVZF
RF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vTExJbnREZXNpcmVkT2Zmc2V0cy5oICR7REVS
SVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vQnl0ZWNvZGVzLmggJHtERVJJVkVEX1NP
VVJDRVNfSkFWQVNDUklQVENPUkVfRElSfS9CeXRlY29kZVN0cnVjdHMuaAogKQogdGFyZ2V0X2xp
bmtfbGlicmFyaWVzKExMSW50T2Zmc2V0c0V4dHJhY3RvciBXVEYpCithZGRfZGVwZW5kZW5jaWVz
KExMSW50T2Zmc2V0c0V4dHJhY3RvciBKYXZhU2NyaXB0Q29yZUZvcndhcmRpbmdIZWFkZXJzKQog
CiAjIFRoZSBidWlsZCBzeXN0ZW0gd2lsbCBleGVjdXRlIGFzbS5yYiBldmVyeSB0aW1lIExMSW50
T2Zmc2V0c0V4dHJhY3RvcidzIG10aW1lIGlzIG5ld2VyIHRoYW4KICMgTExJbnRBc3NlbWJseS5o
J3MgbXRpbWUuIFRoZSBwcm9ibGVtIHdlIGhhdmUgaGVyZSBpczogYXNtLnJiIGhhcyBzb21lIGJ1
aWx0LWluIG9wdGltaXphdGlvbgpAQCAtMTE3Myw3ICsxMTc0LDEzIEBAIFdFQktJVF9GUkFNRVdP
UktfREVDTEFSRShKYXZhU2NyaXB0Q29yZSkKIFdFQktJVF9JTkNMVURFX0NPTkZJR19GSUxFU19J
Rl9FWElTVFMoKQogCiBXRUJLSVRfTUFLRV9GT1JXQVJESU5HX0hFQURFUlMoSmF2YVNjcmlwdENv
cmUKLSAgICBGSUxFUyAke0phdmFTY3JpcHRDb3JlX1BVQkxJQ19GUkFNRVdPUktfSEVBREVSU30g
JHtKYXZhU2NyaXB0Q29yZV9QUklWQVRFX0ZSQU1FV09SS19IRUFERVJTfQorICAgIEZJTEVTICR7
SmF2YVNjcmlwdENvcmVfUFVCTElDX0ZSQU1FV09SS19IRUFERVJTfQorICAgIEZMQVRURU5FRAor
KQorCitXRUJLSVRfTUFLRV9GT1JXQVJESU5HX0hFQURFUlMoSmF2YVNjcmlwdENvcmUKKyAgICBU
QVJHRVRfTkFNRSBKYXZhU2NyaXB0Q29yZVByaXZhdGVGb3J3YXJkaW5nSGVhZGVycworICAgIEZJ
TEVTICR7SmF2YVNjcmlwdENvcmVfUFJJVkFURV9GUkFNRVdPUktfSEVBREVSU30KICAgICBERVJJ
VkVEX1NPVVJDRV9ESVJFQ1RPUklFUyAke0RFUklWRURfU09VUkNFU19ESVJ9L0phdmFTY3JpcHRD
b3JlICR7REVSSVZFRF9TT1VSQ0VTX0RJUn0vSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yCiAgICAg
RkxBVFRFTkVECiApCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n
IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBjNWRlOGI2OGRjZC4uZjBm
YjAzNGFlYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysr
IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE4
LTAzLTAxICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAgICAgICAg
W0NNYWtlXSBTcGxpdCBKU0MgaGVhZGVyIGNvcHlpbmcgaW50byBwdWJsaWMgYW5kIHByaXZhdGUg
dGFyZ2V0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTgzMjUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
KiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxOC0wMy0wMSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUu
dGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXggZXhjZXB0aW9uIGNoZWNr
IGZvciBFeGNlcHRpb25TY29wZQpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQ2hhbmdl
TG9nIGIvU291cmNlL1RoaXJkUGFydHkvQ2hhbmdlTG9nCmluZGV4IDRjMDc4MGY1NWFmLi4xZjg4
ZWVhOTk1NCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE4LTAzLTAxICBE
b24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAgICAgICAgW0NNYWtlXSBT
cGxpdCBKU0MgaGVhZGVyIGNvcHlpbmcgaW50byBwdWJsaWMgYW5kIHByaXZhdGUgdGFyZ2V0cwor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzMjUxCisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBndGVzdC9D
TWFrZUxpc3RzLnR4dDoKKwogMjAxOC0wMi0wNiAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFk
QHNvbnkuY29tPgogCiAgICAgICAgIFJlbW92ZSBXZWJDb3JlL0ZvcndhcmRpbmdIZWFkZXJzIGRp
cmVjdG9yeQpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvZ3Rlc3QvQ01ha2VMaXN0cy50
eHQgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9ndGVzdC9DTWFrZUxpc3RzLnR4dAppbmRleCBkMjk3ZWJm
ODY3Yi4uOTlmN2ZiMDQ2ZjkgMTAwNzU1Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0L0NN
YWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0L0NNYWtlTGlzdHMudHh0
CkBAIC00Niw3ICs0Niw3IEBAIGVuZGlmICgpCiB0YXJnZXRfbGlua19saWJyYXJpZXMoZ3Rlc3QK
ICAgICBXVEYKICkKLWFkZF9kZXBlbmRlbmNpZXMoZ3Rlc3QgSmF2YVNjcmlwdENvcmVGb3J3YXJk
aW5nSGVhZGVycykKK2FkZF9kZXBlbmRlbmNpZXMoZ3Rlc3QgSmF2YVNjcmlwdENvcmVQcml2YXRl
Rm9yd2FyZGluZ0hlYWRlcnMpCiAKIGlmIChDTUFLRV9VU0VfUFRIUkVBRFNfSU5JVCkKICAgICB0
YXJnZXRfbGlua19saWJyYXJpZXMoZ3Rlc3QgJHtDTUFLRV9USFJFQURfTElCU19JTklUfSkKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UgYi9Tb3VyY2UvY21ha2Uv
V2ViS2l0TWFjcm9zLmNtYWtlCmluZGV4IGExZTdlOGY1YTc1Li4zNmU1YTAyMDBjOSAxMDA2NDQK
LS0tIGEvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2Uv
V2ViS2l0TWFjcm9zLmNtYWtlCkBAIC0yMTcsNyArMjE3LDcgQEAgZW5kbWFjcm8oKQogCiBmdW5j
dGlvbihXRUJLSVRfTUFLRV9GT1JXQVJESU5HX0hFQURFUlMgZnJhbWV3b3JrKQogICAgIHNldChv
cHRpb25zIEZMQVRURU5FRCkKLSAgICBzZXQob25lVmFsdWVBcmdzIERFU1RJTkFUSU9OKQorICAg
IHNldChvbmVWYWx1ZUFyZ3MgREVTVElOQVRJT04gVEFSR0VUX05BTUUpCiAgICAgc2V0KG11bHRp
VmFsdWVBcmdzIERJUkVDVE9SSUVTIEVYVFJBX0RJUkVDVE9SSUVTIERFUklWRURfU09VUkNFX0RJ
UkVDVE9SSUVTIEZJTEVTKQogICAgIGNtYWtlX3BhcnNlX2FyZ3VtZW50cyhvcHQgIiR7b3B0aW9u
c30iICIke29uZVZhbHVlQXJnc30iICIke211bHRpVmFsdWVBcmdzfSIgJHtBUkdOfSkKICAgICBz
ZXQoaGVhZGVycyAke29wdF9GSUxFU30pCkBAIC0yNjMsOCArMjYzLDEzIEBAIGZ1bmN0aW9uKFdF
QktJVF9NQUtFX0ZPUldBUkRJTkdfSEVBREVSUyBmcmFtZXdvcmspCiAgICAgICAgICAgICBsaXN0
KEFQUEVORCBmd2RfaGVhZGVycyAke2Z3ZF9oZWFkZXJ9KQogICAgICAgICBlbmRmb3JlYWNoICgp
CiAgICAgZW5kZm9yZWFjaCAoKQotICAgIGFkZF9jdXN0b21fdGFyZ2V0KCR7ZnJhbWV3b3JrfUZv
cndhcmRpbmdIZWFkZXJzIERFUEVORFMgJHtmd2RfaGVhZGVyc30pCi0gICAgYWRkX2RlcGVuZGVu
Y2llcygke2ZyYW1ld29ya30gJHtmcmFtZXdvcmt9Rm9yd2FyZGluZ0hlYWRlcnMpCisgICAgaWYg
KG9wdF9UQVJHRVRfTkFNRSkKKyAgICAgICAgc2V0KHRhcmdldF9uYW1lICR7b3B0X1RBUkdFVF9O
QU1FfSkKKyAgICBlbHNlICgpCisgICAgICAgIHNldCh0YXJnZXRfbmFtZSAke2ZyYW1ld29ya31G
b3J3YXJkaW5nSGVhZGVycykKKyAgICBlbmRpZiAoKQorICAgIGFkZF9jdXN0b21fdGFyZ2V0KCR7
dGFyZ2V0X25hbWV9IERFUEVORFMgJHtmd2RfaGVhZGVyc30pCisgICAgYWRkX2RlcGVuZGVuY2ll
cygke2ZyYW1ld29ya30gJHt0YXJnZXRfbmFtZX0pCiAgICAgaWYgKG9wdF9ERVJJVkVEX1NPVVJD
RV9ESVJFQ1RPUklFUykKICAgICAgICAgc2V0KHNjcmlwdCAke0NNQUtFX0NVUlJFTlRfQklOQVJZ
X0RJUn0vbWFrZUZvcndhcmRpbmdIZWFkZXJzLmNtYWtlKQogICAgICAgICBzZXQoY29udGVudCAi
IikK
</data>
<flag name="review"
          id="353545"
          type_id="1"
          status="+"
          setter="annulen"
    />
    <flag name="commit-queue"
          id="353701"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
      

    </bug>

</bugzilla>