183072 2018-02-22 20:17:11 -0800 Clang reports undefined reference errors of poison variables while building LLIntOffsetsExtractor with -gsplit-dwarf 2022-02-28 12:14:19 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID P2 Normal --- 145121 1 fujii fujii ews-watchlist keith_miller mark.lam msaboff saam oldest_to_newest 1401638 0 fujii 2018-02-22 20:17:11 -0800 CC=clang-5.0 CXX=clang++-5.0 ./Tools/Scripts/build-webkit --gtk --debug > [1/2400] Linking CXX executable bin/LLIntOffsetsExtractor > FAILED: bin/LLIntOffsetsExtractor > : && /usr/bin/clang++-5.0 -fdiagnostics-color=always -fcolor-diagnostics -Wno-parentheses-equality -Wno-noexcept-type -Qunused-arguments -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wextra -Wall -fno-strict-aliasing -fno-exceptions -std=c++14 -fno-rtti -gsplit-dwarf -g -L/home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Root/lib -fuse-ld=gold -Wl,--disable-new-dtags -Wl,--gdb-index -rdynamic Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o -o bin/LLIntOffsetsExtractor lib/libWTFGTK.a lib/libbmalloc.a -ldl -licudata -licui18n -licuuc -lpthread -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lz && : > Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o(.debug_addr+0x8): error: undefined reference to 'g_NativeCodePoison' > Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o(.debug_addr+0x10): error: undefined reference to 'g_JITCodePoison' > Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o(.debug_addr+0x18): error: undefined reference to 'g_UnlinkedSourceCodePoison' > Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o(.debug_addr+0x20): error: undefined reference to 'g_JSFunctionPoison' > Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o(.debug_addr+0x28): error: undefined reference to 'g_GlobalDataPoison' > Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o(.debug_addr+0x30): error: undefined reference to 'g_JSGlobalObjectPoison' > Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o(.debug_addr+0x38): error: undefined reference to 'g_CodeBlockPoison' > clang: error: linker command failed with exit code 1 (use -v to see invocation) 1401654 1 fujii 2018-02-22 22:32:14 -0800 I created a reduced LLIntOffsetsExtractor.cpp: https://gist.github.com/fujii/9940945fc788aba2577e41eb06ec7271 This is caused by -gsplit-dwarf. > fujii@ubuntu $ clang++-5.0 -std=c++14 -gsplit-dwarf LLIntOffsetsExtractor.cpp > /tmp/LLIntOffsetsExtractor-15eec5.o:(.debug_addr+0x0): undefined reference to `g_JITCodePoison' > clang: error: linker command failed with exit code 1 (use -v to see invocation) > fujii@ubuntu $ clang++-5.0 -std=c++14 LLIntOffsetsExtractor.cpp > fujii@ubuntu $ This is a document about .debug_addr. https://gcc.gnu.org/wiki/DebugFission 1401655 2 fujii 2018-02-22 22:36:30 -0800 GTK port release builds has no problem because it doesn't use -gsplit-dwarf. > [1/1] : && /usr/bin/clang++-5.0 -fdiagnostics-color=always -fcolor-diagnostics -Wno-parentheses-equality -Wno-noexcept-type -Qunused-arguments -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wextra -Wall -fno-strict-aliasing -fno-exceptions -std=c++14 -fno-rtti -O3 -DNDEBUG -L/home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Root/lib -fuse-ld=gold -Wl,--disable-new-dtags -rdynamic Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o -o bin/LLIntOffsetsExtractor lib/libWTFGTK.a lib/libbmalloc.a -ldl -licudata -licui18n -licuuc -lpthread -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lz && : 1401656 3 fujii 2018-02-22 22:38:47 -0800 GCC doesn't seem to have this issue. $ g++-7 -std=c++14 -gsplit-dwarf LLIntOffsetsExtractor.cpp 1401661 4 334505 fujii 2018-02-22 22:48:58 -0800 Created attachment 334505 Patch 1401662 5 ews-watchlist 2018-02-22 22:51:48 -0800 Attachment 334505 did not pass style-queue: ERROR: Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:68: POISON_KEY_NAME is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1401663 6 334505 mark.lam 2018-02-22 23:08:26 -0800 Comment on attachment 334505 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334505&action=review > Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:69 > +#define DEFINE_POISON(poisonID) \ > + uintptr_t POISON_KEY_NAME(poisonID); > +FOR_EACH_JSC_POISON(DEFINE_POISON) Why is this necessary at all? We don't ever use these as offsets. So, I find it suspicious that we need them here. Secondly, the LLInt asm code only refers to them as global addresses that should come from the JavaScriptCore library. Fabricating a second set of such variables here in LLIntOffsetsExtractor will only at best stop the compiler from complaining, but any addresses or offsets generated from these will have nothing to do with the versions in the JavaScriptCore library. As such, you'll definitely be getting wrong values. Hence, I'm not sure that this is not the right solution. r- for now. Can you explain what -gsplit-dwarf is and what does it have to do with triggering this issue? 1846723 7 fujii 2022-02-28 12:14:19 -0800 I don't see this issue with the latest GTK port. Closed as INVALID. 334505 2018-02-22 22:48:58 -0800 2022-02-27 23:30:08 -0800 Patch bug-183072-20180222224839.patch text/plain 1390 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4Nzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 ZDNkZTAxYWUzY2Y0ZDE5N2M5YjIzMjcxOGE1ZmEzZGRkZDY4NzBmLi41ZTZiYjNhYmVlYmM2NDNl ODU3ZTVmYjMxNjRmMjFjY2RlZGRmYmE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxOC0wMi0yMiAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBDbGFuZyByZXBvcnRzIHVuZGVmaW5lZCByZWZlcmVuY2UgZXJy b3JzIG9mIHBvaXNvbiB2YXJpYWJsZXMgd2hpbGUgYnVpbGRpbmcgTExJbnRPZmZzZXRzRXh0cmFj dG9yIHdpdGggLWdzcGxpdC1kd2FyZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTgzMDcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBsbGludC9MTEludE9mZnNldHNFeHRyYWN0b3IuY3BwOiBEZWZpbmUg cG9pc29uIHZhcmlhYmxlcyBpbiB0aGlzIGZpbGUuCisKIDIwMTgtMDItMTQgIFl1c3VrZSBTdXp1 a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0ZUTF0gU3VwcG9ydCBBcnJh eVB1c2ggZm9yIEFycmF5U3RvcmFnZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2xsaW50L0xMSW50T2Zmc2V0c0V4dHJhY3Rvci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv bGxpbnQvTExJbnRPZmZzZXRzRXh0cmFjdG9yLmNwcAppbmRleCA1NmFjZWQ3NjVjYzRjMzMzNDFm MzhkYTYyYjFiOTAxYWYyMjU3YWFlLi5jYWE5YjdlOGI4ZmEyNzJlMjQ2MGJkMWUzY2YwODNiNTIz MmE2OTRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnRPZmZz ZXRzRXh0cmFjdG9yLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnRP ZmZzZXRzRXh0cmFjdG9yLmNwcApAQCAtNjQsNiArNjQsMTAgQEAKIAogbmFtZXNwYWNlIEpTQyB7 CiAKKyNkZWZpbmUgREVGSU5FX1BPSVNPTihwb2lzb25JRCkgXAorICAgIHVpbnRwdHJfdCBQT0lT T05fS0VZX05BTUUocG9pc29uSUQpOworRk9SX0VBQ0hfSlNDX1BPSVNPTihERUZJTkVfUE9JU09O KQorCiAjZGVmaW5lIE9GRkxJTkVfQVNNX09GRlNFVE9GKGNsYXp6LCBmaWVsZCkgKHN0YXRpY19j YXN0PHVuc2lnbmVkPihPQkpFQ1RfT0ZGU0VUT0YoY2xhenosIGZpZWxkKSkpCiAKIGNsYXNzIExM SW50T2Zmc2V0c0V4dHJhY3RvciB7Cg==