<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>182969</bug_id>
          
          <creation_ts>2018-02-20 06:24:18 -0800</creation_ts>
          <short_desc>[WinCairo] Fix compile errors in WebPageWin.cpp and WebProcessWin.cpp due to WebCore forwarding header paths</short_desc>
          <delta_ts>2018-02-22 11:52:24 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>174003</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Yousuke Kimoto">Yousuke.Kimoto</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>achristensen</cc>
    
    <cc>annulen</cc>
    
    <cc>basuke</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>don.olmstead</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1400747</commentid>
    <comment_count>0</comment_count>
    <who name="Yousuke Kimoto">Yousuke.Kimoto</who>
    <bug_when>2018-02-20 06:24:18 -0800</bug_when>
    <thetext>WebPageWin.cpp and WebProcessWin.cpp refer header files for WebCore with an incorrect include style, which should be &lt;WebCore/xxxx.h&gt;.
In this ticket, styles to include the following header are fixed.
For WebPageWin.cpp:
- NotImplemented.h
- WindowsKeyboardCodes.h
For WebProcessWin.cpp:
- SharedBuffer.h</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1400749</commentid>
    <comment_count>1</comment_count>
      <attachid>334265</attachid>
    <who name="Yousuke Kimoto">Yousuke.Kimoto</who>
    <bug_when>2018-02-20 06:28:17 -0800</bug_when>
    <thetext>Created attachment 334265
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1400871</commentid>
    <comment_count>2</comment_count>
      <attachid>334265</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-02-20 12:13:14 -0800</bug_when>
    <thetext>Comment on attachment 334265
Patch

Rejecting attachment 334265 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.webkit.org&apos;, &apos;--bot-id=webkit-cq-02&apos;, &apos;land-attachment&apos;, &apos;--force-clean&apos;, &apos;--non-interactive&apos;, &apos;--parent-command=commit-queue&apos;, 334265, &apos;--port=mac&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
rdparty/autoinstalled/mechanize/_urllib2_fork.py&quot;, line 332, in _call_chain
    result = func(*args)
  File &quot;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py&quot;, line 1170, in https_open
    return self.do_open(conn_factory, req)
  File &quot;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py&quot;, line 1118, in do_open
    raise URLError(err)
urllib2.URLError: &lt;urlopen error [Errno 60] Operation timed out&gt;

Full output: http://webkit-queues.webkit.org/results/6593997</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1401491</commentid>
    <comment_count>3</comment_count>
      <attachid>334265</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-02-22 11:51:02 -0800</bug_when>
    <thetext>Comment on attachment 334265
Patch

Clearing flags on attachment: 334265

Committed r228929: &lt;https://trac.webkit.org/changeset/228929&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1401492</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-02-22 11:51:03 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1401493</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-02-22 11:52:24 -0800</bug_when>
    <thetext>&lt;rdar://problem/37796359&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>334265</attachid>
            <date>2018-02-20 06:28:17 -0800</date>
            <delta_ts>2018-02-22 11:51:02 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-182969-20180220232842.patch</filename>
            <type>text/plain</type>
            <size>2303</size>
            <attacher name="Yousuke Kimoto">Yousuke.Kimoto</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4NjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDcyYmZkN2JlNmQ1N2MxMDM5
YWZhYTMxNjRlYTkxN2Y2OGVlZWRmYmMuLjdmZGYyMmRkZGM4YmI0NTQyOGQ0NzZhZDhkM2Q1MmI0
ZTkzYWFkYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDItMjAgIFlvdXN1a2Ug
S2ltb3RvICA8eW91c3VrZS5raW1vdG9Ac29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXSBG
aXggY29tcGlsZSBlcnJvcnMgaW4gV2ViUGFnZVdpbi5jcHAgYW5kIFdlYlByb2Nlc3NXaW4uY3Bw
IGR1ZSB0byBXZWJDb3JlIGZvcndhcmRpbmcgaGVhZGVyIHBhdGhzCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI5NjkKKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS93aW4v
V2ViUGFnZVdpbi5jcHA6CisgICAgICAgICogV2ViUHJvY2Vzcy93aW4vV2ViUHJvY2Vzc1dpbi5j
cHA6CisKIDIwMTgtMDItMTggIFJlemEgQWJiYXNpYW4gIDxyYWJiYXNpYW5AYXBwbGUuY29tPgog
CiAgICAgICAgIFNldCB0aGUgYXBwcm9wcmlhdGUgQXV0b0ZpbGwgY29udGV4dCBmb3Igc3VnZ2Vz
dGVkIHBhc3N3b3Jkcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQ
YWdlL3dpbi9XZWJQYWdlV2luLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdl
L3dpbi9XZWJQYWdlV2luLmNwcAppbmRleCAwOGQ3ZWM5ZGJkNDdjM2MyY2ViN2I5MTQ1NGJmZWU2
OTY1OWRiNTUzLi4xMzk4MmRkNDY3MjcwNmFiMGRmNzA3ZGE3Y2NmYTk3YjBlZjEwN2NlIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS93aW4vV2ViUGFnZVdpbi5j
cHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2Uvd2luL1dlYlBhZ2VXaW4u
Y3BwCkBAIC0yOCwxMiArMjgsMTAgQEAKICNpbmNsdWRlICJXZWJQYWdlLmgiCiAKICNpbmNsdWRl
ICJFZGl0b3JTdGF0ZS5oIgotI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCiAjaW5jbHVkZSAi
V2ViRXZlbnQuaCIKICNpbmNsdWRlICJXZWJGcmFtZS5oIgogI2luY2x1ZGUgIldlYlBhZ2VQcm94
eU1lc3NhZ2VzLmgiCiAjaW5jbHVkZSAiV2ViUHJvY2Vzcy5oIgotI2luY2x1ZGUgIldpbmRvd3NL
ZXlib2FyZENvZGVzLmgiCiAjaW5jbHVkZSA8V2ViQ29yZS9CYWNrRm9yd2FyZENvbnRyb2xsZXIu
aD4KICNpbmNsdWRlIDxXZWJDb3JlL0V2ZW50SGFuZGxlci5oPgogI2luY2x1ZGUgPFdlYkNvcmUv
RXZlbnROYW1lcy5oPgpAQCAtNDEsMTEgKzM5LDEzIEBACiAjaW5jbHVkZSA8V2ViQ29yZS9GcmFt
ZS5oPgogI2luY2x1ZGUgPFdlYkNvcmUvRnJhbWVWaWV3Lmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9L
ZXlib2FyZEV2ZW50Lmg+CisjaW5jbHVkZSA8V2ViQ29yZS9Ob3RJbXBsZW1lbnRlZC5oPgogI2lu
Y2x1ZGUgPFdlYkNvcmUvUGFnZS5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUGxhdGZvcm1LZXlib2Fy
ZEV2ZW50Lmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9TZXR0aW5ncy5oPgogI2luY2x1ZGUgPFdlYkNv
cmUvU2hhcmVkQnVmZmVyLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9Vc2VyQWdlbnQuaD4KKyNpbmNs
dWRlIDxXZWJDb3JlL1dpbmRvd3NLZXlib2FyZENvZGVzLmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBX
ZWJDb3JlOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mvd2luL1dlYlBy
b2Nlc3NXaW4uY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL3dpbi9XZWJQcm9jZXNzV2lu
LmNwcAppbmRleCBlY2I2MmNiMGE3MzI3ZWY2OTFmNGM5MTBkNjAxN2NiMGQwODQyOTM0Li4xNzM5
NTFmNWU2MTNhNDVkYTE1NTFhODYyZjdkMWE3MDRiMWYxYzllIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViS2l0L1dlYlByb2Nlc3Mvd2luL1dlYlByb2Nlc3NXaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJL
aXQvV2ViUHJvY2Vzcy93aW4vV2ViUHJvY2Vzc1dpbi5jcHAKQEAgLTI2LDcgKzI2LDcgQEAKICNp
bmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJXZWJQcm9jZXNzLmgiCiAKLSNpbmNsdWRlICJT
aGFyZWRCdWZmZXIuaCIKKyNpbmNsdWRlIDxXZWJDb3JlL1NoYXJlZEJ1ZmZlci5oPgogCiB1c2lu
ZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>