182870 2018-02-16 05:29:34 -0800 [WinCairo] Fix compile errors of WebProcess and NetworkProcess due to no implementation for windows 2018-02-21 14:19:47 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 174003 1 Yousuke.Kimoto webkit-unassigned achristensen ap beidson cdumez commit-queue darin don.olmstead koivisto webkit-bug-importer youennf oldest_to_newest 1399865 0 Yousuke.Kimoto 2018-02-16 05:29:34 -0800 Some WebKit sources of WebProcess and NetworkProcess don't have appropriate implementation for the windows port, so many compile errors occur. This ticket solves this issue which comes from the following files: - Source/WebKit/NetworkProcess/NetworkProcess.cpp - Source/WebKit/WebProcess/Plugins/PluginProcessConnectionManager.cpp - Source/WebKit/WebProcess/WebPage/WebInspector.cpp - Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp - Source/WebKit/WebProcess/WebProcess.cpp 1399870 1 334037 Yousuke.Kimoto 2018-02-16 05:39:58 -0800 Created attachment 334037 bz182870-1.patch 1401253 2 334037 commit-queue 2018-02-21 13:41:11 -0800 Comment on attachment 334037 bz182870-1.patch Clearing flags on attachment: 334037 Committed r228893: <https://trac.webkit.org/changeset/228893> 1401254 3 commit-queue 2018-02-21 13:41:12 -0800 All reviewed patches have been landed. Closing bug. 1401255 4 webkit-bug-importer 2018-02-21 13:44:24 -0800 <rdar://problem/37759301> 1401268 5 cdumez 2018-02-21 14:19:47 -0800 Was there discussion on the mailing list about adding support for Windows to WebKit2? 334037 2018-02-16 05:39:58 -0800 2018-02-21 13:41:11 -0800 bz182870-1.patch bz182870-1.patch text/plain 5596 Yousuke.Kimoto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYTI3YWViNi4uNTYwN2ZkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAor MjAxOC0wMi0xNiAgWW91c3VrZSBLaW1vdG8gIDx5b3VzdWtlLmtpbW90b0Bzb255LmNvbT4KKwor ICAgICAgICBbV2luQ2Fpcm9dIEZpeCBjb21waWxlIGVycm9ycyBvZiBXZWJQcm9jZXNzIGFuZCBO ZXR3b3JrUHJvY2VzcyBkdWUgdG8gbm8gaW1wbGVtZW50YXRpb24gZm9yIHdpbmRvd3MKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Mjg3MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTmV0d29ya1Byb2Nl c3MvTmV0d29ya1Byb2Nlc3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUHJvY2Vzczo6 Y3JlYXRlTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MpOgorICAgICAgICAqIFdlYlByb2Nl c3MvUGx1Z2lucy9QbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbk1hbmFnZXIuY3BwOgorICAgICAgICAo V2ViS2l0OjpQbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbk1hbmFnZXI6OmdldFBsdWdpblByb2Nlc3ND b25uZWN0aW9uKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViSW5zcGVjdG9yLmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yOjpvcGVuRnJvbnRlbmRDb25uZWN0aW9u KToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViSW5zcGVjdG9yVUkuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JVSTo6ZXN0YWJsaXNoQ29ubmVjdGlvbik6CisgICAg ICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJv Y2Vzczo6ZW5zdXJlTmV0d29ya1Byb2Nlc3NDb25uZWN0aW9uKToKKwogMjAxOC0wMi0xNSAgSmll d2VuIFRhbiAgPGppZXdlbl90YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJBdXRoTl0gUmV2 aXNpdCB0aGUgd2hvbGUgYXN5bmMgbW9kZWwgb2YgdGFzayBkaXNwYXRjaGluZywgdGltZW91dCBh bmQgYWJvcnRpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0 d29ya1Byb2Nlc3MuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJv Y2Vzcy5jcHAKaW5kZXggNjhiNzBhMC4uMzZiYmJmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKQEAgLTEsNSArMSw2IEBACiAvKgogICog Q29weXJpZ2h0IChDKSAyMDEyLTIwMTcgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgor ICogQ29weXJpZ2h0IChDKSAyMDE4IFNvbnkgSW50ZXJhY3RpdmUgRW50ZXJ0YWlubWVudCBJbmMu CiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jt cywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlk ZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTI5Miw2ICsyOTMsMTYgQEAgdm9p ZCBOZXR3b3JrUHJvY2Vzczo6Y3JlYXRlTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MoKQog CiAgICAgSVBDOjpBdHRhY2htZW50IGNsaWVudFBvcnQobGlzdGVuaW5nUG9ydCwgTUFDSF9NU0df VFlQRV9NQUtFX1NFTkQpOwogICAgIHBhcmVudFByb2Nlc3NDb25uZWN0aW9uKCktPnNlbmQoTWVz c2FnZXM6Ok5ldHdvcmtQcm9jZXNzUHJveHk6OkRpZENyZWF0ZU5ldHdvcmtDb25uZWN0aW9uVG9X ZWJQcm9jZXNzKGNsaWVudFBvcnQpLCAwKTsKKyNlbGlmIE9TKFdJTkRPV1MpCisgICAgSVBDOjpD b25uZWN0aW9uOjpJZGVudGlmaWVyIHNlcnZlcklkZW50aWZpZXIsIGNsaWVudElkZW50aWZpZXI7 CisgICAgaWYgKCFJUEM6OkNvbm5lY3Rpb246OmNyZWF0ZVNlcnZlckFuZENsaWVudElkZW50aWZp ZXJzKHNlcnZlcklkZW50aWZpZXIsIGNsaWVudElkZW50aWZpZXIpKQorICAgICAgICByZXR1cm47 CisKKyAgICBhdXRvIGNvbm5lY3Rpb24gPSBOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6 Y3JlYXRlKHNlcnZlcklkZW50aWZpZXIpOworICAgIG1fd2ViUHJvY2Vzc0Nvbm5lY3Rpb25zLmFw cGVuZChXVEZNb3ZlKGNvbm5lY3Rpb24pKTsKKworICAgIElQQzo6QXR0YWNobWVudCBjbGllbnRT b2NrZXQoY2xpZW50SWRlbnRpZmllcik7CisgICAgcGFyZW50UHJvY2Vzc0Nvbm5lY3Rpb24oKS0+ c2VuZChNZXNzYWdlczo6TmV0d29ya1Byb2Nlc3NQcm94eTo6RGlkQ3JlYXRlTmV0d29ya0Nvbm5l Y3Rpb25Ub1dlYlByb2Nlc3MoY2xpZW50U29ja2V0KSwgMCk7CiAjZWxzZQogICAgIG5vdEltcGxl bWVudGVkKCk7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9Q bHVnaW5zL1BsdWdpblByb2Nlc3NDb25uZWN0aW9uTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbk1hbmFnZXIuY3BwCmlu ZGV4IGNiYzRmMGUuLmE5YmQ0NzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9QbHVnaW5zL1BsdWdpblByb2Nlc3NDb25uZWN0aW9uTWFuYWdlci5jcHAKKysrIGIvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJvY2Vzc0Nvbm5lY3Rpb25NYW5hZ2Vy LmNwcApAQCAtNzgsNiArNzgsOCBAQCBQbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbiogUGx1Z2luUHJv Y2Vzc0Nvbm5lY3Rpb25NYW5hZ2VyOjpnZXRQbHVnaW5Qcm9jZXNzQ29ubmVjdAogICAgIElQQzo6 Q29ubmVjdGlvbjo6SWRlbnRpZmllciBjb25uZWN0aW9uSWRlbnRpZmllciA9IGVuY29kZWRDb25u ZWN0aW9uSWRlbnRpZmllci5yZWxlYXNlRmlsZURlc2NyaXB0b3IoKTsKICNlbGlmIE9TKERBUldJ TikKICAgICBJUEM6OkNvbm5lY3Rpb246OklkZW50aWZpZXIgY29ubmVjdGlvbklkZW50aWZpZXIo ZW5jb2RlZENvbm5lY3Rpb25JZGVudGlmaWVyLnBvcnQoKSk7CisjZWxpZiBPUyhXSU5ET1dTKQor ICAgIElQQzo6Q29ubmVjdGlvbjo6SWRlbnRpZmllciBjb25uZWN0aW9uSWRlbnRpZmllciA9IGVu Y29kZWRDb25uZWN0aW9uSWRlbnRpZmllci5oYW5kbGUoKTsKICNlbmRpZgogICAgIGlmIChJUEM6 OkNvbm5lY3Rpb246OmlkZW50aWZpZXJJc051bGwoY29ubmVjdGlvbklkZW50aWZpZXIpKQogICAg ICAgICByZXR1cm4gbnVsbHB0cjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYkluc3BlY3Rvci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJJbnNwZWN0b3IuY3BwCmluZGV4IDcyZjViZjkuLmNjZDU0N2UgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3BlY3Rvci5jcHAKKysrIGIv U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViSW5zcGVjdG9yLmNwcApAQCAtOTQs MTAgKzk0LDEyIEBAIHZvaWQgV2ViSW5zcGVjdG9yOjpvcGVuRnJvbnRlbmRDb25uZWN0aW9uKGJv b2wgdW5kZXJUZXN0KQogICAgIHJldHVybjsKICNlbmRpZgogCisjaWYgVVNFKFVOSVhfRE9NQUlO X1NPQ0tFVFMpIHx8IE9TKERBUldJTikKICAgICBtX2Zyb250ZW5kQ29ubmVjdGlvbiA9IElQQzo6 Q29ubmVjdGlvbjo6Y3JlYXRlU2VydmVyQ29ubmVjdGlvbihjb25uZWN0aW9uSWRlbnRpZmllciwg KnRoaXMpOwogICAgIG1fZnJvbnRlbmRDb25uZWN0aW9uLT5vcGVuKCk7CiAKICAgICBXZWJQcm9j ZXNzOjpzaW5nbGV0b24oKS5wYXJlbnRQcm9jZXNzQ29ubmVjdGlvbigpLT5zZW5kKE1lc3NhZ2Vz OjpXZWJJbnNwZWN0b3JQcm94eTo6Q3JlYXRlSW5zcGVjdG9yUGFnZShjb25uZWN0aW9uQ2xpZW50 UG9ydCwgY2FuQXR0YWNoV2luZG93KCksIHVuZGVyVGVzdCksIG1fcGFnZS0+cGFnZUlEKCkpOwor I2VuZGlmCiB9CiAKIHZvaWQgV2ViSW5zcGVjdG9yOjpjbG9zZUZyb250ZW5kQ29ubmVjdGlvbigp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJJbnNwZWN0 b3JVSS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJJbnNwZWN0b3JV SS5jcHAKaW5kZXggZGJhNjhlMS4uZTMyNmI0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViSW5zcGVjdG9yVUkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3BlY3RvclVJLmNwcApAQCAtNTgsNiArNTgsOCBAQCB2 b2lkIFdlYkluc3BlY3RvclVJOjplc3RhYmxpc2hDb25uZWN0aW9uKElQQzo6QXR0YWNobWVudCBl bmNvZGVkQ29ubmVjdGlvbklkZW50aQogICAgIElQQzo6Q29ubmVjdGlvbjo6SWRlbnRpZmllciBj b25uZWN0aW9uSWRlbnRpZmllcihlbmNvZGVkQ29ubmVjdGlvbklkZW50aWZpZXIucmVsZWFzZUZp bGVEZXNjcmlwdG9yKCkpOwogI2VsaWYgT1MoREFSV0lOKQogICAgIElQQzo6Q29ubmVjdGlvbjo6 SWRlbnRpZmllciBjb25uZWN0aW9uSWRlbnRpZmllcihlbmNvZGVkQ29ubmVjdGlvbklkZW50aWZp ZXIucG9ydCgpKTsKKyNlbGlmIE9TKFdJTkRPV1MpCisgICAgSVBDOjpDb25uZWN0aW9uOjpJZGVu dGlmaWVyIGNvbm5lY3Rpb25JZGVudGlmaWVyKGVuY29kZWRDb25uZWN0aW9uSWRlbnRpZmllci5o YW5kbGUoKSk7CiAjZWxzZQogICAgIG5vdEltcGxlbWVudGVkKCk7CiAgICAgcmV0dXJuOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwIGIvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCmluZGV4IDFjMWVkMWMuLjFhN2Y3NDMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAKQEAgLTExMzEsNiArMTEz MSw4IEBAIE5ldHdvcmtQcm9jZXNzQ29ubmVjdGlvbiYgV2ViUHJvY2Vzczo6ZW5zdXJlTmV0d29y a1Byb2Nlc3NDb25uZWN0aW9uKCkKICAgICAgICAgSVBDOjpDb25uZWN0aW9uOjpJZGVudGlmaWVy IGNvbm5lY3Rpb25JZGVudGlmaWVyID0gZW5jb2RlZENvbm5lY3Rpb25JZGVudGlmaWVyLnJlbGVh c2VGaWxlRGVzY3JpcHRvcigpOwogI2VsaWYgT1MoREFSV0lOKQogICAgICAgICBJUEM6OkNvbm5l Y3Rpb246OklkZW50aWZpZXIgY29ubmVjdGlvbklkZW50aWZpZXIoZW5jb2RlZENvbm5lY3Rpb25J ZGVudGlmaWVyLnBvcnQoKSk7CisjZWxpZiBPUyhXSU5ET1dTKQorICAgICAgICBJUEM6OkNvbm5l Y3Rpb246OklkZW50aWZpZXIgY29ubmVjdGlvbklkZW50aWZpZXIoZW5jb2RlZENvbm5lY3Rpb25J ZGVudGlmaWVyLmhhbmRsZSgpKTsKICNlbHNlCiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgp OwogI2VuZGlmCg==