182729 2018-02-13 07:03:35 -0800 run-jsc-stress-tests - skip a test if any of the run commands evals to skip 2018-02-15 08:50:30 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 182730 1 tpopela tpopela fpizlo lforschler mark.lam saam webkit-bug-importer oldest_to_newest 1398651 0 tpopela 2018-02-13 07:03:35 -0800 Imagine, that we have the following run command in the beginning of some stress tests: //@ defaultNoEagerRun now, we don't want to run this test if JIT is disabled (because the test is failing there). What we could do is: //@ if $jitTests then defaultNoEagerRun else skip end but I personally don't like it.. Better would be to use: //@ skip if not $jitTests //@ defaultNoEagerRun but this does not work right now, because Tools/Scripts/run-jsc-stress-tests will analyse the first line, skip the run as expected, but then will start to analyse the second line and will schedule a run. We should skip further analysis if the test is skipped. 1398654 1 333688 tpopela 2018-02-13 07:18:36 -0800 Created attachment 333688 Patch 1399460 2 333688 saam 2018-02-15 08:17:14 -0800 Comment on attachment 333688 Patch r=me The only thing slightly unintuitive here is you could have code like: //@ runXYZ //@ skip And we’ll print out that we’re skipping. But it’s probably ok to not care about this 1399472 3 333688 tpopela 2018-02-15 08:49:07 -0800 Comment on attachment 333688 Patch Clearing flags on attachment: 333688 Committed r228512: <https://trac.webkit.org/changeset/228512> 1399473 4 tpopela 2018-02-15 08:49:11 -0800 All reviewed patches have been landed. Closing bug. 1399477 5 webkit-bug-importer 2018-02-15 08:50:30 -0800 <rdar://problem/37571539> 333688 2018-02-13 07:18:36 -0800 2018-02-15 08:49:07 -0800 Patch bug-182729-20180213161835.patch text/plain 1873 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4NDE3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTQ4MmFhNDliZGQzMDMzOWRmOGFkY2Y1Y2Q2ZjU0ZDQ4 OGE5NGY3OS4uMmE0ZWQ5ODM4MGM5ZmYxMjc2ZmUwNjI1NDBlZjE5NzBjZGMwNjI1ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE4LTAyLTEzICBUb21hcyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAg ICAgICAgcnVuLWpzYy1zdHJlc3MtdGVzdHMgLSBza2lwIGEgdGVzdCBpZiBhbnkgb2YgdGhlIHJ1 biBjb21tYW5kcyBldmFscyB0byBza2lwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODI3MjkKKworICAgICAgICBJZiBtdWx0aXBsZSBydW4gY29tbWFu ZHMgYXJlIHNwZWNpZmllZCBhbmQgb25lIG9mIHRoZW0gZXZhbHMgdG8gc2tpcCwKKyAgICAgICAg dGhlbiB0aGUgdGVzdCBpcyBub3Qgc2tpcHBlZCwgYmVjYXVzZSB0aGUgcnVuIGlzIHNjaGVkdWxl ZCB3aGlsZQorICAgICAgICBldmFsdWF0aW5nIG90aGVyIGNvbW1hbmRzLgorCisgICAgICAgIFJl bWVtYmVyIGlmIHRoZSB0ZXN0IGlzIGdvaW5nIHRvIGJlIHNraXBwZWQgLSBpZiB5ZXMsIGp1c3Qg c3RvcAorICAgICAgICBldmFsdWF0aW5nIHRoZSBvdGhlciBydW4gY29tbWFuZHMuCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1q c2Mtc3RyZXNzLXRlc3RzOgorCiAyMDE4LTAyLTEyICBKb2huIFdpbGFuZGVyICA8d2lsYW5kZXJA YXBwbGUuY29tPgogCiAgICAgICAgIFJlc291cmNlIExvYWQgU3RhdGlzdGljczogQ2xhc3NpZnkg cmVzb3VyY2VzIGFzIHByZXZhbGVudCBiYXNlZCBvbiByZWRpcmVjdHMgdG8gb3RoZXIgcHJldmFs ZW50IHJlc291cmNlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10 ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMKaW5kZXggNjAzYzRkMGM5 ZDRjN2M0MmNjZTkzZTRhZGIyMjgyNjFiYWQxZDM3NS4uZDQ1YTM3NTBiZGFjYzdhMzg5NDE4NDY2 MWNmMjMyMmMwNmJkNWJjNyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVz cy10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCkBAIC01MzYs NiArNTM2LDcgQEAgZW5kCiBkZWYgcGFyc2VSdW5Db21tYW5kcwogICAgIG9sZERpZEFkZFJ1bkNv bW1hbmQgPSAkZGlkQWRkUnVuQ29tbWFuZAogICAgICRkaWRBZGRSdW5Db21tYW5kID0gZmFsc2UK KyAgICAkc2tpcHBlZCA9IGZhbHNlCiAKICAgICBEaXIuY2hkaXIoJG91dHB1dERpcikgewogICAg ICAgICBGaWxlLm9wZW4oJGJlbmNobWFya0RpcmVjdG9yeSArICRiZW5jaG1hcmspIHsKQEAgLTU1 MSw2ICs1NTIsOSBAQCBkZWYgcGFyc2VSdW5Db21tYW5kcwogICAgICAgICAgICAgICAgIGVuZAog ICAgICAgICAgICAgICAgIG5leHQgdW5sZXNzIGRvZXNNYXRjaAogICAgICAgICAgICAgICAgIGV2 YWwgJH4ucG9zdF9tYXRjaAorICAgICAgICAgICAgICAgIGlmICRza2lwcGVkCisgICAgICAgICAg ICAgICAgICAgIGJyZWFrCisgICAgICAgICAgICAgICAgZW5kCiAgICAgICAgICAgICB9CiAgICAg ICAgIH0KICAgICB9CkBAIC0xMzU2LDYgKzEzNjAsNyBAQCBlbmQKIAogZGVmIHNraXAKICAgICAk ZGlkQWRkUnVuQ29tbWFuZCA9IHRydWUKKyAgICAkc2tpcHBlZCA9IHRydWUKICAgICBwdXRzICJT a2lwcGluZyAjeyRjb2xsZWN0aW9uTmFtZX0vI3skYmVuY2htYXJrfSIKIGVuZAogCg==