182673 2018-02-11 02:09:28 -0800 [GTK] whatsapp web blurry in some parts, sharp on others 2018-02-20 04:46:29 -0800 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Linux RESOLVED FIXED https://bugzilla.gnome.org/show_bug.cgi?id=793354 P2 Normal --- 1 plusfabi magomez aperez bugs-noreply cgarcia cmarcelo commit-queue ews-watchlist kondapallykalyan luiz magomez mcatanzaro noam zan oldest_to_newest 1398265 0 plusfabi 2018-02-11 02:09:28 -0800 https://bugzilla.gnome.org/show_bug.cgi?id=793354 <- (BGO) Webkit-GTK version: 2.18.6 If you use whatsapp web on a HiDPI display, some parts are rendered sharp, others look blurry to very blurry. It's completely random. There is an example screenshot in the original bugreport on BGO 1400409 1 aperez 2018-02-19 10:44:47 -0800 I can confirm that this also happens to me. Of course with a HiDPI display and a 2x scaling factor, running on an Intel HD Graphics 520 GPU (Skylake), with the Open Source driver (Mesa 17.3.4). Similar blurry artifacts happen in other websites like Google Inbox (https://inbox.google.com). I cannot remember any others from the top of my head, but I am sure of having seen this in a few others — I'll try to remember to comment here if I find another website which does not need creating an account for reproducing. The websites which exhibit this issue are still usable (e.g. text can be read okay, input works properly), but the blurriness looks quite ugly. 1400670 2 cgarcia 2018-02-19 22:41:47 -0800 Does it also happen with AC disabled? 1400699 3 magomez 2018-02-20 01:35:28 -0800 (In reply to Carlos Garcia Campos from comment #2) > Does it also happen with AC disabled? Nope. It's a problem with the size of the backingStore created by CoordinatedGraphicsLayer, which is not following the required scale factors. CoordinatedGraphicsLayer::createBackingStore() uses effectiveContentsScale() to get the scale factor to apply. But effectiveContentsScale() returns always 1 if selfOrAncestorHaveNonAffineTransforms() returns true. The weird part is that selfOrAncestorHaveNonAffineTransforms() returns true if the layer has an ongoing animation, which effectively means that animated layers won't use the appropriate backingStore size. I don't see why that is intended. I've looked into that code history and there is a comment about "disabling progressive tiling for animated layers" years ago but I don't see the reason to do it. Maybe at hat point they wanted to perform the scaling during the composition stage to save memory. But the problem with that is that it causes blurry rendering, as we can see in this bug. IMO we should be using the scale factor even if the layer is animated. 1400701 4 334253 magomez 2018-02-20 01:55:53 -0800 Created attachment 334253 Patch 1400703 5 334254 magomez 2018-02-20 02:08:57 -0800 Created attachment 334254 Patch 1400715 6 334254 commit-queue 2018-02-20 04:08:47 -0800 Comment on attachment 334254 Patch Rejecting attachment 334254 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 334254, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://webkit-queues.webkit.org/results/6588792 1400724 7 334254 commit-queue 2018-02-20 04:46:28 -0800 Comment on attachment 334254 Patch Clearing flags on attachment: 334254 Committed r228796: <https://trac.webkit.org/changeset/228796> 1400725 8 commit-queue 2018-02-20 04:46:29 -0800 All reviewed patches have been landed. Closing bug. 334253 2018-02-20 01:55:53 -0800 2018-02-20 02:08:53 -0800 Patch bug-182673-20180220105552.patch text/plain 1728 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4NzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTkyOGMxYjhjY2Y4NTZj ZTA3MTY0NzZhMmY1ZDgyZGQ4MWUxZGRiNy4uNmJkZTFiNjQyN2U3MWMzNGJkZDg3ZThlYWJhNTE1 NDgxYmFhZDhjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTAyLTIwICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gd2hhdHNhcHAg d2ViIGJsdXJyeSBpbiBzb21lIHBhcnRzLCBzaGFycCBvbiBvdGhlcnMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjY3MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSB0aGUgYXBwcm9wcmlhdGUgc2Nh bGUgZmFjdG9yIHdoZW4gY3JlYXRpbmcgdGhlIGJhY2tpbmcgc3RvcmUgb2YgYSBsYXllciB3aXRo IHRyYW5zZm9ybWF0aW9uCisgICAgICAgIGFuaW1hdGlvbnMuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90 ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkNvb3JkaW5hdGVkR3JhcGhpY3NMYXllcjo6c2VsZk9yQW5jZXN0b3JIYXZlTm9u QWZmaW5lVHJhbnNmb3Jtcyk6CisKIDIwMTgtMDItMTkgIEFudHRpIEtvaXZpc3RvICA8YW50dGlA YXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBzZWxlY3RvciBmaWx0ZXIgd2hlbiBpbnZhbGlkYXRp bmcgZGVzY2VuZGFudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5h dGVkR3JhcGhpY3NMYXllci5jcHAKaW5kZXggY2RjNzBmMWRlM2JiMDgwODFiMjBkMGNmNmE1ZWUw M2MxMzc1ZWQyNy4uMGE0YjA4ZTJhNTFkOTgzM2FkNjlmZDJjZGE2MGUxNTI2MzQ3ZjJmZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5h dGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXll ci5jcHAKQEAgLTExMjQsOSArMTEyNCw2IEBAIGJvb2wgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVy OjpzZWxmT3JBbmNlc3Rvckhhc0FjdGl2ZVRyYW5zZm9ybUFuaW1hdGlvbigpIGNvbnN0CiAKIGJv b2wgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjpzZWxmT3JBbmNlc3RvckhhdmVOb25BZmZpbmVU cmFuc2Zvcm1zKCkKIHsKLSAgICBpZiAobV9hbmltYXRpb25zLmhhc0FjdGl2ZUFuaW1hdGlvbnNP ZlR5cGUoQW5pbWF0ZWRQcm9wZXJ0eVRyYW5zZm9ybSkpCi0gICAgICAgIHJldHVybiB0cnVlOwot CiAgICAgaWYgKCFtX2xheWVyVHJhbnNmb3JtLmNvbWJpbmVkKCkuaXNBZmZpbmUoKSkKICAgICAg ICAgcmV0dXJuIHRydWU7CiAK 334254 2018-02-20 02:08:57 -0800 2018-02-20 04:46:28 -0800 Patch bug-182673-20180220110856.patch text/plain 2138 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4NzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTkyOGMxYjhjY2Y4NTZj ZTA3MTY0NzZhMmY1ZDgyZGQ4MWUxZGRiNy4uODhiMTQ0NWE3YjFjYzQ4ZGNkOWJkNjliYTEwYmZi YzNlZTJiY2UyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTAyLTIwICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gd2hhdHNhcHAg d2ViIGJsdXJyeSBpbiBzb21lIHBhcnRzLCBzaGFycCBvbiBvdGhlcnMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjY3MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvb3JkaW5hdGVkR3JhcGhpY3NMYXll cjo6Y3JlYXRlQmFja2luZ1N0b3JlKCkgdXNlcyB0aGUgc2NhbGUgZmFjdG9yIHJldHVybmVkIGJ5 IGVmZmVjdGl2ZUNvbnRlbnRzU2NhbGUoKSwKKyAgICAgICAgd2hpY2ggaXMgYWx3YXlzIDEgaWYg c2VsZk9yQW5jZXN0b3JIYXZlTm9uQWZmaW5lVHJhbnNmb3JtcygpIHJldHVybnMgdHJ1ZS4gQnV0 IHRoaXMgZnVjdGlvbiBhbHdheXMgcmV0dXJucworICAgICAgICB0cnVlIGlmIHRoZSBsYXllciBo YXMgYW4gQW5pbWF0ZWRQcm9wZXJ0eVRyYW5zZm9ybSBhbmltYXRpb24sIHdoaWNoIG1lYW5zIHRo YXQgbGF5ZXJzIHdpdGggdGhvc2UgYW5pbWF0aW9ucworICAgICAgICB3b24ndCB1c2UgdGhlIGFw cHJvcHJpYXRlIHNjYWxlIGZhY3RvciwgY2F1c2luZyBibHVycnkgcmVuZGVyaW5ncy4KKworICAg ICAgICBUaGlzIHBhdGNoIHJlbW92ZXMgdGhlIGFuaW1hdGlvbnMgY2hlY2ssIHNvIGFuaW1hdGVk IGxheWVycyBwcm9wZXJseSB1c2UgdGhlIHJlcXVpcmVkIHNjYWxlIGZhY3Rvci4KKworICAgICAg ICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6Q29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjpzZWxmT3JBbmNl c3RvckhhdmVOb25BZmZpbmVUcmFuc2Zvcm1zKToKKwogMjAxOC0wMi0xOSAgQW50dGkgS29pdmlz dG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIHNlbGVjdG9yIGZpbHRlciB3aGVu IGludmFsaWRhdGluZyBkZXNjZW5kYW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXll ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0 ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmNwcAppbmRleCBjZGM3MGYxZGUzYmIwODA4MWIy MGQwY2Y2YTVlZTAzYzEzNzVlZDI3Li4wYTRiMDhlMmE1MWQ5ODMzYWQ2OWZkMmNkYTYwZTE1MjYz NDdmMmZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXht YXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRH cmFwaGljc0xheWVyLmNwcApAQCAtMTEyNCw5ICsxMTI0LDYgQEAgYm9vbCBDb29yZGluYXRlZEdy YXBoaWNzTGF5ZXI6OnNlbGZPckFuY2VzdG9ySGFzQWN0aXZlVHJhbnNmb3JtQW5pbWF0aW9uKCkg Y29uc3QKIAogYm9vbCBDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXI6OnNlbGZPckFuY2VzdG9ySGF2 ZU5vbkFmZmluZVRyYW5zZm9ybXMoKQogewotICAgIGlmIChtX2FuaW1hdGlvbnMuaGFzQWN0aXZl QW5pbWF0aW9uc09mVHlwZShBbmltYXRlZFByb3BlcnR5VHJhbnNmb3JtKSkKLSAgICAgICAgcmV0 dXJuIHRydWU7Ci0KICAgICBpZiAoIW1fbGF5ZXJUcmFuc2Zvcm0uY29tYmluZWQoKS5pc0FmZmlu ZSgpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAo=