182629 2018-02-08 15:49:09 -0800 [macOS, iOS] Expose OS marketing version in UserAgent 2019-08-21 09:29:25 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=200605 https://bugs.webkit.org/show_bug.cgi?id=200948 InRadar P2 Normal --- 180365 192809 1 bfulgham bfulgham bfulgham cdumez commit-queue dbates mitz mjs rniwa sam tonikitoo webkit-bug-importer oldest_to_newest 1397751 0 bfulgham 2018-02-08 15:49:09 -0800 Allow the UserAgent to expose the marketing version of the operating system WebKit is running on. 1397759 1 webkit-bug-importer 2018-02-08 16:24:34 -0800 <rdar://problem/37370975> 1397760 2 333434 bfulgham 2018-02-08 16:25:35 -0800 Created attachment 333434 Patch 1397761 3 mitz 2018-02-08 16:34:28 -0800 Having a variable user-agent string like this has been a constant source of website compatibility bugs. 1397768 4 bfulgham 2018-02-08 17:05:13 -0800 (In reply to mitz from comment #3) > Having a variable user-agent string like this has been a constant source of > website compatibility bugs. That's true. But there are also compelling reasons why some level of variation is needed by websites. 1397770 5 sam 2018-02-08 17:08:11 -0800 (In reply to Brent Fulgham from comment #4) > (In reply to mitz from comment #3) > > Having a variable user-agent string like this has been a constant source of > > website compatibility bugs. > > That's true. But there are also compelling reasons why some level of > variation is needed by websites. What are those reasons? 1397957 6 bfulgham 2018-02-09 09:06:23 -0800 (In reply to Sam Weinig from comment #5) > (In reply to Brent Fulgham from comment #4) > > (In reply to mitz from comment #3) > > > Having a variable user-agent string like this has been a constant source of > > > website compatibility bugs. > > > > That's true. But there are also compelling reasons why some level of > > variation is needed by websites. > > What are those reasons? The primary reasons were: 1. WebKit sometimes ships with bugs that can be worked around at the website level. Having a release version allows websites to activate workarounds where needed. 2. Decisions about what site content to send to a user agent are often made before the page is loaded. Having UA information when connecting to the server allows websites to send only the relevant payload (e.g., more recent javascript, more efficient image formats, etc.) 3. Safari (for example) ships with the same version on several operating system revisions. Sometimes bugs exist in specific OS revisions that websites can work around. For these reasons, we decided to relax some of the restrictions we had originally planned on making. 1398010 7 333434 dbates 2018-02-09 10:44:46 -0800 Comment on attachment 333434 Patch OK. 1398014 8 333434 dbates 2018-02-09 10:48:54 -0800 Comment on attachment 333434 Patch As others have already brought up, this seems like it is moving us back a step and it is unclear how valuable the OS version is for a site to work around WebKit issues given that it does not seem to provide sufficient granularity. Sites that depend on such version information will keep their WebKit workarounds longer than may be necessary. 1398017 9 dbates 2018-02-09 10:58:34 -0800 (In reply to Daniel Bates from comment #8) > Comment on attachment 333434 [details] > Patch > > As others have already brought up, this seems like it is moving us back a > step and it is unclear how valuable the OS version is for a site to work > around WebKit issues given that it does not seem to provide sufficient > granularity. Obviously, the remark about granularity is specific to Mac where we release Safari/WebKit updates out-of-band with OS updates. On iOS, a publicly released version of WebKit always implies a new rev of the OS; => the version information is more meaningful. 1398022 10 mitz 2018-02-09 11:04:25 -0800 (In reply to Brent Fulgham from comment #6) > (In reply to Sam Weinig from comment #5) > > (In reply to Brent Fulgham from comment #4) > > > (In reply to mitz from comment #3) > > > > Having a variable user-agent string like this has been a constant source of > > > > website compatibility bugs. > > > > > > That's true. But there are also compelling reasons why some level of > > > variation is needed by websites. > > > > What are those reasons? > > The primary reasons were: > > 1. WebKit sometimes ships with bugs that can be worked around at the website > level. Having a release version allows websites to activate workarounds > where needed. Shouldn’t WebKit provide a direct and explicit way for websites to determine that a bug is fixed? > > 2. Decisions about what site content to send to a user agent are often made > before the page is loaded. Having UA information when connecting to the > server allows websites to send only the relevant payload (e.g., more recent > javascript, more efficient image formats, etc.) Aren’t there other request headers dedicated to explicitly, directly conveying what the user agent supports? > > 3. Safari (for example) ships with the same version on several operating > system revisions. Sometimes bugs exist in specific OS revisions that > websites can work around. See 1. > > For these reasons, we decided to relax some of the restrictions we had > originally planned on making. 1398031 11 333434 commit-queue 2018-02-09 11:19:46 -0800 Comment on attachment 333434 Patch Clearing flags on attachment: 333434 Committed r228334: <https://trac.webkit.org/changeset/228334> 1398032 12 commit-queue 2018-02-09 11:19:47 -0800 All reviewed patches have been landed. Closing bug. 1418491 13 bfulgham 2018-04-27 08:39:51 -0700 Note: For people arriving here looking for ways to live in a world with a frozen user agent, please look at <https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Feature_detection> 333434 2018-02-08 16:25:35 -0800 2018-02-09 11:19:46 -0800 Patch bug-182629-20180208162535.patch text/plain 1878 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyODMwMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAyLTA4ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPUywgaU9TXSBFeHBv c2UgT1MgbWFya2V0aW5nIHZlcnNpb24gaW4gVXNlckFnZW50CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODI2MjkKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzM3MzcwOTc1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJldmVydCBiYWNrIHRvIGR5bmFtaWNhbGx5IHJlYWRpbmcgdGhlIG9wZXJhdGluZyBz eXN0ZW0gbWFya2V0aW5nIHZlcnNpb24KKyAgICAgICAgcmF0aGVyIHRoYW4gdXNpbmcgYSBoYXJk LWNvZGVkIHZlcnNpb24uCisKKyAgICAgICAgKiBwYWdlL2NvY29hL1VzZXJBZ2VudC5tbToKKyAg ICAgICAgKFdlYkNvcmU6OnN5c3RlbU1hcmtldGluZ1ZlcnNpb25Gb3JVc2VyQWdlbnRTdHJpbmcp OgorCiAyMDE4LTAyLTA4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAg ICAgRm9ybSBzdWJtaXNzaW9uIGFmdGVyIG5hdmlnYXRpb24gZmFpbHMgd2hlbiBkZWNpZGVQb2xp Y3lGb3JOYXZpZ2F0aW9uQWN0aW9uIGlzIGFzeW5jCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdl L2NvY29hL1VzZXJBZ2VudC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL2Nv Y29hL1VzZXJBZ2VudC5tbQkocmV2aXNpb24gMjI4Mjk2KQorKysgU291cmNlL1dlYkNvcmUvcGFn ZS9jb2NvYS9Vc2VyQWdlbnQubW0JKHdvcmtpbmcgY29weSkKQEAgLTI2LDYgKzI2LDggQEAKICNp bXBvcnQgImNvbmZpZy5oIgogI2ltcG9ydCAiVXNlckFnZW50LmgiCiAKKyNpbXBvcnQgIlN5c3Rl bVZlcnNpb24uaCIKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBTdHJpbmcgc3lzdGVtTWFya2V0 aW5nVmVyc2lvbkZvclVzZXJBZ2VudFN0cmluZygpCkBAIC0zMywxMSArMzUsNyBAQCBTdHJpbmcg c3lzdGVtTWFya2V0aW5nVmVyc2lvbkZvclVzZXJBZ2VuCiAgICAgLy8gVXNlIHVuZGVyc2NvcmVz IGluc3RlYWQgb2YgZG90cyBiZWNhdXNlIHdoZW4gd2UgZmlyc3QgYWRkZWQgdGhlIE1hYyBPUyBY IHZlcnNpb24gdG8gdGhlIHVzZXIgYWdlbnQgc3RyaW5nCiAgICAgLy8gd2Ugd2VyZSBjb25jZXJu ZWQgYWJvdXQgb2xkIERIVE1MIGxpYnJhcmllcyBpbnRlcnByZXRpbmcgIjQuIiBhcyBOZXRzY2Fw ZSA0LiBUaGF0J3Mgbm8gbG9uZ2VyIGEgY29uY2VybiBmb3IgdXMKICAgICAvLyBidXQgd2UncmUg c3RpY2tpbmcgd2l0aCB0aGUgdW5kZXJzY29yZXMgZm9yIGNvbXBhdGliaWxpdHkgd2l0aCB0aGUg Zm9ybWF0IHVzZWQgYnkgb2xkZXIgdmVyc2lvbnMgb2YgU2FmYXJpLgotI2lmIFBMQVRGT1JNKE1B QykKLSAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCIxMF8xM180Iik7Ci0jZWxzZQotICAgIHJldHVy biBBU0NJSUxpdGVyYWwoIjExXzMiKTsKLSNlbmRpZgorICAgIHJldHVybiBbc3lzdGVtTWFya2V0 aW5nVmVyc2lvbigpIHN0cmluZ0J5UmVwbGFjaW5nT2NjdXJyZW5jZXNPZlN0cmluZzpAIi4iIHdp dGhTdHJpbmc6QCJfIl07CiB9CiAKIFN0cmluZyB1c2VyQWdlbnRCdW5kbGVWZXJzaW9uKCkK