182479 2018-02-05 04:20:46 -0800 [Win] Fix MSVC's treating __attribute__((warn_unused_result)) 2018-02-20 11:30:46 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 174003 1 Yousuke.Kimoto webkit-unassigned achristensen ap cdumez commit-queue darin don.olmstead koivisto webkit-bug-importer oldest_to_newest 1396271 0 Yousuke.Kimoto 2018-02-05 04:20:46 -0800 MSVC doesn't understand __attribute((warn_unsed_resutl)), but it has a similar option, _Check_return_. MSVC Annotating Function Behavior: https://msdn.microsoft.com/en-us/library/jj159529.aspx 1396273 1 333074 Yousuke.Kimoto 2018-02-05 04:34:36 -0800 Created attachment 333074 Patch 1396295 2 Yousuke.Kimoto 2018-02-05 06:58:57 -0800 >ERROR: '/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKitFailed to run "['Tools/Scripts/build-webkit', '--release']" exit_code: 65 >Last 500 characters of output: >A55DEAA61670402E003DB841.sh >ERROR: >'/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/PrivateHeaders/WKRetainPtr.h:245' included forbidden macro 'COMPILER' => '#if !COMPILER(MSVC)' >Command /bin/sh failed with exit code 1 > >** BUILD FAILED ** > >The following build commands failed: > PhaseScriptExecution Check\ For\ Inappropriate\ Macros\ in\ External\ Headers /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit.build/Release/WebKit.build/Script-A55DEAA61670402E003DB841.sh >(1 failure) Mac and iOS failed by the same reason like the above. 1396636 3 333074 achristensen 2018-02-05 17:29:33 -0800 Comment on attachment 333074 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333074&action=review > Source/WebKit/UIProcess/API/cpp/WKRetainPtr.h:245 > +#if !COMPILER(MSVC) We usually try to put the positive first, so this would be #if COMPILER(MSVC) But you can't use COMPILER here because this header is part of the API. Elsewhere in the API we've done #if defined(WIN32) || defined(_WIN32), but maybe we should check _MSC_VER instead for people using clang on windows. 1396669 4 Yousuke.Kimoto 2018-02-05 19:07:38 -0800 (In reply to Alex Christensen from comment #3) > We usually try to put the positive first, so this would be #if COMPILER(MSVC) > But you can't use COMPILER here because this header is part of the API. > Elsewhere in the API we've done #if defined(WIN32) || defined(_WIN32), but > maybe we should check _MSC_VER instead for people using clang on windows. Thank you for your advice. I'll fix it with the condition you suggested. 1396680 5 333152 Yousuke.Kimoto 2018-02-05 19:45:46 -0800 Created attachment 333152 Patch 1396768 6 Yousuke.Kimoto 2018-02-06 05:04:49 -0800 (In reply to Alex Christensen from comment #3) > maybe we should check _MSC_VER instead for people using clang on windows. Table about _MSC_VER and Visual Studio version: https://blogs.msdn.microsoft.com/vcblog/2015/12/04/clang-with-microsoft-codegen-in-vs-2015-update-1/ https://cpprefjp.github.io/implementation.html#visual_cpp I have two questions about _MSC_VER. 1. Is VisualStudio 2017 a recommended IDE on windows ? 2. When clang is used on windows, which template should be chosen, a) or b)? a) template<typename T> inline WKRetainPtr<T> adoptWK(T) _Check_return_; b) template<typename T> inline WKRetainPtr<T> adoptWK(T) __attribute__((warn_unused_result)); 1397434 7 333152 Yousuke.Kimoto 2018-02-07 19:37:33 -0800 Comment on attachment 333152 Patch I confirmed this patch works on the wincairo build but the Bot status was failure on wincairo. If we take care of clang users on windows, for example, the part will be as follows. (In this case, supposing VisualStudio 2017 and Clang/C2 are used.) Please give me your comment. #if defined(WIN32) || defined(_WIN32) #if (_MSC_VER > 1900) && (__c2__) template<typename T> inline WKRetainPtr<T> adoptWK(T) __attribute__((warn_unused_result)); #else template<typename T> inline WKRetainPtr<T> adoptWK(T) _Check_return_; #endif #else template<typename T> inline WKRetainPtr<T> adoptWK(T) __attribute__((warn_unused_result)); #endif 1399315 8 333152 darin 2018-02-14 16:36:10 -0800 Comment on attachment 333152 Patch This is the wrong fix. The correct fix would be to use WARN_UNUSED_RETURN from Compiler.h instead of using warn_unused_result directly. 1399318 9 333152 darin 2018-02-14 16:38:08 -0800 Comment on attachment 333152 Patch Oh wait, I see, this is in an "API" header. Maybe this is OK, then. Lets try it at least. 1399319 10 333152 darin 2018-02-14 16:38:52 -0800 Comment on attachment 333152 Patch Actually, the compiler version issue you mentioned has to be resolved first, so back to review-. 1399433 11 333892 Yousuke.Kimoto 2018-02-15 05:28:53 -0800 Created attachment 333892 Patch 1399490 12 333909 Yousuke.Kimoto 2018-02-15 09:56:02 -0800 Created attachment 333909 Patch 1399618 13 Yousuke.Kimoto 2018-02-15 14:26:00 -0800 (In reply to Darin Adler from comment #10) > Actually, the compiler version issue you mentioned has to be resolved first, > so back to review-. > Created attachment 333909 [details] This patch fixed the compiler version issue. Could you review it again? 1400226 14 333909 commit-queue 2018-02-18 08:04:20 -0800 Comment on attachment 333909 Patch Rejecting attachment 333909 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 333909, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://webkit-queues.webkit.org/results/6563066 1400611 15 334223 Yousuke.Kimoto 2018-02-19 18:35:04 -0800 Created attachment 334223 Patch (a rebased version) This patch is a rebased version of attachment 333909 [details]. 1400615 16 334224 Yousuke.Kimoto 2018-02-19 18:44:10 -0800 Created attachment 334224 Patch (a rebased version) 1400694 17 334224 commit-queue 2018-02-20 00:42:17 -0800 Comment on attachment 334224 Patch (a rebased version) Clearing flags on attachment: 334224 Committed r228751: <https://trac.webkit.org/changeset/228751> 1400851 18 don.olmstead 2018-02-20 11:29:15 -0800 Not sure why this didn't get closed automagically. 1400852 19 webkit-bug-importer 2018-02-20 11:30:46 -0800 <rdar://problem/37715172> 333074 2018-02-05 04:34:36 -0800 2018-02-05 19:45:46 -0800 Patch bug-182479-20180205213505.patch text/plain 1596 Yousuke.Kimoto U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4MDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFlMGYxOTA5NjkyZTMyOWJj YzI2MzVjYzIyMjljZTZkM2NjN2FhM2YuLjc4MDQ1ZDE2OTZiNDZlMTk3MzE2YThlMGViMjY0YjNh MjNjODg3YTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDItMDUgIFlvdXN1a2Ug S2ltb3RvICA8eW91c3VrZS5raW1vdG9Ac29ueS5jb20+CisKKyAgICAgICAgW1dpbl0gRml4IE1T VkMncyB0cmVhdGluZyBfX2F0dHJpYnV0ZV9fKCh3YXJuX3VudXNlZF9yZXN1bHQpKQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyNDc5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTVNWQyBkb2Vzbid0IHVu ZGVyc3RhbmQgX19hdHRyaWJ1dGUoKHdhcm5fdW51c2VkX3Jlc3VsdCksIGJ1dAorICAgICAgICBf Q2hlY2tfcmV0dXJuXyBjYW4gYmUgdXNlZCBpbnN0ZWFkLgorCisgICAgICAgICogVUlQcm9jZXNz L0FQSS9jcHAvV0tSZXRhaW5QdHIuaDogQWRkZWQgYSBhZG9wdFdLKCkgZGVmaW5pdGlvbiBmb3Ig TVNWQy4KKwogMjAxOC0wMi0wMiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAK ICAgICAgICAgQ2xlYXJpbmcgYWxsIHNlcnZpY2Ugd29ya2VyIHJlZ2lzdHJhdGlvbnMgc2hvdWxk IHdhaXQgZm9yIGltcG9ydGluZyBzZXJ2aWNlIHdvcmtlciByZWdpc3RyYXRpb24gdG8gZmluaXNo CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvY3BwL1dLUmV0YWluUHRy LmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvY3BwL1dLUmV0YWluUHRyLmgKaW5kZXgg NDllOWRiYzQ4ZmJhMGExNTFkMTZkMGY1YjljZTQxZjJiNDE5NWZjZC4uMzg0YmRiMmZkMTI3Y2Qy NGYxYzVlNDk5MzZhNjQ2M2M3YjQ2MWUxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQVBJL2NwcC9XS1JldGFpblB0ci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9jcHAvV0tSZXRhaW5QdHIuaApAQCAtMjQyLDcgKzI0MiwxMSBAQCB0ZW1wbGF0ZTx0eXBl bmFtZSBULCB0eXBlbmFtZSBVPiBpbmxpbmUgYm9vbCBvcGVyYXRvciE9KFQqIGEsIGNvbnN0IFdL UmV0YWluUHRyPAogICAgIHJldHVybiBhICE9IGIuZ2V0KCk7IAogfQogCisjaWYgIUNPTVBJTEVS KE1TVkMpCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgV0tSZXRhaW5QdHI8VD4gYWRvcHRX SyhUKSBfX2F0dHJpYnV0ZV9fKCh3YXJuX3VudXNlZF9yZXN1bHQpKTsKKyNlbHNlCit0ZW1wbGF0 ZTx0eXBlbmFtZSBUPiBpbmxpbmUgV0tSZXRhaW5QdHI8VD4gYWRvcHRXSyhUKSBfQ2hlY2tfcmV0 dXJuXzsKKyNlbmRpZgogdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIFdLUmV0YWluUHRyPFQ+ IGFkb3B0V0soVCBvKQogewogICAgIHJldHVybiBXS1JldGFpblB0cjxUPihBZG9wdFdLLCBvKTsK 333152 2018-02-05 19:45:46 -0800 2018-02-15 05:28:53 -0800 Patch bz182479-1.patch text/plain 1444 Yousuke.Kimoto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNjYwMTI1Mi4uZjc5MjQyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxOC0wMi0wNSAgWW91c3VrZSBLaW1vdG8gIDx5b3VzdWtlLmtpbW90b0Bzb255LmNvbT4KKwor ICAgICAgICBbV2luXSBGaXggTVNWQydzIHRyZWF0aW5nIF9fYXR0cmlidXRlX18oKHdhcm5fdW51 c2VkX3Jlc3VsdCkpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODI0NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBNU1ZDIGRvZXNuJ3QgdW5kZXJzdGFuZCBfX2F0dHJpYnV0ZSgod2Fybl91bnVzZWRfcmVz dWx0KSwgYnV0CisgICAgICAgIF9DaGVja19yZXR1cm5fIGNhbiBiZSB1c2VkIGluc3RlYWQuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2NwcC9XS1JldGFpblB0ci5oOgorCiAyMDE4LTAyLTA1 ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJzaXRlRGF0 YVN0b3JlOjpyZXNvbHZlRGlyZWN0b3JpZXNJZk5lY2Vzc2FyeSgpIHNob3VsZCBub3Qgb3Zlcndy aXRlIGl0cyByZXNvbHZlZCBzZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uRGlyZWN0b3J5ICBpZiBh bHJlYWR5IHNldApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2NwcC9X S1JldGFpblB0ci5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2NwcC9XS1JldGFpblB0 ci5oCmluZGV4IDQ5ZTlkYmMuLjVlNDE3ZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0FQSS9jcHAvV0tSZXRhaW5QdHIuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvY3BwL1dLUmV0YWluUHRyLmgKQEAgLTI0Miw3ICsyNDIsMTEgQEAgdGVtcGxhdGU8dHlw ZW5hbWUgVCwgdHlwZW5hbWUgVT4gaW5saW5lIGJvb2wgb3BlcmF0b3IhPShUKiBhLCBjb25zdCBX S1JldGFpblB0cjwKICAgICByZXR1cm4gYSAhPSBiLmdldCgpOyAKIH0KIAorI2lmIGRlZmluZWQo V0lOMzIpIHx8IGRlZmluZWQoX1dJTjMyKQordGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIFdL UmV0YWluUHRyPFQ+IGFkb3B0V0soVCkgX0NoZWNrX3JldHVybl87CisjZWxzZQogdGVtcGxhdGU8 dHlwZW5hbWUgVD4gaW5saW5lIFdLUmV0YWluUHRyPFQ+IGFkb3B0V0soVCkgX19hdHRyaWJ1dGVf Xygod2Fybl91bnVzZWRfcmVzdWx0KSk7CisjZW5kaWYKIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlu bGluZSBXS1JldGFpblB0cjxUPiBhZG9wdFdLKFQgbykKIHsKICAgICByZXR1cm4gV0tSZXRhaW5Q dHI8VD4oQWRvcHRXSywgbyk7Cg== 333892 2018-02-15 05:28:53 -0800 2018-02-15 09:56:02 -0800 Patch bz182479-2.patch text/plain 1479 Yousuke.Kimoto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMjMzOTg0YS4uMzUwOGE3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxOC0wMi0xNSAgWW91c3VrZSBLaW1vdG8gIDx5b3VzdWtlLmtpbW90b0Bzb255LmNvbT4KKwor ICAgICAgICBbV2luXSBGaXggTVNWQydzIHRyZWF0aW5nIF9fYXR0cmlidXRlX18oKHdhcm5fdW51 c2VkX3Jlc3VsdCkpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODI0NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBTaW5jZSBNU1ZDIGRvZXNuJ3QgdW5kZXJzdGFuZCAiX19hdHRyaWJ1dGVfXyIsICJfQ2hl Y2tfcmV0dXJuXyIgaXMgdXNlZCBpbnN0ZWFkLgorICAgICAgICBJZiBjbGFuZyBhbmQgVmlzdWFs U3R1ZGlvIDIwMTcgYXJlIHVzZWQsIGEgbWFjcm8gd2l0aCAiX19hdHRyaXV0ZV9fIiB3aWxsIGJl IGNob3Nlbi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvY3BwL1dLUmV0YWluUHRyLmg6CisK IDIwMTgtMDItMTQgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAg IERpc2FsbG93IGNyb3NzLW9yaWdpbiBzdWJyZXNvdXJjZXMgZnJvbSBhc2tpbmcgZm9yIGNyZWRl bnRpYWxzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvY3BwL1dLUmV0 YWluUHRyLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvY3BwL1dLUmV0YWluUHRyLmgK aW5kZXggNDllOWRiYy4uNjUyOTExMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL2NwcC9XS1JldGFpblB0ci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ SS9jcHAvV0tSZXRhaW5QdHIuaApAQCAtMjQyLDcgKzI0MiwxMSBAQCB0ZW1wbGF0ZTx0eXBlbmFt ZSBULCB0eXBlbmFtZSBVPiBpbmxpbmUgYm9vbCBvcGVyYXRvciE9KFQqIGEsIGNvbnN0IFdLUmV0 YWluUHRyPAogICAgIHJldHVybiBhICE9IGIuZ2V0KCk7IAogfQogCisjaWYgKGRlZmluZWQoV0lO MzIpIHx8IGRlZmluZWQoX1dJTjMyKSkgJiYgISgoX01TQ19WRVIgPiAxOTAwKSAmJiBfX2NsYW5n X18pCit0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgV0tSZXRhaW5QdHI8VD4gYWRvcHRXSyhU KSBfQ2hlY2tfcmV0dXJuXzsKKyNlbHNlCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgV0tS ZXRhaW5QdHI8VD4gYWRvcHRXSyhUKSBfX2F0dHJpYnV0ZV9fKCh3YXJuX3VudXNlZF9yZXN1bHQp KTsKKyNlbmRpZgogdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIFdLUmV0YWluUHRyPFQ+IGFk b3B0V0soVCBvKQogewogICAgIHJldHVybiBXS1JldGFpblB0cjxUPihBZG9wdFdLLCBvKTsK 333909 2018-02-15 09:56:02 -0800 2018-02-18 08:04:20 -0800 Patch bz182479-3.patch text/plain 1479 Yousuke.Kimoto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMjMzOTg0YS4uMzUwOGE3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxOC0wMi0xNSAgWW91c3VrZSBLaW1vdG8gIDx5b3VzdWtlLmtpbW90b0Bzb255LmNvbT4KKwor ICAgICAgICBbV2luXSBGaXggTVNWQydzIHRyZWF0aW5nIF9fYXR0cmlidXRlX18oKHdhcm5fdW51 c2VkX3Jlc3VsdCkpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODI0NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBTaW5jZSBNU1ZDIGRvZXNuJ3QgdW5kZXJzdGFuZCAiX19hdHRyaWJ1dGVfXyIsICJfQ2hl Y2tfcmV0dXJuXyIgaXMgdXNlZCBpbnN0ZWFkLgorICAgICAgICBJZiBjbGFuZyBhbmQgVmlzdWFs U3R1ZGlvIDIwMTcgYXJlIHVzZWQsIGEgbWFjcm8gd2l0aCAiX19hdHRyaXV0ZV9fIiB3aWxsIGJl IGNob3Nlbi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvY3BwL1dLUmV0YWluUHRyLmg6CisK IDIwMTgtMDItMTQgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAg IERpc2FsbG93IGNyb3NzLW9yaWdpbiBzdWJyZXNvdXJjZXMgZnJvbSBhc2tpbmcgZm9yIGNyZWRl bnRpYWxzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvY3BwL1dLUmV0 YWluUHRyLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvY3BwL1dLUmV0YWluUHRyLmgK aW5kZXggNDllOWRiYy4uNjUyOTExMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL2NwcC9XS1JldGFpblB0ci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ SS9jcHAvV0tSZXRhaW5QdHIuaApAQCAtMjQyLDcgKzI0MiwxMSBAQCB0ZW1wbGF0ZTx0eXBlbmFt ZSBULCB0eXBlbmFtZSBVPiBpbmxpbmUgYm9vbCBvcGVyYXRvciE9KFQqIGEsIGNvbnN0IFdLUmV0 YWluUHRyPAogICAgIHJldHVybiBhICE9IGIuZ2V0KCk7IAogfQogCisjaWYgKGRlZmluZWQoV0lO MzIpIHx8IGRlZmluZWQoX1dJTjMyKSkgJiYgISgoX01TQ19WRVIgPiAxOTAwKSAmJiBfX2NsYW5n X18pCit0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgV0tSZXRhaW5QdHI8VD4gYWRvcHRXSyhU KSBfQ2hlY2tfcmV0dXJuXzsKKyNlbHNlCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgV0tS ZXRhaW5QdHI8VD4gYWRvcHRXSyhUKSBfX2F0dHJpYnV0ZV9fKCh3YXJuX3VudXNlZF9yZXN1bHQp KTsKKyNlbmRpZgogdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIFdLUmV0YWluUHRyPFQ+IGFk b3B0V0soVCBvKQogewogICAgIHJldHVybiBXS1JldGFpblB0cjxUPihBZG9wdFdLLCBvKTsK 334223 2018-02-19 18:35:04 -0800 2018-02-19 18:44:10 -0800 Patch (a rebased version) bz182479-2.patch text/plain 1481 Yousuke.Kimoto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNzJiZmQ3Yi4uZWRiNWIwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxOC0wMi0xOSAgWW91c3VrZSBLaW1vdG8gIDx5b3VzdWtlLmtpbW90b0Bzb255LmNvbT4KKwor ICAgICAgICBbV2luXSBGaXggTVNWQydzIHRyZWF0aW5nIF9fYXR0cmlidXRlX18oKHdhcm5fdW51 c2VkX3Jlc3VsdCkpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODI0NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBTaW5jZSBNU1ZDIGRvZXNuJ3QgdW5kZXJzdGFuZCAiX19hdHRyaWJ1dGVfXyIsICJfQ2hl Y2tfcmV0dXJuXyIgaXMgdXNlZCBpbnN0ZWFkLgorICAgICAgICBJZiBjbGFuZyBhbmQgVmlzdWFs U3R1ZGlvIDIwMTcgYXJlIHVzZWQsIGEgbWFjcm8gd2l0aCAiX19hdHRyaXV0ZV9fIiB3aWxsIGJl IGNob3Nlbi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvY3BwL1dLUmV0YWluUHRyLmg6CisK IDIwMTgtMDItMTggIFJlemEgQWJiYXNpYW4gIDxyYWJiYXNpYW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFNldCB0aGUgYXBwcm9wcmlhdGUgQXV0b0ZpbGwgY29udGV4dCBmb3Igc3VnZ2VzdGVkIHBh c3N3b3Jkcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9jcHAvV0tS ZXRhaW5QdHIuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9jcHAvV0tSZXRhaW5QdHIu aAppbmRleCA0OWU5ZGJjLi42NTI5MTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvY3BwL1dLUmV0YWluUHRyLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL2NwcC9XS1JldGFpblB0ci5oCkBAIC0yNDIsNyArMjQyLDExIEBAIHRlbXBsYXRlPHR5cGVu YW1lIFQsIHR5cGVuYW1lIFU+IGlubGluZSBib29sIG9wZXJhdG9yIT0oVCogYSwgY29uc3QgV0tS ZXRhaW5QdHI8CiAgICAgcmV0dXJuIGEgIT0gYi5nZXQoKTsgCiB9CiAKKyNpZiAoZGVmaW5lZChX SU4zMikgfHwgZGVmaW5lZChfV0lOMzIpKSAmJiAhKChfTVNDX1ZFUiA+IDE5MDApICYmIF9fY2xh bmdfXykKK3RlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSBXS1JldGFpblB0cjxUPiBhZG9wdFdL KFQpIF9DaGVja19yZXR1cm5fOworI2Vsc2UKIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSBX S1JldGFpblB0cjxUPiBhZG9wdFdLKFQpIF9fYXR0cmlidXRlX18oKHdhcm5fdW51c2VkX3Jlc3Vs dCkpOworI2VuZGlmCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgV0tSZXRhaW5QdHI8VD4g YWRvcHRXSyhUIG8pCiB7CiAgICAgcmV0dXJuIFdLUmV0YWluUHRyPFQ+KEFkb3B0V0ssIG8pOwo= 334224 2018-02-19 18:44:10 -0800 2018-02-20 00:42:17 -0800 Patch (a rebased version) bz182479-3.patch text/plain 1478 Yousuke.Kimoto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNzJiZmQ3Yi4uNjgwY2Y3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxOC0wMi0xOSAgWW91c3VrZSBLaW1vdG8gIDx5b3VzdWtlLmtpbW90b0Bzb255LmNvbT4KKwor ICAgICAgICBbV2luXSBGaXggTVNWQydzIHRyZWF0aW5nIF9fYXR0cmlidXRlX18oKHdhcm5fdW51 c2VkX3Jlc3VsdCkpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODI0NzkKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAg ICBTaW5jZSBNU1ZDIGRvZXNuJ3QgdW5kZXJzdGFuZCAiX19hdHRyaWJ1dGVfXyIsICJfQ2hlY2tf cmV0dXJuXyIgaXMgdXNlZCBpbnN0ZWFkLgorICAgICAgICBJZiBjbGFuZyBhbmQgVmlzdWFsU3R1 ZGlvIDIwMTcgYXJlIHVzZWQsIGEgbWFjcm8gd2l0aCAiX19hdHRyaXV0ZV9fIiB3aWxsIGJlIGNo b3Nlbi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvY3BwL1dLUmV0YWluUHRyLmg6CisKIDIw MTgtMDItMTggIFJlemEgQWJiYXNpYW4gIDxyYWJiYXNpYW5AYXBwbGUuY29tPgogCiAgICAgICAg IFNldCB0aGUgYXBwcm9wcmlhdGUgQXV0b0ZpbGwgY29udGV4dCBmb3Igc3VnZ2VzdGVkIHBhc3N3 b3Jkcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9jcHAvV0tSZXRh aW5QdHIuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9jcHAvV0tSZXRhaW5QdHIuaApp bmRleCA0OWU5ZGJjLi42NTI5MTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvY3BwL1dLUmV0YWluUHRyLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L2NwcC9XS1JldGFpblB0ci5oCkBAIC0yNDIsNyArMjQyLDExIEBAIHRlbXBsYXRlPHR5cGVuYW1l IFQsIHR5cGVuYW1lIFU+IGlubGluZSBib29sIG9wZXJhdG9yIT0oVCogYSwgY29uc3QgV0tSZXRh aW5QdHI8CiAgICAgcmV0dXJuIGEgIT0gYi5nZXQoKTsgCiB9CiAKKyNpZiAoZGVmaW5lZChXSU4z MikgfHwgZGVmaW5lZChfV0lOMzIpKSAmJiAhKChfTVNDX1ZFUiA+IDE5MDApICYmIF9fY2xhbmdf XykKK3RlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSBXS1JldGFpblB0cjxUPiBhZG9wdFdLKFQp IF9DaGVja19yZXR1cm5fOworI2Vsc2UKIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSBXS1Jl dGFpblB0cjxUPiBhZG9wdFdLKFQpIF9fYXR0cmlidXRlX18oKHdhcm5fdW51c2VkX3Jlc3VsdCkp OworI2VuZGlmCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgV0tSZXRhaW5QdHI8VD4gYWRv cHRXSyhUIG8pCiB7CiAgICAgcmV0dXJuIFdLUmV0YWluUHRyPFQ+KEFkb3B0V0ssIG8pOwo=