18214 2008-03-29 19:50:39 -0700 WebKit will sometimes load duplicate plugins 2008-03-31 09:53:28 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Windows XP RESOLVED FIXED PlatformOnly P2 Normal --- 18208 1 aroben aroben andersca jhoneycutt oldest_to_newest 75803 0 aroben 2008-03-29 19:50:39 -0700 I've noticed that if I look at Safari's "Installed Plugins" page I see two copies of "RealPlayer(tm) G2 LiveConnect-Enabled Plug-In (32-bit)" and "RealJukebox NS Plugin", but in Firefox's about:plugins I only see one of each. I believe that PluginPackage::equal is not being strict enough. 75804 1 aroben 2008-03-29 20:03:02 -0700 (In reply to comment #0) > I believe that PluginPackage::equal is not being strict enough. By which I mean: I believe that PluginPackage::equal is being too strict. 75805 2 20206 aroben 2008-03-29 20:13:33 -0700 Created attachment 20206 Patch v1 + ChangeLog 75872 3 20206 darin 2008-03-30 16:37:41 -0700 Comment on attachment 20206 Patch v1 + ChangeLog r=me 75932 4 aroben 2008-03-31 09:53:28 -0700 Committed in r31458. 20206 2008-03-29 20:13:33 -0700 2008-03-30 16:37:41 -0700 Patch v1 + ChangeLog 0001--Fix-Bug-18214-WebKit-will-sometimes-load-du.patch text/plain 3598 aroben RnJvbSA0YWVhMTE3MTJkYjdiZGM0MzdlOTc0ZDE1NGVjMWE5ODkwOTE4Yzk2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIFJvYmVuIDxhcm9iZW5AYXBwbGUuY29tPgpEYXRlOiBT YXQsIDI5IE1hciAyMDA4IDIzOjEyOjI4IC0wNDAwClN1YmplY3Q6IFtQRlJdICAgICAgICAgRml4 IEJ1ZyAxODIxNDogV2ViS2l0IHdpbGwgc29tZXRpbWVzIGxvYWQgZHVwbGljYXRlIHBsdWdpbnMK CiAgICAgICAgPGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjE0PgoK ICAgICAgICBXZSBub3cgY29tcGFyZSAzIHRoaW5ncyB0byBkZXRlcm1pbmUgaWYgdHdvIFBsdWdp blBhY2thZ2VzIGFyZSBlcXVhbDoKICAgICAgICAgIDEpIE5hbWUKICAgICAgICAgIDIpIERlc2Ny aXB0aW9uCiAgICAgICAgICAzKSBTdXBwb3J0ZWQgTUlNRSB0eXBlcwoKICAgICAgICBUaGlzIG1h dGNoZXMgR2Vja28ncyBlcXVhbGl0eSBsb2dpYyBmb3IgcGx1Z2lucyAoaW1wbGVtZW50ZWQgaW4K ICAgICAgICBuc1BsdWdpblRhZzo6RXF1YWxzKS4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCgogICAgICAgICogcGx1Z2lucy93aW4vUGx1Z2luUGFja2FnZVdpbi5jcHA6CiAg ICAgICAgKFdlYkNvcmU6OlBsdWdpblBhY2thZ2U6Omhhc2gpOiBVc2UgdGhlIGFib3ZlLW1lbnRp b25lZCAzIGNyaXRlcmlhIHRvCiAgICAgICAgY2FsY3VsYXRlIHRoZSBoYXNoLgogICAgICAgIChX ZWJDb3JlOjpQbHVnaW5QYWNrYWdlOjplcXVhbCk6IFVzZSB0aGUgYWJvdmUtbWVudGlvbmVkIDMg Y3JpdGVyaWEgdG8KICAgICAgICBkZXRlcm1pbmUgZXF1YWxpdHkuCi0tLQogV2ViQ29yZS9DaGFu Z2VMb2cgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMjIgKysrKysrKysrKysrKysrKysrKysr KwogV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5QYWNrYWdlV2luLmNwcCB8ICAgMjUgKysrKysr KysrKysrKysrKysrKystLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCA0MiBpbnNlcnRpb25zKCspLCA1 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9D aGFuZ2VMb2cKaW5kZXggZGE0M2JjMi4uNjFmZjQ3ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFu Z2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAwOC0wMy0y OSAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IEJ1ZyAxODIx NDogV2ViS2l0IHdpbGwgc29tZXRpbWVzIGxvYWQgZHVwbGljYXRlIHBsdWdpbnMKKworICAgICAg ICA8aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyMTQ+CisKKyAgICAg ICAgV2Ugbm93IGNvbXBhcmUgMyB0aGluZ3MgdG8gZGV0ZXJtaW5lIGlmIHR3byBQbHVnaW5QYWNr YWdlcyBhcmUgZXF1YWw6CisgICAgICAgICAgMSkgTmFtZQorICAgICAgICAgIDIpIERlc2NyaXB0 aW9uCisgICAgICAgICAgMykgU3VwcG9ydGVkIE1JTUUgdHlwZXMKKworICAgICAgICBUaGlzIG1h dGNoZXMgR2Vja28ncyBlcXVhbGl0eSBsb2dpYyBmb3IgcGx1Z2lucyAoaW1wbGVtZW50ZWQgaW4K KyAgICAgICAgbnNQbHVnaW5UYWc6OkVxdWFscykuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbHVnaW5zL3dpbi9QbHVnaW5QYWNrYWdlV2luLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblBhY2thZ2U6Omhhc2gpOiBVc2UgdGhlIGFib3Zl LW1lbnRpb25lZCAzIGNyaXRlcmlhIHRvCisgICAgICAgIGNhbGN1bGF0ZSB0aGUgaGFzaC4KKyAg ICAgICAgKFdlYkNvcmU6OlBsdWdpblBhY2thZ2U6OmVxdWFsKTogVXNlIHRoZSBhYm92ZS1tZW50 aW9uZWQgMyBjcml0ZXJpYSB0bworICAgICAgICBkZXRlcm1pbmUgZXF1YWxpdHkuCisKIDIwMDgt MDMtMjcgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9sbGl2aWVycy5jb20+CiAKICAgICAg ICAgd3ggYnVpbGQgZml4LiBSZXR1cm4gYSBkZWZhdWx0IHZhbHVlIGZvciBvcGVyYXRvciA9PSAK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luUGFja2FnZVdpbi5jcHAgYi9X ZWJDb3JlL3BsdWdpbnMvd2luL1BsdWdpblBhY2thZ2VXaW4uY3BwCmluZGV4IGNjYzc1ODYuLjUy ODkxYmEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luUGFja2FnZVdpbi5j cHAKKysrIGIvV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5QYWNrYWdlV2luLmNwcApAQCAtMzYw LDE4ICszNjAsMzMgQEAgYWJvcnQ6CiAKIHVuc2lnbmVkIFBsdWdpblBhY2thZ2U6Omhhc2goKSBj b25zdAogeyAKLSAgICBjb25zdCB1bnNpZ25lZCBoYXNoQ29kZXNbM10gPSB7CisgICAgY29uc3Qg dW5zaWduZWQgaGFzaENvZGVzW10gPSB7CisgICAgICAgIG1fbmFtZS5pbXBsKCktPmhhc2goKSwK ICAgICAgICAgbV9kZXNjcmlwdGlvbi5pbXBsKCktPmhhc2goKSwKLSAgICAgICAgbV9sYXN0TW9k aWZpZWQuZHdMb3dEYXRlVGltZSwKLSAgICAgICAgbV9sYXN0TW9kaWZpZWQuZHdIaWdoRGF0ZVRp bWUKKyAgICAgICAgbV9taW1lVG9FeHRlbnNpb25zLnNpemUoKQogICAgIH07CiAKLSAgICByZXR1 cm4gU3RyaW5nSW1wbDo6Y29tcHV0ZUhhc2gocmVpbnRlcnByZXRfY2FzdDxjb25zdCBVQ2hhcio+ KGhhc2hDb2RlcyksIDMgKiBzaXplb2YodW5zaWduZWQpIC8gc2l6ZW9mKFVDaGFyKSk7CisgICAg cmV0dXJuIFN0cmluZ0ltcGw6OmNvbXB1dGVIYXNoKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgVUNo YXIqPihoYXNoQ29kZXMpLCBzaXplb2YoaGFzaENvZGVzKSAvIHNpemVvZihVQ2hhcikpOwogfQog CiBib29sIFBsdWdpblBhY2thZ2U6OmVxdWFsKGNvbnN0IFBsdWdpblBhY2thZ2UmIGEsIGNvbnN0 IFBsdWdpblBhY2thZ2UmIGIpCiB7Ci0gICAgcmV0dXJuIGEubV9kZXNjcmlwdGlvbiA9PSBiLm1f ZGVzY3JpcHRpb24gJiYgKENvbXBhcmVGaWxlVGltZSgmYS5tX2xhc3RNb2RpZmllZCwgJmIubV9s YXN0TW9kaWZpZWQpID09IDApOworICAgIGlmIChhLm1fbmFtZSAhPSBiLm1fbmFtZSkKKyAgICAg ICAgcmV0dXJuIGZhbHNlOworCisgICAgaWYgKGEubV9kZXNjcmlwdGlvbiAhPSBiLm1fZGVzY3Jp cHRpb24pCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGlmIChhLm1fbWltZVRvRXh0ZW5z aW9ucy5zaXplKCkgIT0gYi5tX21pbWVUb0V4dGVuc2lvbnMuc2l6ZSgpKQorICAgICAgICByZXR1 cm4gZmFsc2U7CisKKyAgICBNSU1FVG9FeHRlbnNpb25zTWFwOjpjb25zdF9pdGVyYXRvcjo6S2V5 cyBlbmQgPSBhLm1fbWltZVRvRXh0ZW5zaW9ucy5lbmQoKS5rZXlzKCk7CisgICAgZm9yIChNSU1F VG9FeHRlbnNpb25zTWFwOjpjb25zdF9pdGVyYXRvcjo6S2V5cyBpdCA9IGEubV9taW1lVG9FeHRl bnNpb25zLmJlZ2luKCkua2V5cygpOyBpdCAhPSBlbmQ7ICsraXQpIHsKKyAgICAgICAgaWYgKCFi Lm1fbWltZVRvRXh0ZW5zaW9ucy5jb250YWlucygqaXQpKQorICAgICAgICAgICAgcmV0dXJuIGZh bHNlOworICAgIH0KKworICAgIHJldHVybiB0cnVlOwogfQogCiB9Ci0tIAoxLjUuNC40LjUzNy5n Yjc1YWEKCg==