182007 2018-01-23 13:03:57 -0800 REGRESSION (r227340): Layout Test fast/workers/worker-cloneport.html is a flaky failure 2019-12-18 12:11:23 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=181922 https://bugs.webkit.org/show_bug.cgi?id=205357 InRadar P2 Normal --- 1 ryanhaddad cdumez achristensen beidson cdumez commit-queue ggaren jlewis3 rniwa webkit-bug-importer youennf oldest_to_newest 1392217 0 ryanhaddad 2018-01-23 13:03:57 -0800 The following layout test is flaky on macOS Release WK2 fast/workers/worker-cloneport.html Probable cause: Unknown. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fworkers%2Fworker-cloneport.html --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/fast/workers/worker-cloneport-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/fast/workers/worker-cloneport-actual.txt @@ -1,6 +1,7 @@ Test MessagePort messaging/entangle/detangle across threads. Should print "SUCCESS" when done. PASS: Received request for 50000 messages +FAILURE: Received: 0 events - expected: 50000 SUCCESS - received 50000 messages. DONE 1394308 1 ryanhaddad 2018-01-29 15:49:51 -0800 This regressed with https://trac.webkit.org/changeset/227340/webkit I can reproduce the failure with a build of r227340 using the following: run-webkit-tests fast/workers/worker-cloneport.html -fg --iter 25 --no-retry-failure I cannot reproduce with r227339. 1394310 2 webkit-bug-importer 2018-01-29 15:51:04 -0800 <rdar://problem/37005504> 1394400 3 beidson 2018-01-29 19:27:37 -0800 (In reply to Ryan Haddad from comment #0) > The following layout test is flaky on macOS Release WK2 > > fast/workers/worker-cloneport.html > > Probable cause: > > Unknown. How sure are we there's no crashes? 1394402 4 cdumez 2018-01-29 19:29:02 -0800 (In reply to Brady Eidson from comment #3) > (In reply to Ryan Haddad from comment #0) > > The following layout test is flaky on macOS Release WK2 > > > > fast/workers/worker-cloneport.html > > > > Probable cause: > > > > Unknown. > > How sure are we there's no crashes? https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r227764%20(2595)/results.html shows no crash 1394833 5 jlewis3 2018-01-30 16:46:30 -0800 marked as flaky on macOS release: https://trac.webkit.org/changeset/227865/webkit 1395157 6 cdumez 2018-01-31 14:37:46 -0800 I can easily reproduce the issue with the command provided by Ryan. 1395162 7 cdumez 2018-01-31 14:45:26 -0800 PASS: Received request for 50000 messages +FAILURE: Received: 0 events - expected: 50000 // Evidence a timeout timer has fired too early SUCCESS - received 50000 messages. // Evidence the test is succeeding. DONE The code looks like: // Queue up a task to execute once the messages have been processed. The timeout value is set fairly large to account for Chromium's different message delivery architecture. // This only fires in the case of a test failure, so it does not slow down test running. var timer = setTimeout(function() { log("FAILURE: Received: " + itemNum + " events - expected: " + numMessages); }, 1000); So if we've not received all the messages within one second, that line will be printed out. This is clearly an issue with the test. 1395165 8 332803 cdumez 2018-01-31 14:48:59 -0800 Created attachment 332803 Patch 1395166 9 332803 rniwa 2018-01-31 14:52:52 -0800 Comment on attachment 332803 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332803&action=review > LayoutTests/fast/workers/worker-cloneport.html:60 > - }, 1000); > + }, 20000); 20s? That's more than DRTs timeout. How about 8s? 1395170 10 332805 cdumez 2018-01-31 14:56:27 -0800 Created attachment 332805 Patch 1395171 11 cdumez 2018-01-31 14:57:01 -0800 (In reply to Ryosuke Niwa from comment #9) > Comment on attachment 332803 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=332803&action=review > > > LayoutTests/fast/workers/worker-cloneport.html:60 > > - }, 1000); > > + }, 20000); > > 20s? That's more than DRTs timeout. How about 8s? Deal. 1395185 12 332805 commit-queue 2018-01-31 15:22:36 -0800 Comment on attachment 332805 Patch Clearing flags on attachment: 332805 Committed r227935: <https://trac.webkit.org/changeset/227935> 1395186 13 commit-queue 2018-01-31 15:22:38 -0800 All reviewed patches have been landed. Closing bug. 332803 2018-01-31 14:48:59 -0800 2018-01-31 14:56:26 -0800 Patch bug-182007-20180131144858.patch text/plain 2260 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3OTA0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODk5Nzk1ZTkxZGYwYzM1OTZlMjc1 ZjNjOGM3ZTFmMmY5NmY5OTkzNi4uYjA5MGNkNGQ3YjI0MGU1MTg1NzIyOGRhOGM0YmMwMDQwNzkz ZGRiYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAxLTMxICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjIyNzM0MCk6IExheW91dCBU ZXN0IGZhc3Qvd29ya2Vycy93b3JrZXItY2xvbmVwb3J0Lmh0bWwgaXMgYSBmbGFreSBmYWlsdXJl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODIwMDcK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM3MDA1NTA0PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluY3JlYXNlIHRoZSB0ZXN0J3MgdGltZW91dC4g VGhlIHRlc3Qgc29tZXRpbWVzIHRha2VzIG1vcmUgdGhhbiAxIHNlY29uZCB0byBydW4gYW5kIHdv dWxkCisgICAgICAgIGxvZyBhIEZBSUwgbGluZSwgZXZlbiB0aG91Z2ggdGhlIHRlc3QgZXZlbnR1 YWxseSBzdWNjZWVkcy4KKworICAgICAgICAqIGZhc3Qvd29ya2Vycy93b3JrZXItY2xvbmVwb3J0 Lmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zOgorCiAy MDE4LTAxLTMxICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAgICAgICAg W01vZGVybiBNZWRpYSBDb250cm9sc10gVHVybiBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMv c3RhcnQtc3VwcG9ydCB0ZXN0cyBiYWNrIG9uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L3dvcmtlcnMvd29ya2VyLWNsb25lcG9ydC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJz L3dvcmtlci1jbG9uZXBvcnQuaHRtbAppbmRleCA5ZDUwOTFiZDIwODIxODQ3YjIxMmU3MmRkZjZj NTZkYTk1N2Y2MmMzLi44YzhjODljMjVmOGVlN2Y5ZmQ5YzQyMzkzNzUwYmY4NjVkNzY1Njg0IDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvd29ya2VyLWNsb25lcG9ydC5odG1s CisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy93b3JrZXItY2xvbmVwb3J0Lmh0bWwKQEAg LTU3LDcgKzU3LDcgQEAgZnVuY3Rpb24gcmVzZW5kUG9ydChldnQpCiAgICAgICAgIC8vIFRoaXMg b25seSBmaXJlcyBpbiB0aGUgY2FzZSBvZiBhIHRlc3QgZmFpbHVyZSwgc28gaXQgZG9lcyBub3Qg c2xvdyBkb3duIHRlc3QgcnVubmluZy4KICAgICAgICAgdmFyIHRpbWVyID0gc2V0VGltZW91dChm dW5jdGlvbigpIHsKICAgICAgICAgICAgIGxvZygiRkFJTFVSRTogUmVjZWl2ZWQ6ICIgKyBpdGVt TnVtICsgIiBldmVudHMgLSBleHBlY3RlZDogIiArIG51bU1lc3NhZ2VzKTsKLSAgICAgICAgfSwg MTAwMCk7CisgICAgICAgIH0sIDIwMDAwKTsKICAgICAgICAgZXZ0LnBvcnRzWzBdLm9ubWVzc2Fn ZSA9IGZ1bmN0aW9uKGV2ZW50KSB7CiAgICAgICAgICAgICB2YXIgZG9uZSA9IGZhbHNlOwogICAg ICAgICAgICAgaWYgKGV2ZW50LmRhdGEgPT0gaXRlbU51bSkgewpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDcwNWNmMzFjNTQ5MjQxYWQ5ZmM3 NzYwYWMzY2RkZmJkMTAxYTQ4NjIuLjIzYzlhYzJlNzFkNWM3NjYyZDMxMDMxMjMyMWE2OWMzY2Ex ZGJjYjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVj dGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlv bnMKQEAgLTg4MSw1ICs4ODEsMyBAQCB3ZWJraXQub3JnL2IvMTgxOTU3IFsgUmVsZWFzZSBdIGh0 dHAvdGVzdHMvbWlzYy9yZXNvdXJjZS10aW1pbmctcmVzb2x1dGlvbi5odG1sCiAKIHdlYmtpdC5v cmcvYi8xODE4MzUgd2VicnRjL2NhcHR1cmVDYW52YXMtd2VicnRjLmh0bWwgWyBQYXNzIFRpbWVv dXQgXQogCi13ZWJraXQub3JnL2IvMTgyMDA3IFsgUmVsZWFzZSBdIGZhc3Qvd29ya2Vycy93b3Jr ZXItY2xvbmVwb3J0Lmh0bWwgWyBQYXNzIEZhaWx1cmUgXQotCg== 332805 2018-01-31 14:56:27 -0800 2018-01-31 15:22:36 -0800 Patch bug-182007-20180131145627.patch text/plain 2284 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3OTA0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODk5Nzk1ZTkxZGYwYzM1OTZlMjc1 ZjNjOGM3ZTFmMmY5NmY5OTkzNi4uOGJiODg1YzAyNzEzMTQ2NzFkNTVhMDZiZGFjYjFiODJiODdl ZTZmOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAxLTMxICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjIyNzM0MCk6IExheW91dCBU ZXN0IGZhc3Qvd29ya2Vycy93b3JrZXItY2xvbmVwb3J0Lmh0bWwgaXMgYSBmbGFreSBmYWlsdXJl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODIwMDcK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM3MDA1NTA0PgorCisgICAgICAgIFJldmlld2VkIGJ5 IFJ5b3N1a2UgTml3YS4KKworICAgICAgICBJbmNyZWFzZSB0aGUgdGVzdCdzIHRpbWVvdXQuIFRo ZSB0ZXN0IHNvbWV0aW1lcyB0YWtlcyBtb3JlIHRoYW4gMSBzZWNvbmQgdG8gcnVuIGFuZCB3b3Vs ZAorICAgICAgICBsb2cgYSBGQUlMIGxpbmUsIGV2ZW4gdGhvdWdoIHRoZSB0ZXN0IGV2ZW50dWFs bHkgc3VjY2VlZHMuCisKKyAgICAgICAgKiBmYXN0L3dvcmtlcnMvd29ya2VyLWNsb25lcG9ydC5o dG1sOgorICAgICAgICAqIHBsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAx OC0wMS0zMSAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAgICAgIFtN b2Rlcm4gTWVkaWEgQ29udHJvbHNdIFR1cm4gbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3N0 YXJ0LXN1cHBvcnQgdGVzdHMgYmFjayBvbgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC93 b3JrZXJzL3dvcmtlci1jbG9uZXBvcnQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy93 b3JrZXItY2xvbmVwb3J0Lmh0bWwKaW5kZXggOWQ1MDkxYmQyMDgyMTg0N2IyMTJlNzJkZGY2YzU2 ZGE5NTdmNjJjMy4uZjdmMzNiZjFmNTUyZTM3OTZkODNjOGJiYTM2NjU2Mzg3YzhjYjdmNCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3dvcmtlci1jbG9uZXBvcnQuaHRtbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvd29ya2VyLWNsb25lcG9ydC5odG1sCkBAIC01 Nyw3ICs1Nyw4IEBAIGZ1bmN0aW9uIHJlc2VuZFBvcnQoZXZ0KQogICAgICAgICAvLyBUaGlzIG9u bHkgZmlyZXMgaW4gdGhlIGNhc2Ugb2YgYSB0ZXN0IGZhaWx1cmUsIHNvIGl0IGRvZXMgbm90IHNs b3cgZG93biB0ZXN0IHJ1bm5pbmcuCiAgICAgICAgIHZhciB0aW1lciA9IHNldFRpbWVvdXQoZnVu Y3Rpb24oKSB7CiAgICAgICAgICAgICBsb2coIkZBSUxVUkU6IFJlY2VpdmVkOiAiICsgaXRlbU51 bSArICIgZXZlbnRzIC0gZXhwZWN0ZWQ6ICIgKyBudW1NZXNzYWdlcyk7Ci0gICAgICAgIH0sIDEw MDApOworICAgICAgICAgICAgcmVwb3J0RG9uZSgpOworICAgICAgICB9LCA4MDAwKTsKICAgICAg ICAgZXZ0LnBvcnRzWzBdLm9ubWVzc2FnZSA9IGZ1bmN0aW9uKGV2ZW50KSB7CiAgICAgICAgICAg ICB2YXIgZG9uZSA9IGZhbHNlOwogICAgICAgICAgICAgaWYgKGV2ZW50LmRhdGEgPT0gaXRlbU51 bSkgewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0 YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCmlu ZGV4IDcwNWNmMzFjNTQ5MjQxYWQ5ZmM3NzYwYWMzY2RkZmJkMTAxYTQ4NjIuLjIzYzlhYzJlNzFk NWM3NjYyZDMxMDMxMjMyMWE2OWMzY2ExZGJjYjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTg4MSw1ICs4ODEsMyBAQCB3ZWJraXQub3Jn L2IvMTgxOTU3IFsgUmVsZWFzZSBdIGh0dHAvdGVzdHMvbWlzYy9yZXNvdXJjZS10aW1pbmctcmVz b2x1dGlvbi5odG1sCiAKIHdlYmtpdC5vcmcvYi8xODE4MzUgd2VicnRjL2NhcHR1cmVDYW52YXMt d2VicnRjLmh0bWwgWyBQYXNzIFRpbWVvdXQgXQogCi13ZWJraXQub3JnL2IvMTgyMDA3IFsgUmVs ZWFzZSBdIGZhc3Qvd29ya2Vycy93b3JrZXItY2xvbmVwb3J0Lmh0bWwgWyBQYXNzIEZhaWx1cmUg XQotCg==