181957 2018-01-22 14:58:19 -0800 Layout Test http/tests/misc/resource-timing-resolution.html is a flaky failure 2018-12-06 11:33:43 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad jiewen_tan achristensen ap commit-queue jiewen_tan jlewis3 joepeck rniwa tsavell webkit-bug-importer youennf oldest_to_newest 1391838 0 ryanhaddad 2018-01-22 14:58:19 -0800 The following layout test is flaky on release testers http/tests/misc/resource-timing-resolution.html Probable cause: Unknown. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fmisc%2Fresource-timing-resolution.html --- /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/http/tests/misc/resource-timing-resolution-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/http/tests/misc/resource-timing-resolution-actual.txt @@ -3,7 +3,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS t0 !== t1 is true +FAIL t0 !== t1 should be true. Was false. PASS shouldBeNearZeroOrOne < 1e-10 || Math.abs(shouldBeNearZeroOrOne - 1) < 1e-10 is true PASS successfullyParsed is true 1391840 1 ryanhaddad 2018-01-22 14:59:49 -0800 The earliest failure visible on the dashboard is https://trac.webkit.org/changeset/226646/webkit, but that change is unrelated. 1392283 2 jlewis3 2018-01-23 15:14:56 -0800 Marked as flaky https://trac.webkit.org/changeset/227451/webkit 1485499 3 ryanhaddad 2018-12-05 16:23:51 -0800 This test has become very flaky after https://trac.webkit.org/changeset/238877/webkit The diff is the same as the one above. https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/r238912%20(1467)/results.html 1485516 4 jiewen_tan 2018-12-05 17:07:20 -0800 (In reply to Ryan Haddad from comment #3) > This test has become very flaky after > https://trac.webkit.org/changeset/238877/webkit > > The diff is the same as the one above. > > https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/ > r238912%20(1467)/results.html I don’t think so. I tried to ran the test 1000 times before and after my change. It more or less reserves the same level of flakiness. Also, I don’t think there is anything my patch could affect this test case as it doesn’t have any iframes. 1485518 5 ryanhaddad 2018-12-05 17:11:33 -0800 (In reply to Jiewen Tan from comment #4) > (In reply to Ryan Haddad from comment #3) > > This test has become very flaky after > > https://trac.webkit.org/changeset/238877/webkit > > > > The diff is the same as the one above. > > > > https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/ > > r238912%20(1467)/results.html > > I don’t think so. I tried to ran the test 1000 times before and after my > change. It more or less reserves the same level of flakiness. Also, I don’t > think there is anything my patch could affect this test case as it doesn’t > have any iframes. Hm, the flakiness dashboard shows a drastic increase in the number of failures starting yesterday. Even if it isn't your revision, something definitely changed. 1485519 6 jiewen_tan 2018-12-05 17:20:00 -0800 (In reply to Ryan Haddad from comment #5) > (In reply to Jiewen Tan from comment #4) > > (In reply to Ryan Haddad from comment #3) > > > This test has become very flaky after > > > https://trac.webkit.org/changeset/238877/webkit > > > > > > The diff is the same as the one above. > > > > > > https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/ > > > r238912%20(1467)/results.html > > > > I don’t think so. I tried to ran the test 1000 times before and after my > > change. It more or less reserves the same level of flakiness. Also, I don’t > > think there is anything my patch could affect this test case as it doesn’t > > have any iframes. > > Hm, the flakiness dashboard shows a drastic increase in the number of > failures starting yesterday. Even if it isn't your revision, something > definitely changed. How about I fix the thing and relieve us all. 1485532 7 356689 jiewen_tan 2018-12-05 17:59:27 -0800 Created attachment 356689 Patch 1485598 8 ryanhaddad 2018-12-05 20:25:04 -0800 (In reply to Jiewen Tan from comment #6) > How about I fix the thing and relieve us all. Works for me. Thanks, Jiewen! 1485747 9 356689 jiewen_tan 2018-12-06 11:06:42 -0800 Comment on attachment 356689 Patch Thanks Youenn for r+ it. 1485750 10 356689 commit-queue 2018-12-06 11:32:47 -0800 Comment on attachment 356689 Patch Clearing flags on attachment: 356689 Committed r238935: <https://trac.webkit.org/changeset/238935> 1485751 11 commit-queue 2018-12-06 11:32:48 -0800 All reviewed patches have been landed. Closing bug. 1485752 12 webkit-bug-importer 2018-12-06 11:33:43 -0800 <rdar://problem/46529944> 356689 2018-12-05 17:59:27 -0800 2018-12-06 11:32:47 -0800 Patch bug-181957-20181205175926.patch text/plain 4108 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4ODc3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjljOTAyYmNmNDFiNWY3MzBjYzQ0 MWRkMmQ3ZjY1OGIxMGM0ZjZlMS4uOGJjYWRjYTM0ZjA1N2EzNGYyNjJkZDVmMzEyZGZlY2UwNTU3 ZWM0MCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEyLTA1ICBKaWV3ZW4gVGFuICA8amll d2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0IFRlc3QgaHR0cC90ZXN0cy9taXNj L3Jlc291cmNlLXRpbWluZy1yZXNvbHV0aW9uLmh0bWwgaXMgYSBmbGFreSBmYWlsdXJlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE5NTcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSB0aGUgdGlt aW5nIGluZm9ybWF0aW9uIGlzIGEgbXVsdGlwbGllciBvZiBhIHNtYWxsIGRlbHRhLCBpdCBpcyBs aWtlbHkgdGhhdAorICAgICAgICB0d28gdGltaW5nIGluZm9ybWF0aW9uIGFyZSB0aGUgc2FtZSBh cyB0aGV5IGFyZSBzbyBjbG9zZSB0aGF0IGZhbGwgaW50byB0aGUgc2FtZQorICAgICAgICBidWNr ZXQuIFRoZXJlZm9yZSwgdGhpcyBwYXRjaCByZWxlYXNlcyB0aGUgY2hlY2sgb2YgJ3QwICE9PSB0 MScuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL21pc2MvcmVzb3VyY2UtdGltaW5nLXJlc29sdXRp b24tZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMvbWlzYy9yZXNvdXJjZS10aW1p bmctcmVzb2x1dGlvbi5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL2lvcy13azIvVGVzdEV4cGVj dGF0aW9uczoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnM6CisK IDIwMTgtMTEtMzAgIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KIAogICAgICAg ICBEb24ndCByZXBvcnQgcmVzb3VyY2UgdGltaW5nIHRvIHBhcmVudCBmcmFtZSBmb3IgaGlzdG9y eSBpdGVtcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL3Jlc291cmNl LXRpbWluZy1yZXNvbHV0aW9uLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMv bWlzYy9yZXNvdXJjZS10aW1pbmctcmVzb2x1dGlvbi1leHBlY3RlZC50eHQKaW5kZXggYjkxNTYx ZDE0ZmMxNWYxZTI1YzU0MDYzMmZkYmFlZGRhNTUwMTQxMi4uMmIyMTNmMmE0NjhiOTJkNTYwMTRi ZDAwMWMzMGZhMDdiMDk0MjI2OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9t aXNjL3Jlc291cmNlLXRpbWluZy1yZXNvbHV0aW9uLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL21pc2MvcmVzb3VyY2UtdGltaW5nLXJlc29sdXRpb24tZXhwZWN0ZWQu dHh0CkBAIC0zLDcgKzMsNiBAQCBWZXJpZmllcyB0aGUgbWluaW11bSByZXNvbHV0aW9uIGlzIDUg bWljcm9zZWNvbmRzLgogT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNT IiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgogCiAKLVBBU1MgdDAgIT09 IHQxIGlzIHRydWUKIFBBU1Mgc2hvdWxkQmVOZWFyWmVyb09yT25lIDwgMWUtMTAgfHwgTWF0aC5h YnMoc2hvdWxkQmVOZWFyWmVyb09yT25lIC0gMSkgPCAxZS0xMCBpcyB0cnVlCiBQQVNTIHN1Y2Nl c3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvbWlzYy9yZXNvdXJjZS10aW1pbmctcmVzb2x1dGlvbi5odG1sIGIvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9taXNjL3Jlc291cmNlLXRpbWluZy1yZXNvbHV0aW9uLmh0bWwKaW5kZXggZDE5OTVk ZjhiOWViODIyYzBhZWU1NjMyZTRjNGRiYWFkN2E3NjAxZi4uYTQ3YjI4MzczZTMxZjEwNzY2ZmIx NDliZTlkNzhmMDY4N2RmYWU4YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9t aXNjL3Jlc291cmNlLXRpbWluZy1yZXNvbHV0aW9uLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9taXNjL3Jlc291cmNlLXRpbWluZy1yZXNvbHV0aW9uLmh0bWwKQEAgLTE4LDcgKzE4 LDYgQEAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoImxvYWQiLCBmdW5jdGlvbigpIHsKICAgICB2 YXIgZW50cmllcyA9IHBlcmZvcm1hbmNlLmdldEVudHJpZXMoKTsKICAgICB0MCA9IGVudHJpZXNb MF0uZmV0Y2hTdGFydDsKICAgICB0MSA9IGVudHJpZXNbMV0uZmV0Y2hTdGFydDsKLSAgICBzaG91 bGRCZSgidDAgIT09IHQxIiwgInRydWUiKTsKIAogICAgIHZhciBleHBlY3RlZFJlc29sdXRpb25N aWxsaXNlY29uZHMgPSAwLjAwNTsKICAgICB2YXIgaW50ZWdlck11bHRpcGxlT2ZSZXNvbHV0aW9u ID0gKHQxIC0gdDApIC8gZXhwZWN0ZWRSZXNvbHV0aW9uTWlsbGlzZWNvbmRzOwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDUzYmFjNDc4NDY1 NDcxMjY1YWNmOWQ1YmFhY2YzNDM2YWE5MGU5MDIuLjA1MTM1ZjU0ZGI2ODc0NmY1MjQ4YjIxMDQ3 ZDgxZjczMjBlMWEwN2QgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy13azIv VGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtd2syL1Rlc3RF eHBlY3RhdGlvbnMKQEAgLTEyNjAsOCArMTI2MCw2IEBAIHdlYmtpdC5vcmcvYi8xODExNjcgaW1w b3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9zZXJ2aWNlLXdvcmtlcnMvc2VydmljZS13b3Jr CiAKIHdlYmtpdC5vcmcvYi8xODEzOTIgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9z ZXJ2aWNlLXdvcmtlcnMvc2VydmljZS13b3JrZXIvZmV0Y2gtd2FpdHMtZm9yLWFjdGl2YXRlLmh0 dHBzLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTgxOTU3IFsgUmVsZWFz ZSBdIGh0dHAvdGVzdHMvbWlzYy9yZXNvdXJjZS10aW1pbmctcmVzb2x1dGlvbi5odG1sIFsgUGFz cyBGYWlsdXJlIF0KLQogd2Via2l0Lm9yZy9iLzE4MTgyMSBmYXN0L3Zpc3VhbC12aWV3cG9ydC9p b3MvY2FyZXQtYWZ0ZXItZm9jdXMtaW4tZml4ZWQuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKIHdl YmtpdC5vcmcvYi8xODIxNDQgWyBEZWJ1ZyBdIHdlYmdsLzEuMC4zL2NvbmZvcm1hbmNlL3JlbmRl cmluZy9tYW55LWRyYXctY2FsbHMuaHRtbCBbIFNraXAgXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGJlMDYzNjAzMGExZGZjMzQyY2JlMDgy ODgzZmM4ZGEzY2I1YTk2ODguLmZmOWIzN2ZhYzQ1NmFlNTJiYjE1OWM2NjlmZTBjMzRjYzYwN2Mz NTMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0 aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMK QEAgLTgyMCw4ICs4MjAsNiBAQCB3ZWJraXQub3JnL2IvMTgxNzUwIGltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvc2VydmljZS13b3JrZXJzL3NlcnZpY2Utd29yawogCiB3ZWJraXQub3Jn L2IvMTgxODM5IFsgRGVidWcgXSBpbnNwZWN0b3IvZGVidWdnZXIvYnJlYWtwb2ludC1hY3Rpb24t bG9nLmh0bWwgWyBQYXNzIFRpbWVvdXQgXQogCi13ZWJraXQub3JnL2IvMTgxOTU3IFsgUmVsZWFz ZSBdIGh0dHAvdGVzdHMvbWlzYy9yZXNvdXJjZS10aW1pbmctcmVzb2x1dGlvbi5odG1sIFsgUGFz cyBGYWlsdXJlIF0KLQogd2Via2l0Lm9yZy9iLzE4MTgzNSB3ZWJydGMvY2FwdHVyZUNhbnZhcy13 ZWJydGMuaHRtbCBbIFBhc3MgVGltZW91dCBdCiAKIHdlYmtpdC5vcmcvYi8xNzc2NjMgbWVkaWEv VzNDL3ZpZGVvL2V2ZW50cy9ldmVudF9wcm9ncmVzc19tYW51YWwuaHRtbCBbIFBhc3MgRmFpbHVy ZSBdCg==