181772 2018-01-17 17:30:47 -0800 Web Inspector: clicking on a path component that has no siblings should select it 2018-01-17 21:04:33 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=178802 InRadar P2 Normal --- 1 hi hi commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1390306 0 hi 2018-01-17 17:30:47 -0800 Instead of showing a <select> with one item and requiring the user to select that item to fire an event, allow the user to just click the path component and have the same effect. 1390308 1 331566 hi 2018-01-17 17:31:42 -0800 Created attachment 331566 Patch 1390336 2 331566 joepeck 2018-01-17 18:42:55 -0800 Comment on attachment 331566 Patch r=me, seems reasonable. 1390391 3 331566 commit-queue 2018-01-17 21:03:30 -0800 Comment on attachment 331566 Patch Clearing flags on attachment: 331566 Committed r227108: <https://trac.webkit.org/changeset/227108> 1390392 4 commit-queue 2018-01-17 21:03:31 -0800 All reviewed patches have been landed. Closing bug. 1390393 5 webkit-bug-importer 2018-01-17 21:04:33 -0800 <rdar://problem/36607997> 331566 2018-01-17 17:31:42 -0800 2018-01-17 21:03:30 -0800 Patch bug-181772-20180117173141.patch text/plain 2761 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDFlNmYyYWQ5MmE4MjhhZTc2YTk3ZTcxYjlhOThi MTRmMzc3MjM3ZGYuLmMwM2FlMGMzOWI0ZWFkNzRkOTk1N2VkMDcxNmM2NWI3NWUyNmYxMjcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTAxLTE3ICBEZXZp biBSb3Vzc28gIDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGNsaWNraW5nIG9uIGEgcGF0aCBjb21wb25lbnQgdGhhdCBoYXMgbm8gc2libGluZ3Mgc2hv dWxkIHNlbGVjdCBpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTgxNzcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0hpZXJhcmNoaWNhbFBhdGhDb21wb25lbnQuanM6 CisgICAgICAgIChXSS5IaWVyYXJjaGljYWxQYXRoQ29tcG9uZW50LnByb3RvdHlwZS5fdXBkYXRl U2VsZWN0RWxlbWVudCk6CisgICAgICAgIChXSS5IaWVyYXJjaGljYWxQYXRoQ29tcG9uZW50LnBy b3RvdHlwZS5fc2VsZWN0RWxlbWVudE1vdXNlRG93bik6CisKIDIwMTgtMDEtMTYgIE1hdHQgQmFr ZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENhbnZh cyB0YWI6IHR5cGluZyBhICJzcGFjZSIgaW4gdGhlIFF1aWNrQ29uc29sZSBzaG91bGRuJ3QgdHJp Z2dlciBhIHJlY29yZGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvSGllcmFyY2hpY2FsUGF0aENvbXBvbmVudC5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0hpZXJhcmNoaWNhbFBhdGhDb21wb25lbnQu anMKaW5kZXggOTJhZTQzOGUwN2RlMTUzOTk5N2Y1ZDcwNzUwMWJiMTM5YTJmOTRhZi4uMjQ2NTE5 OTI0MmU5OWI5ZjYzNjQ3M2Q0NjE2Y2IwZmNlNTg4M2RlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvSGllcmFyY2hpY2FsUGF0aENvbXBvbmVu dC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9IaWVy YXJjaGljYWxQYXRoQ29tcG9uZW50LmpzCkBAIC0yNjMsMTcgKzI2Myw3IEBAIFdJLkhpZXJhcmNo aWNhbFBhdGhDb21wb25lbnQgPSBjbGFzcyBIaWVyYXJjaGljYWxQYXRoQ29tcG9uZW50IGV4dGVu ZHMgV0kuT2JqZWN0CiAgICAgICAgICAgICBzaWJsaW5nID0gc2libGluZy5uZXh0U2libGluZzsK ICAgICAgICAgfQogCi0gICAgICAgIC8vIFNpbmNlIHRoZSBjaGFuZ2UgZXZlbnQgb25seSBmaXJl cyB3aGVuIHRoZSBzZWxlY3Rpb24gYWN0dWFsbHkgY2hhbmdlcyB3ZSBhcmUKLSAgICAgICAgLy8g c3R1Y2sgd2l0aCBlaXRoZXIgbm90IHNob3dpbmcgdGhlIGN1cnJlbnQgc2VsZWN0aW9uIGluIHRo ZSBtZW51IG9yIGFjY2VwdGluZyB0aGF0Ci0gICAgICAgIC8vIHRoZSB1c2VyIGNhbid0IHNlbGVj dCB3aGF0IGlzIGFscmVhZHkgc2VsZWN0ZWQgYWdhaW4uIFNlbGVjdGluZyB0aGUgc2FtZSBpdGVt Ci0gICAgICAgIC8vIGFnYWluIGNhbiBiZSBkZXNpcmVkIChmb3Igc2VsZWN0aW5nIHRoZSBtYWlu IHJlc291cmNlIHdoaWxlIGxvb2tpbmcgYXQgYW4gaW1hZ2UpLgotICAgICAgICAvLyBTbyBpZiB0 aGVyZSBpcyBvbmx5IG9uZSBvcHRpb24sIGRvbid0IG1ha2UgaXQgYmUgc2VsZWN0ZWQgYnkgZGVm YXVsdC4gVGhpcyBsZXRzCi0gICAgICAgIC8vIHlvdSBzZWxlY3QgdGhlIHRvcCBsZXZlbCBpdGVt IHdoaWNoIHVzdWFsbHkgaGFzIG5vIHNpYmxpbmdzIHRvIGdvIGJhY2suCi0gICAgICAgIC8vIEZJ WE1FOiBNYWtlIHRoaXMgd29yayB3aGVuIHRoZXJlIGFyZSBtdWx0aXBsZSBvcHRpb25zIHdpdGgg YSBzZWxlY3RlZEluZGV4LgotICAgICAgICBpZiAodGhpcy5fc2VsZWN0RWxlbWVudC5vcHRpb25z Lmxlbmd0aCA9PT0gMSkKLSAgICAgICAgICAgIHRoaXMuX3NlbGVjdEVsZW1lbnQuc2VsZWN0ZWRJ bmRleCA9IC0xOwotICAgICAgICBlbHNlCi0gICAgICAgICAgICB0aGlzLl9zZWxlY3RFbGVtZW50 LnNlbGVjdGVkSW5kZXggPSBwcmV2aW91c1NpYmxpbmdDb3VudDsKKyAgICAgICAgdGhpcy5fc2Vs ZWN0RWxlbWVudC5zZWxlY3RlZEluZGV4ID0gcHJldmlvdXNTaWJsaW5nQ291bnQ7CiAgICAgfQog CiAgICAgX3NlbGVjdEVsZW1lbnRNb3VzZU92ZXIoZXZlbnQpCkBAIC0yOTEsNiArMjgxLDEyIEBA IFdJLkhpZXJhcmNoaWNhbFBhdGhDb21wb25lbnQgPSBjbGFzcyBIaWVyYXJjaGljYWxQYXRoQ29t cG9uZW50IGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgX3NlbGVjdEVsZW1lbnRNb3VzZURvd24oZXZl bnQpCiAgICAgewogICAgICAgICB0aGlzLl91cGRhdGVTZWxlY3RFbGVtZW50KCk7CisKKyAgICAg ICAgaWYgKHRoaXMuX3NlbGVjdEVsZW1lbnQub3B0aW9ucy5sZW5ndGggPT09IDEpIHsKKyAgICAg ICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CisKKyAgICAgICAgICAgIHRoaXMuX3NlbGVj dEVsZW1lbnRTZWxlY3Rpb25DaGFuZ2VkKCk7CisgICAgICAgIH0KICAgICB9CiAKICAgICBfc2Vs ZWN0RWxlbWVudE1vdXNlVXAoZXZlbnQpCg==