181706 2018-01-16 14:23:27 -0800 Web Inspector: Canvas tab: typing a "space" in the QuickConsole shouldn't trigger a recording 2018-01-19 11:49:40 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 175485 1 mattbaker mattbaker commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1389747 0 mattbaker 2018-01-16 14:23:27 -0800 Summary: Typing a "space" in the QuickConsole shouldn't trigger a recording. CanvasOverviewContentView should prevent this and allow the default behavior when an editable field has the focus (like TimelineTabContentView). Steps to Reproduce: 1. Goto any page with a canvas 2. Open Canvas tab 3. Focus the QuickConsole prompt, type a space => Canvas recording is triggered 1389748 1 webkit-bug-importer 2018-01-16 14:23:43 -0800 <rdar://problem/36558221> 1389754 2 331432 mattbaker 2018-01-16 14:28:30 -0800 Created attachment 331432 Patch 1389764 3 331432 joepeck 2018-01-16 15:02:21 -0800 Comment on attachment 331432 Patch Nice! r=me 1389771 4 331432 commit-queue 2018-01-16 15:17:40 -0800 Comment on attachment 331432 Patch Clearing flags on attachment: 331432 Committed r227008: <https://trac.webkit.org/changeset/227008> 1389772 5 commit-queue 2018-01-16 15:17:42 -0800 All reviewed patches have been landed. Closing bug. 331432 2018-01-16 14:28:30 -0800 2018-01-16 15:17:40 -0800 Patch bug-181706-20180116142829.patch text/plain 3236 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2OTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm ZjVjNjkwZmM3ZjQyODlkYzBiM2Y3ZDA4ZDYzZGY1MTgyMjcyZjgzLi5lZTNhYTdiMzllMWJhMWUx MjYxNTAxMjEzYjNjYTFkN2VmNzhjMjhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOC0wMS0xNiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2FudmFzIHRhYjogdHlwaW5nIGEgInNwYWNlIiBp biB0aGUgUXVpY2tDb25zb2xlIHNob3VsZG4ndCB0cmlnZ2VyIGEgcmVjb3JkaW5nCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE3MDYKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzM2NTU4MjIxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNPdmVydmlld0Nv bnRlbnRWaWV3LmpzOgorICAgICAgICAoV0kuQ2FudmFzT3ZlcnZpZXdDb250ZW50Vmlldyk6Cisg ICAgICAgIChXSS5DYW52YXNPdmVydmlld0NvbnRlbnRWaWV3LnByb3RvdHlwZS5faGFuZGxlU3Bh Y2UpOgorCiAyMDE4LTAxLTE2ICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29t PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFN0eWxlcyBSZWRlc2lnbjogY2xpY2tpbmcgb24g dGhlIHdoaXRlIHNwYWNlIGFmdGVyIHRoZSBwcm9wZXJ0eSBzb21ldGltZXMgcGxhY2VzIGEgYmxh bmsgcHJvcGVydHkgYXQgdGhlIHdyb25nIGluZGV4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNPdmVydmlld0NvbnRlbnRWaWV3Lmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzT3ZlcnZp ZXdDb250ZW50Vmlldy5qcwppbmRleCBkNDllMjkyMmRlZTZmODMyOTg2NzQ0NjM4N2IwODVkYjFm OGIxN2QzLi44YThiZDFhMGQ5ZTc5ZmUyOWI4ZjkwMDM2NDU5NTUwNmNiYzZlODg0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNPdmVy dmlld0NvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0NhbnZhc092ZXJ2aWV3Q29udGVudFZpZXcuanMKQEAgLTYxLDEwICs2MSwxNiBA QCBXSS5DYW52YXNPdmVydmlld0NvbnRlbnRWaWV3ID0gY2xhc3MgQ2FudmFzT3ZlcnZpZXdDb250 ZW50VmlldyBleHRlbmRzIFdJLkNvbGxlYwogICAgICAgICAgICAgbmV3IFdJLktleWJvYXJkU2hv cnRjdXQobnVsbCwgV0kuS2V5Ym9hcmRTaG9ydGN1dC5LZXkuUmlnaHQsIHRoaXMuX2hhbmRsZVJp Z2h0LmJpbmQodGhpcykpLAogICAgICAgICAgICAgbmV3IFdJLktleWJvYXJkU2hvcnRjdXQobnVs bCwgV0kuS2V5Ym9hcmRTaG9ydGN1dC5LZXkuRG93biwgdGhpcy5faGFuZGxlRG93bi5iaW5kKHRo aXMpKSwKICAgICAgICAgICAgIG5ldyBXSS5LZXlib2FyZFNob3J0Y3V0KG51bGwsIFdJLktleWJv YXJkU2hvcnRjdXQuS2V5LkxlZnQsIHRoaXMuX2hhbmRsZUxlZnQuYmluZCh0aGlzKSksCi0gICAg ICAgICAgICBuZXcgV0kuS2V5Ym9hcmRTaG9ydGN1dChudWxsLCBXSS5LZXlib2FyZFNob3J0Y3V0 LktleS5TcGFjZSwgdGhpcy5faGFuZGxlU3BhY2UuYmluZCh0aGlzKSksCi0gICAgICAgICAgICBu ZXcgV0kuS2V5Ym9hcmRTaG9ydGN1dChXSS5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLlNoaWZ0 LCBXSS5LZXlib2FyZFNob3J0Y3V0LktleS5TcGFjZSwgdGhpcy5faGFuZGxlU3BhY2UuYmluZCh0 aGlzKSksCiAgICAgICAgIF07CiAKKyAgICAgICAgbGV0IHJlY29yZFNob3J0Y3V0ID0gbmV3IFdJ LktleWJvYXJkU2hvcnRjdXQobnVsbCwgV0kuS2V5Ym9hcmRTaG9ydGN1dC5LZXkuU3BhY2UsIHRo aXMuX2hhbmRsZVNwYWNlLmJpbmQodGhpcykpOworICAgICAgICByZWNvcmRTaG9ydGN1dC5pbXBs aWNpdGx5UHJldmVudHNEZWZhdWx0ID0gZmFsc2U7CisgICAgICAgIHRoaXMuX2tleWJvYXJkU2hv cnRjdXRzLnB1c2gocmVjb3JkU2hvcnRjdXQpOworCisgICAgICAgIGxldCByZWNvcmRTaW5nbGVG cmFtZVNob3J0Y3V0ID0gbmV3IFdJLktleWJvYXJkU2hvcnRjdXQoV0kuS2V5Ym9hcmRTaG9ydGN1 dC5Nb2RpZmllci5TaGlmdCwgV0kuS2V5Ym9hcmRTaG9ydGN1dC5LZXkuU3BhY2UsIHRoaXMuX2hh bmRsZVNwYWNlLmJpbmQodGhpcykpOworICAgICAgICByZWNvcmRTaW5nbGVGcmFtZVNob3J0Y3V0 LmltcGxpY2l0bHlQcmV2ZW50c0RlZmF1bHQgPSBmYWxzZTsKKyAgICAgICAgdGhpcy5fa2V5Ym9h cmRTaG9ydGN1dHMucHVzaChyZWNvcmRTaW5nbGVGcmFtZVNob3J0Y3V0KTsKKwogICAgICAgICBm b3IgKGxldCBzaG9ydGN1dCBvZiB0aGlzLl9rZXlib2FyZFNob3J0Y3V0cykKICAgICAgICAgICAg IHNob3J0Y3V0LmRpc2FibGVkID0gdHJ1ZTsKICAgICB9CkBAIC0yNDEsNiArMjQ3LDkgQEAgV0ku Q2FudmFzT3ZlcnZpZXdDb250ZW50VmlldyA9IGNsYXNzIENhbnZhc092ZXJ2aWV3Q29udGVudFZp ZXcgZXh0ZW5kcyBXSS5Db2xsZWMKIAogICAgIF9oYW5kbGVTcGFjZShldmVudCkKICAgICB7Cisg ICAgICAgIGlmIChXSS5pc0V2ZW50VGFyZ2V0QW5FZGl0YWJsZUZpZWxkKGV2ZW50KSkKKyAgICAg ICAgICAgIHJldHVybjsKKwogICAgICAgICBpZiAoIXRoaXMuX3NlbGVjdGVkSXRlbSkKICAgICAg ICAgICAgIHJldHVybjsKIApAQCAtMjUwLDYgKzI1OSw4IEBAIFdJLkNhbnZhc092ZXJ2aWV3Q29u dGVudFZpZXcgPSBjbGFzcyBDYW52YXNPdmVydmlld0NvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29s bGVjCiAgICAgICAgICAgICBsZXQgc2luZ2xlRnJhbWUgPSAhIWV2ZW50LnNoaWZ0S2V5OwogICAg ICAgICAgICAgV0kuY2FudmFzTWFuYWdlci5zdGFydFJlY29yZGluZyh0aGlzLl9zZWxlY3RlZEl0 ZW0sIHNpbmdsZUZyYW1lKTsKICAgICAgICAgfQorCisgICAgICAgIGV2ZW50LnByZXZlbnREZWZh dWx0KCk7CiAgICAgfQogCiAgICAgX3VwZGF0ZVNob3dJbWFnZUdyaWQoKQo=