180734 2017-12-12 19:20:15 -0800 TypeCheckHoistingPhase needs to emit a CheckStructureOrEmpty if it's doing it for |this| 2017-12-13 12:48:01 -0800 1 1 1 Unclassified WebKit JavaScriptCore Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 180764 1 saam saam benjamin bugs-noreply clopez commit-queue fpizlo ggaren gskachkov guijemont jfbastien keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1381018 0 saam 2017-12-12 19:20:15 -0800 Because |this| can be TDZ. This doesn't happen at a function's call entrypoint, but it can happen at a catch entry point. 1381019 1 saam 2017-12-12 19:20:48 -0800 <rdar://problem/35640547> 1381023 2 329194 saam 2017-12-12 19:28:47 -0800 Created attachment 329194 patch 1381073 3 329194 ysuzuki 2017-12-13 00:25:28 -0800 Comment on attachment 329194 patch r=me 1381129 4 329194 commit-queue 2017-12-13 09:19:27 -0800 Comment on attachment 329194 patch Clearing flags on attachment: 329194 Committed r225844: <https://trac.webkit.org/changeset/225844> 1381130 5 commit-queue 2017-12-13 09:19:29 -0800 All reviewed patches have been landed. Closing bug. 1381228 6 clopez 2017-12-13 11:54:34 -0800 (In reply to WebKit Commit Bot from comment #4) > Comment on attachment 329194 [details] > patch > > Clearing flags on attachment: 329194 > > Committed r225844: <https://trac.webkit.org/changeset/225844> It seems this did cased like 900 test failures on 32-bit? Results for r225843 (74 JSC test failed) https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5267 Results for r225844 (904 JSC test failed) https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5268 1381234 7 clopez 2017-12-13 12:06:36 -0800 (In reply to Carlos Alberto Lopez Perez from comment #6) > (In reply to WebKit Commit Bot from comment #4) > > Comment on attachment 329194 [details] > > patch > > > > Clearing flags on attachment: 329194 > > > > Committed r225844: <https://trac.webkit.org/changeset/225844> > > It seems this did cased like 900 test failures on 32-bit? > > Results for r225843 (74 JSC test failed) > https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5267 > Results for r225844 (904 JSC test failed) > https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5268 Reported in bug 180764 1381240 8 saam 2017-12-13 12:25:15 -0800 (In reply to Carlos Alberto Lopez Perez from comment #7) > (In reply to Carlos Alberto Lopez Perez from comment #6) > > (In reply to WebKit Commit Bot from comment #4) > > > Comment on attachment 329194 [details] > > > patch > > > > > > Clearing flags on attachment: 329194 > > > > > > Committed r225844: <https://trac.webkit.org/changeset/225844> > > > > It seems this did cased like 900 test failures on 32-bit? > > > > Results for r225843 (74 JSC test failed) > > https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5267 > > Results for r225844 (904 JSC test failed) > > https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5268 > > Reported in bug 180764 Thanks will look in a few. 1381246 9 saam 2017-12-13 12:48:01 -0800 Fixed in: https://trac.webkit.org/changeset/225865/webkit 329194 2017-12-12 19:28:47 -0800 2017-12-13 09:19:27 -0800 patch c-backup.diff text/plain 5249 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMjU4MzUpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDIxIEBACisyMDE3LTEyLTEyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIFR5cGVDaGVja0hvaXN0aW5nUGhhc2UgbmVlZHMgdG8gZW1pdCBhIENo ZWNrU3RydWN0dXJlT3JFbXB0eSBpZiBpdCdzIGRvaW5nIGl0IGZvciB8dGhpc3wKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDczNAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMzU2NDA1NDc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvdHlwZS1jaGVjay1ob2lzdGluZy1waGFzZS1ob2lz dC1jaGVjay1zdHJ1Y3R1cmUtb24tdGR6LXRoaXMtdmFsdWUuanM6IEFkZGVkLgorICAgICAgICAo X19pc1Byb3BlcnR5T2ZUeXBlKToKKyAgICAgICAgKF9fZ2V0UHJvcGVydGllcyk6CisgICAgICAg IChfX2dldE9iamVjdHMpOgorICAgICAgICAoX19nZXRSYW5kb21PYmplY3QpOgorICAgICAgICAo dGhlQ2xhc3MuKToKKyAgICAgICAgKHRoZUNsYXNzKToKKyAgICAgICAgKGNoaWxkQ2xhc3MpOgor ICAgICAgICAoY291bnRlci5jYXRjaCk6CisKIDIwMTctMTItMTIgIFNhYW0gQmFyYXRpICA8c2Jh cmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgV2UgbmVlZCB0byBtb2RlbCBlZmZlY3RzIG9mIFNw cmVhZChAUGhhbnRvbUNyZWF0ZVJlc3QpIGluIENsb2JiZXJpemUvUHJlY2lzZUxvY2FsQ2xvYmJl cml6ZQpJbmRleDogSlNUZXN0cy9zdHJlc3MvdHlwZS1jaGVjay1ob2lzdGluZy1waGFzZS1ob2lz dC1jaGVjay1zdHJ1Y3R1cmUtb24tdGR6LXRoaXMtdmFsdWUuanMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNU ZXN0cy9zdHJlc3MvdHlwZS1jaGVjay1ob2lzdGluZy1waGFzZS1ob2lzdC1jaGVjay1zdHJ1Y3R1 cmUtb24tdGR6LXRoaXMtdmFsdWUuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3Mv dHlwZS1jaGVjay1ob2lzdGluZy1waGFzZS1ob2lzdC1jaGVjay1zdHJ1Y3R1cmUtb24tdGR6LXRo aXMtdmFsdWUuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw1MSBAQAorZnVuY3Rpb24gX19p c1Byb3BlcnR5T2ZUeXBlKG9iaiwgbmFtZSwgdHlwZSkgeworICAgIGRlc2MgPSBPYmplY3QuZ2V0 T3duUHJvcGVydHlEZXNjcmlwdG9yKG9iaiwgbmFtZSkKKyAgICByZXR1cm4gdHlwZW9mIHR5cGUg PT09ICd1bmRlZmluZWQnIHx8IHR5cGVvZiBkZXNjLnZhbHVlID09PSB0eXBlOworfQorZnVuY3Rp b24gX19nZXRQcm9wZXJ0aWVzKG9iaiwgdHlwZSkgeworICAgIGxldCBwcm9wZXJ0aWVzID0gW107 CisgICAgZm9yIChsZXQgbmFtZSBvZiBPYmplY3QuZ2V0T3duUHJvcGVydHlOYW1lcyhvYmopKSB7 CisgICAgICAgIGlmIChfX2lzUHJvcGVydHlPZlR5cGUob2JqLCBuYW1lLCB0eXBlKSkgcHJvcGVy dGllcy5wdXNoKG5hbWUpOworICAgIH0KKyAgICBsZXQgcHJvdG8gPSBPYmplY3QuZ2V0UHJvdG90 eXBlT2Yob2JqKTsKKyAgICB3aGlsZSAocHJvdG8gJiYgcHJvdG8gIT0gT2JqZWN0LnByb3RvdHlw ZSkgeworICAgICAgICBPYmplY3QuZ2V0T3duUHJvcGVydHlOYW1lcyhwcm90bykuZm9yRWFjaChu YW1lID0+IHsKKyAgICAgICAgfSk7CisgICAgICAgIHByb3RvID0gT2JqZWN0LmdldFByb3RvdHlw ZU9mKHByb3RvKTsKKyAgICB9CisgICAgcmV0dXJuIHByb3BlcnRpZXM7Cit9CitmdW5jdGlvbiog X19nZXRPYmplY3RzKHJvb3QgPSB0aGlzLCBsZXZlbCA9IDApIHsKKyAgICBpZiAobGV2ZWwgPiA0 KSByZXR1cm47CisgICAgbGV0IG9ial9uYW1lcyA9IF9fZ2V0UHJvcGVydGllcyhyb290LCAnb2Jq ZWN0Jyk7CisgICAgZm9yIChsZXQgb2JqX25hbWUgb2Ygb2JqX25hbWVzKSB7CisgICAgICAgIGxl dCBvYmogPSByb290W29ial9uYW1lXTsKKyAgICAgICAgeWllbGQqIF9fZ2V0T2JqZWN0cyhvYmos IGxldmVsICsgMSk7CisgICAgfQorfQorZnVuY3Rpb24gX19nZXRSYW5kb21PYmplY3QoKSB7Cisg ICAgZm9yIChsZXQgb2JqIG9mIF9fZ2V0T2JqZWN0cygpKSB7CisgICAgfQorfQordmFyIHRoZUNs YXNzID0gY2xhc3MgeworICAgIGNvbnN0cnVjdG9yKCkgeworICAgICAgICBpZiAoMjQyNDg3ICE9 IG51bGwgJiYgdHlwZW9mIF9fZ2V0UmFuZG9tT2JqZWN0KCkgPT0gIm9iamVjdCIpIHRyeSB7Cisg ICAgICAgIH0gY2F0Y2ggKGUpIHt9CisgICAgfQorfTsKK3ZhciBjaGlsZENsYXNzID0gY2xhc3Mg Q2xhc3MgZXh0ZW5kcyB0aGVDbGFzcyB7CisgICAgY29uc3RydWN0b3IoKSB7CisgICAgICAgIHZh ciBhcnJvdyA9ICgpID0+IHsKKyAgICAgICAgICAgIHRyeSB7CisgICAgICAgICAgICAgICAgc3Vw ZXIoKTsKKyAgICAgICAgICAgIH0gY2F0Y2ggKGUpIHt9CisgICAgICAgICAgICB0aGlzLmlkVmFs dWUKKyAgICAgICAgfTsKKyAgICAgICAgYXJyb3coKSgpKCk7CisgICAgfQorfTsKK2ZvciAodmFy IGNvdW50ZXIgPSAwOyBjb3VudGVyIDwgMTAwMDsgY291bnRlcisrKSB7CisgICAgdHJ5IHsKKyAg ICAgICAgbmV3IGNoaWxkQ2xhc3MoKTsKKyAgICB9IGNhdGNoIChlKSB7fQorfQpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjU4MDkpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTctMTIt MTIgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CisKKyAgICAgICAgVHlwZUNoZWNr SG9pc3RpbmdQaGFzZSBuZWVkcyB0byBlbWl0IGEgQ2hlY2tTdHJ1Y3R1cmVPckVtcHR5IGlmIGl0 J3MgZG9pbmcgaXQgZm9yIHx0aGlzfAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTgwNzM0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTY0MDU0Nz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgfHRo aXN8IHZhbHVlIG1heSBiZSBURFouIElmIHR5cGUgY2hlY2sgaG9pc3RpbmcgcGhhc2UKKyAgICAg ICAgaG9pc3RzIGEgQ2hlY2tTdHJ1Y3R1cmUgdG8gaXQsIGl0IHdpbGwgY3Jhc2guIFRoaXMgcGF0 Y2gKKyAgICAgICAgbWFrZXMgaXQgc28gd2UgZW1pdCBDaGVja1N0cnVjdHVyZU9yRW1wdHkgZm9y IHx0aGlzfC4KKworICAgICAgICAqIGRmZy9ERkdUeXBlQ2hlY2tIb2lzdGluZ1BoYXNlLmNwcDoK KyAgICAgICAgKEpTQzo6REZHOjpUeXBlQ2hlY2tIb2lzdGluZ1BoYXNlOjpydW4pOgorCiAyMDE3 LTEyLTA0ICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IG1vZGVybml6ZSBJbmplY3RlZFNjcmlwdCBhIGJpdApJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdUeXBlQ2hlY2tIb2lzdGluZ1BoYXNlLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1R5cGVDaGVja0hvaXN0aW5nUGhhc2UuY3Bw CShyZXZpc2lvbiAyMjU4MDkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1R5cGVD aGVja0hvaXN0aW5nUGhhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDQsOCArMTQ0LDE3IEBA IHB1YmxpYzoKICAgICAgICAgICAgICAgICAgICAgICAgIGluZGV4SW5CbG9jayArIDEsIHZhcmlh YmxlLT5wcmVkaWN0aW9uKCksIEdldExvY2FsLCBvcmlnaW4sCiAgICAgICAgICAgICAgICAgICAg ICAgICBPcEluZm8odmFyaWFibGUpLCBFZGdlKG5vZGUpKTsKICAgICAgICAgICAgICAgICAgICAg aWYgKGl0ZXItPnZhbHVlLm1fc3RydWN0dXJlKSB7CisgICAgICAgICAgICAgICAgICAgICAgICBh dXRvIGNoZWNrT3AgPSBDaGVja1N0cnVjdHVyZTsKKyAgICAgICAgICAgICAgICAgICAgICAgIFZp cnR1YWxSZWdpc3RlciBsb2NhbCA9IG5vZGUtPnZhcmlhYmxlQWNjZXNzRGF0YSgpLT5sb2NhbCgp OworICAgICAgICAgICAgICAgICAgICAgICAgYXV0byogaW5saW5lQ2FsbEZyYW1lID0gbm9kZS0+ b3JpZ2luLnNlbWFudGljLmlubGluZUNhbGxGcmFtZTsKKyAgICAgICAgICAgICAgICAgICAgICAg IGlmICgobG9jYWwgLSAoaW5saW5lQ2FsbEZyYW1lID8gaW5saW5lQ2FsbEZyYW1lLT5zdGFja09m ZnNldCA6IDApKSA9PSB2aXJ0dWFsUmVnaXN0ZXJGb3JBcmd1bWVudCgwKSkgeworICAgICAgICAg ICAgICAgICAgICAgICAgICAgIC8vIHx0aGlzfCBjYW4gYmUgdGhlIFREWiB2YWx1ZS4gVGhlIGNh bGwgZW50cnlwb2ludCB3b24ndCBoYXZlIHx0aGlzfCBhcyBURFosCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgLy8gYnV0IGEgY2F0Y2ggb3IgYSBsb29wIE9TUiBlbnRyeSBtYXkgaGF2ZSB8 dGhpc3wgYmUgVERaLgorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNoZWNrT3AgPSBDaGVj a1N0cnVjdHVyZU9yRW1wdHk7CisgICAgICAgICAgICAgICAgICAgICAgICB9CisKICAgICAgICAg ICAgICAgICAgICAgICAgIGluc2VydGlvblNldC5pbnNlcnROb2RlKAotICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGluZGV4SW5CbG9jayArIDEsIFNwZWNOb25lLCBDaGVja1N0cnVjdHVyZSwg b3JpZ2luLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluZGV4SW5CbG9jayArIDEsIFNw ZWNOb25lLCBjaGVja09wLCBvcmlnaW4sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgT3BJ bmZvKG1fZ3JhcGguYWRkU3RydWN0dXJlU2V0KGl0ZXItPnZhbHVlLm1fc3RydWN0dXJlKSksCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgRWRnZShnZXRMb2NhbCwgQ2VsbFVzZSkpOwogICAg ICAgICAgICAgICAgICAgICB9IGVsc2UgaWYgKGl0ZXItPnZhbHVlLm1fYXJyYXlNb2RlSXNWYWxp ZCkgewo=