180660 2017-12-11 10:39:18 -0800 [WinCairo] Enable running sharded tests 2017-12-11 20:55:25 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke basuke achristensen basuke bfulgham commit-queue don.olmstead ews-watchlist glenn lforschler webkit-bug-importer oldest_to_newest 1380292 0 basuke 2017-12-11 10:39:18 -0800 Sharding haven't worked for WinCairo on native Windows by failing separation if basename and dirname. 1380312 1 329006 basuke 2017-12-11 11:34:39 -0800 Created attachment 329006 patch 1380440 2 329006 achristensen 2017-12-11 15:53:53 -0800 Comment on attachment 329006 patch View in context: https://bugs.webkit.org/attachment.cgi?id=329006&action=review > Tools/Scripts/webkitpy/port/win.py:440 > + # FIXME I don't see why base Port depends on UNIX separator, but I'm afraid breaking other environment > + TEST_PATH_SEPARATOR = os.sep I don't think this is a good comment. If this is necessary, then it's necessary. 1380534 3 329081 basuke 2017-12-11 20:02:21 -0800 Created attachment 329081 fixed remove comment as reviewd 1380535 4 329081 ews-watchlist 2017-12-11 20:02:43 -0800 Comment on attachment 329081 fixed Rejecting attachment 329081 from commit-queue. Basuke.Suzuki@sony.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1380540 5 329081 commit-queue 2017-12-11 20:54:28 -0800 Comment on attachment 329081 fixed Clearing flags on attachment: 329081 Committed r225770: <https://trac.webkit.org/changeset/225770> 1380541 6 commit-queue 2017-12-11 20:54:29 -0800 All reviewed patches have been landed. Closing bug. 1380542 7 webkit-bug-importer 2017-12-11 20:55:25 -0800 <rdar://problem/35986463> 329006 2017-12-11 11:34:39 -0800 2017-12-11 20:02:21 -0800 patch bug-180660.diff text/plain 1452 basuke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2NzQy MTZiYTA5Zi4uYzcwYzc5ZTYwYjAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxNy0xMi0xMSAgQmFzdWtlIFN1enVr aSAgPEJhc3VrZS5TdXp1a2lAc29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXSBFbmFibGUg cnVubmluZyBzaGFyZGVkIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODA2NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgc2hhcmRlciBzcGxpdHMgdGhlIHRlc3QgaW5wdXRzIGludG8gZ3Jv dXBzIG9mIHRlc3QgYmFzZWQgb24gdGhlIGRpcmVjdG9yeSwgCisgICAgICAgIGJ1dCBzZXBhcmF0 aW9uIG9mIGJhc2UgbmFtZSBhbmQgZGlyZWN0b3J5IG5hbWUgd2FzIGZhaWxlZCBiZWNhdXNlIG9m IHRoaXMgYnVnLgorICAgICAgICBPbmNlIHNoYXJkZWQgY29ycmVjdGx5LCB0aGUgZXhlY3V0aW9u IG9mIGxheW91dCB0ZXN0IG9uIG5hdGl2ZSBXaW5kb3dzIGVudmlyb25tZW50CisgICAgICAgIGlz IGluIHBhcmFsbGVsIGFuZCBtdWNoIGxlc3MgdGltZSB0byBydW4uCisKKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5OgorICAgICAgICAoV2luQ2Fpcm9Qb3J0KToKKwogMjAx Ny0xMi0wOCAgQmFzdWtlIFN1enVraSAgPEJhc3VrZS5TdXp1a2lAc29ueS5jb20+CiAKICAgICAg ICAgW1dpbkNhaXJvXSBGaXggcnVudGltZSBlcnJvciBhZnRlciByMjI1MjI5CmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9wb3J0L3dpbi5weQppbmRleCBhZTk3ODFjNGNjNy4uOTY2Y2I0YzkxN2QgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93aW4ucHkKKysrIGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9wb3J0L3dpbi5weQpAQCAtNDM2LDYgKzQzNiw5IEBAIGNsYXNzIFdpblBvcnQo QXBwbGVQb3J0KToKIGNsYXNzIFdpbkNhaXJvUG9ydChXaW5Qb3J0KToKICAgICBwb3J0X25hbWUg PSAid2luY2Fpcm8iCiAKKyAgICAjIEZJWE1FIEkgZG9uJ3Qgc2VlIHdoeSBiYXNlIFBvcnQgZGVw ZW5kcyBvbiBVTklYIHNlcGFyYXRvciwgYnV0IEknbSBhZnJhaWQgYnJlYWtpbmcgb3RoZXIgZW52 aXJvbm1lbnQKKyAgICBURVNUX1BBVEhfU0VQQVJBVE9SID0gb3Muc2VwCisKICAgICBWRVJTSU9O X0ZBTExCQUNLX09SREVSID0gWyJ3aW5jYWlyby0iICsgb3NfbmFtZS5sb3dlcigpIGZvciBvc19u YW1lIGluIFZlcnNpb25OYW1lTWFwLm1hcCgpLm5hbWVzKCldCiAKICAgICBkZWYgZGVmYXVsdF9i YXNlbGluZV9zZWFyY2hfcGF0aChzZWxmKToK 329081 2017-12-11 20:02:21 -0800 2017-12-11 20:54:28 -0800 fixed bug-180660.diff text/plain 1339 basuke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlZjNk ODU1M2NiNy4uNjhkMzRjNzVlOGQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxNy0xMi0xMSAgQmFzdWtlIFN1enVr aSAgPEJhc3VrZS5TdXp1a2lAc29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXSBFbmFibGUg cnVubmluZyBzaGFyZGVkIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODA2NjAKKworICAgICAgICBSZXZpZXdlZCBieSBBbGV4IENocmlzdGVu c2VuLgorCisgICAgICAgIFRoZSBzaGFyZGVyIHNwbGl0cyB0aGUgdGVzdCBpbnB1dHMgaW50byBn cm91cHMgb2YgdGVzdCBiYXNlZCBvbiB0aGUgZGlyZWN0b3J5LCAKKyAgICAgICAgYnV0IHNlcGFy YXRpb24gb2YgYmFzZSBuYW1lIGFuZCBkaXJlY3RvcnkgbmFtZSB3YXMgd3JvbmcgYmVjYXVzZSBv ZiB0aGlzIGJ1Zy4KKyAgICAgICAgT25jZSBzaGFyZGVkIGNvcnJlY3RseSwgdGhlIGV4ZWN1dGlv biBvZiBsYXlvdXQgdGVzdCBvbiBuYXRpdmUgV2luZG93cyBlbnZpcm9ubWVudAorICAgICAgICBp cyBpbiBwYXJhbGxlbCBhbmQgbXVjaCBsZXNzIHRpbWUgdG8gcnVuLgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9wb3J0L3dpbi5weToKKyAgICAgICAgKFdpbkNhaXJvUG9ydCk6CisKIDIw MTctMTItMTEgIERhdmlkIFF1ZXNhZGEgIDxkYXZpZF9xdWVzYWRhQGFwcGxlLmNvbT4KIAogICAg ICAgICBUdXJuIG9uIEVOQUJMRV9BUFBMSUNBVElPTl9NQU5JRkVTVApkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dpbi5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv cG9ydC93aW4ucHkKaW5kZXggMTJiNmUxNjI4MWIuLmU0ODM5ZDRmNmEyIDEwMDY0NAotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvcG9ydC93aW4ucHkKQEAgLTQzNiw2ICs0MzYsOCBAQCBjbGFzcyBXaW5Qb3J0KEFwcGxl UG9ydCk6CiBjbGFzcyBXaW5DYWlyb1BvcnQoV2luUG9ydCk6CiAgICAgcG9ydF9uYW1lID0gIndp bmNhaXJvIgogCisgICAgVEVTVF9QQVRIX1NFUEFSQVRPUiA9IG9zLnNlcAorCiAgICAgVkVSU0lP Tl9GQUxMQkFDS19PUkRFUiA9IFsid2luY2Fpcm8tIiArIG9zX25hbWUubG93ZXIoKSBmb3Igb3Nf bmFtZSBpbiBWZXJzaW9uTmFtZU1hcC5tYXAoKS5uYW1lcygpXQogCiAgICAgZGVmIGRlZmF1bHRf YmFzZWxpbmVfc2VhcmNoX3BhdGgoc2VsZik6Cg==