180625 2017-12-09 13:26:32 -0800 Link-Time-Optimizations could be used 2022-02-28 15:08:20 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Local Build PC Linux RESOLVED WORKSFORME P2 Enhancement --- 1 walter.huettenmeyer webkit-unassigned annulen aperez ews-watchlist keith_miller mark.lam msaboff saam tzagallo walter.huettenmeyer oldest_to_newest 1380003 0 328914 walter.huettenmeyer 2017-12-09 13:26:32 -0800 Created attachment 328914 Patch to allow LTO Compiling webkitgtk+-2.18.3 locally on an AMD64 machine, it will fail when using --flto=x --fuse-linker-plugin. Only way to compile it without errors was to disable LTO. I found a small patch on the gentoo forums here: https://forums.gentoo.org/viewtopic-t-1052716-start-0.html (credits to user costel78). Patching the source with this allows me to compile it fine with LTO enabled. Could you include this in upstream, if it seems worth? 1521673 1 annulen 2019-03-27 07:18:26 -0700 FWIW, Mac port uses clang's ThinLTO since r243396 1549689 2 walter.huettenmeyer 2019-07-02 13:04:54 -0700 Hi Konstantin, thank you for the info. On Linux it still won't compile with "-flto=n" the attached patch does do the magic. I do not know if any of the changes are in the correct and appropriate sections, and even it's not included a statement like "well, you could do that without harming much" may do to include it in the gentoo tree until you decide on what to do with the patch. 1549690 3 373354 walter.huettenmeyer 2019-07-02 13:07:24 -0700 Created attachment 373354 Patch to allow -flto=n; tested against webkit-gtk-2.24.2 1549692 4 373354 annulen 2019-07-02 13:16:57 -0700 Comment on attachment 373354 Patch to allow -flto=n; tested against webkit-gtk-2.24.2 View in context: https://bugs.webkit.org/attachment.cgi?id=373354&action=review > b/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp 2016-01-14 21:25:52.000000000 +0100:30 > +#if __GNUC__ >= 5 We require GCC 7 now so this check is redundant 1846798 5 aperez 2022-02-28 15:05:12 -0800 LTO has always worked fine for me without this patch. For the sake of being thorough, I just did a build using the following command for configuring it: CC=gcc CXX=g++ \ LDFLAGS='-flto=27 -fuse-linker-plugin -fuse-ld=bfd' \ CFLAGS='-flto=27 -fuse-linker-plugin' \ CXX='g++ -flto=27 -fuse-linker-plugin' \ cmake -S. -Bbuild-gtk -DCMAKE_BUILD_TYPE=Release -DPORT=GTK -GNinja && \ ninja -Cbuild-gtk -j27 This completed just fine :) I am going to close this as WORKSFORME, but if somebody runs into the same issue again of course we can reopen it. In that case, please do indicate how to reproduce the build issue (commands used for building, and information about the compiler/linker/etc. being used). 1846800 6 aperez 2022-02-28 15:07:51 -0800 For the record, I also tried Clang/LLD with -flto=thin/-fuse-ld=lld and WebKitGTK built fine as well. Compiler versions here were: % gcc -dumpversion 11.2.0 % clang -dumpversion 13.0.1 328914 2017-12-09 13:26:32 -0800 2019-07-02 13:07:24 -0700 Patch to allow LTO webkit-lto.patch text/plain 743 walter.huettenmeyer ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJl dGVyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVy LmNwcCAKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0 ZXIuY3BwICAgMjAxNi0wMS0xNCAyMToyMDo0Mi4zMDQ5MDI5MDUgKzAxMDAgCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmNwcCAgIDIwMTYtMDEt MTQgMjE6MjU6NTIuMDAwMDAwMDAwICswMTAwIApAQCAtMjMsNiArMjMsMTUgQEAgCiAgKiBPRiBU SElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0gg REFNQUdFLiAKICAqLyAKICAKKy8vIElmIHdlIGFyZSB1c2luZyBnY2MgPj0gNS4wLCBtYWtlIHN1 cmUgdGhhdCB0aGlzIGNvbXBpbGF0aW9uIHVuaXQgaXMgCisvLyBjb21waWxlZCB3aXRoIC1mbm8t bHRvLCBiZWNhdXNlIHdlIG1heSBiZSB1c2luZyBpbmxpbmUgYXNzZW1ibHkgCisvLyBpbmNsdWRl ZCBmcm9tIExMSW50QXNzZW1ibHkuaCAKKyNpZmRlZiBfX0dOVUNfXyAKKyNpZiBfX0dOVUNfXyA+ PSA1IAorI3ByYWdtYSBHQ0Mgb3B0aW1pemUgKCJuby1sdG8iKSAKKyNlbmRpZiAKKyNlbmRpZiAK KyAKICNpbmNsdWRlICJjb25maWcuaCIgCiAjaW5jbHVkZSAiTG93TGV2ZWxJbnRlcnByZXRlci5o Igo= 373354 2019-07-02 13:07:24 -0700 2022-02-28 15:08:20 -0800 Patch to allow -flto=n; tested against webkit-gtk-2.24.2 lto.patch text/plain 607 walter.huettenmeyer LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuY3Bw ICAgMjAxNi0wMS0xNCAyMToyMDo0Mi4zMDQ5MDI5MDUgKzAxMDAKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuY3BwICAgMjAxNi0wMS0xNCAyMToy NTo1Mi4wMDAwMDAwMDAgKzAxMDAKQEAgLTIzLDYgKzIzLDE1IEBACiAgKiBPRiBUSElTIFNPRlRX QVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgog ICovCiAKKy8vIElmIHdlIGFyZSB1c2luZyBnY2MgPj0gNS4wLCBtYWtlIHN1cmUgdGhhdCB0aGlz IGNvbXBpbGF0aW9uIHVuaXQgaXMKKy8vIGNvbXBpbGVkIHdpdGggLWZuby1sdG8sIGJlY2F1c2Ug d2UgbWF5IGJlIHVzaW5nIGlubGluZSBhc3NlbWJseQorLy8gaW5jbHVkZWQgZnJvbSBMTEludEFz c2VtYmx5LmgKKyNpZmRlZiBfX0dOVUNfXworI2lmIF9fR05VQ19fID49IDUKKyNwcmFnbWEgR0ND IG9wdGltaXplICgibm8tbHRvIikKKyNlbmRpZgorI2VuZGlmCisKICNpbmNsdWRlICJjb25maWcu aCIKICNpbmNsdWRlICJMb3dMZXZlbEludGVycHJldGVyLmgiCg==