180467 2017-12-06 00:54:38 -0800 Web Inspector: Style Redesign: filtering removes header if one rule has no match even if others do 2017-12-06 16:18:51 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 180466 1 hi hi commit-queue inspector-bugzilla-changes lforschler timothy webkit-bug-importer oldest_to_newest 1378570 0 hi 2017-12-06 00:54:38 -0800 In the case that multiple rules are inherited, if at least one of these rules has no match to the filtered text, the header is hidden, even if other rules do have a match. 1378572 1 328559 hi 2017-12-06 01:01:31 -0800 Created attachment 328559 Patch 1378714 2 328600 hi 2017-12-06 11:29:17 -0800 Created attachment 328600 Patch Rebase 1378839 3 328600 commit-queue 2017-12-06 15:04:34 -0800 Comment on attachment 328600 Patch Clearing flags on attachment: 328600 Committed r225600: <https://trac.webkit.org/changeset/225600> 1378840 4 commit-queue 2017-12-06 15:04:36 -0800 All reviewed patches have been landed. Closing bug. 1378869 5 webkit-bug-importer 2017-12-06 16:18:51 -0800 <rdar://problem/35895756> 328559 2017-12-06 01:01:31 -0800 2017-12-06 11:29:15 -0800 Patch 180467.diff text/plain 2651 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDA2YzAyOWE1ODYwLi5iZjAxNGEyZmIzNSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTctMTItMDYgIERldmlu IFJvdXNzbyAgPHdlYmtpdEBkZXZpbnJvdXNzby5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogU3R5bGUgUmVkZXNpZ246IGZpbHRlcmluZyByZW1vdmVzIGhlYWRlciBpZiBvbmUgcnVsZSBo YXMgbm8gbWF0Y2ggZXZlbiBpZiBvdGhlcnMgZG8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDQ2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVldFJ1 bGVzU3R5bGVEZXRhaWxzUGFuZWwuanM6CisgICAgICAgIChXSS5TcHJlYWRzaGVldFJ1bGVzU3R5 bGVEZXRhaWxzUGFuZWwucHJvdG90eXBlLmFwcGx5RmlsdGVyKToKKyAgICAgICAgKFdJLlNwcmVh ZHNoZWV0UnVsZXNTdHlsZURldGFpbHNQYW5lbC5wcm90b3R5cGUuX2hhbmRsZVNlY3Rpb25GaWx0 ZXJBcHBsaWVkKToKKworMjAxNy0xMi0wNiAgRGV2aW4gUm91c3NvICA8d2Via2l0QGRldmlucm91 c3NvLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTdHlsZXMgUmVkZXNpZ246IGRpc3Bs YXkgcmVsYXRlZCBwc2V1ZG8tZWxlbWVudHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3NjE4NwogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzQxOTQ5 MTc+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9TcHJlYWRzaGVldFJ1bGVzU3R5bGVEZXRhaWxzUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVldFJ1bGVzU3R5bGVEZXRhaWxzUGFu ZWwuanMKaW5kZXggMTQ1NmYwYmQzNjQuLmFhY2Q3OTFmYmU4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVldFJ1bGVzU3R5bGVE ZXRhaWxzUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvU3ByZWFkc2hlZXRSdWxlc1N0eWxlRGV0YWlsc1BhbmVsLmpzCkBAIC0yNDAsNyArMjQw LDcgQEAgV0kuU3ByZWFkc2hlZXRSdWxlc1N0eWxlRGV0YWlsc1BhbmVsID0gY2xhc3MgU3ByZWFk c2hlZXRSdWxlc1N0eWxlRGV0YWlsc1BhbmVsIGUKICAgICAgICAgICAgIHRoaXMuZWxlbWVudC5j bGFzc0xpc3QuYWRkKCJmaWx0ZXItbm9uLW1hdGNoaW5nIik7CiAKICAgICAgICAgZm9yIChsZXQg aGVhZGVyIG9mIHRoaXMuX2hlYWRlck1hcC52YWx1ZXMoKSkKLSAgICAgICAgICAgIGhlYWRlci5j bGFzc0xpc3QucmVtb3ZlKFdJLkdlbmVyYWxTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwuTm9GaWx0 ZXJNYXRjaEluU2VjdGlvbkNsYXNzTmFtZSk7CisgICAgICAgICAgICBoZWFkZXIuY2xhc3NMaXN0 LmFkZChXSS5HZW5lcmFsU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsLk5vRmlsdGVyTWF0Y2hJblNl Y3Rpb25DbGFzc05hbWUpOwogCiAgICAgICAgIGZvciAobGV0IHNlY3Rpb24gb2YgdGhpcy5fc2Vj dGlvbnMpCiAgICAgICAgICAgICBzZWN0aW9uLmFwcGx5RmlsdGVyKHRoaXMuX2ZpbHRlclRleHQp OwpAQCAtMjU5LDEzICsyNTksMTQgQEAgV0kuU3ByZWFkc2hlZXRSdWxlc1N0eWxlRGV0YWlsc1Bh bmVsID0gY2xhc3MgU3ByZWFkc2hlZXRSdWxlc1N0eWxlRGV0YWlsc1BhbmVsIGUKIAogICAgIF9o YW5kbGVTZWN0aW9uRmlsdGVyQXBwbGllZChldmVudCkKICAgICB7Ci0gICAgICAgIGlmIChldmVu dC5kYXRhLm1hdGNoZXMpCi0gICAgICAgICAgICB0aGlzLmVsZW1lbnQuY2xhc3NMaXN0LnJlbW92 ZSgiZmlsdGVyLW5vbi1tYXRjaGluZyIpOwotICAgICAgICBlbHNlIHsKLSAgICAgICAgICAgIGxl dCBoZWFkZXIgPSB0aGlzLl9oZWFkZXJNYXAuZ2V0KGV2ZW50LnRhcmdldC5zdHlsZS5ub2RlKTsK LSAgICAgICAgICAgIGlmIChoZWFkZXIpCi0gICAgICAgICAgICAgICAgaGVhZGVyLmNsYXNzTGlz dC5hZGQoV0kuR2VuZXJhbFN0eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5Ob0ZpbHRlck1hdGNoSW5T ZWN0aW9uQ2xhc3NOYW1lKTsKLSAgICAgICAgfQorICAgICAgICBpZiAoIWV2ZW50LmRhdGEubWF0 Y2hlcykKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICB0aGlzLmVsZW1lbnQuY2xhc3NM aXN0LnJlbW92ZSgiZmlsdGVyLW5vbi1tYXRjaGluZyIpOworCisgICAgICAgIGxldCBoZWFkZXIg PSB0aGlzLl9oZWFkZXJNYXAuZ2V0KGV2ZW50LnRhcmdldC5zdHlsZS5ub2RlKTsKKyAgICAgICAg aWYgKGhlYWRlcikKKyAgICAgICAgICAgIGhlYWRlci5jbGFzc0xpc3QucmVtb3ZlKFdJLkdlbmVy YWxTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwuTm9GaWx0ZXJNYXRjaEluU2VjdGlvbkNsYXNzTmFt ZSk7CiAgICAgfQogCiAgICAgLy8gUHJpdmF0ZQo= 328600 2017-12-06 11:29:17 -0800 2017-12-06 15:04:34 -0800 Patch bug-180467-20171206112916.patch text/plain 2751 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDEyMjg3YmUyMzM4NGUzOWVjNDkyZTBmNjY3ZTNm YjQzYzk0Y2NlYjEuLmQ0MTQ0NzI1NWJiMTI0YWYyYzhkMDYyZTI2OGJjMWY5MTA1YTYxNzYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE3LTEyLTA2ICBEZXZp biBSb3Vzc28gIDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFN0eWxlIFJlZGVzaWduOiBmaWx0ZXJpbmcgcmVtb3ZlcyBoZWFkZXIgaWYgb25lIHJ1bGUg aGFzIG5vIG1hdGNoIGV2ZW4gaWYgb3RoZXJzIGRvCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODA0NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU3ByZWFkc2hlZXRS dWxlc1N0eWxlRGV0YWlsc1BhbmVsLmpzOgorICAgICAgICAoV0kuU3ByZWFkc2hlZXRSdWxlc1N0 eWxlRGV0YWlsc1BhbmVsLnByb3RvdHlwZS5hcHBseUZpbHRlcik6CisgICAgICAgIChXSS5TcHJl YWRzaGVldFJ1bGVzU3R5bGVEZXRhaWxzUGFuZWwucHJvdG90eXBlLl9oYW5kbGVTZWN0aW9uRmls dGVyQXBwbGllZCk6CisKKzIwMTctMTItMDYgIERldmluIFJvdXNzbyAgPHdlYmtpdEBkZXZpbnJv dXNzby5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTihyMjI1NTY5KTog Q1NTU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsIG5vIGxvbmdlciBleGlzdHMKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDQ2NgogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVldFJ1 bGVzU3R5bGVEZXRhaWxzUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9TcHJlYWRzaGVldFJ1bGVzU3R5bGVEZXRhaWxzUGFuZWwuanMKaW5kZXggZmE3 NTJiY2EzYWQzYzg2ODJmYTQ5NDJjYzFiNmM4YjgyOTkwMTM3MS4uYWFjZDc5MWZiZThkN2FhYjA1 Mjc0NDY3YmVmZDRlZjZmMmE3YzEwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvU3ByZWFkc2hlZXRSdWxlc1N0eWxlRGV0YWlsc1BhbmVsLmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NwcmVhZHNo ZWV0UnVsZXNTdHlsZURldGFpbHNQYW5lbC5qcwpAQCAtMjQwLDcgKzI0MCw3IEBAIFdJLlNwcmVh ZHNoZWV0UnVsZXNTdHlsZURldGFpbHNQYW5lbCA9IGNsYXNzIFNwcmVhZHNoZWV0UnVsZXNTdHls ZURldGFpbHNQYW5lbCBlCiAgICAgICAgICAgICB0aGlzLmVsZW1lbnQuY2xhc3NMaXN0LmFkZCgi ZmlsdGVyLW5vbi1tYXRjaGluZyIpOwogCiAgICAgICAgIGZvciAobGV0IGhlYWRlciBvZiB0aGlz Ll9oZWFkZXJNYXAudmFsdWVzKCkpCi0gICAgICAgICAgICBoZWFkZXIuY2xhc3NMaXN0LnJlbW92 ZShXSS5HZW5lcmFsU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsLk5vRmlsdGVyTWF0Y2hJblNlY3Rp b25DbGFzc05hbWUpOworICAgICAgICAgICAgaGVhZGVyLmNsYXNzTGlzdC5hZGQoV0kuR2VuZXJh bFN0eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5Ob0ZpbHRlck1hdGNoSW5TZWN0aW9uQ2xhc3NOYW1l KTsKIAogICAgICAgICBmb3IgKGxldCBzZWN0aW9uIG9mIHRoaXMuX3NlY3Rpb25zKQogICAgICAg ICAgICAgc2VjdGlvbi5hcHBseUZpbHRlcih0aGlzLl9maWx0ZXJUZXh0KTsKQEAgLTI1OSwxMyAr MjU5LDE0IEBAIFdJLlNwcmVhZHNoZWV0UnVsZXNTdHlsZURldGFpbHNQYW5lbCA9IGNsYXNzIFNw cmVhZHNoZWV0UnVsZXNTdHlsZURldGFpbHNQYW5lbCBlCiAKICAgICBfaGFuZGxlU2VjdGlvbkZp bHRlckFwcGxpZWQoZXZlbnQpCiAgICAgewotICAgICAgICBpZiAoZXZlbnQuZGF0YS5tYXRjaGVz KQotICAgICAgICAgICAgdGhpcy5lbGVtZW50LmNsYXNzTGlzdC5yZW1vdmUoImZpbHRlci1ub24t bWF0Y2hpbmciKTsKLSAgICAgICAgZWxzZSB7Ci0gICAgICAgICAgICBsZXQgaGVhZGVyID0gdGhp cy5faGVhZGVyTWFwLmdldChldmVudC50YXJnZXQuc3R5bGUubm9kZSk7Ci0gICAgICAgICAgICBp ZiAoaGVhZGVyKQotICAgICAgICAgICAgICAgIGhlYWRlci5jbGFzc0xpc3QuYWRkKFdJLkdlbmVy YWxTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwuTm9GaWx0ZXJNYXRjaEluU2VjdGlvbkNsYXNzTmFt ZSk7Ci0gICAgICAgIH0KKyAgICAgICAgaWYgKCFldmVudC5kYXRhLm1hdGNoZXMpCisgICAgICAg ICAgICByZXR1cm47CisKKyAgICAgICAgdGhpcy5lbGVtZW50LmNsYXNzTGlzdC5yZW1vdmUoImZp bHRlci1ub24tbWF0Y2hpbmciKTsKKworICAgICAgICBsZXQgaGVhZGVyID0gdGhpcy5faGVhZGVy TWFwLmdldChldmVudC50YXJnZXQuc3R5bGUubm9kZSk7CisgICAgICAgIGlmIChoZWFkZXIpCisg ICAgICAgICAgICBoZWFkZXIuY2xhc3NMaXN0LnJlbW92ZShXSS5HZW5lcmFsU3R5bGVEZXRhaWxz U2lkZWJhclBhbmVsLk5vRmlsdGVyTWF0Y2hJblNlY3Rpb25DbGFzc05hbWUpOwogICAgIH0KIAog ICAgIC8vIFByaXZhdGUK